Skip to contentSkip to conversation

automation/eclair: tag more rules as clean

PATCH In review Federico Serafini 2 participants 5 messages Aug 5, 2024

lore
Share & tools
lore
#3 lore raw

PATCH 2/2 automation/eclair: tag more guidelines as clean

In reply to Federico Serafini

Tag more of the accepted guidelines as clean to avoid regressions.

---
 automation/eclair_analysis/ECLAIR/tagging.ecl | 4 ++++
 1 file changed, 4 insertions(+)
automation/eclair_analysis/ECLAIR/tagging.ecl +4 -0
index e7b32773e6..4d0ac94848 100644
@@ -56,11 +56,14 @@ MC3R1.R9.3||
 MC3R1.R9.4||
 MC3R1.R9.5||
 MC3R1.R10.2||
+MC3R1.R11.6||
 MC3R1.R11.7||
 MC3R1.R11.9||
 MC3R1.R12.5||
 MC3R1.R14.1||
+MC3R1.R14.3||
 MC3R1.R14.4||
+MC3R1.R16.2||
 MC3R1.R16.7||
 MC3R1.R17.1||
 MC3R1.R17.3||
@@ -85,6 +88,7 @@ MC3R1.R21.7||
 MC3R1.R21.8||
 MC3R1.R21.9||
 MC3R1.R21.10||
+MC3R1.R21.11||
 MC3R1.R21.12||
 MC3R1.R21.13||
 MC3R1.R21.19||
Signature · 1 line
2.34.1
#0 lore raw

cover automation/eclair: tag more rules as clean

Sort -v monitored guidelines and tag more guidelines as clean.

Federico Serafini (2):
automation/eclair: sort monitored guidelines with -V automation/eclair: tag more guidelines as clean

 .../eclair_analysis/ECLAIR/monitored.ecl      | 92 +++++++++----------
 automation/eclair_analysis/ECLAIR/tagging.ecl |  4 +
 2 files changed, 50 insertions(+), 46 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 automation/eclair: sort monitored guidelines with -V

To improve readability, sort guidelines with -V.

No functional change.

---
 .../eclair_analysis/ECLAIR/monitored.ecl      | 92 +++++++++----------
 1 file changed, 46 insertions(+), 46 deletions(-)
automation/eclair_analysis/ECLAIR/monitored.ecl +46 -46
index 8a7e3f3cea..7b085a329a 100644
@@ -2,58 +2,17 @@
 -enable=MC3R1.D1.1
 -enable=MC3R1.D2.1
 -enable=MC3R1.D4.1
+-enable=MC3R1.D4.3
+-enable=MC3R1.D4.7
 -enable=MC3R1.D4.10
 -enable=MC3R1.D4.11
 -enable=MC3R1.D4.12
 -enable=MC3R1.D4.14
--enable=MC3R1.D4.3
--enable=MC3R1.D4.7
--enable=MC3R1.R10.1
--enable=MC3R1.R10.2
 -enable=MC3R1.R1.1
--enable=MC3R1.R11.1
--enable=MC3R1.R11.7
--enable=MC3R1.R11.8
--enable=MC3R1.R11.9
--enable=MC3R1.R12.5
 -enable=MC3R1.R1.3
--enable=MC3R1.R13.6
--enable=MC3R1.R13.1
 -enable=MC3R1.R1.4
--enable=MC3R1.R14.1
--enable=MC3R1.R14.4
--enable=MC3R1.R16.2
--enable=MC3R1.R16.3
--enable=MC3R1.R16.4
--enable=MC3R1.R16.6
--enable=MC3R1.R16.7
--enable=MC3R1.R17.1
--enable=MC3R1.R17.3
--enable=MC3R1.R17.4
--enable=MC3R1.R17.5
--enable=MC3R1.R17.6
--enable=MC3R1.R18.6
--enable=MC3R1.R19.1
--enable=MC3R1.R20.12
--enable=MC3R1.R20.13
--enable=MC3R1.R20.14
--enable=MC3R1.R20.4
--enable=MC3R1.R20.7
--enable=MC3R1.R20.9
 -enable=MC3R1.R2.1
--enable=MC3R1.R21.10
--enable=MC3R1.R21.13
--enable=MC3R1.R21.17
--enable=MC3R1.R21.18
--enable=MC3R1.R21.19
--enable=MC3R1.R21.20
--enable=MC3R1.R21.21
--enable=MC3R1.R21.9
 -enable=MC3R1.R2.2
--enable=MC3R1.R22.2
--enable=MC3R1.R22.4
--enable=MC3R1.R22.5
--enable=MC3R1.R22.6
 -enable=MC3R1.R2.6
 -enable=MC3R1.R3.1
 -enable=MC3R1.R3.2
@@ -72,32 +31,73 @@
 -enable=MC3R1.R7.3
 -enable=MC3R1.R7.4
 -enable=MC3R1.R8.1
--enable=MC3R1.R8.10
--enable=MC3R1.R8.12
--enable=MC3R1.R8.14
 -enable=MC3R1.R8.2
 -enable=MC3R1.R8.3
 -enable=MC3R1.R8.4
 -enable=MC3R1.R8.5
 -enable=MC3R1.R8.6
 -enable=MC3R1.R8.8
+-enable=MC3R1.R8.10
+-enable=MC3R1.R8.12
+-enable=MC3R1.R8.14
 -enable=MC3R1.R9.2
 -enable=MC3R1.R9.3
 -enable=MC3R1.R9.4
 -enable=MC3R1.R9.5
+-enable=MC3R1.R10.1
+-enable=MC3R1.R10.2
+-enable=MC3R1.R11.1
+-enable=MC3R1.R11.7
+-enable=MC3R1.R11.8
+-enable=MC3R1.R11.9
+-enable=MC3R1.R12.5
+-enable=MC3R1.R13.1
+-enable=MC3R1.R13.6
+-enable=MC3R1.R14.1
+-enable=MC3R1.R14.4
+-enable=MC3R1.R16.2
+-enable=MC3R1.R16.3
+-enable=MC3R1.R16.4
+-enable=MC3R1.R16.6
+-enable=MC3R1.R16.7
+-enable=MC3R1.R17.1
+-enable=MC3R1.R17.3
+-enable=MC3R1.R17.4
+-enable=MC3R1.R17.5
+-enable=MC3R1.R17.6
+-enable=MC3R1.R18.6
 -enable=MC3R1.R18.8
+-enable=MC3R1.R19.1
 -enable=MC3R1.R20.2
 -enable=MC3R1.R20.3
+-enable=MC3R1.R20.4
 -enable=MC3R1.R20.6
+-enable=MC3R1.R20.7
+-enable=MC3R1.R20.9
 -enable=MC3R1.R20.11
+-enable=MC3R1.R20.12
+-enable=MC3R1.R20.13
+-enable=MC3R1.R20.14
 -enable=MC3R1.R21.3
 -enable=MC3R1.R21.4
 -enable=MC3R1.R21.5
 -enable=MC3R1.R21.7
 -enable=MC3R1.R21.8
+-enable=MC3R1.R21.9
+-enable=MC3R1.R21.10
 -enable=MC3R1.R21.12
+-enable=MC3R1.R21.13
+-enable=MC3R1.R21.17
+-enable=MC3R1.R21.18
+-enable=MC3R1.R21.19
+-enable=MC3R1.R21.20
+-enable=MC3R1.R21.21
 -enable=MC3R1.R22.1
+-enable=MC3R1.R22.2
 -enable=MC3R1.R22.3
+-enable=MC3R1.R22.4
+-enable=MC3R1.R22.5
+-enable=MC3R1.R22.6
 -enable=MC3R1.R22.7
 -enable=MC3R1.R22.8
 -enable=MC3R1.R22.9
Signature · 1 line
2.34.1
Acked-by on v1 1/2
#2 lore raw

Re: [XEN PATCH 1/2] automation/eclair: sort monitored guidelines with -V

Quoted 3 lines · Federico Serafini

To improve readability, sort guidelines with -V.

No functional change.

Quoted 149 lines
---
 .../eclair_analysis/ECLAIR/monitored.ecl      | 92 +++++++++----------
 1 file changed, 46 insertions(+), 46 deletions(-)
automation/eclair_analysis/ECLAIR/monitored.ecl +46 -46
index 8a7e3f3cea..7b085a329a 100644
@@ -2,58 +2,17 @@
 -enable=MC3R1.D1.1
 -enable=MC3R1.D2.1
 -enable=MC3R1.D4.1
+-enable=MC3R1.D4.3
+-enable=MC3R1.D4.7
 -enable=MC3R1.D4.10
 -enable=MC3R1.D4.11
 -enable=MC3R1.D4.12
 -enable=MC3R1.D4.14
--enable=MC3R1.D4.3
--enable=MC3R1.D4.7
--enable=MC3R1.R10.1
--enable=MC3R1.R10.2
 -enable=MC3R1.R1.1
--enable=MC3R1.R11.1
--enable=MC3R1.R11.7
--enable=MC3R1.R11.8
--enable=MC3R1.R11.9
--enable=MC3R1.R12.5
 -enable=MC3R1.R1.3
--enable=MC3R1.R13.6
--enable=MC3R1.R13.1
 -enable=MC3R1.R1.4
--enable=MC3R1.R14.1
--enable=MC3R1.R14.4
--enable=MC3R1.R16.2
--enable=MC3R1.R16.3
--enable=MC3R1.R16.4
--enable=MC3R1.R16.6
--enable=MC3R1.R16.7
--enable=MC3R1.R17.1
--enable=MC3R1.R17.3
--enable=MC3R1.R17.4
--enable=MC3R1.R17.5
--enable=MC3R1.R17.6
--enable=MC3R1.R18.6
--enable=MC3R1.R19.1
--enable=MC3R1.R20.12
--enable=MC3R1.R20.13
--enable=MC3R1.R20.14
--enable=MC3R1.R20.4
--enable=MC3R1.R20.7
--enable=MC3R1.R20.9
 -enable=MC3R1.R2.1
--enable=MC3R1.R21.10
--enable=MC3R1.R21.13
--enable=MC3R1.R21.17
--enable=MC3R1.R21.18
--enable=MC3R1.R21.19
--enable=MC3R1.R21.20
--enable=MC3R1.R21.21
--enable=MC3R1.R21.9
 -enable=MC3R1.R2.2
--enable=MC3R1.R22.2
--enable=MC3R1.R22.4
--enable=MC3R1.R22.5
--enable=MC3R1.R22.6
 -enable=MC3R1.R2.6
 -enable=MC3R1.R3.1
 -enable=MC3R1.R3.2
@@ -72,32 +31,73 @@
 -enable=MC3R1.R7.3
 -enable=MC3R1.R7.4
 -enable=MC3R1.R8.1
--enable=MC3R1.R8.10
--enable=MC3R1.R8.12
--enable=MC3R1.R8.14
 -enable=MC3R1.R8.2
 -enable=MC3R1.R8.3
 -enable=MC3R1.R8.4
 -enable=MC3R1.R8.5
 -enable=MC3R1.R8.6
 -enable=MC3R1.R8.8
+-enable=MC3R1.R8.10
+-enable=MC3R1.R8.12
+-enable=MC3R1.R8.14
 -enable=MC3R1.R9.2
 -enable=MC3R1.R9.3
 -enable=MC3R1.R9.4
 -enable=MC3R1.R9.5
+-enable=MC3R1.R10.1
+-enable=MC3R1.R10.2
+-enable=MC3R1.R11.1
+-enable=MC3R1.R11.7
+-enable=MC3R1.R11.8
+-enable=MC3R1.R11.9
+-enable=MC3R1.R12.5
+-enable=MC3R1.R13.1
+-enable=MC3R1.R13.6
+-enable=MC3R1.R14.1
+-enable=MC3R1.R14.4
+-enable=MC3R1.R16.2
+-enable=MC3R1.R16.3
+-enable=MC3R1.R16.4
+-enable=MC3R1.R16.6
+-enable=MC3R1.R16.7
+-enable=MC3R1.R17.1
+-enable=MC3R1.R17.3
+-enable=MC3R1.R17.4
+-enable=MC3R1.R17.5
+-enable=MC3R1.R17.6
+-enable=MC3R1.R18.6
 -enable=MC3R1.R18.8
+-enable=MC3R1.R19.1
 -enable=MC3R1.R20.2
 -enable=MC3R1.R20.3
+-enable=MC3R1.R20.4
 -enable=MC3R1.R20.6
+-enable=MC3R1.R20.7
+-enable=MC3R1.R20.9
 -enable=MC3R1.R20.11
+-enable=MC3R1.R20.12
+-enable=MC3R1.R20.13
+-enable=MC3R1.R20.14
 -enable=MC3R1.R21.3
 -enable=MC3R1.R21.4
 -enable=MC3R1.R21.5
 -enable=MC3R1.R21.7
 -enable=MC3R1.R21.8
+-enable=MC3R1.R21.9
+-enable=MC3R1.R21.10
 -enable=MC3R1.R21.12
+-enable=MC3R1.R21.13
+-enable=MC3R1.R21.17
+-enable=MC3R1.R21.18
+-enable=MC3R1.R21.19
+-enable=MC3R1.R21.20
+-enable=MC3R1.R21.21
 -enable=MC3R1.R22.1
+-enable=MC3R1.R22.2
 -enable=MC3R1.R22.3
+-enable=MC3R1.R22.4
+-enable=MC3R1.R22.5
+-enable=MC3R1.R22.6
 -enable=MC3R1.R22.7
 -enable=MC3R1.R22.8
 -enable=MC3R1.R22.9
Signature · 1 line
2.34.1
Reviewed-by on v1 2/2
#4 lore raw

Re: [XEN PATCH 2/2] automation/eclair: tag more guidelines as clean

In reply to Federico Serafini
Quoted 3 lines · Federico Serafini

Tag more of the accepted guidelines as clean to avoid regressions.

Quoted 34 lines
---
 automation/eclair_analysis/ECLAIR/tagging.ecl | 4 ++++
 1 file changed, 4 insertions(+)
automation/eclair_analysis/ECLAIR/tagging.ecl +4 -0
index e7b32773e6..4d0ac94848 100644
@@ -56,11 +56,14 @@ MC3R1.R9.3||
 MC3R1.R9.4||
 MC3R1.R9.5||
 MC3R1.R10.2||
+MC3R1.R11.6||
 MC3R1.R11.7||
 MC3R1.R11.9||
 MC3R1.R12.5||
 MC3R1.R14.1||
+MC3R1.R14.3||
 MC3R1.R14.4||
+MC3R1.R16.2||
 MC3R1.R16.7||
 MC3R1.R17.1||
 MC3R1.R17.3||
@@ -85,6 +88,7 @@ MC3R1.R21.7||
 MC3R1.R21.8||
 MC3R1.R21.9||
 MC3R1.R21.10||
+MC3R1.R21.11||
 MC3R1.R21.12||
 MC3R1.R21.13||
 MC3R1.R21.19||
Signature · 1 line
2.34.1