Skip to contentSkip to conversation

arm64: dts: rockchip: rk3399: Fix rt5651 compatible values

PATCH Applied Geert Uytterhoeven 2 participants 4 messages Sep 26, 2024 – Sep 30, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: rockchip: rk3399: Fix rt5651 compatible values

Hi all,

This patch series fixes two occurrences of the "rockchip,rt5651" compatible value, which is not documented in DT bindings or supported in any upstream driver. Presumable these are typos for "realtek,rt5651", as the "simple-audio-card,name" properties in the "rt5651-sound" nodes refer to Realtek codecs.

This is untested due to lack of hardware.
Thanks for your comments!

Geert Uytterhoeven (2):
arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value
arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible
value

 arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts          | 2 +-
 arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

PATCH 1/2 arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value

There are no DT bindings and driver support for a "rockchip,rt5651" codec. Replace "rockchip,rt5651" by "realtek,rt5651", which matches the "simple-audio-card,name" property in the "rt5651-sound" node.

Fixes 904f983256fdd24b ("arm64: dts: rockchip: Add dts for a rk3399 based board EAIDK-610")
---
 arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +1 -1
index 1489eb32e266a748..4feb78797982baa5 100644
@@ -541,7 +541,7 @@ &i2c1 {
 	status = "okay";
 
 	rt5651: audio-codec@1a {
-		compatible = "rockchip,rt5651";
+		compatible = "realtek,rt5651";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		clock-names = "mclk";
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible value

In reply to Geert Uytterhoeven

There are no DT bindings and driver support for a "rockchip,rt5651" codec. Replace "rockchip,rt5651" by "realtek,rt5651", which matches the "simple-audio-card,name" property in the "rt5651-sound" node.

Fixes 0a3c78e251b3a266 ("arm64: dts: rockchip: Add support for rk3399 excavator main board")
---
 arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts +1 -1
index dbec2b7173a0b677..31ea3d0182c062ef 100644
@@ -163,7 +163,7 @@ &i2c1 {
 	status = "okay";
 
 	rt5651: rt5651@1a {
-		compatible = "rockchip,rt5651";
+		compatible = "realtek,rt5651";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		clock-names = "mclk";
Signature · 1 line
2.34.1
maintainer Applied
#3 lore raw
In reply to Geert Uytterhoeven
Quoted 9 lines · Geert Uytterhoeven

Hi all,

This patch series fixes two occurrences of the "rockchip,rt5651" compatible value, which is not documented in DT bindings or supported in any upstream driver. Presumable these are typos for "realtek,rt5651", as the "simple-audio-card,name" properties in the "rt5651-sound" nodes refer to Realtek codecs.

[...]

Applied, thanks!

[1/2] arm64: dts: rockchip: rk3399-eaidk-610: Fix rt5651 compatible value

      commit: 2f39bba3b4f037d6c3c9174eed5befcef1c79abb
[2/2] arm64: dts: rockchip: rk3399-sapphire-excavator: Fix rt5651 compatible value
      commit: 577b5761679da90e691acc939ebbe7879fff5f31

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>