Skip to contentSkip to conversation

Use devm_register_power_off_handler() where appropriate

PATCH Applied Dragan Simic 2 participants 4 messages Nov 12, 2024 – Dec 11, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Use devm_register_power_off_handler() where appropriate

This is a tiny series that simplifies the code a bit in a couple of MFD drivers by using devm_register_power_off_handler(), which is a purpose- specific wrapper for devm_register_sys_off_handler().

No intended functional changes are introduced.

Dragan Simic (2):
mfd: axp20x: Use devm_register_power_off_handler()
mfd: stpmic1: Use devm_register_power_off_handler()

 drivers/mfd/axp20x.c  | 5 +----
 drivers/mfd/stpmic1.c | 6 +-----
 2 files changed, 2 insertions(+), 9 deletions(-)
#1 lore raw

PATCH 1/2 mfd: axp20x: Use devm_register_power_off_handler()

Simplify the code a bit by using devm_register_power_off_handler(), which is a purpose-specific wrapper for devm_register_sys_off_handler(). No intended functional changes are introduced.

---
 drivers/mfd/axp20x.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mfd/axp20x.c +1 -4
index 4051551757f2..2005d4291332 100644
@@ -1429,10 +1429,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
 	}
 
 	if (axp20x->variant != AXP288_ID)
-		devm_register_sys_off_handler(axp20x->dev,
-					      SYS_OFF_MODE_POWER_OFF,
-					      SYS_OFF_PRIO_DEFAULT,
-					      axp20x_power_off, axp20x);
+		devm_register_power_off_handler(axp20x->dev, axp20x_power_off, axp20x);
 
 	dev_info(axp20x->dev, "AXP20X driver loaded\n");
 
#2 lore raw

PATCH 2/2 mfd: stpmic1: Use devm_register_power_off_handler()

In reply to Dragan Simic

Simplify the code a bit by using devm_register_power_off_handler(), which is a purpose-specific wrapper for devm_register_sys_off_handler(). No intended functional changes are introduced.

---
 drivers/mfd/stpmic1.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/mfd/stpmic1.c +1 -5
index d8a603d95aa6..081827bc0596 100644
@@ -170,11 +170,7 @@ static int stpmic1_probe(struct i2c_client *i2c)
 		return ret;
 	}
 
-	ret = devm_register_sys_off_handler(ddata->dev,
-					    SYS_OFF_MODE_POWER_OFF,
-					    SYS_OFF_PRIO_DEFAULT,
-					    stpmic1_power_off,
-					    ddata);
+	ret = devm_register_power_off_handler(ddata->dev, stpmic1_power_off, ddata);
 	if (ret) {
 		dev_err(ddata->dev, "failed to register sys-off handler: %d\n", ret);
 		return ret;
maintainer Applied
#3 lore raw
In reply to Dragan Simic
Quoted 11 lines · Dragan Simic

This is a tiny series that simplifies the code a bit in a couple of MFD drivers by using devm_register_power_off_handler(), which is a purpose- specific wrapper for devm_register_sys_off_handler().

No intended functional changes are introduced.

Dragan Simic (2):
mfd: axp20x: Use devm_register_power_off_handler()
mfd: stpmic1: Use devm_register_power_off_handler()

[...]

Applied, thanks!

[1/2] mfd: axp20x: Use devm_register_power_off_handler()

      commit: c8729f5dc9aacd4bad8ac93487c2f5ee1c409f2c
[2/2] mfd: stpmic1: Use devm_register_power_off_handler()
      commit: d893a7ed58430259cbc939cd001e24833df93a75

--
Lee Jones [李琼斯]