net: hinic3: Add a driver for Huawei 3rd gen NIC
Subsystems (4)
cover net: hinic3: Add a driver for Huawei 3rd gen NIC
This is the 1/3 patch of the patch-set described below.
The patch-set contains driver for Huawei's 3rd generation HiNIC Ethernet device that will be available in the future.
This is an SRIOV device, designed for data centers. Initially, the driver only supports VFs.
Following the discussion over RFC01, the code will be submitted in separate smaller patches where until the last patch the driver is non-functional. The RFC02 submission contains overall view of the entire driver but every patch will be posted as a standalone submission.
Changes:
RFC V01: https://lore.kernel.org/netdev/[email protected]
RFC V02: https://lore.kernel.org/netdev/[email protected]
* Reduce overall line of code by removing optional functionality.
* Break down into smaller patches.
PATCH 01 V01:
* Documentation style and consistency fixes (from Bjorn Helgaas)
* Use ipoll instead of custom code (from Andrew Lunn)
* Move dev_set_drvdata up in initialization order (from Andrew Lunn)
* Use netdev's max_mtu, min_mtu (from Andrew Lunn)
* Fix variable 'xxx' set but not used warnings (from Linux patchwork)
gongfan (1):
hinic3: module initialization and tx/rx logic
.../device_drivers/ethernet/huawei/hinic3.rst | 137 ++++ MAINTAINERS | 7 + drivers/net/ethernet/huawei/Kconfig | 1 + drivers/net/ethernet/huawei/Makefile | 1 + drivers/net/ethernet/huawei/hinic3/Kconfig | 16 + drivers/net/ethernet/huawei/hinic3/Makefile | 21 + .../ethernet/huawei/hinic3/hinic3_common.c | 53 ++ .../ethernet/huawei/hinic3/hinic3_common.h | 27 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 30 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.h | 58 ++ .../ethernet/huawei/hinic3/hinic3_hw_comm.c | 37 + .../ethernet/huawei/hinic3/hinic3_hw_comm.h | 13 + .../ethernet/huawei/hinic3/hinic3_hw_intf.h | 85 +++ .../net/ethernet/huawei/hinic3/hinic3_hwdev.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_hwdev.h | 82 +++ .../net/ethernet/huawei/hinic3/hinic3_hwif.c | 15 + .../net/ethernet/huawei/hinic3/hinic3_hwif.h | 50 ++ .../net/ethernet/huawei/hinic3/hinic3_lld.c | 410 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_lld.h | 20 + .../net/ethernet/huawei/hinic3/hinic3_main.c | 415 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_mbox.c | 17 + .../net/ethernet/huawei/hinic3/hinic3_mbox.h | 16 + .../net/ethernet/huawei/hinic3/hinic3_mgmt.h | 13 + .../huawei/hinic3/hinic3_mgmt_interface.h | 111 +++ .../huawei/hinic3/hinic3_netdev_ops.c | 77 ++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.c | 254 +++++++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.h | 45 ++ .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 100 +++ .../ethernet/huawei/hinic3/hinic3_nic_io.c | 21 + .../ethernet/huawei/hinic3/hinic3_nic_io.h | 117 +++ .../huawei/hinic3/hinic3_queue_common.c | 65 ++ .../huawei/hinic3/hinic3_queue_common.h | 51 ++ .../net/ethernet/huawei/hinic3/hinic3_rss.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_rss.h | 12 + .../net/ethernet/huawei/hinic3/hinic3_rx.c | 401 ++++++++++ .../net/ethernet/huawei/hinic3/hinic3_rx.h | 91 +++ .../net/ethernet/huawei/hinic3/hinic3_tx.c | 691 ++++++++++++++++++ .../net/ethernet/huawei/hinic3/hinic3_tx.h | 129 ++++ .../net/ethernet/huawei/hinic3/hinic3_wq.c | 29 + .../net/ethernet/huawei/hinic3/hinic3_wq.h | 75 ++ 40 files changed, 3841 insertions(+) create mode 100644 Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst create mode 100644 drivers/net/ethernet/huawei/hinic3/Kconfig create mode 100644 drivers/net/ethernet/huawei/hinic3/Makefile create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_common.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_common.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_intf.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwif.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_lld.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_lld.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_main.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mbox.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mgmt_interface.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rss.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rss.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rx.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rx.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_tx.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_tx.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_wq.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_wq.h
base-commit: 65fb414c93f486cef5408951350f20552113abd0
Signature · 1 line
2.45.2
PATCH 1/1 hinic3: module initialization and tx/rx logic
From: gongfan <[email protected]>
This is [1/3] part of hinic3 Ethernet driver initial submission. With this patch hinic3 is a valid kernel module but non-functional driver.
The driver parts contained in this patch:
Module initialization.
PCI driver registration but with empty id_table. Auxiliary driver registration.
Net device_ops registration but open/stop are empty stubs. tx/rx logic.
All major data structures of the driver are fully introduced with the code that uses them but without their initialization code that requires management interface with the hw.
--- .../device_drivers/ethernet/huawei/hinic3.rst | 137 ++++ MAINTAINERS | 7 + drivers/net/ethernet/huawei/Kconfig | 1 + drivers/net/ethernet/huawei/Makefile | 1 + drivers/net/ethernet/huawei/hinic3/Kconfig | 16 + drivers/net/ethernet/huawei/hinic3/Makefile | 21 + .../ethernet/huawei/hinic3/hinic3_common.c | 53 ++ .../ethernet/huawei/hinic3/hinic3_common.h | 27 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 30 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.h | 58 ++ .../ethernet/huawei/hinic3/hinic3_hw_comm.c | 37 + .../ethernet/huawei/hinic3/hinic3_hw_comm.h | 13 + .../ethernet/huawei/hinic3/hinic3_hw_intf.h | 85 +++ .../net/ethernet/huawei/hinic3/hinic3_hwdev.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_hwdev.h | 82 +++ .../net/ethernet/huawei/hinic3/hinic3_hwif.c | 15 + .../net/ethernet/huawei/hinic3/hinic3_hwif.h | 50 ++ .../net/ethernet/huawei/hinic3/hinic3_lld.c | 410 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_lld.h | 20 + .../net/ethernet/huawei/hinic3/hinic3_main.c | 415 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_mbox.c | 17 + .../net/ethernet/huawei/hinic3/hinic3_mbox.h | 16 + .../net/ethernet/huawei/hinic3/hinic3_mgmt.h | 13 + .../huawei/hinic3/hinic3_mgmt_interface.h | 111 +++ .../huawei/hinic3/hinic3_netdev_ops.c | 77 ++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.c | 254 +++++++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.h | 45 ++ .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 100 +++ .../ethernet/huawei/hinic3/hinic3_nic_io.c | 21 + .../ethernet/huawei/hinic3/hinic3_nic_io.h | 117 +++ .../huawei/hinic3/hinic3_queue_common.c | 65 ++ .../huawei/hinic3/hinic3_queue_common.h | 51 ++ .../net/ethernet/huawei/hinic3/hinic3_rss.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_rss.h | 12 + .../net/ethernet/huawei/hinic3/hinic3_rx.c | 401 ++++++++++ .../net/ethernet/huawei/hinic3/hinic3_rx.h | 91 +++ .../net/ethernet/huawei/hinic3/hinic3_tx.c | 691 ++++++++++++++++++ .../net/ethernet/huawei/hinic3/hinic3_tx.h | 129 ++++ .../net/ethernet/huawei/hinic3/hinic3_wq.c | 29 + .../net/ethernet/huawei/hinic3/hinic3_wq.h | 75 ++ 40 files changed, 3841 insertions(+)
Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst new file +137 -0
@@ -0,0 +1,137 @@ +.. SPDX-License-Identifier: GPL-2.0 + +===================================================================== +Linux kernel driver for Huawei Ethernet Device Driver (hinic3) family +===================================================================== + +Overview +======== + +The hinic3 is a network interface card (NIC) for Data Center. It supports +a range of link-speed devices (10GE, 25GE, 100GE, etc.). The hinic3 +devices can have multiple physical forms (LOM NIC, PCIe standard NIC, +OCP NIC etc.). + +The hinic3 driver supports the following features: +- IPv4/IPv6 TCP/UDP checksum offload +- TSO (TCP Segmentation Offload), LRO (Large Receive Offload) +- RSS (Receive Side Scaling) +- MSI-X interrupt aggregation configuration and interrupt adaptation. +- SR-IOV (Single Root I/O Virtualization). + +Content +======= + +- Supported PCI vendor ID/device IDs +- Source Code Structure of Hinic3 Driver +- Management Interface + +Supported PCI vendor ID/device IDs +================================== + +19e5:0222 - hinic3 PF/PPF +19e5:375F - hinic3 VF + +Prime Physical Function (PPF) is responsible for the management of the +whole NIC card. For example, clock synchronization between the NIC and +the host. Any PF may serve as a PPF. The PPF is selected dynamically. + +Source Code Structure of Hinic3 Driver +====================================== + +======================== ================================================ +hinic3_pci_id_tbl.h Supported device IDs +hinic3_hw_intf.h Interface between HW and driver +hinic3_queue_common.[ch] Common structures and methods for NIC queues +hinic3_common.[ch] Encapsulation of memory operations in Linux +hinic3_csr.h Register definitions in the BAR +hinic3_hwif.[ch] Interface for BAR +hinic3_eqs.[ch] Interface for AEQs and CEQs +hinic3_mbox.[ch] Interface for mailbox +hinic3_mgmt.[ch] Management interface based on mailbox and AEQ +hinic3_wq.[ch] Work queue data structures and interface +hinic3_cmdq.[ch] Command queue is used to post command to HW +hinic3_hwdev.[ch] HW structures and methods abstractions +hinic3_lld.[ch] Auxiliary driver adaptation layer +hinic3_hw_comm.[ch] Interface for common HW operations +hinic3_mgmt_interface.h Interface between firmware and driver +hinic3_hw_cfg.[ch] Interface for HW configuration +hinic3_irq.c Interrupt request +hinic3_netdev_ops.c Operations registered to Linux kernel stack +hinic3_nic_dev.h NIC structures and methods abstractions +hinic3_main.c Main Linux kernel driver +hinic3_nic_cfg.[ch] NIC service configuration +hinic3_nic_io.[ch] Management plane interface for TX and RX +hinic3_rss.[ch] Interface for Receive Side Scaling (RSS) +hinic3_rx.[ch] Interface for transmit +hinic3_tx.[ch] Interface for receive +hinic3_ethtool.c Interface for ethtool operations (ops) +hinic3_filter.c Interface for MAC address +======================== ================================================ + +Management Interface +==================== + +Asynchronous Event Queue (AEQ) +------------------------------ + +AEQ receives high priority events from the HW over a descriptor queue. +Every descriptor is a fixed size of 64 bytes. AEQ can receive solicited or +unsolicited events. Every device, VF or PF, can have up to 4 AEQs. +Every AEQ is associated to a dedicated IRQ. AEQ can receive multiple types +of events, but in practice the hinic3 driver ignores all events except for +2 mailbox related events. + +Mailbox +------- + +Mailbox is a communication mechanism between the hinic3 driver and the HW. +Each device has an independent mailbox. Driver can use the mailbox to send +requests to management. Driver receives mailbox messages, such as responses +to requests, over the AEQ (using event HINIC3_AEQ_FOR_MBOX). Due to the +limited size of mailbox data register, mailbox messages are sent +segment-by-segment. + +Every device can use its mailbox to post request to firmware. The mailbox +can also be used to post requests and responses between the PF and its VFs. + +Completion Event Queue (CEQ) +-------------------------- + +The implementation of CEQ is the same as AEQ. It receives completion events +from HW over a fixed size descriptor of 32 bits. Every device can have up +to 32 CEQs. Every CEQ has a dedicated IRQ. CEQ only receives solicited +events that are responses to requests from the driver. CEQ can receive +multiple types of events, but in practice the hinic3 driver ignores all +events except for HINIC3_CMDQ that represents completion of previously +posted commands on a cmdq. + +Command Queue (cmdq) +-------------------- + +Every cmdq has a dedicated work queue on which commands are posted. +Commands on the work queue are fixed size descriptor of size 64 bytes. +Completion of a command will be indicated using ctrl bits in the +descriptor that carried the command. Notification of command completions +will also be provided via event on CEQ. Every device has 4 command queues +that are initialized as a set (called cmdqs), each with its own type. +Hinic3 driver only uses type HINIC3_CMDQ_SYNC. + +Work Queues(WQ) +--------------- + +Work queues are logical arrays of fixed size WQEs. The array may be spread +over multiple non-contiguous pages using indirection table. Work queues are +used by I/O queues and command queues. + +Global function ID +------------------ + +Every function, PF or VF, has a unique ordinal identification within the device. +Many commands to management (mbox or cmdq) contain this ID so HW can apply the +command effect to the right function. + +PF is allowed to post management commands to a subordinate VF by specifying the +VFs ID. A VF must provide its own ID. Anti-spoofing in the HW will cause +command from a VF to fail if it contains the wrong ID. +
MAINTAINERS +7 -0
@@ -10600,6 +10600,13 @@ S: Maintained F: Documentation/networking/device_drivers/ethernet/huawei/hinic.rst F: drivers/net/ethernet/huawei/hinic/ +HUAWEI 3RD GEN ETHERNET DRIVER +M: gongfan <[email protected]> +L: [email protected] +S: Supported +F: Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst +F: drivers/net/ethernet/huawei/hinic3/ + HUGETLB SUBSYSTEM M: Muchun Song <[email protected]> L: [email protected]
drivers/net/ethernet/huawei/Kconfig +1 -0
@@ -16,5 +16,6 @@ config NET_VENDOR_HUAWEI if NET_VENDOR_HUAWEI source "drivers/net/ethernet/huawei/hinic/Kconfig" +source "drivers/net/ethernet/huawei/hinic3/Kconfig" endif # NET_VENDOR_HUAWEI
drivers/net/ethernet/huawei/Makefile +1 -0
@@ -4,3 +4,4 @@ # obj-$(CONFIG_HINIC) += hinic/ +obj-$(CONFIG_HINIC3) += hinic3/
drivers/net/ethernet/huawei/hinic3/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Huawei driver configuration +# + +config HINIC3 + tristate "Huawei Intelligent Network Interface Card 3rd" + # Fields of HW and management structures are little endian and will not + # be explicitly converted + depends on 64BIT && !CPU_BIG_ENDIAN + depends on PCI_MSI && (X86 || ARM64) + help + This driver supports HiNIC PCIE Ethernet cards. + To compile this driver as part of the kernel, choose Y here. + If unsure, choose N. + The default is N.
drivers/net/ethernet/huawei/hinic3/Makefile new file +21 -0
@@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +obj-$(CONFIG_HINIC3) += hinic3.o + +hinic3-objs := hinic3_hwdev.o \ + hinic3_lld.o \ + hinic3_common.o \ + hinic3_hwif.o \ + hinic3_hw_cfg.o \ + hinic3_queue_common.o \ + hinic3_mbox.o \ + hinic3_hw_comm.o \ + hinic3_wq.o \ + hinic3_nic_io.o \ + hinic3_nic_cfg.o \ + hinic3_tx.o \ + hinic3_rx.o \ + hinic3_netdev_ops.o \ + hinic3_rss.o \ + hinic3_main.o
drivers/net/ethernet/huawei/hinic3/hinic3_common.c new file +53 -0
53 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_common.h new file +27 -0
@@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_COMMON_H +#define HINIC3_COMMON_H + +#include <linux/device.h> + +#define HINIC3_MIN_PAGE_SIZE 0x1000 + +struct hinic3_dma_addr_align { +u32 real_size; + +void *ori_vaddr; +dma_addr_t ori_paddr; + +void *align_vaddr; +dma_addr_t align_paddr; +}; + +int hinic3_dma_zalloc_coherent_align (struct device *dev,u32 size,u32 align, +gfp_t flag, +struct hinic3_dma_addr_align *mem_align); +void hinic3_dma_free_coherent_align (struct device *dev, +struct hinic3_dma_addr_align *mem_align); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c new file +30 -0
@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include <linux/device.h> + +#include "hinic3_hw_cfg.h" +#include "hinic3_hwdev.h" +#include "hinic3_mbox.h" +#include "hinic3_hwif.h" + +#define IS_NIC_TYPE (hwdev) \ + (((u32)(hwdev)->cfg_mgmt->svc_cap.chip_svc_type) & BIT(SERVICE_T_NIC)) + +bool hinic3_support_nic (struct hinic3_hwdev *hwdev) +{ +if (!IS_NIC_TYPE (hwdev)) +return false; + +return true; +} + +u16 hinic3_func_max_qnum (struct hinic3_hwdev *hwdev) +{ +return hwdev->cfg_mgmt->svc_cap.nic_cap.max_sqs; +} + +u8 hinic3_physical_port_id (struct hinic3_hwdev *hwdev) +{ +return hwdev->cfg_mgmt->svc_cap.port_id; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h new file +58 -0
58 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c new file +37 -0
@@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include <linux/delay.h> + +#include "hinic3_hw_comm.h" +#include "hinic3_hwdev.h" +#include "hinic3_mbox.h" +#include "hinic3_hwif.h" + +static int comm_msg_to_mgmt_sync (struct hinic3_hwdev *hwdev,u16 cmd,const void *buf_in, +u32 in_size,void *buf_out,u32 *out_size) +{ +return hinic3_send_mbox_to_mgmt (hwdev,HINIC3_MOD_COMM , cmd, buf_in, + in_size, buf_out, out_size,0 ); +} + +int hinic3_func_reset (struct hinic3_hwdev *hwdev,u16 func_id,u64 reset_flag) +{ +struct comm_cmd_func_reset func_reset; +u32 out_size =sizeof (func_reset); +int err; + +memset (&func_reset,0 ,sizeof (func_reset)); + func_reset.func_id = func_id; + func_reset.reset_flag = reset_flag; + err =comm_msg_to_mgmt_sync (hwdev,COMM_MGMT_CMD_FUNC_RESET , + &func_reset,sizeof (func_reset), + &func_reset, &out_size); +if (err || !out_size || func_reset.head.status) { +dev_err (hwdev->dev,"Failed to reset func resources, reset_flag 0x%llx, err: %d, status: 0x%x, out_size: 0x%x\n" , + reset_flag, err, func_reset.head.status, out_size); +return -EIO ; + } + +return 0 ; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_HW_COMM_H +#define HINIC3_HW_COMM_H + +#include "hinic3_hw_intf.h" + +struct hinic3_hwdev ; + +int hinic3_func_reset (struct hinic3_hwdev *hwdev,u16 func_id,u64 reset_flag); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_hw_intf.h new file +85 -0
85 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c new file +24 -0
@@ -0,0 +1,24 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include "hinic3_hwdev.h" +#include "hinic3_mbox.h" +#include "hinic3_mgmt.h" +#include "hinic3_hw_comm.h" +#include "hinic3_hwif.h" + +int hinic3_init_hwdev (struct pci_dev *pdev) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +} + +void hinic3_free_hwdev (struct hinic3_hwdev *hwdev) +{ +/* Completed by later submission due to LoC limit. */ +} + +void hinic3_set_api_stop (struct hinic3_hwdev *hwdev) +{ +/* Completed by later submission due to LoC limit. */ +}
drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h new file +82 -0
82 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c new file +15 -0
@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include <linux/device.h> +#include <linux/io.h> +#include <linux/bitfield.h> + +#include "hinic3_hwdev.h" +#include "hinic3_common.h" +#include "hinic3_hwif.h" + +u16 hinic3_global_func_id (struct hinic3_hwdev *hwdev) +{ +return hwdev->hwif->attr.func_global_idx; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hwif.h new file +50 -0
50 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c new file +410 -0
410 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_lld.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_LLD_H +#define HINIC3_LLD_H + +#include <linux/auxiliary_bus.h> + +struct hinic3_event_info ; + +#define HINIC3_NIC_DRV_NAME "hinic3" + +int hinic3_lld_init (void ); +void hinic3_lld_exit (void ); +int hinic3_adev_event_register (struct auxiliary_device *adev, +void (*event_handler)(struct auxiliary_device *adev, +struct hinic3_event_info *event)); +struct hinic3_hwdev *adev_get_hwdev (struct auxiliary_device *adev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_main.c new file +415 -0
415 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c new file +17 -0
@@ -0,0 +1,17 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include <linux/dma-mapping.h> + +#include "hinic3_mbox.h" +#include "hinic3_common.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" + +int hinic3_send_mbox_to_mgmt (struct hinic3_hwdev *hwdev,u8 mod,u16 cmd, +const void *buf_in,u32 in_size,void *buf_out, +u32 *out_size,u32 timeout) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +}
drivers/net/ethernet/huawei/hinic3/hinic3_mbox.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_MBOX_H +#define HINIC3_MBOX_H + +#include <linux/mutex.h> +#include <linux/bitfield.h> + +struct hinic3_hwdev ; + +int hinic3_send_mbox_to_mgmt (struct hinic3_hwdev *hwdev,u8 mod,u16 cmd, +const void *buf_in,u32 in_size,void *buf_out, +u32 *out_size,u32 timeout); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_MGMT_H +#define HINIC3_MGMT_H + +#include <linux/types.h> + +struct hinic3_hwdev ; + +void hinic3_flush_mgmt_workq (struct hinic3_hwdev *hwdev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_mgmt_interface.h new file +111 -0
111 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c new file +77 -0
77 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c new file +254 -0
254 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h new file +45 -0
45 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h new file +100 -0
100 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c new file +21 -0
@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include "hinic3_nic_io.h" +#include "hinic3_hwdev.h" +#include "hinic3_nic_cfg.h" +#include "hinic3_nic_dev.h" +#include "hinic3_hw_comm.h" +#include "hinic3_hw_intf.h" +#include "hinic3_hwif.h" + +int hinic3_init_nic_io (struct hinic3_nic_dev *nic_dev) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +} + +void hinic3_free_nic_io (struct hinic3_nic_dev *nic_dev) +{ +/* Completed by later submission due to LoC limit. */ +}
drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.h new file +117 -0
117 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c new file +65 -0
65 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h new file +51 -0
51 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_rss.c new file +24 -0
@@ -0,0 +1,24 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. + +#include "hinic3_rss.h" +#include "hinic3_hwdev.h" +#include "hinic3_nic_dev.h" +#include "hinic3_nic_cfg.h" +#include "hinic3_hwif.h" + +void hinic3_clear_rss_config (struct net_device *netdev) +{ +struct hinic3_nic_dev *nic_dev =netdev_priv (netdev); + +kfree (nic_dev->rss_hkey); + nic_dev->rss_hkey =NULL ; + +kfree (nic_dev->rss_indir); + nic_dev->rss_indir =NULL ; +} + +void hinic3_try_to_enable_rss (struct net_device *netdev) +{ +/* Completed by later submission due to LoC limit. */ +}
drivers/net/ethernet/huawei/hinic3/hinic3_rss.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2024. All rights reserved. */ + +#ifndef HINIC3_RSS_H +#define HINIC3_RSS_H + +#include <linux/netdevice.h> + +void hinic3_try_to_enable_rss (struct net_device *netdev); +void hinic3_clear_rss_config (struct net_device *netdev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_rx.c new file +401 -0
401 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_rx.h new file +91 -0
91 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_tx.c new file +691 -0
69 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_tx.h new file +129 -0
129 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_wq.c new file +29 -0
Lines of this file are not shown. View the raw message.
drivers/net/ethernet/huawei/hinic3/hinic3_wq.h new file +75 -0
75 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.45.2
Part of the diff is not shown here. View the raw message.
Jakub Kicinski
maintainerRe: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
drivers/net/ethernet/huawei/hinic3/Kconfig line 9
Quoted 4 lines · On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
drivers/net/ethernet/huawei/hinic3/Kconfig new file +4
-0+config HINIC3 + tristate "Huawei Intelligent Network Interface Card 3rd" + # Fields of HW and management structures are little endian and will not + # be explicitly converted
This is a PCIe device, users may plug it into any platform. Please annotate the endian of the data structures and use appropriate conversion helpers.
drivers/net/ethernet/huawei/hinic3/Kconfig line 11
Quoted 2 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +2
-0+ depends on 64BIT && !CPU_BIG_ENDIAN + depends on PCI_MSI && (X86 || ARM64)
Also allow COMPILE_TEST
Quoted 5 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +5
-0+ help + This driver supports HiNIC PCIE Ethernet cards. + To compile this driver as part of the kernel, choose Y here. + If unsure, choose N. + The default is N.
Signature · 1 line
pw-bot: cr
Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 10 lines · On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
drivers/net/ethernet/huawei/hinic3/Kconfig line 9
Quoted 4 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +4
-0+config HINIC3 + tristate "Huawei Intelligent Network Interface Card 3rd" + # Fields of HW and management structures are little endian and will not + # be explicitly convertedThis is a PCIe device, users may plug it into any platform. Please annotate the endian of the data structures and use appropriate conversion helpers.
This is basically saying that all drivers MUST support all architectures which is not a currently documented requirement.
As I said before, both Amazon and Microsoft have this dependency. They currently do not sell their HW so users cannot choose where to plug it, but they could start selling it whenever they want and the driver will remain the same.
The primary goal of this driver is for VMs in Huawei cloud, just like Amazon and Microsoft. Whether users can actually buy it in the future is unknown.
for the record, we did start at some point to change all integer members in management structures to __leXX and use cpu_to_le and le_to_cpu. There are hundreds of these and it made the code completely unreadable.
And since we do not plan to test the driver on POWER or ARM big endian I really don't see the point.
Quoted 5 lines
drivers/net/ethernet/huawei/hinic3/Kconfig line 11
Quoted 2 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +2
-0+ depends on 64BIT && !CPU_BIG_ENDIAN + depends on PCI_MSI && (X86 || ARM64)Also allow
COMPILE_TEST
Ack
Quoted 5 lines
Quoted 5 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +5
-0+ help + This driver supports HiNIC PCIE Ethernet cards. + To compile this driver as part of the kernel, choose Y here. + If unsure, choose N. + The default is N.
Jakub Kicinski
maintainerRe: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 20 lines · On Sun, 22 Dec 2024 10:12:25 +0200 Gur Stavi wrote:
Quoted 9 lines · On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
drivers/net/ethernet/huawei/hinic3/Kconfig line 9
Quoted 4 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +4
-0+config HINIC3 + tristate "Huawei Intelligent Network Interface Card 3rd" + # Fields of HW and management structures are little endian and will not + # be explicitly convertedThis is a PCIe device, users may plug it into any platform. Please annotate the endian of the data structures and use appropriate conversion helpers.
This is basically saying that all drivers MUST support all architectures which is not a currently documented requirement.
As I said before, both Amazon and Microsoft have this dependency. They currently do not sell their HW so users cannot choose where to plug it, but they could start selling it whenever they want and the driver will remain the same.
The primary goal of this driver is for VMs in Huawei cloud, just like Amazon and Microsoft. Whether users can actually buy it in the future is unknown.
Quoted 6 lines
for the record, we did start at some point to change all integer members in management structures to
__leXXand usecpu_to_leandle_to_cpu. There are hundreds of these and it made the code completely unreadable.And since we do not plan to test the driver on POWER or ARM big endian I really don't see the point.
I understand. But I'm concerned about the self-assured tone of the "it's not supported" message, that's very corporate verbiage. Annotating endian is standard practice of writing upstream drivers. It makes me doubt if you have any developers with upstream experience on your team if you don't know that. That and the fact that Huawei usually tops the list of net-negative review contributors in netdev.
Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 27 lines
Quoted 20 lines
Quoted 9 lines · On Thu, 19 Dec 2024 11:21:55 +0200 Gur Stavi wrote:
drivers/net/ethernet/huawei/hinic3/Kconfig line 9
Quoted 4 lines
drivers/net/ethernet/huawei/hinic3/Kconfig new file +4
-0+config HINIC3 + tristate "Huawei Intelligent Network Interface Card 3rd" + # Fields of HW and management structures are little endian and will not + # be explicitly convertedThis is a PCIe device, users may plug it into any platform. Please annotate the endian of the data structures and use appropriate conversion helpers.
This is basically saying that all drivers MUST support all architectures which is not a currently documented requirement.
As I said before, both Amazon and Microsoft have this dependency. They currently do not sell their HW so users cannot choose where to plug it, but they could start selling it whenever they want and the driver will remain the same.
The primary goal of this driver is for VMs in Huawei cloud, just like Amazon and Microsoft. Whether users can actually buy it in the future is unknown.Quoted 6 lines
for the record, we did start at some point to change all integer members in management structures to
__leXXand usecpu_to_leandle_to_cpu. There are hundreds of these and it made the code completely unreadable.And since we do not plan to test the driver on POWER or ARM big endian I really don't see the point.
Quoted 6 lines
I understand. But I'm concerned about the self-assured tone of the "it's not supported" message, that's very corporate verbiage. Annotating endian is standard practice of writing upstream drivers. It makes me doubt if you have any developers with upstream experience on your team if you don't know that. That and the fact that Huawei usually tops the list of net-negative review contributors in netdev.
The most popular combination in the last 3 decades was little endian CPUs with big endian device interfaces. Endianity conversion was a necessity and therefore endian annotation became standard practice. But it was never symmetric, conversion to/from BE was more common than conversion to/from LE.
As the pendulum moved from horizontal market to vertical market and major companies started to develop both hw and sw, the hw engineers transformed proprietary parts of the interface to little endian to save extra work in the sw. AWS did it. Azure did it. Huawei did it. These vertical companies do not care about endianity of CPUs they do not use.
This is not "corporate verbiage" this is a real market shift.
The necessity for endian conversion is gone (or just halved). Will the standard practice remain? There is not a single __le annotation in Amazon and Microsoft code. Not in Mellanox code either. Maybe their hw is fully BE (have to wonder about their DPUs). Amazingly, Intel that only creates little endian CPUs has lots of __le annotations. But they are the flag barer of horizontal market.
Interesting how both Amazon and Microsoft started with:
depends on X86
Thus evaded demand for adding __le annotations to the code. Later, both sneaked in quiet small patches with replacement to:
depends on !CPU_BIG_ENDIAN
Maybe that is the true meaning of "upstream experience".
Jakub Kicinski
maintainerRe: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 13 lines · On Wed, 25 Dec 2024 14:56:49 +0200 Gur Stavi wrote:
Quoted 6 lines
I understand. But I'm concerned about the self-assured tone of the "it's not supported" message, that's very corporate verbiage. Annotating endian is standard practice of writing upstream drivers. It makes me doubt if you have any developers with upstream experience on your team if you don't know that. That and the fact that Huawei usually tops the list of net-negative review contributors in netdev.
The most popular combination in the last 3 decades was little endian CPUs with big endian device interfaces. Endianity conversion was a necessity and therefore endian annotation became standard practice. But it was never symmetric, conversion to/from BE was more common than conversion to/from LE.
Quoted 6 lines
As the pendulum moved from horizontal market to vertical market and major companies started to develop both hw and sw, the hw engineers transformed proprietary parts of the interface to little endian to save extra work in the sw. AWS did it. Azure did it. Huawei did it. These vertical companies do not care about endianity of CPUs they do not use.
This is not "corporate verbiage" this is a real market shift.
Don't misquote me. You did it in your previous reply, now you're doing it again.
If you don't understand what I'm saying you can ask for clarifications.
Quoted 13 lines
The necessity for endian conversion is gone (or just halved). Will the standard practice remain? There is not a single
__leannotation in Amazon and Microsoft code. Not in Mellanox code either. Maybe their hw is fully BE (have to wonder about their DPUs). Amazingly, Intel that only creates little endian CPUs has lots of__leannotations. But they are the flag barer of horizontal market.Interesting how both Amazon and Microsoft started with:
depends on X86
Thus evaded demand for adding__leannotations to the code. Later, both sneaked in quiet small patches with replacement to:
depends on !CPU_BIG_ENDIAN
Maybe that is the true meaning of "upstream experience".
Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 20 lines
Quoted 13 lines
Quoted 6 lines
I understand. But I'm concerned about the self-assured tone of the "it's not supported" message, that's very corporate verbiage. Annotating endian is standard practice of writing upstream drivers. It makes me doubt if you have any developers with upstream experience on your team if you don't know that. That and the fact that Huawei usually tops the list of net-negative review contributors in netdev.
The most popular combination in the last 3 decades was little endian CPUs with big endian device interfaces. Endianity conversion was a necessity and therefore endian annotation became standard practice. But it was never symmetric, conversion to/from BE was more common than conversion to/from LE.
Quoted 6 lines
As the pendulum moved from horizontal market to vertical market and major companies started to develop both hw and sw, the hw engineers transformed proprietary parts of the interface to little endian to save extra work in the sw. AWS did it. Azure did it. Huawei did it. These vertical companies do not care about endianity of CPUs they do not use.
This is not "corporate verbiage" this is a real market shift.
Quoted 5 lines
Don't misquote me. You did it in your previous reply, now you're doing it again.
If you don't understand what I'm saying you can ask for clarifications.
We studied previous submissions and followed their example. Were the maintainers wrong to approve Amazon and Microsoft drivers?
I don't understand what the problem is. Please clarify.
Quoted 13 lines
Quoted 13 lines
The necessity for endian conversion is gone (or just halved). Will the standard practice remain? There is not a single
__leannotation in Amazon and Microsoft code. Not in Mellanox code either. Maybe their hw is fully BE (have to wonder about their DPUs). Amazingly, Intel that only creates little endian CPUs has lots of__leannotations. But they are the flag barer of horizontal market.Interesting how both Amazon and Microsoft started with:
depends on X86
Thus evaded demand for adding__leannotations to the code. Later, both sneaked in quiet small patches with replacement to:
depends on !CPU_BIG_ENDIAN
Maybe that is the true meaning of "upstream experience".
Jakub Kicinski
maintainerRe: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 13 lines · On Mon, 30 Dec 2024 16:14:35 +0200 Gur Stavi wrote:
Quoted 13 lines
Quoted 12 lines
The most popular combination in the last 3 decades was little endian CPUs with big endian device interfaces. Endianity conversion was a necessity and therefore endian annotation became standard practice. But it was never symmetric, conversion to/from BE was more common than conversion to/from LE.
As the pendulum moved from horizontal market to vertical market and major companies started to develop both hw and sw, the hw engineers transformed proprietary parts of the interface to little endian to save extra work in the sw. AWS did it. Azure did it. Huawei did it. These vertical companies do not care about endianity of CPUs they do not use.
This is not "corporate verbiage" this is a real market shift.
Quoted 7 lines
Quoted 4 lines
Don't misquote me. You did it in your previous reply, now you're doing it again.
If you don't understand what I'm saying you can ask for clarifications.
We studied previous submissions and followed their example. Were the maintainers wrong to approve Amazon and Microsoft drivers?
It's not a right or wrong question, more a cost/benefit question. I'm not sure the community benefits from merging every single company's paravirt driver, when virtio exists. I'd say having those drivers upstream is somewhere around neutral.
BTW very often guidance for new drivers is set by problems with already merged drivers. Not that it's necessarily the case here, just sharing some general knowledge about the upstream process.
Quoted 1 line
I don't understand what the problem is. Please clarify.
Primarily the fact that you keep arguing as if joining the community was done by winning a fight. If annotating HW structures with endian is beyond your / your teams capabilities, that's okay, just replace the "will not be converted" with "are currently not converted" in the comment.
For your reference here are the development stats showing that Huawei is the biggest net-taker of code reviews in networking:
https://lore.kernel.org/all/[email protected]/
Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic
Quoted 13 lines
Quoted 3 lines
We studied previous submissions and followed their example. Were the maintainers wrong to approve Amazon and Microsoft drivers?
It's not a right or wrong question, more a cost/benefit question. I'm not sure the community benefits from merging every single company's paravirt driver, when virtio exists. I'd say having those drivers upstream is somewhere around neutral.
BTW very often guidance for new drivers is set by problems with already merged drivers. Not that it's necessarily the case here, just sharing some general knowledge about the upstream process.
Quoted 8 lines
Quoted 1 line
I don't understand what the problem is. Please clarify.
Primarily the fact that you keep arguing as if joining the community was done by winning a fight. If annotating HW structures with endian is beyond your / your teams capabilities, that's okay, just replace the "will not be converted" with "are currently not converted" in the comment.
Ack
Quoted 3 lines
For your reference here are the development stats showing that Huawei is the biggest net-taker of code reviews in networking:
https://lore.kernel.org/all/[email protected]/