ALSA: hda: tas2781-spi: Delete some dead code
PATCH 1/2 ALSA: hda: tas2781-spi: Delete some dead code
In reply to a message not in the archiveThe scnprintf() function never returns negatives. And it won't return zero here either, plus if it did we'd need to fix the error code. Delete this dead code.
Signed-off-by Dan Carpenter <[email protected]>
--- sound/pci/hda/tas2781_hda_spi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
sound/pci/hda/tas2781_hda_spi.c +1 -5
@@ -274,13 +274,9 @@ static int tascodec_spi_init(struct tasdevice_priv *tas_priv,*/ guard (mutex)(&tas_priv->codec_lock); - ret =scnprintf (tas_priv->rca_binaryname, +scnprintf (tas_priv->rca_binaryname,sizeof (tas_priv->rca_binaryname),"%sRCA%d.bin" , tas_priv->dev_name, tas_priv->index); -if (ret <=0 ) { -dev_err (tas_priv->dev,"rca name err:0x%08x\n" , ret); -return ret; - }crc8_populate_msb (tas_priv->crc8_lkp_tbl,TASDEVICE_CRC8_POLYNOMIAL ); tas_priv->codec = codec; ret = request_firmware_nowait(module, FW_ACTION_UEVENT,
Signature · 1 line
2.45.2
PATCH 2/2 ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi()
In reply to a message not in the archivePropagate the error code from devm_gpiod_get_index_optional(). The current code returns success.
Fixes bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")
Signed-off-by Dan Carpenter <[email protected]>
--- sound/pci/hda/tas2781_hda_spi.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/tas2781_hda_spi.c +1 -0
@@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda, p->reset =devm_gpiod_get_index_optional (physdev,"reset" , p->index,GPIOD_OUT_LOW );if (IS_ERR (p->reset)) { + ret =PTR_ERR (p->reset);dev_err_probe (p->dev, ret,"Failed on reset GPIO\n" ); goto err; }
Signature · 1 line
2.45.2