Skip to contentSkip to conversation

Add System Components for Microchip SAMA7D65 SoC

PATCH Applied [email protected] 4 participants 19 messages Feb 14, 2025 – Feb 27, 2025

Subsystems (4)
Device tree bindings Arm/Microchip (AT91) SoC support dmaengine Watchdog device drivers

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover Add System Components for Microchip SAMA7D65 SoC

From: Ryan Wanner <[email protected]>

This patch set adds support for the following systems in the SAMA7D65 SoC:
- DMAs
- Chip ID
- Dual watchdog timer.

Ryan Wanner (8):
dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID
dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
dt-bindings: dma: atmel: add microchip,sama7d65-dma
ARM: at91: Add Support in SoC driver for SAMA7D65
ARM: dts: microchip: sama7d65: Add chipID for sama7d65
ARM: dts: microchip: sama7d65: Add watchdog for sama7d65
ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC
ARM: dts: microchip: sama7d65: Enable DMAs

 .../devicetree/bindings/arm/atmel-sysregs.txt |  1 +
 .../bindings/dma/atmel,sama5d4-dma.yaml       |  3 ++
 .../bindings/watchdog/atmel,sama5d4-wdt.yaml  |  3 ++
 .../dts/microchip/at91-sama7d65_curiosity.dts | 12 +++++
 arch/arm/boot/dts/microchip/sama7d65.dtsi     | 44 +++++++++++++++++++
 drivers/soc/atmel/soc.c                       |  5 +++
 drivers/soc/atmel/soc.h                       |  3 ++
 7 files changed, 71 insertions(+)
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 1/8 dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID

From: Ryan Wanner <[email protected]>

Add compatible string for SAMA7D65 SoC ChipID dt-bindings.

Signed-off-by Ryan Wanner <[email protected]>
---
 Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/atmel-sysregs.txt +1 -0
index 1a173e92bb137..d3821f651e728 100644
@@ -2,6 +2,7 @@ Atmel system registers
 
 Chipid required properties:
 - compatible: Should be "atmel,sama5d2-chipid" or "microchip,sama7g5-chipid"
+			"microchip,sama7d65-chipid"
 - reg : Should contain registers location and length
 
 PIT Timer required properties:
Signature · 1 line
2.43.0
author
#3 lore raw

PATCH 2/8 dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.

Signed-off-by Ryan Wanner <[email protected]>
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -0
index cdf87db361837..e9c026194d403 100644
@@ -23,6 +23,9 @@ properties:
           - const: microchip,sam9x7-wdt
           - const: microchip,sam9x60-wdt
 
+      - items:
+          - const: microchip,sama7d65-wdt
+          - const: microchip,sama7g5-wdt
   reg:
     maxItems: 1
Signature · 1 line
2.43.0
author
#6 lore raw

PATCH 3/8 dt-bindings: dma: atmel: add microchip,sama7d65-dma

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add microchip,sama7d65-dma compatible string to DT bindings documentation.

Signed-off-by Ryan Wanner <[email protected]>
---
 Documentation/devicetree/bindings/dma/atmel,sama5d4-dma.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/dma/atmel,sama5d4-dma.yaml +3 -0
index 9ca1c5d1f00f8..73fc13b902b38 100644
@@ -32,6 +32,9 @@ properties:
               - microchip,sam9x60-dma
               - microchip,sam9x7-dma
           - const: atmel,sama5d4-dma
+      - items:
+          - const: microchip,sama7d65-dma
+          - const: microchip,sama7g5-dma
 
   "#dma-cells":
     description: |
Signature · 1 line
2.43.0
author
#8 lore raw

PATCH 4/8 ARM: at91: Add Support in SoC driver for SAMA7D65

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add support for SAMA7D65 SoC in the SoC driver.

Signed-off-by Ryan Wanner <[email protected]>
---
 drivers/soc/atmel/soc.c | 5 +++++
 drivers/soc/atmel/soc.h | 3 +++
 2 files changed, 8 insertions(+)
drivers/soc/atmel/soc.c +5 -0
index 298b542dd1c06..68f20024dcebb 100644
@@ -246,6 +246,9 @@ static const struct at91_soc socs[] __initconst = {
 		 "samv70q19", "samv7"),
 #endif
 #ifdef CONFIG_SOC_SAMA7
+	AT91_SOC(SAMA7D65_CIDR_MATCH, AT91_CIDR_MASK_SAMA7G5,
+		 AT91_CIDR_VERSION_MASK_SAMA7G5, SAMA7D65_EXID_MATCH,
+		 "sama7d65", "sama7d6"),
 	AT91_SOC(SAMA7G5_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
 		 AT91_CIDR_VERSION_MASK_SAMA7G5, SAMA7G51_EXID_MATCH,
 		 "sama7g51", "sama7g5"),

@@ -305,6 +308,7 @@ static int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid)
 	void __iomem *regs;
 	static const struct of_device_id chipids[] = {
 		{ .compatible = "atmel,sama5d2-chipid" },
+		{ .compatible = "microchip,sama7d65-chipid"},
 		{ .compatible = "microchip,sama7g5-chipid" },
 		{ },
 	};

@@ -393,6 +397,7 @@ static const struct of_device_id at91_soc_allowed_list[] __initconst = {
 	{ .compatible = "atmel,at91sam9", },
 	{ .compatible = "atmel,sama5", },
 	{ .compatible = "atmel,samv7", },
+	{ .compatible = "microchip,sama7d65",},
 	{ .compatible = "microchip,sama7g5", },
 	{ }
 };
drivers/soc/atmel/soc.h +3 -0
index 2c78e54255f7f..66a74017d9a3e 100644
@@ -45,6 +45,7 @@ at91_soc_init(const struct at91_soc *socs);
 #define AT91SAM9N12_CIDR_MATCH		0x019a07a0
 #define SAM9X60_CIDR_MATCH		0x019b35a0
 #define SAM9X7_CIDR_MATCH		0x09750020
+#define SAMA7D65_CIDR_MATCH		0x00262100
 #define SAMA7G5_CIDR_MATCH		0x00162100
 
 #define AT91SAM9M11_EXID_MATCH		0x00000001

@@ -75,6 +76,8 @@ at91_soc_init(const struct at91_soc *socs);
 #define SAM9X75_D5M_EXID_MATCH		0x00000010
 #define SAM9X75_EXID_MATCH		0x00000000
 
+#define SAMA7D65_EXID_MATCH		0x00000080
+
 #define SAMA7G51_EXID_MATCH		0x3
 #define SAMA7G52_EXID_MATCH		0x2
 #define SAMA7G53_EXID_MATCH		0x1
Signature · 1 line
2.43.0
author
#9 lore raw

PATCH 5/8 ARM: dts: microchip: sama7d65: Add chipID for sama7d65

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add chipID for the sama7d65 SoC to the device tree.

Signed-off-by Ryan Wanner <[email protected]>
---
 arch/arm/boot/dts/microchip/sama7d65.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/microchip/sama7d65.dtsi +5 -0
index 854b30d15dcd4..b1b236e1f6e38 100644
@@ -83,6 +83,11 @@ clk32k: clock-controller@e001d500 {
 			#clock-cells = <1>;
 		};
 
+		chipid@e0020000 {
+			compatible = "microchip,sama7d65-chipid";
+			reg = <0xe0020000 0x8>;
+		};
+
 		sdmmc1: mmc@e1208000 {
 			compatible = "microchip,sama7d65-sdhci", "microchip,sam9x60-sdhci";
 			reg = <0xe1208000 0x400>;
Signature · 1 line
2.43.0
author
#10 lore raw

PATCH 6/8 ARM: dts: microchip: sama7d65: Add watchdog for sama7d65

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add watchdog timer support for SAMA7D65 SoC.

Signed-off-by Ryan Wanner <[email protected]>
---
 arch/arm/boot/dts/microchip/sama7d65.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/microchip/sama7d65.dtsi +7 -0
index b1b236e1f6e38..d06a51972d363 100644
@@ -83,6 +83,13 @@ clk32k: clock-controller@e001d500 {
 			#clock-cells = <1>;
 		};
 
+		ps_wdt: watchdog@e001d180 {
+			compatible = "microchip,sama7d65-wdt", "microchip,sama7g5-wdt";
+			reg = <0xe001d000 0x30>;
+			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk32k 0>;
+		};
+
 		chipid@e0020000 {
 			compatible = "microchip,sama7d65-chipid";
 			reg = <0xe0020000 0x8>;
Signature · 1 line
2.43.0
author
#12 lore raw

PATCH 7/8 ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Add DMAs to the SAMA7D65 SoC device tree.

Signed-off-by Ryan Wanner <[email protected]>
---
 arch/arm/boot/dts/microchip/sama7d65.dtsi | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/microchip/sama7d65.dtsi +32 -0
index d06a51972d363..b472a7d929ee4 100644
@@ -9,6 +9,7 @@
  */
 
 #include <dt-bindings/clock/at91.h>
+#include <dt-bindings/dma/at91.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/interrupt-controller/irq.h>

@@ -95,6 +96,17 @@ chipid@e0020000 {
 			reg = <0xe0020000 0x8>;
 		};
 
+		dma2: dma-controller@e1200000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = <0xe1200000 0x1000>;
+			interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>;
+			clock-names = "dma_clk";
+			dma-requests = <0>;
+			status = "disabled";
+		};
+
 		sdmmc1: mmc@e1208000 {
 			compatible = "microchip,sama7d65-sdhci", "microchip,sam9x60-sdhci";
 			reg = <0xe1208000 0x400>;

@@ -107,6 +119,26 @@ sdmmc1: mmc@e1208000 {
 			status = "disabled";
 		};
 
+		dma0: dma-controller@e1610000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = < 0xe1610000 0x1000>;
+			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 21>;
+			clock-names = "dma_clk";
+			status = "disabled";
+		};
+
+		dma1: dma-controller@e1614000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = <0xe1614000 0x1000>;
+			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 22>;
+			clock-names = "dma_clk";
+			status = "disabled";
+		};
+
 		pit64b0: timer@e1800000 {
 			compatible = "microchip,sama7d65-pit64b", "microchip,sam9x60-pit64b";
 			reg = <0xe1800000 0x100>;
Signature · 1 line
2.43.0
author
#14 lore raw

PATCH 8/8 ARM: dts: microchip: sama7d65: Enable DMAs

In reply to [email protected]

From: Ryan Wanner <[email protected]>

Enable DMA interface for sama7d65_curiosity board.

Signed-off-by Ryan Wanner <[email protected]>
---
 .../boot/dts/microchip/at91-sama7d65_curiosity.dts   | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts +12 -0
index 0f86360fb733a..0c21e3ed3a95a 100644
@@ -32,6 +32,18 @@ memory@60000000 {
 	};
 };
 
+&dma0 {
+	status = "okay";
+};
+
+&dma1 {
+	status = "okay";
+};
+
+&dma2 {
+	status = "okay";
+};
+
 &flx6 {
 	atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
 	status = "okay";
Signature · 1 line
2.43.0
maintainer
#13 lore raw

Re: [PATCH 7/8] ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC

In reply to [email protected]

Hi, Ryan,

Quoted 40 lines · On 14.02.2025 20:08, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Add DMAs to the SAMA7D65 SoC device tree.

Signed-off-by Ryan Wanner <[email protected]>
---
 arch/arm/boot/dts/microchip/sama7d65.dtsi | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/microchip/sama7d65.dtsi +12 -0
index d06a51972d363..b472a7d929ee4 100644
@@ -9,6 +9,7 @@
  */
 
 #include <dt-bindings/clock/at91.h>
+#include <dt-bindings/dma/at91.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/interrupt-controller/irq.h>

@@ -95,6 +96,17 @@ chipid@e0020000 {
 			reg = <0xe0020000 0x8>;
 		};
 
+		dma2: dma-controller@e1200000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = <0xe1200000 0x1000>;
+			interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>;
+			clock-names = "dma_clk";
+			dma-requests = <0>;
+			status = "disabled";
+		};
+
 		sdmmc1: mmc@e1208000 {
 			compatible = "microchip,sama7d65-sdhci", "microchip,sam9x60-sdhci";
 			reg = <0xe1208000 0x400>;

arch/arm/boot/dts/microchip/sama7d65.dtsi sdmmc1: mmc@e1208000 { · line 124

Quoted 6 lines
arch/arm/boot/dts/microchip/sama7d65.dtsi +3 -0
@@ -107,6 +119,26 @@ sdmmc1: mmc@e1208000 {
 			status = "disabled";
 		};
 
+		dma0: dma-controller@e1610000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = < 0xe1610000 0x1000>;

There is an extra space b/w < and 0x. I can adjust while applying.

Quoted 20 lines
arch/arm/boot/dts/microchip/sama7d65.dtsi +17 -0
+			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 21>;
+			clock-names = "dma_clk";
+			status = "disabled";
+		};
+
+		dma1: dma-controller@e1614000 {
+			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
+			reg = <0xe1614000 0x1000>;
+			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 22>;
+			clock-names = "dma_clk";
+			status = "disabled";
+		};
+
 		pit64b0: timer@e1800000 {
 			compatible = "microchip,sama7d65-pit64b", "microchip,sam9x60-pit64b";
 			reg = <0xe1800000 0x100>;
maintainer
#4 lore raw

Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

In reply to [email protected]
Quoted 14 lines · On 14.02.2025 20:08, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.

Signed-off-by Ryan Wanner <[email protected]>
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
index cdf87db361837..e9c026194d403 100644

Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml properties: · line 25

Quoted 3 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
@@ -23,6 +23,9 @@ properties:
           - const: microchip,sam9x7-wdt
           - const: microchip,sam9x60-wdt

You could have keep this new line after the items section that you've added.

Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml properties: · line 28

Quoted 3 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -0
+      - items:
+          - const: microchip,sama7d65-wdt
+          - const: microchip,sama7g5-wdt

here.

Quoted 3 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
   reg:
     maxItems: 1
maintainer
#15 lore raw
In reply to [email protected]

Hi, Ryan,

Quoted 8 lines · On 14.02.2025 20:08, [email protected] wrote:

From: Ryan Wanner <[email protected]>

This patch set adds support for the following systems in the SAMA7D65 SoC:
- DMAs
- Chip ID
- Dual watchdog timer.

Quoted 9 lines

Ryan Wanner (8):
dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID
dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
dt-bindings: dma: atmel: add microchip,sama7d65-dma
ARM: at91: Add Support in SoC driver for SAMA7D65
ARM: dts: microchip: sama7d65: Add chipID for sama7d65
ARM: dts: microchip: sama7d65: Add watchdog for sama7d65
ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC
ARM: dts: microchip: sama7d65: Enable DMAs

Series looks good to me. I'm waiting to see if there are comments on bindings before applying the DT part.

Thank you,
Claudiu

maintainer
#16 lore raw
In reply to [email protected]
Quoted 27 lines · On Fri, 14 Feb 2025 11:08:13 -0700, [email protected] wrote:

From: Ryan Wanner <[email protected]>

This patch set adds support for the following systems in the SAMA7D65 SoC:
- DMAs
- Chip ID
- Dual watchdog timer.

Ryan Wanner (8):
dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID
dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
dt-bindings: dma: atmel: add microchip,sama7d65-dma
ARM: at91: Add Support in SoC driver for SAMA7D65
ARM: dts: microchip: sama7d65: Add chipID for sama7d65
ARM: dts: microchip: sama7d65: Add watchdog for sama7d65
ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC
ARM: dts: microchip: sama7d65: Enable DMAs

 .../devicetree/bindings/arm/atmel-sysregs.txt |  1 +
 .../bindings/dma/atmel,sama5d4-dma.yaml       |  3 ++
 .../bindings/watchdog/atmel,sama5d4-wdt.yaml  |  3 ++
 .../dts/microchip/at91-sama7d65_curiosity.dts | 12 +++++
 arch/arm/boot/dts/microchip/sama7d65.dtsi     | 44 +++++++++++++++++++
 drivers/soc/atmel/soc.c                       |  5 +++
 drivers/soc/atmel/soc.h                       |  3 ++
 7 files changed, 71 insertions(+)
Quoted 5 lines

--
2.43.0

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/microchip/' for [email protected]:

arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: watchdog@e001d180: Unevaluated properties are not allowed ('clocks' was unexpected)
from schema $id: http://devicetree.org/schemas/watchdog/atmel,sama5d4-wdt.yaml#
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/chipid@e0020000: failed to match any schema with compatible: ['microchip,sama7d65-chipid']

maintainer Acked-by on v1 1/8
#2 lore raw

Re: [PATCH 1/8] dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID

In reply to [email protected]
Quoted 8 lines · On Fri, Feb 14, 2025 at 11:08:14AM -0700, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Add compatible string for SAMA7D65 SoC ChipID dt-bindings.

Signed-off-by Ryan Wanner <[email protected]>
---
 Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 +
 1 file changed, 1 insertion(+)
Acked-by Rob Herring (Arm) <[email protected]>

But please convert this to schema.

Rob

maintainer
#5 lore raw

Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

In reply to Claudiu Beznea
Quoted 23 lines · Claudiu Beznea
Quoted 14 lines · On 14.02.2025 20:08, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.

Signed-off-by Ryan Wanner <[email protected]>
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
index cdf87db361837..e9c026194d403 100644

Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml properties: · line 25

Quoted 3 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
@@ -23,6 +23,9 @@ properties:
           - const: microchip,sam9x7-wdt
           - const: microchip,sam9x60-wdt

You could have keep this new line after the items section that you've added.

Quoted 5 lines

Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml properties: · line 28

Quoted 3 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +3 -0
+      - items:
+          - const: microchip,sama7d65-wdt
+          - const: microchip,sama7g5-wdt

here.

Please do.

Quoted 5 lines
Quoted 4 lines
Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml +0 -0
   reg:
     maxItems: 1
maintainer Acked-by on v1 3/8
#7 lore raw

Re: [PATCH 3/8] dt-bindings: dma: atmel: add microchip,sama7d65-dma

In reply to [email protected]
Quoted 10 lines · On Fri, 14 Feb 2025 11:08:16 -0700, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Add microchip,sama7d65-dma compatible string to DT bindings documentation.

Signed-off-by Ryan Wanner <[email protected]>
---
 Documentation/devicetree/bindings/dma/atmel,sama5d4-dma.yaml | 3 +++
 1 file changed, 3 insertions(+)
Acked-by Rob Herring (Arm) <[email protected]>
maintainer
#11 lore raw

Re: [PATCH 6/8] ARM: dts: microchip: sama7d65: Add watchdog for sama7d65

In reply to [email protected]

Hi, Ryan,

arch/arm/boot/dts/microchip/sama7d65.dtsi clk32k: clock-controller@e001d500 { · line 88

Quoted 3 lines · On 14.02.2025 20:08, [email protected] wrote:
arch/arm/boot/dts/microchip/sama7d65.dtsi +3 -0
+		ps_wdt: watchdog@e001d180 {
+			compatible = "microchip,sama7d65-wdt", "microchip,sama7g5-wdt";
+			reg = <0xe001d000 0x30>;

The node address and the one specified in reg don't match. I will skip applying this.

Also, please sort the nodes by their addresses.

Thank you,
Claudiu

Quoted 4 lines
arch/arm/boot/dts/microchip/sama7d65.dtsi +4 -0
+			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk32k 0>;
+		};
+
maintainer Applied
#17 lore raw
In reply to [email protected]
Quoted 5 lines · On 14.02.2025 20:08, [email protected] wrote:

From: Ryan Wanner <[email protected]>

Ryan Wanner (8):
dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID
ARM: at91: Add Support in SoC driver for SAMA7D65

Applied to at91-soc, thanks!

Quoted 3 lines

ARM: dts: microchip: sama7d65: Add chipID for sama7d65
ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC
ARM: dts: microchip: sama7d65: Enable DMAs

Applied to at91-dt, thanks!

maintainer Applied
#18 lore raw

Re: (subset) [PATCH 0/8] Add System Components for Microchip SAMA7D65 SoC

In reply to [email protected]
Quoted 16 lines · On Fri, 14 Feb 2025 11:08:13 -0700, [email protected] wrote:

This patch set adds support for the following systems in the SAMA7D65 SoC:
- DMAs
- Chip ID
- Dual watchdog timer.

Ryan Wanner (8):
dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID
dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
dt-bindings: dma: atmel: add microchip,sama7d65-dma
ARM: at91: Add Support in SoC driver for SAMA7D65
ARM: dts: microchip: sama7d65: Add chipID for sama7d65
ARM: dts: microchip: sama7d65: Add watchdog for sama7d65
ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC
ARM: dts: microchip: sama7d65: Enable DMAs

Quoted 1 line

[...]

Applied, thanks!

[3/8] dt-bindings: dma: atmel: add microchip,sama7d65-dma

      commit: e19ba02eeb8e98086708ee11ca1b123d17ec1977

Best regards,

Signature · 1 line
~Vinod