iio: adc: ad71{73,92}: Grab direct mode for calibration
Subsystems (3)
cover iio: adc: ad71{73,92}: Grab direct mode for calibration
Hello,
in a patch series I sent last week
(https://lore.kernel.org/linux-iio/[email protected])
a review comment by David suggested to claim direct mode for calibration and he also pointed out that this is missing from a few other drivers.
These drivers are fixed here.
Best regards
Uwe
Uwe Kleine-König (2):
iio: adc: ad7173: Grab direct mode for calibration
iio: adc: ad7192: Grab direct mode for calibration
drivers/iio/adc/ad7173.c | 5 +++++ drivers/iio/adc/ad7192.c | 5 +++++ 2 files changed, 10 insertions(+)
base-commit: 66e80e2f21762bdaa56a4d63c79e5aca5f6bd93c
prerequisite-patch-id: afd7caae7616d474e5a1a68e963828a88fa9cd3b
prerequisite-patch-id: f5900fd31dc701cf190c7b451e0917e5b659f03b
prerequisite-patch-id: 3c1b44d4645eee7668f543f0e9148c52337e1cd9
prerequisite-patch-id: 9f600afd72914d22298067f86c1298d18cb335cd
prerequisite-patch-id: 16607d29f72b649d63790b9c4c0852c089d27a1f
prerequisite-patch-id: edc1a70e612a16ff5a72b05741beb02f874c7d1b
prerequisite-patch-id: 4370980539a471328b354e94529da4dfe915b573
prerequisite-patch-id: 0bdad93ca4dd031c335799abdbf6c93e36f27dcc
prerequisite-patch-id: 4aa927f0072026df1ad9627a82f73b45250ad950
prerequisite-patch-id: 027c26bf1a9c762ebb9828682a61537051835cc4
Signature · 1 line
2.47.1
PATCH 1/2 iio: adc: ad7173: Grab direct mode for calibration
While a calibration is running, better don't make the device do anything else.
To enforce that, grab direct mode during calibration.
--- drivers/iio/adc/ad7173.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/iio/adc/ad7173.c +5 -0
@@ -349,6 +349,9 @@ static ssize_t ad7173_write_syscalib(struct iio_dev *indio_dev,if (ret)return ret; +if (!iio_device_claim_direct (indio_dev)) +return -EBUSY ; + mode = st->channels[chan->channel].syscalib_mode;if (sys_calib) {if (mode ==AD7173_SYSCALIB_ZERO_SCALE )
@@ -359,6 +362,8 @@ static ssize_t ad7173_write_syscalib(struct iio_dev *indio_dev, chan->address); } +iio_device_release_direct (indio_dev); +return ret ? : len; }
Signature · 1 line
2.47.1
PATCH 2/2 iio: adc: ad7192: Grab direct mode for calibration
In reply to Uwe Kleine-KönigWhile a calibration is running, better don't make the device do anything else.
To enforce that, grab direct mode during calibration.
--- drivers/iio/adc/ad7192.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/iio/adc/ad7192.c +5 -0
@@ -256,6 +256,9 @@ static ssize_t ad7192_write_syscalib(struct iio_dev *indio_dev,if (ret)return ret; +if (!iio_device_claim_direct (indio_dev)) +return -EBUSY ; + temp = st->syscalib_mode[chan->channel];if (sys_calib) {if (temp ==AD7192_SYSCALIB_ZERO_SCALE )
@@ -266,6 +269,8 @@ static ssize_t ad7192_write_syscalib(struct iio_dev *indio_dev, chan->address); } +iio_device_release_direct (indio_dev); +return ret ? ret : len; }
Signature · 1 line
2.47.1
Quoted 22 lines · Uwe Kleine-König
Hello,
in a patch series I sent last week
(https://lore.kernel.org/linux-iio/[email protected])
a review comment by David suggested to claim direct mode for calibration and he also pointed out that this is missing from a few other drivers.These drivers are fixed here.
Best regards
UweUwe Kleine-König (2):
iio: adc: ad7173: Grab direct mode for calibration
iio: adc: ad7192: Grab direct mode for calibrationdrivers/iio/adc/ad7173.c | 5 +++++ drivers/iio/adc/ad7192.c | 5 +++++ 2 files changed, 10 insertions(+)
Quoted 11 lines
base-commit:
66e80e2f21762bdaa56a4d63c79e5aca5f6bd93c
prerequisite-patch-id:afd7caae7616d474e5a1a68e963828a88fa9cd3b
prerequisite-patch-id:f5900fd31dc701cf190c7b451e0917e5b659f03b
prerequisite-patch-id:3c1b44d4645eee7668f543f0e9148c52337e1cd9
prerequisite-patch-id:9f600afd72914d22298067f86c1298d18cb335cd
prerequisite-patch-id:16607d29f72b649d63790b9c4c0852c089d27a1f
prerequisite-patch-id:edc1a70e612a16ff5a72b05741beb02f874c7d1b
prerequisite-patch-id:4370980539a471328b354e94529da4dfe915b573
prerequisite-patch-id:0bdad93ca4dd031c335799abdbf6c93e36f27dcc
prerequisite-patch-id:4aa927f0072026df1ad9627a82f73b45250ad950
prerequisite-patch-id:027c26bf1a9c762ebb9828682a61537051835cc4
Note this is non-sense. The patch set applies just fine to 66e80e2f21762bdaa56a4d63c79e5aca5f6bd93c (i.e. iio/togreg from a few days ago). It also applies fine to today's iio/togreg.
Best regards
Uwe
Jonathan Cameron
maintainerQuoted 9 lines · On Thu, 27 Feb 2025 12:35:26 +0100 Uwe Kleine-König…
Hello,
in a patch series I sent last week
(https://lore.kernel.org/linux-iio/[email protected])
a review comment by David suggested to claim direct mode for calibration and he also pointed out that this is missing from a few other drivers.These drivers are fixed here.
I've applied these to the togreg branch of iio.git an pushed out as testing but please consider if these are suitable for a backport once this version lands upstream. The change in handling of claiming direct mode will require manual backport.
Thanks,
Jonathan
Quoted 24 lines
Best regards
UweUwe Kleine-König (2):
iio: adc: ad7173: Grab direct mode for calibration
iio: adc: ad7192: Grab direct mode for calibrationdrivers/iio/adc/ad7173.c | 5 +++++ drivers/iio/adc/ad7192.c | 5 +++++ 2 files changed, 10 insertions(+)base-commit:
66e80e2f21762bdaa56a4d63c79e5aca5f6bd93c
prerequisite-patch-id:afd7caae7616d474e5a1a68e963828a88fa9cd3b
prerequisite-patch-id:f5900fd31dc701cf190c7b451e0917e5b659f03b
prerequisite-patch-id:3c1b44d4645eee7668f543f0e9148c52337e1cd9
prerequisite-patch-id:9f600afd72914d22298067f86c1298d18cb335cd
prerequisite-patch-id:16607d29f72b649d63790b9c4c0852c089d27a1f
prerequisite-patch-id:edc1a70e612a16ff5a72b05741beb02f874c7d1b
prerequisite-patch-id:4370980539a471328b354e94529da4dfe915b573
prerequisite-patch-id:0bdad93ca4dd031c335799abdbf6c93e36f27dcc
prerequisite-patch-id:4aa927f0072026df1ad9627a82f73b45250ad950
prerequisite-patch-id:027c26bf1a9c762ebb9828682a61537051835cc4