xfs/539: Ignore remount failures on v5 xfs
v2 cover xfs/539: Ignore remount failures on v5 xfs
The test just checks for the deprecation dmesg
warnings when remounted with noattr2 and ikeep, and they appear even if the remount fails. I wrote the patch because xfs/539 has started failing in one of our fstests CI runs because RHEL 10 has started disabling xfs v4 support i.e, CONFIG_XFS_SUPPORT_V4=n. The reason why it was not failing with CONFIG_XFS_SUPPORT_V4=y is because remount was incorrectly succeeding - reason is explained in [2].
[v1] --> v2
- Removed patch 2/3 and patch 3/3 for now,
- For patch 1/3 - Ignore the mount failure instead of skipping noattr2.
[v1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
Nirjhar Roy (IBM) (1):
xfs/539: Ignore remount failures on v5 xfs
tests/xfs/539 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
PATCH v2 1/1 xfs/539: Ignore remount failures on v5 xfs
Remount with noattr2 fails on a v5 filesystem, however the deprecation warnings still get printed and that is exactly what the test is checking. So ignore the mount failures in this case.
--- tests/xfs/539 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/539 +1 -1
@@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do done for VAR in {noattr2,ikeep}; do log_tag - _scratch_remount $VAR + _scratch_remount $VAR >> $seqres.full 2>&1 check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \ echo "Could not find deprecation warning for $VAR" done
Signature · 1 line
2.34.1
Quoted 3 lines · Nirjhar Roy (IBM)
Remount with noattr2 fails on a v5 filesystem, however the deprecation warnings still get printed and that is exactly what the test is checking. So ignore the mount failures in this case.
Hi,
Can I please get some review on this?
--NR
Quoted 19 lines
Signed-off-by Nirjhar Roy (IBM) <[email protected]>--- tests/xfs/539 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/xfs/539 +1
-1@@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do done for VAR in {noattr2,ikeep}; do log_tag - _scratch_remount $VAR + _scratch_remount $VAR >> $seqres.full 2>&1 check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \ echo "Could not find deprecation warning for $VAR" done
Signature · 3 lines
Nirjhar Roy Linux Kernel Developer IBM, Bangalore
Quoted 14 lines · Nirjhar Roy (IBM)
Remount with noattr2 fails on a v5 filesystem, however the deprecation warnings still get printed and that is exactly what the test is checking. So ignore the mount failures in this case.
Signed-off-by Nirjhar Roy (IBM) <[email protected]>--- tests/xfs/539 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/xfs/539 +0
-0
tests/xfs/539 for VAR in {attr2,noikeep}; do · line 67
Quoted 8 lines
tests/xfs/539 +1
-1@@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do done for VAR in {noattr2,ikeep}; do log_tag - _scratch_remount $VAR + _scratch_remount $VAR >> $seqres.full 2>&1 check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \ echo "Could not find deprecation warning for $VAR" done
Quoted 11 lines · Pavel Reichl
Quoted 9 lines · Nirjhar Roy (IBM)
Remount with noattr2 fails on a v5 filesystem, however the deprecation warnings still get printed and that is exactly what the test is checking. So ignore the mount failures in this case.
Signed-off-by Nirjhar Roy (IBM) <[email protected]>---
tests/xfs/539 | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
tests/xfs/539 +0
-0@@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; doQuoted 8 lines
done
for VAR in {noattr2,ikeep}; do
log_tag
-_scratch_remount$VAR
+_scratch_remount$VAR >> $seqres.full 2>&1check_dmesg_for_since_tag"XFS: $VAR mount option is deprecated" || \
echo "Could not find deprecation warning for $VAR" doneReviewed-by Pavel Reichl <[email protected]>
Thank you for the review.
--NR
Signature · 3 lines
Nirjhar Roy Linux Kernel Developer IBM, Bangalore