net: hinic3: Add a driver for Huawei 3rd gen NIC
Subsystems (4)
v8 cover net: hinic3: Add a driver for Huawei 3rd gen NIC
This is the 1/3 patch of the patch-set described below.
The patch-set contains driver for Huawei's 3rd generation HiNIC Ethernet device that will be available in the future.
This is an SRIOV device, designed for data centers. Initially, the driver only supports VFs.
Following the discussion over RFC01, the code will be submitted in separate smaller patches where until the last patch the driver is non-functional. The RFC02 submission contains overall view of the entire driver but every patch will be posted as a standalone submission.
Changes:
RFC V01: https://lore.kernel.org/netdev/[email protected]
RFC V02: https://lore.kernel.org/netdev/[email protected]
* Reduce overall line of code by removing optional functionality.
* Break down into smaller patches.
PATCH 01 V01: https://lore.kernel.org/netdev/[email protected]
* Documentation style and consistency fixes (from Bjorn Helgaas)
* Use ipoll instead of custom code (from Andrew Lunn)
* Move dev_set_drvdata up in initialization order (from Andrew Lunn)
* Use netdev's max_mtu, min_mtu (from Andrew Lunn)
* Fix variable 'xxx' set but not used warnings (from Linux patchwork)
PATCH 01 V02: https://lore.kernel.org/netdev/[email protected]
* Add comment regarding usage of random MAC. (Andrew Lunn)
* Add COMPILE_TEST to Kconfig (Jakub Kicinski)
PATCH 01 V03: https://lore.kernel.org/netdev/[email protected]
* Rephrase Kconfig comment (Jakub Kicinski)
* Kconfig: add 'select AUXILIARY_BUS' (Kernel test robot)
* ARCH=um: missing include 'net/ip6_checksum.h' (Kernel test robot)
PATCH 01 V04: https://lore.kernel.org/netdev/[email protected]
* Improve naming consistency, missing hinic3 prefixes (Suman Ghosh)
* Change hinic3_remove_func to void (Suman Ghosh)
* Add adev_event_unregister (Suman Ghosh)
* Add comment for service types enum (Suman Ghosh)
PATCH 01 V05: https://lore.kernel.org/netdev/[email protected]
* Fix signed-by signatures (Przemek Kitszel)
* Expand initials in documentation (Przemek Kitszel)
* Update copyright messages to 2025 (Przemek Kitszel)
* Sort filenames in makefile (Przemek Kitszel)
* Sort include statements (Przemek Kitszel)
* Reduce padding in irq allocation struct (Przemek Kitszel)
* Replace memset of zero with '= {}' init (Przemek Kitszel)
* Revise mbox API to avoid using same pointer twice (Przemek Kitszel)
* Use 2 underscores for header file ifdef guards (Przemek Kitszel)
* Remove 'Intelligent' from Kconfig (Przemek Kitszel)
* Documentation, fix line length mismatch to header (Simon Horman)
PATCH 01 V06: https://lore.kernel.org/netdev/[email protected]
* Add hinic3 doc to device_drivers/ethernet TOC (Jakub Kicinski)
PATCH 01 V07: https://lore.kernel.org/netdev/[email protected]
* Remove unneeded conversion to bool (Jakub Kicinski)
* Use net_prefetch and net_prefetchw (Joe Damato)
* Push IRQ coalescing and rss alloc/free to later patch (Joe Damato)
* Pull additional rx/tx/napi code from next patch (Joe Damato)
PATCH 01 V08:
* Fix build warning following pulling napi code from later patch (patchwork)
* Add missing net/gro.h include for napi_gro_flush (patchwork)
Fan Gong (1):
hinic3: module initialization and tx/rx logic
.../device_drivers/ethernet/huawei/hinic3.rst | 137 ++++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 + drivers/net/ethernet/huawei/Kconfig | 1 + drivers/net/ethernet/huawei/Makefile | 1 + drivers/net/ethernet/huawei/hinic3/Kconfig | 19 + drivers/net/ethernet/huawei/hinic3/Makefile | 21 + .../ethernet/huawei/hinic3/hinic3_common.c | 53 ++ .../ethernet/huawei/hinic3/hinic3_common.h | 27 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 25 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.h | 53 ++ .../ethernet/huawei/hinic3/hinic3_hw_comm.c | 32 + .../ethernet/huawei/hinic3/hinic3_hw_comm.h | 13 + .../ethernet/huawei/hinic3/hinic3_hw_intf.h | 113 +++ .../net/ethernet/huawei/hinic3/hinic3_hwdev.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_hwdev.h | 81 ++ .../net/ethernet/huawei/hinic3/hinic3_hwif.c | 21 + .../net/ethernet/huawei/hinic3/hinic3_hwif.h | 58 ++ .../net/ethernet/huawei/hinic3/hinic3_irq.c | 47 ++ .../net/ethernet/huawei/hinic3/hinic3_lld.c | 416 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_lld.h | 21 + .../net/ethernet/huawei/hinic3/hinic3_main.c | 360 +++++++++ .../net/ethernet/huawei/hinic3/hinic3_mbox.c | 16 + .../net/ethernet/huawei/hinic3/hinic3_mbox.h | 15 + .../net/ethernet/huawei/hinic3/hinic3_mgmt.h | 13 + .../huawei/hinic3/hinic3_mgmt_interface.h | 105 +++ .../huawei/hinic3/hinic3_netdev_ops.c | 76 ++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.c | 230 ++++++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.h | 39 + .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 91 +++ .../ethernet/huawei/hinic3/hinic3_nic_io.c | 21 + .../ethernet/huawei/hinic3/hinic3_nic_io.h | 118 +++ .../huawei/hinic3/hinic3_queue_common.c | 67 ++ .../huawei/hinic3/hinic3_queue_common.h | 54 ++ .../net/ethernet/huawei/hinic3/hinic3_rx.c | 404 ++++++++++ .../net/ethernet/huawei/hinic3/hinic3_rx.h | 91 +++ .../net/ethernet/huawei/hinic3/hinic3_tx.c | 693 ++++++++++++++++++ .../net/ethernet/huawei/hinic3/hinic3_tx.h | 130 ++++ .../net/ethernet/huawei/hinic3/hinic3_wq.c | 29 + .../net/ethernet/huawei/hinic3/hinic3_wq.h | 76 ++ 40 files changed, 3799 insertions(+) create mode 100644 Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst create mode 100644 drivers/net/ethernet/huawei/hinic3/Kconfig create mode 100644 drivers/net/ethernet/huawei/hinic3/Makefile create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_common.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_common.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hw_intf.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_hwif.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_irq.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_lld.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_lld.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_main.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mbox.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_mgmt_interface.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rx.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_rx.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_tx.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_tx.h create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_wq.c create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_wq.h
base-commit: f252f23ab657cd224cb8334ba69966396f3f629b
Signature · 1 line
2.45.2
PATCH v8 1/1 hinic3: module initialization and tx/rx logic
From: Fan Gong <[email protected]>
This is [1/3] part of hinic3 Ethernet driver initial submission. With this patch hinic3 is a valid kernel module but non-functional driver.
The driver parts contained in this patch:
Module initialization.
PCI driver registration but with empty id_table. Auxiliary driver registration.
Net device_ops registration but open/stop are empty stubs. tx/rx logic.
All major data structures of the driver are fully introduced with the code that uses them but without their initialization code that requires management interface with the hw.
--- .../device_drivers/ethernet/huawei/hinic3.rst | 137 ++++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 + drivers/net/ethernet/huawei/Kconfig | 1 + drivers/net/ethernet/huawei/Makefile | 1 + drivers/net/ethernet/huawei/hinic3/Kconfig | 19 + drivers/net/ethernet/huawei/hinic3/Makefile | 21 + .../ethernet/huawei/hinic3/hinic3_common.c | 53 ++ .../ethernet/huawei/hinic3/hinic3_common.h | 27 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 25 + .../ethernet/huawei/hinic3/hinic3_hw_cfg.h | 53 ++ .../ethernet/huawei/hinic3/hinic3_hw_comm.c | 32 + .../ethernet/huawei/hinic3/hinic3_hw_comm.h | 13 + .../ethernet/huawei/hinic3/hinic3_hw_intf.h | 113 +++ .../net/ethernet/huawei/hinic3/hinic3_hwdev.c | 24 + .../net/ethernet/huawei/hinic3/hinic3_hwdev.h | 81 ++ .../net/ethernet/huawei/hinic3/hinic3_hwif.c | 21 + .../net/ethernet/huawei/hinic3/hinic3_hwif.h | 58 ++ .../net/ethernet/huawei/hinic3/hinic3_irq.c | 47 ++ .../net/ethernet/huawei/hinic3/hinic3_lld.c | 416 +++++++++++ .../net/ethernet/huawei/hinic3/hinic3_lld.h | 21 + .../net/ethernet/huawei/hinic3/hinic3_main.c | 360 +++++++++ .../net/ethernet/huawei/hinic3/hinic3_mbox.c | 16 + .../net/ethernet/huawei/hinic3/hinic3_mbox.h | 15 + .../net/ethernet/huawei/hinic3/hinic3_mgmt.h | 13 + .../huawei/hinic3/hinic3_mgmt_interface.h | 105 +++ .../huawei/hinic3/hinic3_netdev_ops.c | 76 ++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.c | 230 ++++++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.h | 39 + .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 91 +++ .../ethernet/huawei/hinic3/hinic3_nic_io.c | 21 + .../ethernet/huawei/hinic3/hinic3_nic_io.h | 118 +++ .../huawei/hinic3/hinic3_queue_common.c | 67 ++ .../huawei/hinic3/hinic3_queue_common.h | 54 ++ .../net/ethernet/huawei/hinic3/hinic3_rx.c | 404 ++++++++++ .../net/ethernet/huawei/hinic3/hinic3_rx.h | 91 +++ .../net/ethernet/huawei/hinic3/hinic3_tx.c | 693 ++++++++++++++++++ .../net/ethernet/huawei/hinic3/hinic3_tx.h | 130 ++++ .../net/ethernet/huawei/hinic3/hinic3_wq.c | 29 + .../net/ethernet/huawei/hinic3/hinic3_wq.h | 76 ++ 40 files changed, 3799 insertions(+)
Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst new file +137 -0
@@ -0,0 +1,137 @@ +.. SPDX-License-Identifier: GPL-2.0 + +===================================================================== +Linux kernel driver for Huawei Ethernet Device Driver (hinic3) family +===================================================================== + +Overview +======== + +The hinic3 is a network interface card (NIC) for Data Center. It supports +a range of link-speed devices (10GE, 25GE, 100GE, etc.). The hinic3 +devices can have multiple physical forms: LOM (Lan on Motherboard) NIC, +PCIe standard NIC, OCP (Open Compute Project) NIC, etc. + +The hinic3 driver supports the following features: +- IPv4/IPv6 TCP/UDP checksum offload +- TSO (TCP Segmentation Offload), LRO (Large Receive Offload) +- RSS (Receive Side Scaling) +- MSI-X interrupt aggregation configuration and interrupt adaptation. +- SR-IOV (Single Root I/O Virtualization). + +Content +======= + +- Supported PCI vendor ID/device IDs +- Source Code Structure of Hinic3 Driver +- Management Interface + +Supported PCI vendor ID/device IDs +================================== + +19e5:0222 - hinic3 PF/PPF +19e5:375F - hinic3 VF + +Prime Physical Function (PPF) is responsible for the management of the +whole NIC card. For example, clock synchronization between the NIC and +the host. Any PF may serve as a PPF. The PPF is selected dynamically. + +Source Code Structure of Hinic3 Driver +====================================== + +======================== ================================================ +hinic3_pci_id_tbl.h Supported device IDs +hinic3_hw_intf.h Interface between HW and driver +hinic3_queue_common.[ch] Common structures and methods for NIC queues +hinic3_common.[ch] Encapsulation of memory operations in Linux +hinic3_csr.h Register definitions in the BAR +hinic3_hwif.[ch] Interface for BAR +hinic3_eqs.[ch] Interface for AEQs and CEQs +hinic3_mbox.[ch] Interface for mailbox +hinic3_mgmt.[ch] Management interface based on mailbox and AEQ +hinic3_wq.[ch] Work queue data structures and interface +hinic3_cmdq.[ch] Command queue is used to post command to HW +hinic3_hwdev.[ch] HW structures and methods abstractions +hinic3_lld.[ch] Auxiliary driver adaptation layer +hinic3_hw_comm.[ch] Interface for common HW operations +hinic3_mgmt_interface.h Interface between firmware and driver +hinic3_hw_cfg.[ch] Interface for HW configuration +hinic3_irq.c Interrupt request +hinic3_netdev_ops.c Operations registered to Linux kernel stack +hinic3_nic_dev.h NIC structures and methods abstractions +hinic3_main.c Main Linux kernel driver +hinic3_nic_cfg.[ch] NIC service configuration +hinic3_nic_io.[ch] Management plane interface for TX and RX +hinic3_rss.[ch] Interface for Receive Side Scaling (RSS) +hinic3_rx.[ch] Interface for transmit +hinic3_tx.[ch] Interface for receive +hinic3_ethtool.c Interface for ethtool operations (ops) +hinic3_filter.c Interface for MAC address +======================== ================================================ + +Management Interface +==================== + +Asynchronous Event Queue (AEQ) +------------------------------ + +AEQ receives high priority events from the HW over a descriptor queue. +Every descriptor is a fixed size of 64 bytes. AEQ can receive solicited or +unsolicited events. Every device, VF or PF, can have up to 4 AEQs. +Every AEQ is associated to a dedicated IRQ. AEQ can receive multiple types +of events, but in practice the hinic3 driver ignores all events except for +2 mailbox related events. + +Mailbox +------- + +Mailbox is a communication mechanism between the hinic3 driver and the HW. +Each device has an independent mailbox. Driver can use the mailbox to send +requests to management. Driver receives mailbox messages, such as responses +to requests, over the AEQ (using event HINIC3_AEQ_FOR_MBOX). Due to the +limited size of mailbox data register, mailbox messages are sent +segment-by-segment. + +Every device can use its mailbox to post request to firmware. The mailbox +can also be used to post requests and responses between the PF and its VFs. + +Completion Event Queue (CEQ) +---------------------------- + +The implementation of CEQ is the same as AEQ. It receives completion events +from HW over a fixed size descriptor of 32 bits. Every device can have up +to 32 CEQs. Every CEQ has a dedicated IRQ. CEQ only receives solicited +events that are responses to requests from the driver. CEQ can receive +multiple types of events, but in practice the hinic3 driver ignores all +events except for HINIC3_CMDQ that represents completion of previously +posted commands on a cmdq. + +Command Queue (cmdq) +-------------------- + +Every cmdq has a dedicated work queue on which commands are posted. +Commands on the work queue are fixed size descriptor of size 64 bytes. +Completion of a command will be indicated using ctrl bits in the +descriptor that carried the command. Notification of command completions +will also be provided via event on CEQ. Every device has 4 command queues +that are initialized as a set (called cmdqs), each with its own type. +Hinic3 driver only uses type HINIC3_CMDQ_SYNC. + +Work Queues(WQ) +--------------- + +Work queues are logical arrays of fixed size WQEs. The array may be spread +over multiple non-contiguous pages using indirection table. Work queues are +used by I/O queues and command queues. + +Global function ID +------------------ + +Every function, PF or VF, has a unique ordinal identification within the device. +Many management commands (mbox or cmdq) contain this ID so HW can apply the +command effect to the right function. + +PF is allowed to post management commands to a subordinate VF by specifying the +VFs ID. A VF must provide its own ID. Anti-spoofing in the HW will cause +command from a VF to fail if it contains the wrong ID. +
Documentation/networking/device_drivers/ethernet/index.rst +1 -0
@@ -28,6 +28,7 @@ Contents: freescale/gianfar google/gve huawei/hinic + huawei/hinic3 intel/e100 intel/e1000 intel/e1000e
MAINTAINERS +7 -0
@@ -10687,6 +10687,13 @@ S: Maintained F: Documentation/networking/device_drivers/ethernet/huawei/hinic.rst F: drivers/net/ethernet/huawei/hinic/ +HUAWEI 3RD GEN ETHERNET DRIVER +M: Fan Gong <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst +F: drivers/net/ethernet/huawei/hinic3/ + HUGETLB SUBSYSTEM M: Muchun Song <[email protected]> L: [email protected]
drivers/net/ethernet/huawei/Kconfig +1 -0
@@ -16,5 +16,6 @@ config NET_VENDOR_HUAWEI if NET_VENDOR_HUAWEI source "drivers/net/ethernet/huawei/hinic/Kconfig" +source "drivers/net/ethernet/huawei/hinic3/Kconfig" endif # NET_VENDOR_HUAWEI
drivers/net/ethernet/huawei/Makefile +1 -0
@@ -4,3 +4,4 @@ # obj-$(CONFIG_HINIC) += hinic/ +obj-$(CONFIG_HINIC3) += hinic3/
drivers/net/ethernet/huawei/hinic3/Kconfig new file +19 -0
@@ -0,0 +1,19 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Huawei driver configuration +# + +config HINIC3 + tristate "Huawei 3rd generation network adapters (HINIC3) support" + # Fields of HW and management structures are little endian and are + # currently not converted + depends on !CPU_BIG_ENDIAN + depends on X86 || ARM64 || COMPILE_TEST + depends on PCI_MSI && 64BIT + select AUXILIARY_BUS + help + This driver supports HiNIC 3rd gen Network Adapter (HINIC3). + The driver is supported on X86_64 and ARM64 little endian. + + To compile this driver as a module, choose M here. + The module will be called hinic3.
drivers/net/ethernet/huawei/hinic3/Makefile new file +21 -0
@@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +obj-$(CONFIG_HINIC3) += hinic3.o + +hinic3-objs := hinic3_common.o \ + hinic3_hw_cfg.o \ + hinic3_hw_comm.o \ + hinic3_hwdev.o \ + hinic3_hwif.o \ + hinic3_irq.o \ + hinic3_lld.o \ + hinic3_main.o \ + hinic3_mbox.o \ + hinic3_netdev_ops.o \ + hinic3_nic_cfg.o \ + hinic3_nic_io.o \ + hinic3_queue_common.o \ + hinic3_rx.o \ + hinic3_tx.o \ + hinic3_wq.o
drivers/net/ethernet/huawei/hinic3/hinic3_common.c new file +53 -0
53 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_common.h new file +27 -0
@@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_COMMON_H_ +#define _HINIC3_COMMON_H_ + +#include <linux/device.h> + +#define HINIC3_MIN_PAGE_SIZE 0x1000 + +struct hinic3_dma_addr_align { +u32 real_size; + +void *ori_vaddr; +dma_addr_t ori_paddr; + +void *align_vaddr; +dma_addr_t align_paddr; +}; + +int hinic3_dma_zalloc_coherent_align (struct device *dev,u32 size,u32 align, +gfp_t flag, +struct hinic3_dma_addr_align *mem_align); +void hinic3_dma_free_coherent_align (struct device *dev, +struct hinic3_dma_addr_align *mem_align); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c new file +25 -0
@@ -0,0 +1,25 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include <linux/device.h> + +#include "hinic3_hw_cfg.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" +#include "hinic3_mbox.h" + +bool hinic3_support_nic (struct hinic3_hwdev *hwdev) +{ +return (u32 )hwdev->cfg_mgmt->cap.supp_svcs_bitmap & +BIT (HINIC3_SERVICE_T_NIC ); +} + +u16 hinic3_func_max_qnum (struct hinic3_hwdev *hwdev) +{ +return hwdev->cfg_mgmt->cap.nic_svc_cap.max_sqs; +} + +u8 hinic3_physical_port_id (struct hinic3_hwdev *hwdev) +{ +return hwdev->cfg_mgmt->cap.port_id; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h new file +53 -0
53 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c new file +32 -0
@@ -0,0 +1,32 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include <linux/delay.h> + +#include "hinic3_hw_comm.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" +#include "hinic3_mbox.h" + +int hinic3_func_reset (struct hinic3_hwdev *hwdev,u16 func_id,u64 reset_flag) +{ +struct comm_cmd_func_reset func_reset = {}; +struct mgmt_msg_params msg_params = {}; +int err; + + func_reset.func_id = func_id; + func_reset.reset_flag = reset_flag; + +mgmt_msg_params_init_default (&msg_params, &func_reset, +sizeof (func_reset)); + + err =hinic3_send_mbox_to_mgmt (hwdev,MGMT_MOD_COMM , +COMM_CMD_FUNC_RESET , &msg_params); +if (err || func_reset.head.status) { +dev_err (hwdev->dev,"Failed to reset func resources, reset_flag 0x%llx, err: %d, status: 0x%x\n" , + reset_flag, err, func_reset.head.status); +return -EIO ; + } + +return 0 ; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_HW_COMM_H_ +#define _HINIC3_HW_COMM_H_ + +#include "hinic3_hw_intf.h" + +struct hinic3_hwdev ; + +int hinic3_func_reset (struct hinic3_hwdev *hwdev,u16 func_id,u64 reset_flag); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_hw_intf.h new file +113 -0
113 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c new file +24 -0
@@ -0,0 +1,24 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include "hinic3_hw_comm.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" +#include "hinic3_mbox.h" +#include "hinic3_mgmt.h" + +int hinic3_init_hwdev (struct pci_dev *pdev) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +} + +void hinic3_free_hwdev (struct hinic3_hwdev *hwdev) +{ +/* Completed by later submission due to LoC limit. */ +} + +void hinic3_set_api_stop (struct hinic3_hwdev *hwdev) +{ +/* Completed by later submission due to LoC limit. */ +}
drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h new file +81 -0
81 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c new file +21 -0
@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include <linux/bitfield.h> +#include <linux/device.h> +#include <linux/io.h> + +#include "hinic3_common.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" + +void hinic3_set_msix_state (struct hinic3_hwdev *hwdev,u16 msix_idx, +enum hinic3_msix_state flag) +{ +/* Completed by later submission due to LoC limit. */ +} + +u16 hinic3_global_func_id (struct hinic3_hwdev *hwdev) +{ +return hwdev->hwif->attr.func_global_idx; +}
drivers/net/ethernet/huawei/hinic3/hinic3_hwif.h new file +58 -0
58 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_irq.c new file +47 -0
47 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c new file +416 -0
416 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_lld.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_LLD_H_ +#define _HINIC3_LLD_H_ + +#include <linux/auxiliary_bus.h> + +struct hinic3_event_info ; + +#define HINIC3_NIC_DRV_NAME "hinic3" + +int hinic3_lld_init (void ); +void hinic3_lld_exit (void ); +void hinic3_adev_event_register (struct auxiliary_device *adev, +void (*event_handler)(struct auxiliary_device *adev, +struct hinic3_event_info *event)); +void hinic3_adev_event_unregister (struct auxiliary_device *adev); +struct hinic3_hwdev *hinic3_adev_get_hwdev (struct auxiliary_device *adev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_main.c new file +360 -0
360 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c new file +16 -0
@@ -0,0 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include <linux/dma-mapping.h> + +#include "hinic3_common.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" +#include "hinic3_mbox.h" + +int hinic3_send_mbox_to_mgmt (struct hinic3_hwdev *hwdev,u8 mod,u16 cmd, +const struct mgmt_msg_params *msg_params) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +}
drivers/net/ethernet/huawei/hinic3/hinic3_mbox.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_MBOX_H_ +#define _HINIC3_MBOX_H_ + +#include <linux/bitfield.h> +#include <linux/mutex.h> + +struct hinic3_hwdev ; + +int hinic3_send_mbox_to_mgmt (struct hinic3_hwdev *hwdev,u8 mod,u16 cmd, +const struct mgmt_msg_params *msg_params); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_MGMT_H_ +#define _HINIC3_MGMT_H_ + +#include <linux/types.h> + +struct hinic3_hwdev ; + +void hinic3_flush_mgmt_workq (struct hinic3_hwdev *hwdev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_mgmt_interface.h new file +105 -0
105 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c new file +76 -0
76 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c new file +230 -0
230 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h new file +39 -0
@@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. */ + +#ifndef _HINIC3_NIC_CFG_H_ +#define _HINIC3_NIC_CFG_H_ + +#include <linux/types.h> + +#include "hinic3_hw_intf.h" +#include "hinic3_mgmt_interface.h" + +struct hinic3_hwdev ; +struct hinic3_nic_dev ; + +#define HINIC3_MIN_MTU_SIZE 256 +#define HINIC3_MAX_JUMBO_FRAME_SIZE 9600 + +#define HINIC3_VLAN_ID_MASK 0x7FFF + +enum hinic3_nic_event_type { +HINIC3_NIC_EVENT_LINK_DOWN =0 , +HINIC3_NIC_EVENT_LINK_UP =1 , +}; + +int hinic3_set_nic_feature_to_hw (struct hinic3_nic_dev *nic_dev); +bool hinic3_test_support (struct hinic3_nic_dev *nic_dev, +enum hinic3_nic_feature_cap feature_bits); +void hinic3_update_nic_feature (struct hinic3_nic_dev *nic_dev,u64 feature_cap); + +int hinic3_set_port_mtu (struct net_device *netdev,u16 new_mtu); + +int hinic3_set_mac (struct hinic3_hwdev *hwdev,const u8 *mac_addr,u16 vlan_id,u16 func_id); +int hinic3_del_mac (struct hinic3_hwdev *hwdev,const u8 *mac_addr,u16 vlan_id,u16 func_id); +int hinic3_update_mac (struct hinic3_hwdev *hwdev,const u8 *old_mac,u8 *new_mac,u16 vlan_id, +u16 func_id); + +int hinic3_force_drop_tx_pkt (struct hinic3_hwdev *hwdev); + +#endif
drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h new file +91 -0
91 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c new file +21 -0
@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) Huawei Technologies Co., Ltd. 2025. All rights reserved. + +#include "hinic3_hw_comm.h" +#include "hinic3_hw_intf.h" +#include "hinic3_hwdev.h" +#include "hinic3_hwif.h" +#include "hinic3_nic_cfg.h" +#include "hinic3_nic_dev.h" +#include "hinic3_nic_io.h" + +int hinic3_init_nic_io (struct hinic3_nic_dev *nic_dev) +{ +/* Completed by later submission due to LoC limit. */ +return -EFAULT ; +} + +void hinic3_free_nic_io (struct hinic3_nic_dev *nic_dev) +{ +/* Completed by later submission due to LoC limit. */ +}
drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.h new file +118 -0
118 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c new file +67 -0
67 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h new file +54 -0
54 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_rx.c new file +404 -0
404 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_rx.h new file +91 -0
91 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_tx.c new file +693 -0
109 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_tx.h new file +130 -0
130 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic3/hinic3_wq.c new file +29 -0
Lines of this file are not shown. View the raw message.
drivers/net/ethernet/huawei/hinic3/hinic3_wq.h new file +76 -0
76 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.45.2
Part of the diff is not shown here. View the raw message.
Simon Horman
reviewerRe: [PATCH net-next v08 1/1] hinic3: module initialization and tx/rx logic
Quoted 17 lines · Gur Stavi
From: Fan Gong <[email protected]>
This is [1/3] part of hinic3 Ethernet driver initial submission. With this patch hinic3 is a valid kernel module but non-functional driver.
The driver parts contained in this patch:
Module initialization.
PCI driver registration but with emptyid_table. Auxiliary driver registration.
Netdevice_opsregistration but open/stop are empty stubs. tx/rx logic.All major data structures of the driver are fully introduced with the code that uses them but without their initialization code that requires management interface with the hw.
Quoted 5 lines
Co-developed-by Xin Guo <[email protected]>Signed-off-by Xin Guo <[email protected]>Signed-off-by Fan Gong <[email protected]>Co-developed-by Gur Stavi <[email protected]>Signed-off-by Gur Stavi <[email protected]>
Hi Gur,
I've reviewed this patch paying particular attention to error handling.
Please find some minor feedback below.
...
Quoted 1 line
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +0
-0
...
Quoted 12 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +12
-0+static int hinic3_probe_func (struct hinic3_pcidev *pci_adapter) +{ +struct pci_dev *pdev = pci_adapter->pdev; +int err; + + err =hinic3_mapping_bar (pdev, pci_adapter); +if (err) { +dev_err (&pdev->dev,"Failed to map bar\n" ); + goto err_map_bar; + } + + err =hinic3_func_init (pdev, pci_adapter);
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c line 337
Quoted 10 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +10
-0+if (err) + goto err_func_init; + +return 0 ; + +err_func_init: +hinic3_unmapping_bar (pci_adapter); + +err_map_bar: +dev_err (&pdev->dev,"Pcie device probe function failed\n" );
nit: PCIE
Quoted 2 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +2
-0+return err; +}
...
Quoted 11 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +11
-0+static int hinic3_sw_init (struct net_device *netdev) +{ +struct hinic3_nic_dev *nic_dev =netdev_priv (netdev); +struct hinic3_hwdev *hwdev = nic_dev->hwdev; +int err; + + nic_dev->q_params.sq_depth =HINIC3_SQ_DEPTH ; + nic_dev->q_params.rq_depth =HINIC3_RQ_DEPTH ; + +/* VF driver always uses random MAC address. During VM migration to a +* new device, the new device should learn the VMs old MAC rather than
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c
Quoted 10 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +10
-0+* provide its own MAC. The product design assumes that every VF is +* suspectable to migration so the device avoids offering MAC address +* to VFs. +*/ +eth_hw_addr_random (netdev); + err =hinic3_set_mac (hwdev, netdev->dev_addr,0 , +hinic3_global_func_id (hwdev)); +if (err) { +dev_err (hwdev->dev,"Failed to set default MAC\n" ); + goto err_out;
nit: I think it would be slightly nicer to simply return err here
and drop the err_out label. This is because there is no unwind to perform in this error case.
Likewise for any similar cases that may be in this patch (I didn't spot any so far).
Quoted 25 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +25
-0+ } + + err =hinic3_alloc_txrxqs (netdev); +if (err) { +dev_err (hwdev->dev,"Failed to alloc qps\n" ); + goto err_alloc_qps; + } + +return 0 ; + +err_alloc_qps: +hinic3_del_mac (hwdev, netdev->dev_addr,0 ,hinic3_global_func_id (hwdev)); + +err_out: +return err; +} + +static void hinic3_sw_deinit (struct net_device *netdev) +{ +struct hinic3_nic_dev *nic_dev =netdev_priv (netdev); + +hinic3_free_txrxqs (netdev); +hinic3_del_mac (nic_dev->hwdev, netdev->dev_addr,0 , +hinic3_global_func_id (nic_dev->hwdev)); +}
...
Quoted 46 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +46
-0+static int hinic3_nic_probe (struct auxiliary_device *adev, +const struct auxiliary_device_id *id) +{ +struct hinic3_hwdev *hwdev =hinic3_adev_get_hwdev (adev); +struct pci_dev *pdev = hwdev->pdev; +struct hinic3_nic_dev *nic_dev; +struct net_device *netdev; +u16 max_qps, glb_func_id; +int err; + +if (!hinic3_support_nic (hwdev)) { +dev_dbg (&adev->dev,"HW doesn't support nic\n" ); +return 0 ; + } + +hinic3_adev_event_register (adev, hinic3_nic_event); + + glb_func_id =hinic3_global_func_id (hwdev); + err =hinic3_func_reset (hwdev, glb_func_id,COMM_FUNC_RESET_BIT_NIC ); +if (err) { +dev_err (&adev->dev,"Failed to reset function\n" ); + goto err_undo_event_register; + } + + max_qps =hinic3_func_max_qnum (hwdev); + netdev =alloc_etherdev_mq (sizeof (*nic_dev), max_qps); +if (!netdev) { +dev_err (&adev->dev,"Failed to allocate netdev\n" ); + err = -ENOMEM ; + goto err_undo_event_register; + } + + nic_dev =netdev_priv (netdev); +dev_set_drvdata (&adev->dev, nic_dev); + err =hinic3_init_nic_dev (netdev, hwdev); +if (err) + goto err_undo_netdev_alloc; + + err =hinic3_init_nic_io (nic_dev); +if (err) + goto err_undo_netdev_alloc; + + err =hinic3_sw_init (netdev); +if (err) + goto err_sw_init; +
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c
Quoted 10 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +10
-0+hinic3_assign_netdev_ops (netdev); + +netdev_feature_init (netdev); + err =hinic3_set_default_hw_feature (netdev); +if (err) + goto err_set_features; + + err =register_netdev (netdev); +if (err) { + err = -ENOMEM ;
Could you clarify why err is being overridden here? I would have expected this function to return the error returned by register_netdev?
Quoted 25 lines
drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +25
-0+ goto err_register_netdev; + } + +netif_carrier_off (netdev); +return 0 ; + +err_register_netdev: +hinic3_update_nic_feature (nic_dev,0 ); +hinic3_set_nic_feature_to_hw (nic_dev); + +err_set_features: +hinic3_sw_deinit (netdev); + +err_sw_init: +hinic3_free_nic_io (nic_dev); + +err_undo_netdev_alloc: +free_netdev (netdev); + +err_undo_event_register: +hinic3_adev_event_unregister (adev); +dev_err (&pdev->dev,"NIC service probe failed\n" ); + +return err; +}
...
Quoted 1 line
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c +0
-0
...
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c line 38
Quoted 13 lines
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c +13
-0+static int hinic3_change_mtu (struct net_device *netdev,int new_mtu) +{ +int err; + + err =hinic3_set_port_mtu (netdev, new_mtu); +if (err) { +netdev_err (netdev,"Failed to change port mtu to %d\n" , new_mtu); + }else { +netdev_dbg (netdev,"Change mtu from %u to %d\n" , netdev->mtu, new_mtu); +WRITE_ONCE (netdev->mtu, new_mtu); + } + +return err;
The above is straightforward enough, but I do think it would be nicer to stick with the idiomatic pattern of keeping the non-error paths in the main flow of execution, while error paths are handled conditionally.
And also, to keep lines less than 80 columns wide unless it reduces readability.
Something like this (completely untested!):
err = hinic3_set_port_mtu(netdev, new_mtu);
if (err) {
netdev_err(netdev, "Failed to change port mtu to %d\n",
new_mtu);
return err;
}
netdev_dbg(netdev, "Change mtu from %u to %d\n", netdev->mtu, new_mtu);
WRITE_ONCE(netdev->mtu, new_mtu);
return 0;Quoted 1 line
+}
...