Skip to contentSkip to conversation

mcb: update for 6.15

PATCH New Johannes Thumshirn 1 participant 2 messages Mar 10, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover mcb: update for 6.15

Hi Greg,

Here's an update for drivers/mcb for 6.15 from Haoxiang Li fixing a double free in an error path in chameleon_parse_gdd().

Haoxiang Li (1):
mcb: fix a double free bug in chameleon_parse_gdd()

 drivers/mcb/mcb-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/1 mcb: fix a double free bug in chameleon_parse_gdd()

From: Haoxiang Li <[email protected]>

In chameleon_parse_gdd(), if mcb_device_register() fails, 'mdev' would be released in mcb_device_register() via put_device(). Thus, goto 'err' label and free 'mdev' again causes a double free. Just return if mcb_device_register() fails.

Fixes 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus")
---
 drivers/mcb/mcb-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mcb/mcb-parse.c +1 -1
index 02a680c73979..bf0d7d58c8b0 100644
@@ -96,7 +96,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
 
 	ret = mcb_device_register(bus, mdev);
 	if (ret < 0)
-		goto err;
+		return ret;
 
 	return 0;
 
Signature · 1 line
2.43.0