mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context
Subsystems (3)
Alexander Gordeev
maintainerv2 cover mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context
Hi All,
This patch is aimed at 6.16-rc1 and should be applied not before [1].
Changes since v1:
- this patch is split into a separate series;
Thanks!
Alexander Gordeev (1):
mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context
include/linux/pgtable.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
Signature · 1 line
2.45.2
Alexander Gordeev
maintainerPATCH v2 1/1 mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context
The lazy MMU batching may be only be entered and left under the protection of the page table locks for all page tables which may be modified. Yet, there were cases arch_enter_lazy_mmu_mode() was called without the locks taken, e.g. commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash lazy mmu mode").
Make default arch_enter|leave|flush_lazy_mmu_mode() callbacks complain at least in case the preemption is enabled to detect wrong contexts.
Most platforms do not implement the callbacks, so to aovid a performance impact allow the complaint when CONFIG_DEBUG_VM option is enabled only.
--- include/linux/pgtable.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
include/linux/pgtable.h +12 -3
@@ -232,9 +232,18 @@ static inline int pmd_dirty(pmd_t pmd)* and the mode cannot be used in interrupt context. */ #ifndef __HAVE_ARCH_ENTER_LAZY_MMU_MODE -#define arch_enter_lazy_mmu_mode () do {} while (0) -#define arch_leave_lazy_mmu_mode () do {} while (0) -#define arch_flush_lazy_mmu_mode () do {} while (0) +static inline void arch_enter_lazy_mmu_mode (void ) +{ +VM_WARN_ON (preemptible ()); +} +static inline void arch_leave_lazy_mmu_mode (void ) +{ +VM_WARN_ON (preemptible ()); +} +static inline void arch_flush_lazy_mmu_mode (void ) +{ +VM_WARN_ON (preemptible ()); +}#endif #ifndef pte_batch_hint
Signature · 1 line
2.45.2
Alexander Gordeev
maintainerQuoted 10 lines · Alexander Gordeev
The lazy MMU batching may be only be entered and left under the protection of the page table locks for all page tables which may be modified. Yet, there were cases
arch_enter_lazy_mmu_mode()was called without the locks taken, e.g. commitb9ef323ea168("powerpc/64s: Disable preemption in hash lazy mmu mode").Make default arch_enter|leave|flush_lazy_mmu_mode() callbacks complain at least in case the preemption is enabled to detect wrong contexts.
Quoted 8 lines
Most platforms do not implement the callbacks, so to aovid a performance impact allow the complaint when
CONFIG_DEBUG_VMoption is enabled only.Signed-off-by Alexander Gordeev <[email protected]>--- include/linux/pgtable.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
Andrew,
Following [1] comment to "[PATCH v2 3/3] mm: Protect kernel pgtables in apply_to_pte_range()" I think this patch should also be dropped.
1. https://lore.kernel.org/all/Z%[email protected]/
Thanks!