Skip to contentSkip to conversation

fstests: btrfs: add test case to validate sysfs input arguments

PATCH In review Anand Jain 2 participants 14 messages Apr 9, 2025 – May 24, 2025 Btrfs file system

lore
Share & tools
lore

Anand Jain

author
#0 lore raw

v6 cover fstests: btrfs: add test case to validate sysfs input arguments

v6:
- Add missing if statement for the test in _has_fs_sysfs_attr_policy().
- Add a comment to _verify_sysfs_syntax().
- Set seqres early in check::run_section().
- Add _require_test to btrfs/334 and btrfs/329.

v5:
https://lore.kernel.org/fstests/[email protected]/

v4:
https://lore.kernel.org/fstests/[email protected]/

v3:
https://lore.kernel.org/fstests/[email protected]/

v2:
https://lore.kernel.org/fstests/[email protected]/

v1:
https://lwn.net/ml/all/[email protected]/

Anand Jain (6):
fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
fstests: common/rc: fix unset seqres in _set_fs_sysfs_attr
fstests: filter: helper for sysfs error filtering
fstests: common/sysfs: add new file sysfs and helpers
fstests: btrfs: testcase for sysfs policy syntax verification
fstests: btrfs: testcase for sysfs chunk_size attribute validation

 check               |   2 +-
 common/filter       |   9 +++
 common/rc           |   3 +-
 common/sysfs        | 145 ++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/329     |  21 +++++++
 tests/btrfs/329.out |  19 ++++++
 tests/btrfs/334     |  21 +++++++
 tests/btrfs/334.out |  14 +++++
 8 files changed, 232 insertions(+), 2 deletions(-)
 create mode 100644 common/sysfs
 create mode 100755 tests/btrfs/329
 create mode 100644 tests/btrfs/329.out
 create mode 100755 tests/btrfs/334
 create mode 100644 tests/btrfs/334.out
Signature · 1 line
2.47.0
author
#1 lore raw

PATCH v6 1/6 fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout

Redirect sysfs write errors to stdout as a preparatory patch to enable testing of expected sysfs write failures. Also, log the executed sysfs write command and its failure if any to seqres.full for better debugging and traceability.

---
 common/rc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
common/rc +2 -1
index 16d627e1bdd4..e89eee5de840 100644
@@ -5208,7 +5208,8 @@ _set_fs_sysfs_attr()
 
 	local dname=$(_fs_sysfs_dname $dev)
 
-	echo "$content" > /sys/fs/${FSTYP}/${dname}/${attr}
+	echo "echo '$content' 2>&1 > /sys/fs/${FSTYP}/${dname}/${attr}" >> $seqres.full
+	echo "$content" 2>&1 > /sys/fs/${FSTYP}/${dname}/${attr} | tee -a $seqres.full
 }
 
 # Print the content of /sys/fs/$FSTYP/$DEV/$ATTR
Signature · 1 line
2.47.0
author
#2 lore raw

PATCH v6 2/6 fstests: check: fix unset seqres in run_section()

In reply to Anand Jain

Ensure seqres is set early in run_section().

---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
check +1 -1
index 32890470a020..16f695e9d75c 100755
@@ -804,6 +804,7 @@ function run_section()
 
 	seq="check.$$"
 	check="$RESULT_BASE/check"
+	seqres="$check"
 
 	# don't leave old full output behind on a clean run
 	rm -f $check.full
@@ -849,7 +850,6 @@ function run_section()
 	  fi
 	fi
 
-	seqres="$check"
 	_check_test_fs
 
 	loop_status=()	# track rerun-on-failure state
Signature · 1 line
2.47.0
#3 lore raw

Re: [PATCH v6 2/6] fstests: check: fix unset seqres in run_section()

Quoted 12 lines · Anand Jain

Ensure seqres is set early in run_section().

---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
check +0 -0
index 32890470a020..16f695e9d75c 100755

check function run_section() · line 807

Quoted 4 lines
check +1 -0
@@ -804,6 +804,7 @@ function run_section()
 
 	seq="check.$$"
 	check="$RESULT_BASE/check"
+	seqres="$check"

The "seqres" even might be used earlier than that. If your rootfs is readonly, you'll see that.

Thanks,
Zorro

Quoted 14 lines
check +0 -1
 	# don't leave old full output behind on a clean run
 	rm -f $check.full
@@ -849,7 +850,6 @@ function run_section()
 	  fi
 	fi
 
-	seqres="$check"
 	_check_test_fs
 
 	loop_status=()	# track rerun-on-failure state
Signature · 1 line
2.47.0
author
#4 lore raw

Re: [PATCH v6 2/6] fstests: check: fix unset seqres in run_section()

Quoted 14 lines · Zorro Lang
Quoted 13 lines · Anand Jain

Ensure seqres is set early in run_section().

---
  check | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
check +0 -0
index 32890470a020..16f695e9d75c 100755
@@ -804,6 +804,7 @@ function run_section()
 
Quoted 7 lines

check function run_section() · line 807

Quoted 3 lines
check +1 -0
  	seq="check.$$"
  	check="$RESULT_BASE/check"
+	seqres="$check"

The "seqres" even might be used earlier than that. If your rootfs is readonly, you'll see that.

Zorro,

Thanks a lot for the review and RVB!

I’ll take care of this patch 2/6 in a separate patchset. Meanwhile, could you help merge the rest of the sysfs patches, except for patch 2/6? I don't want the seqres issue to block the rest of the sysfs patches.

Thanks, Anand

Quoted 18 lines

Thanks,
Zorro

Quoted 14 lines
check +0 -1
  	# don't leave old full output behind on a clean run
  	rm -f $check.full
@@ -849,7 +850,6 @@ function run_section()
  	  fi
  	fi
 
-	seqres="$check"
  	_check_test_fs
 
  	loop_status=()	# track rerun-on-failure state
Signature · 1 line
2.47.0
#5 lore raw

Re: [PATCH v6 2/6] fstests: check: fix unset seqres in run_section()

Quoted 24 lines · Anand Jain
Quoted 8 lines · Zorro Lang
Quoted 7 lines · Anand Jain

Ensure seqres is set early in run_section().

---
  check | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

check function run_section() · line 806

Quoted 8 lines
check +1 -0
index 32890470a020..16f695e9d75c 100755
@@ -804,6 +804,7 @@ function run_section()
  	seq="check.$$"
  	check="$RESULT_BASE/check"
+	seqres="$check"

The "seqres" even might be used earlier than that. If your rootfs is readonly, you'll see that.

Quoted 8 lines

Zorro,

Thanks a lot for the review and RVB!

I’ll take care of this patch 2/6 in a separate patchset. Meanwhile, could you help merge the rest of the sysfs patches, except for patch 2/6? I don't want the seqres issue to block the rest of the sysfs patches.

OK, let's have the test coverage at first. You can merge this patchset without the 2/6 in your branch, (or use the way you did in
https://lore.kernel.org/fstests/5e081252abdcf7253ad83d2b5eda49a8818305ad.1743996408.git.anand.jain@oracle.com/
temporarily). Then send PR to me, I'll try to push this patchset in this week :)

Thanks,
Zorro

Quoted 19 lines

Thanks, Anand

Quoted 15 lines

Thanks,
Zorro

Quoted 11 lines
check +0 -1
  	# don't leave old full output behind on a clean run
  	rm -f $check.full
@@ -849,7 +850,6 @@ function run_section()
  	  fi
  	fi
-	seqres="$check"
  	_check_test_fs
  	loop_status=()	# track rerun-on-failure state
Signature · 1 line
2.47.0
author
#6 lore raw

Re: [PATCH v6 2/6] fstests: check: fix unset seqres in run_section()

In reply to Anand Jain
Quoted 11 lines · Anand Jain
Quoted 8 lines · Zorro Lang
Quoted 7 lines · Anand Jain

Ensure seqres is set early in run_section().

---
  check | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
check +0 -0
index 32890470a020..16f695e9d75c 100755
@@ -804,6 +804,7 @@ function run_section()

      seq="check.$$"
      check="$RESULT_BASE/check"
+    seqres="$check"

The "seqres" even might be used earlier than that. If your rootfs is readonly, you'll see that.

Zorro,

While testing, I saw that ".full" is created by _scratch_unmount(), called here:

725 function run_section()
::
815 if [ ! -z "$SCRATCH_DEV" ]; then
816 _scratch_unmount 2> /dev/null
817 # call the overridden mkfs - make sure the FS is built

So the fix in this patch is correct..

I also tried with a read-only rootfs—".full" wasn’t there an error to create that file..

I’ll resend the patch soon.

Thanks. Anand

Quoted 29 lines
Quoted 1 line

Zorro,

Thanks a lot for the review and RVB!

I’ll take care of this patch 2/6 in a separate patchset. Meanwhile, could you help merge the rest of the sysfs patches, except for patch 2/6? I don't want the seqres issue to block the rest of the sysfs patches.

Thanks, Anand

Quoted 15 lines

Thanks,
Zorro

Quoted 11 lines

      # don't leave old full output behind on a clean run rm -f $check.full

check +0 -0
@@ -849,7 +850,6 @@ function run_section()

        fi
      fi
-    seqres="$check"
      _check_test_fs
      loop_status=()    # track rerun-on-failure state

Signature · 1 line
2.47.0
author
#7 lore raw

PATCH v6 3/6 fstests: filter: helper for sysfs error filtering

In reply to Anand Jain

Added filter helper to filter sysfs write errors, retain only the error part.

---
 common/filter | 9 +++++++++
 1 file changed, 9 insertions(+)
common/filter +9 -0
index 1ebfd27e898e..bbe13f4c8a8d 100644
@@ -674,5 +674,14 @@ _filter_flakey_EIO()
 	sed -e "s#.*: Input\/output error#$message#"
 }
 
+# Filters
+#      +./common/rc: line 5085: echo: write error: Invalid argument
+# to
+# 	Invalid argument
+_filter_sysfs_error()
+{
+	sed 's/.*: \(.*\)$/\1/'
+}
+
 # make sure this script returns success
 /bin/true
Signature · 1 line
2.47.0
author
#8 lore raw

PATCH v6 4/6 fstests: common/sysfs: add new file sysfs and helpers

In reply to Anand Jain

Introduce verify_sysfs_syntax() and _require_fs_sysfs_attr_policy() to verify whether a sysfs attribute rejects invalid input arguments during writes.

---
 common/sysfs | 145 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 145 insertions(+)
 create mode 100644 common/sysfs
common/sysfs new file +145 -0
new file mode 100644
index 000000000000..16d4b482f9e9
@@ -0,0 +1,145 @@
+##/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# Common/sysfs file for the sysfs related helper functions.
+
+# Test for the existence of a policy at /sys/fs/$FSTYP/$DEV/$ATTR
+#
+# All arguments are necessary, and in this order:
+#  - dev: device name, e.g. $SCRATCH_DEV
+#  - attr: path name under /sys/fs/$FSTYP/$dev
+#  - policy: policy within /sys/fs/$FSTYP/$dev
+#
+# Usage example:
+#   _has_fs_sysfs_attr_policy /dev/mapper/scratch-dev read_policy round-robin
+_has_fs_sysfs_attr_policy()
+{
+	local dev=$1
+	local attr=$2
+	local policy=$3
+
+	if [ ! -b "$dev" -o -z "$attr" -o -z "$policy" ]; then
+		_fail \
+	     "Usage: _has_fs_sysfs_attr_policy <mounted_device> <attr> <policy>"
+	fi
+
+	local dname=$(_fs_sysfs_dname $dev)
+	if ! test -e /sys/fs/${FSTYP}/${dname}/${attr}; then
+		return 1
+	fi
+
+	cat /sys/fs/${FSTYP}/${dname}/${attr} | grep -q ${policy}
+}
+
+# Require the existence of a sysfs entry at /sys/fs/$FSTYP/$DEV/$ATTR
+# and value in it contains $policy
+# All arguments are necessary, and in this order:
+#  - dev: device name, e.g. $SCRATCH_DEV
+#  - attr: path name under /sys/fs/$FSTYP/$dev
+#  - policy: mentioned in /sys/fs/$FSTYP/$dev/$attr
+#
+# Usage example:
+#   _require_fs_sysfs_attr_policy /dev/mapper/scratch-dev read_policy round-robin
+_require_fs_sysfs_attr_policy()
+{
+	_has_fs_sysfs_attr_policy "$@" && return
+
+	local dev=$1
+	local attr=$2
+	local policy=$3
+	local dname=$(_fs_sysfs_dname $dev)
+
+	_notrun "This test requires /sys/fs/${FSTYP}/${dname}/${attr} ${policy}"
+}
+
+_set_sysfs_policy()
+{
+	local dev=$1
+	local attr=$2
+	shift
+	shift
+	local policy=$@
+
+	_set_fs_sysfs_attr $dev $attr ${policy}
+
+	case "$FSTYP" in
+	btrfs)
+		_get_fs_sysfs_attr $dev $attr | grep -q "[${policy}]"
+		if [[ $? != 0 ]]; then
+			echo "Setting sysfs $attr $policy failed"
+		fi
+		;;
+	*)
+		_fail \
+"sysfs syntax verification for '${attr}' '${policy}' for '${FSTYP}' is not implemented"
+		;;
+	esac
+}
+
+_set_sysfs_policy_must_fail()
+{
+	local dev=$1
+	local attr=$2
+	shift
+	shift
+	local policy=$@
+
+	_set_fs_sysfs_attr $dev $attr ${policy} | _filter_sysfs_error \
+							   | tee -a $seqres.full
+}
+
+# Verify sysfs attribute rejects invalid input.
+# Usage syntax:
+#   _verify_sysfs_syntax <$dev> <$attr> <$policy> [$value]
+# Examples:
+#   _verify_sysfs_syntax $TEST_DEV read_policy pid
+#   _verify_sysfs_syntax $TEST_DEV read_policy round-robin 4k
+# Note:
+#  Testcase must include
+#      . ./common/filter
+# Prerequisite checks are kept outside this function
+# to make them clear to the test case, rather than hiding
+# them deep inside another function.
+#      _require_fs_sysfs_attr_policy $TEST_DEV $attr $policy
+_verify_sysfs_syntax()
+{
+	local dev=$1
+	local attr=$2
+	local policy=$3
+	local value=$4
+
+	# Test policy specified wrongly. Must fail.
+	_set_sysfs_policy_must_fail $dev $attr "'$policy $policy'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy t'"
+	_set_sysfs_policy_must_fail $dev $attr "' '"
+	_set_sysfs_policy_must_fail $dev $attr "'${policy} n'"
+	_set_sysfs_policy_must_fail $dev $attr "'n ${policy}'"
+	_set_sysfs_policy_must_fail $dev $attr "' ${policy}'"
+	_set_sysfs_policy_must_fail $dev $attr "' ${policy} '"
+	_set_sysfs_policy_must_fail $dev $attr "'${policy} '"
+	_set_sysfs_policy_must_fail $dev $attr _${policy}
+	_set_sysfs_policy_must_fail $dev $attr ${policy}_
+	_set_sysfs_policy_must_fail $dev $attr _${policy}_
+	_set_sysfs_policy_must_fail $dev $attr ${policy}:
+	# Test policy longer than 32 chars fails stable.
+	_set_sysfs_policy_must_fail $dev $attr 'jfdkkkkjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjffjfjfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'
+
+	# Test policy specified correctly. Must pass.
+	_set_sysfs_policy $dev $attr $policy
+
+	# If the policy has no value return
+	if [[ -z $value ]]; then
+		return
+	fi
+
+	# Test value specified wrongly. Must fail.
+	_set_sysfs_policy_must_fail $dev $attr "'$policy: $value'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:$value '"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:$value typo'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:${value}typo'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy :$value'"
+
+	# Test policy and value all specified correctly. Must pass.
+	_set_sysfs_policy $dev $attr $policy:$value
+}
Signature · 1 line
2.47.0
Reviewed-by on v6 4/6
#9 lore raw

Re: [PATCH v6 4/6] fstests: common/sysfs: add new file sysfs and helpers

Quoted 6 lines · Anand Jain

Introduce verify_sysfs_syntax() and _require_fs_sysfs_attr_policy() to verify whether a sysfs attribute rejects invalid input arguments during writes.

---

This version is good to me,

Quoted 158 lines
 common/sysfs | 145 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 145 insertions(+)
 create mode 100644 common/sysfs
common/sysfs new file +145 -0
new file mode 100644
index 000000000000..16d4b482f9e9
@@ -0,0 +1,145 @@
+##/bin/bash
+# SPDX-License-Identifier: GPL-2.0+
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# Common/sysfs file for the sysfs related helper functions.
+
+# Test for the existence of a policy at /sys/fs/$FSTYP/$DEV/$ATTR
+#
+# All arguments are necessary, and in this order:
+#  - dev: device name, e.g. $SCRATCH_DEV
+#  - attr: path name under /sys/fs/$FSTYP/$dev
+#  - policy: policy within /sys/fs/$FSTYP/$dev
+#
+# Usage example:
+#   _has_fs_sysfs_attr_policy /dev/mapper/scratch-dev read_policy round-robin
+_has_fs_sysfs_attr_policy()
+{
+	local dev=$1
+	local attr=$2
+	local policy=$3
+
+	if [ ! -b "$dev" -o -z "$attr" -o -z "$policy" ]; then
+		_fail \
+	     "Usage: _has_fs_sysfs_attr_policy <mounted_device> <attr> <policy>"
+	fi
+
+	local dname=$(_fs_sysfs_dname $dev)
+	if ! test -e /sys/fs/${FSTYP}/${dname}/${attr}; then
+		return 1
+	fi
+
+	cat /sys/fs/${FSTYP}/${dname}/${attr} | grep -q ${policy}
+}
+
+# Require the existence of a sysfs entry at /sys/fs/$FSTYP/$DEV/$ATTR
+# and value in it contains $policy
+# All arguments are necessary, and in this order:
+#  - dev: device name, e.g. $SCRATCH_DEV
+#  - attr: path name under /sys/fs/$FSTYP/$dev
+#  - policy: mentioned in /sys/fs/$FSTYP/$dev/$attr
+#
+# Usage example:
+#   _require_fs_sysfs_attr_policy /dev/mapper/scratch-dev read_policy round-robin
+_require_fs_sysfs_attr_policy()
+{
+	_has_fs_sysfs_attr_policy "$@" && return
+
+	local dev=$1
+	local attr=$2
+	local policy=$3
+	local dname=$(_fs_sysfs_dname $dev)
+
+	_notrun "This test requires /sys/fs/${FSTYP}/${dname}/${attr} ${policy}"
+}
+
+_set_sysfs_policy()
+{
+	local dev=$1
+	local attr=$2
+	shift
+	shift
+	local policy=$@
+
+	_set_fs_sysfs_attr $dev $attr ${policy}
+
+	case "$FSTYP" in
+	btrfs)
+		_get_fs_sysfs_attr $dev $attr | grep -q "[${policy}]"
+		if [[ $? != 0 ]]; then
+			echo "Setting sysfs $attr $policy failed"
+		fi
+		;;
+	*)
+		_fail \
+"sysfs syntax verification for '${attr}' '${policy}' for '${FSTYP}' is not implemented"
+		;;
+	esac
+}
+
+_set_sysfs_policy_must_fail()
+{
+	local dev=$1
+	local attr=$2
+	shift
+	shift
+	local policy=$@
+
+	_set_fs_sysfs_attr $dev $attr ${policy} | _filter_sysfs_error \
+							   | tee -a $seqres.full
+}
+
+# Verify sysfs attribute rejects invalid input.
+# Usage syntax:
+#   _verify_sysfs_syntax <$dev> <$attr> <$policy> [$value]
+# Examples:
+#   _verify_sysfs_syntax $TEST_DEV read_policy pid
+#   _verify_sysfs_syntax $TEST_DEV read_policy round-robin 4k
+# Note:
+#  Testcase must include
+#      . ./common/filter
+# Prerequisite checks are kept outside this function
+# to make them clear to the test case, rather than hiding
+# them deep inside another function.
+#      _require_fs_sysfs_attr_policy $TEST_DEV $attr $policy
+_verify_sysfs_syntax()
+{
+	local dev=$1
+	local attr=$2
+	local policy=$3
+	local value=$4
+
+	# Test policy specified wrongly. Must fail.
+	_set_sysfs_policy_must_fail $dev $attr "'$policy $policy'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy t'"
+	_set_sysfs_policy_must_fail $dev $attr "' '"
+	_set_sysfs_policy_must_fail $dev $attr "'${policy} n'"
+	_set_sysfs_policy_must_fail $dev $attr "'n ${policy}'"
+	_set_sysfs_policy_must_fail $dev $attr "' ${policy}'"
+	_set_sysfs_policy_must_fail $dev $attr "' ${policy} '"
+	_set_sysfs_policy_must_fail $dev $attr "'${policy} '"
+	_set_sysfs_policy_must_fail $dev $attr _${policy}
+	_set_sysfs_policy_must_fail $dev $attr ${policy}_
+	_set_sysfs_policy_must_fail $dev $attr _${policy}_
+	_set_sysfs_policy_must_fail $dev $attr ${policy}:
+	# Test policy longer than 32 chars fails stable.
+	_set_sysfs_policy_must_fail $dev $attr 'jfdkkkkjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjffjfjfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'
+
+	# Test policy specified correctly. Must pass.
+	_set_sysfs_policy $dev $attr $policy
+
+	# If the policy has no value return
+	if [[ -z $value ]]; then
+		return
+	fi
+
+	# Test value specified wrongly. Must fail.
+	_set_sysfs_policy_must_fail $dev $attr "'$policy: $value'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:$value '"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:$value typo'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy:${value}typo'"
+	_set_sysfs_policy_must_fail $dev $attr "'$policy :$value'"
+
+	# Test policy and value all specified correctly. Must pass.
+	_set_sysfs_policy $dev $attr $policy:$value
+}
Signature · 1 line
2.47.0
author
#10 lore raw

PATCH v6 5/6 fstests: btrfs: testcase for sysfs policy syntax verification

In reply to Anand Jain

Checks if the sysfs attribute sanitizes arguments and verifies input syntax.

---
 tests/btrfs/329     | 21 +++++++++++++++++++++
 tests/btrfs/329.out | 19 +++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100755 tests/btrfs/329
 create mode 100644 tests/btrfs/329.out
tests/btrfs/329 new file +21 -0
new file mode 100755
index 000000000000..f4faddedf076
@@ -0,0 +1,21 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# FS QA Test 329
+#
+# Verify sysfs knob input syntax for read_policy round-robin
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+. ./common/sysfs
+. ./common/filter
+
+_require_test
+_require_fs_sysfs_attr_policy $TEST_DEV read_policy round-robin
+
+_verify_sysfs_syntax $TEST_DEV read_policy round-robin 4096
+
+status=0
+exit
tests/btrfs/329.out new file +19 -0
new file mode 100644
index 000000000000..eff7573adb6a
@@ -0,0 +1,19 @@
+QA output created by 329
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
Signature · 1 line
2.47.0
Reviewed-by on v6 5/6
#11 lore raw

Re: [PATCH v6 5/6] fstests: btrfs: testcase for sysfs policy syntax verification

Quoted 5 lines · Anand Jain

Checks if the sysfs attribute sanitizes arguments and verifies input syntax.

---

This version is good to me,

Quoted 61 lines
 tests/btrfs/329     | 21 +++++++++++++++++++++
 tests/btrfs/329.out | 19 +++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100755 tests/btrfs/329
 create mode 100644 tests/btrfs/329.out
tests/btrfs/329 new file +21 -0
new file mode 100755
index 000000000000..f4faddedf076
@@ -0,0 +1,21 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# FS QA Test 329
+#
+# Verify sysfs knob input syntax for read_policy round-robin
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+. ./common/sysfs
+. ./common/filter
+
+_require_test
+_require_fs_sysfs_attr_policy $TEST_DEV read_policy round-robin
+
+_verify_sysfs_syntax $TEST_DEV read_policy round-robin 4096
+
+status=0
+exit
tests/btrfs/329.out new file +19 -0
new file mode 100644
index 000000000000..eff7573adb6a
@@ -0,0 +1,19 @@
+QA output created by 329
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
Signature · 1 line
2.47.0
author
#12 lore raw

PATCH v6 6/6 fstests: btrfs: testcase for sysfs chunk_size attribute validation

In reply to Anand Jain

Checks if the sysfs attribute sanitizes arguments and verifies input syntax allocation/data/chunk_size.

---
 tests/btrfs/334     | 21 +++++++++++++++++++++
 tests/btrfs/334.out | 14 ++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100755 tests/btrfs/334
 create mode 100644 tests/btrfs/334.out
tests/btrfs/334 new file +21 -0
new file mode 100755
index 000000000000..d81ec921f1f2
@@ -0,0 +1,21 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# FS QA Test 334
+#
+# Verify sysfs knob input syntax for allocation/data/chunk_size
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+. ./common/sysfs
+. ./common/filter
+
+_require_test
+_require_fs_sysfs_attr $TEST_DEV allocation/data/chunk_size
+
+_verify_sysfs_syntax $TEST_DEV allocation/data/chunk_size 256m
+
+status=0
+exit
tests/btrfs/334.out new file +14 -0
new file mode 100644
index 000000000000..f64f9ac09499
@@ -0,0 +1,14 @@
+QA output created by 334
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
Signature · 1 line
2.47.0
Reviewed-by on v6 6/6
#13 lore raw

Re: [PATCH v6 6/6] fstests: btrfs: testcase for sysfs chunk_size attribute validation

Quoted 5 lines · Anand Jain

Checks if the sysfs attribute sanitizes arguments and verifies input syntax allocation/data/chunk_size.

---

This version is good to me,

Quoted 56 lines
 tests/btrfs/334     | 21 +++++++++++++++++++++
 tests/btrfs/334.out | 14 ++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100755 tests/btrfs/334
 create mode 100644 tests/btrfs/334.out
tests/btrfs/334 new file +21 -0
new file mode 100755
index 000000000000..d81ec921f1f2
@@ -0,0 +1,21 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Oracle.  All Rights Reserved.
+#
+# FS QA Test 334
+#
+# Verify sysfs knob input syntax for allocation/data/chunk_size
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+. ./common/sysfs
+. ./common/filter
+
+_require_test
+_require_fs_sysfs_attr $TEST_DEV allocation/data/chunk_size
+
+_verify_sysfs_syntax $TEST_DEV allocation/data/chunk_size 256m
+
+status=0
+exit
tests/btrfs/334.out new file +14 -0
new file mode 100644
index 000000000000..f64f9ac09499
@@ -0,0 +1,14 @@
+QA output created by 334
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
+Invalid argument
Signature · 1 line
2.47.0