Patch review
cover Patch review
Please review this set of changes for scarthgap and have comments back by end of day Thursday, May 8
Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/1529
The following changes since commit 00dd4901e364d16d96cfab864823a9cfdd336eeb:
Revert "cve-update-nvd2-native: Tweak to work better with NFS DL_DIR" (2025-04-29 10:21:16 -0700)
are available in the Git repository at:
https://git.openembedded.org/openembedded-core-contrib stable/scarthgap-nut
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/scarthgap-nut
Ashish Sharma (1):
libsoup: patch CVE-2025-46420
Deepesh Varatharajan (2):
glibc: stable 2.39 branch updates
binutils: stable 2.42 branch updates
Jeroen Hofstee (2):
bluez5: make media control a PACKAGECONFIG option
bluez5: backport a patch to fix btmgmt -i
Peter Marko (1):
sqlite3: mark CVE-2025-29087 as patched
Soumya Sambu (1):
elfutils: Fix CVE-2025-1371
meta/recipes-connectivity/bluez5/bluez5.inc | 3 + ...ndex-option-for-non-interactive-mode.patch | 29 +++++++++ meta/recipes-core/glibc/glibc-version.inc | 2 +- .../binutils/binutils-2.42.inc | 2 +- .../elfutils/elfutils_0.191.bb | 1 + .../elfutils/files/CVE-2025-1371.patch | 41 +++++++++++++ .../libsoup-3.4.4/CVE-2025-46420.patch | 60 +++++++++++++++++++ meta/recipes-support/libsoup/libsoup_3.4.4.bb | 1 + .../sqlite/sqlite3/CVE-2025-3277.patch | 1 + 9 files changed, 138 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch create mode 100644 meta/recipes-devtools/elfutils/files/CVE-2025-1371.patch create mode 100644 meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-46420.patch
Signature · 1 line
2.43.0
PATCH 1/7 libsoup: patch CVE-2025-46420
From: Ashish Sharma <[email protected]>
Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/libsoup/-/commit/c9083869ec2a3037e6df4bd86b45c419ba295f8e]
--- .../libsoup-3.4.4/CVE-2025-46420.patch | 60 +++++++++++++++++++ meta/recipes-support/libsoup/libsoup_3.4.4.bb | 1 + 2 files changed, 61 insertions(+) create mode 100644 meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-46420.patch
meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-46420.patch new file +60 -0
@@ -0,0 +1,60 @@ +From c9083869ec2a3037e6df4bd86b45c419ba295f8e Mon Sep 17 00:00:00 2001 +From: Patrick Griffis <[email protected]> +Date: Thu, 26 Dec 2024 18:31:42 -0600 +Subject: [PATCH] soup_header_parse_quality_list: Fix leak + +When iterating over the parsed list we now steal the allocated strings that we want and then free_full the list which may contain remaining strings. + +Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/libsoup/-/commit/c9083869ec2a3037e6df4bd86b45c419ba295f8e] +CVE: CVE-2025-46420 +Signed-off-by: Ashish Sharma <[email protected]> + + libsoup/soup-headers.c | 11 +++++------ + 1 file changed, 5 insertions(+), 6 deletions(-) + +diff --git a/libsoup/soup-headers.c b/libsoup/soup-headers.c +index a5f7a7f6..85385cea 100644 +--- a/libsoup/soup-headers.c ++++ b/libsoup/soup-headers.c +@@ -530,7 +530,7 @@ soup_header_parse_quality_list (const char *header, GSList **unacceptable) + GSList *unsorted; + QualityItem *array; + GSList *sorted, *iter; +- char *item, *semi; ++ char *semi; + const char *param, *equal, *value; + double qval; + int n; +@@ -543,9 +543,8 @@ soup_header_parse_quality_list (const char *header, GSList **unacceptable) + unsorted = soup_header_parse_list (header); + array = g_new0 (QualityItem, g_slist_length (unsorted)); + for (iter = unsorted, n = 0; iter; iter = iter->next) { +- item = iter->data; + qval = 1.0; +- for (semi = strchr (item, ';'); semi; semi = strchr (semi + 1, ';')) { ++ for (semi = strchr (iter->data, ';'); semi; semi = strchr (semi + 1, ';')) { + param = skip_lws (semi + 1); + if (*param != 'q') + continue; +@@ -577,15 +576,15 @@ soup_header_parse_quality_list (const char *header, GSList **unacceptable) + if (qval == 0.0) { + if (unacceptable) { + *unacceptable = g_slist_prepend (*unacceptable, +- item); ++ g_steal_pointer (&iter->data)); + } + } else { +- array[n].item = item; ++ array[n].item = g_steal_pointer (&iter->data); + array[n].qval = qval; + n++; + } + } +- g_slist_free (unsorted); ++ g_slist_free_full (unsorted, g_free); + + qsort (array, n, sizeof (QualityItem), sort_by_qval); + sorted = NULL; +-- +GitLab +
meta/recipes-support/libsoup/libsoup_3.4.4.bb +1 -0
@@ -28,6 +28,7 @@ SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \ file://CVE-2025-32912-2.patch \ file://CVE-2025-32906-1.patch \ file://CVE-2025-32906-2.patch \ + file://CVE-2025-46420.patch \ " SRC_URI[sha256sum] = "291c67725f36ed90ea43efff25064b69c5a2d1981488477c05c481a3b4b0c5aa"
Signature · 1 line
2.43.0
PATCH 2/7 elfutils: Fix CVE-2025-1371
In reply to Steve SakomanFrom: Soumya Sambu <[email protected]>
A vulnerability has been found in GNU elfutils 0.192 and classified as problematic. This vulnerability affects the function handle_dynamic_symtab of the file readelf.c of the component eu-read. The manipulation leads to null pointer dereference. Attacking locally is a requirement. The exploit has been disclosed to the public and may be used. The patch is identified as b38e562a4c907e08171c76b8b2def8464d5a104a. It is recommended to apply a patch to fix this issue.
References:
https://nvd.nist.gov/vuln/detail/CVE-2025-1371
https://ubuntu.com/security/CVE-2025-1371
Upstream patch:
https://sourceware.org/cgit/elfutils/commit/?id=b38e562a4c907e08171c76b8b2def8464d5a104a
--- .../elfutils/elfutils_0.191.bb | 1 + .../elfutils/files/CVE-2025-1371.patch | 41 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 meta/recipes-devtools/elfutils/files/CVE-2025-1371.patch
meta/recipes-devtools/elfutils/elfutils_0.191.bb +1 -0
@@ -26,6 +26,7 @@ SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \ file://CVE-2025-1352.patch \ file://CVE-2025-1365.patch \ file://CVE-2025-1372.patch \ + file://CVE-2025-1371.patch \ " SRC_URI:append:libc-musl = " \ file://0003-musl-utils.patch \
meta/recipes-devtools/elfutils/files/CVE-2025-1371.patch new file +41 -0
41 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH 3/7 sqlite3: mark CVE-2025-29087 as patched
In reply to Steve SakomanFrom: Peter Marko <[email protected]>
Description of CVE-2025-29087 and CVE-2025-3277 are very similar. There is no lonk from NVD, but [1] and [2] from Debian mark these two CVEs as duplicates with the same link for patch.
[1] https://security-tracker.debian.org/tracker/CVE-2025-29087
[2] https://security-tracker.debian.org/tracker/CVE-2025-3277
--- meta/recipes-support/sqlite/sqlite3/CVE-2025-3277.patch | 1 + 1 file changed, 1 insertion(+)
meta/recipes-support/sqlite/sqlite3/CVE-2025-3277.patch +1 -0
@@ -7,6 +7,7 @@ Subject: [PATCH] Add a typecast to avoid 32-bit integer overflow in the FossilOrigin-Name: 498e3f1cf57f164fbd8380e92bf91b9f26d6aa05d092fcd135d754abf1e5b1b5 CVE: CVE-2025-3277 +CVE: CVE-2025-29087 Upstream-Status: Backport [https://sqlite.org/src/info/498e3f1cf57f164f] Signed-off-by: Peter Marko <[email protected]> ---
Signature · 1 line
2.43.0
PATCH 4/7 glibc: stable 2.39 branch updates
In reply to Steve SakomanFrom: Deepesh Varatharajan <[email protected]>
3463100f2d x86: Detect Intel Diamond Rapidse09436c2cb x86: Handle unknown Intel processor with default tuning 7620d98186 x86: Add ARL/PTL/CWF model detection support765ff3d0d4 x86: Optimize xstate size calculation65ae73be01 x86: Use Avoid_Non_Temporal_Memset to control non-temporal path 2be36448c4 x86: Tunables may incorrectly set Prefer_PMINUB_for_stringop (bug 32047) bde201e92c x86: Disable non-temporal memset on Skylake Server38a7632f2d x86: Fix value for x86_memset_non_temporal_threshold when it is undesirable cc59fa5dbc x86: Enable non-temporal memset tunable for AMD0da58e8be0 x86: Add seperate non-temporal tunable for memset837a36c371 x86: Link tst-gnu2-tls2-x86-noxsave{,c,xsavec} with libpthread 87ab0c7f7f x86: Use separate variable for TLSDESC XSAVE/XSAVEC state size (bug 32810) 60cd7123a6 x86: Skip XSAVE state size reset if ISA level requires XSAVE 4cf3f9df54 x86_64: Add atanh with FMA01ed435e2e x86_64: Add sinh with FMA0edcc77fe7 x86_64: Add tanh with FMA7ecf0d3bde x86-64: Exclude FMA4 IFUNC functions for -mapxfe1fe22368e nptl: clear the whole rseq area before registrationdd8c0c3bbd math: Improve layout of exp/exp10 dataa1b09e59e2 AArch64: Use prefer_sve_ifuncs for SVE memsetd0e2133470 AArch64: Add SVE memset0cc12d9c47 math: Improve layout of expf data0cd10047bf AArch64: Remove zva_128 from memsetdd1e63ab58 AArch64: Optimize memset65a96a6f2b AArch64: Improve generic strlen4073e4ee2c AArch64: Improve codegen for SVE logs78abd3ef6e AArch64: Improve codegen in SVE tansa10183b633 AArch64: Improve codegen of AdvSIMD atan(2)(f)dcd1229e5b AArch64: Improve codegen of AdvSIMD logf function family 72156cb90b AArch64: Improve codegen in AdvSIMD logs5e354bf4e2 AArch64: Simplify rounding-multiply pattern in several AdvSIMD routines 80df456112 aarch64: Avoid redundant MOVs in AdvSIMD F32 logsd591876303 aarch64: Fix AdvSIMD libmvec routines for big-endianf6d48470ae assert: Add test for CVE-2025-0395
Testresults:
Before update |After update |Difference
PASS: 5068 |PASS: 5072 |PASS: +4
FAIL: 120 |FAIL: 120 |FAIL: 0
XPASS: 4 |XPASS: 4 |XPASS: 0
XFAIL: 16 |XFAIL: 16 |XFAIL: 0
UNSUPPORTED: 157|UNSUPPORTED: 157|UNSUPPORTED: 0
--- meta/recipes-core/glibc/glibc-version.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc-version.inc +1 -1
@@ -1,6 +1,6 @@ SRCBRANCH ?= "release/2.39/master" PV = "2.39+git" -SRCREV_glibc ?= "662516aca8b6bf6aa6555f471055d5eb512b1ddc" +SRCREV_glibc ?= "3463100f2d47f2897a24ba8023a5c7aaf2d26550" SRCREV_localedef ?= "fab74f31b3811df543e24b6de47efdf45b538abc" GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https"
Signature · 1 line
2.43.0
PATCH 5/7 binutils: stable 2.42 branch updates
In reply to Steve SakomanFrom: Deepesh Varatharajan <[email protected]>
Below commit on binutils-2.42 stable branch is updated.
6558f9f5f0c s390: Add support for z17 as CPU name
Testing was done and there were no regressions found
--- meta/recipes-devtools/binutils/binutils-2.42.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/binutils/binutils-2.42.inc +1 -1
@@ -20,7 +20,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "binutils-(?P<pver>\d+_(\d_?)*)" CVE_STATUS[CVE-2023-25584] = "cpe-incorrect: Applies only for version 2.40 and earlier" -SRCREV ?= "758a2290dbdf0d6d6c148c6cf25b2bcfd7a5b84f" +SRCREV ?= "6558f9f5f0ccc107a083ae7fbf106ebcb5efa817" BINUTILS_GIT_URI ?= "git://sourceware.org/git/binutils-gdb.git;branch=${SRCBRANCH};protocol=https" SRC_URI = "\ ${BINUTILS_GIT_URI} \
Signature · 1 line
2.43.0
PATCH 6/7 bluez5: make media control a PACKAGECONFIG option
In reply to Steve SakomanFrom: Jeroen Hofstee <[email protected]>
When not building with the default PACKAGECONFIG options, the build can fail with:
undefined reference to media_player_controller_create' undefined reference to media_player_set_status'
Otherwise. So disable it when not set and enable it by default.
The packageconfig option is the same as in Styhead.
https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52
--- meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-connectivity/bluez5/bluez5.inc +2 -0
@@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ a2dp-profiles \ avrcp-profiles \ + mcp-profiles \ network-profiles \ hid-profiles \ hog-profiles \
@@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc" PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap" PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp" PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp" +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp" PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network" PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid" PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog"
Signature · 1 line
2.43.0
PATCH 7/7 bluez5: backport a patch to fix btmgmt -i
In reply to Steve SakomanFrom: Jeroen Hofstee <[email protected]>
Without this patch btmgmt will always use hci0 in
non interactive mode.
--- meta/recipes-connectivity/bluez5/bluez5.inc | 1 + ...ndex-option-for-non-interactive-mode.patch | 29 +++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch
meta/recipes-connectivity/bluez5/bluez5.inc +1 -0
@@ -57,6 +57,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \ file://0001-tests-add-a-target-for-building-tests-without-runnin.patch \ file://0001-test-gatt-Fix-hung-issue.patch \ file://0001-adapter-Fix-up-address-type-when-loading-keys.patch \ + file://toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch \ " S = "${WORKDIR}/bluez-${PV}"
meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch new file +29 -0
@@ -0,0 +1,29 @@ +From f00d5546c9e989dd68ce0de0190cd0e043b0f1f5 Mon Sep 17 00:00:00 2001 +From: Arjan Opmeer <[email protected]> +Date: Tue, 9 Jul 2024 13:55:41 +0200 +Subject: [PATCH] tools/btmgmt: Fix --index option for non-interactive mode + +In non-interactive mode the --index option does not work because the +call to mgmt_set_index() is made after bt_shell_attach(). + +Fixes: https://github.com/bluez/bluez/issues/893 + +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/f00d5546c9e989dd68ce0de0190cd0e043b0f1f5] +--- + tools/btmgmt.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/btmgmt.c b/tools/btmgmt.c +index 9b7f851bd8..436c2bb21f 100644 +--- a/tools/btmgmt.c ++++ b/tools/btmgmt.c +@@ -51,8 +51,8 @@ int main(int argc, char *argv[]) + return EXIT_FAILURE; + } + +- bt_shell_attach(fileno(stdin)); + mgmt_set_index(index_option); ++ bt_shell_attach(fileno(stdin)); + status = bt_shell_run(); + + mgmt_remove_submenu();
Signature · 1 line
2.43.0
Re: [OE-core][scarthgap 6/7] bluez5: make media control a PACKAGECONFIG option
In reply to Steve SakomanQuoted 8 lines · Steve Sakoman via lists.openembedded.org
From: Jeroen Hofstee <[email protected]>
When not building with the default PACKAGECONFIG options, the build can fail with:
undefined reference to
media_player_controller_create' undefined reference tomedia_player_set_status'
Quoted 6 lines
Otherwise. So disable it when not set and enable it by default.
The packageconfig option is the same as in Styhead.
https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52Signed-off-by Steve Sakoman <[email protected]>
Technicality nitpick, depending on how important it is deemed: this patch is missing the original submitter's sign-off.
Quoted 33 lines
--- meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++ 1 file changed, 2 insertions(+)meta/recipes-connectivity/bluez5/bluez5.inc +2
-1@@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ a2dp-profiles \ avrcp-profiles \ + mcp-profiles \ network-profiles \ hid-profiles \ hog-profiles \@@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc" PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap" PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp" PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp" +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp" PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network" PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid" PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog" -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#216063): https://lists.openembedded.org/g/openembedded-core/message/216063
Mute This Topic: https://lists.openembedded.org/mt/112650828/6084445
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 6/7] bluez5: make media control a PACKAGECONFIG option
Quoted 10 lines · Gyorgy Sarvari
Quoted 8 lines · Steve Sakoman via lists.openembedded.org
From: Jeroen Hofstee <[email protected]>
When not building with the default PACKAGECONFIG options, the build can fail with:
undefined reference to
media_player_controller_create' undefined reference tomedia_player_set_status'
Quoted 8 lines
Quoted 6 lines
Otherwise. So disable it when not set and enable it by default.
The packageconfig option is the same as in Styhead.
https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52Signed-off-by Steve Sakoman <[email protected]>Technicality nitpick, depending on how important it is deemed: this patch is missing the original submitter's sign-off.
Good catch! Thanks for reviewing. I will add it before merging.
Steve
Quoted 34 lines
Quoted 33 lines
--- meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++ 1 file changed, 2 insertions(+)meta/recipes-connectivity/bluez5/bluez5.inc +2
-1@@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ a2dp-profiles \ avrcp-profiles \ + mcp-profiles \ network-profiles \ hid-profiles \ hog-profiles \@@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc" PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap" PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp" PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp" +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp" PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network" PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid" PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog" -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#216063): https://lists.openembedded.org/g/openembedded-core/message/216063
Mute This Topic: https://lists.openembedded.org/mt/112650828/6084445
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-