Add nftables tunnel expr, stmt and object support
cover Add nftables tunnel expr, stmt and object support
This patch series add nftables tunnel expression, statement and object support. The implementation was splitted in multiple patches to ease the review process. All the tests are passing and no memory leaks were detected with valgrind enabled.
Please notice this series requires the following patches:
* libnftnl:
- https://lore.kernel.org/netfilter-devel/[email protected]/T/#t
* Linux kernel (already applied on net-next):
- https://lore.kernel.org/netfilter-devel/[email protected]/T/#u
Fernando Fernandez Mancera (4):
tunnel: add vxlan support
tunnel: add geneve support
tunnel: add tunnel object and statement json support
tests: add tunnel shell and python tests
Pablo Neira Ayuso (3):
src: add tunnel template support
tunnel: add erspan support
src: add tunnel statement and expression support
Makefile.am | 2 + include/expression.h | 6 + include/json.h | 1 + include/parser.h | 1 + include/rule.h | 49 ++++ include/tunnel.h | 37 +++ src/cache.c | 2 + src/evaluate.c | 30 +++ src/expression.c | 1 + src/json.c | 99 +++++++- src/mnl.c | 77 ++++++ src/netlink.c | 121 +++++++++ src/netlink_delinearize.c | 17 ++ src/netlink_linearize.c | 14 ++ src/parser_bison.y | 236 +++++++++++++++++- src/parser_json.c | 190 ++++++++++++++ src/rule.c | 178 ++++++++++++- src/scanner.l | 24 +- src/statement.c | 1 + src/tunnel.c | 94 +++++++ tests/py/netdev/tunnel.t | 7 + tests/py/netdev/tunnel.t.json | 45 ++++ tests/py/netdev/tunnel.t.json.payload | 12 + tests/py/netdev/tunnel.t.payload | 12 + tests/shell/features/tunnel.nft | 17 ++ tests/shell/testcases/sets/0075tunnel_0 | 75 ++++++ .../sets/dumps/0075tunnel_0.json-nft | 171 +++++++++++++ .../testcases/sets/dumps/0075tunnel_0.nft | 63 +++++ 28 files changed, 1568 insertions(+), 14 deletions(-) create mode 100644 include/tunnel.h create mode 100644 src/tunnel.c create mode 100644 tests/py/netdev/tunnel.t create mode 100644 tests/py/netdev/tunnel.t.json create mode 100644 tests/py/netdev/tunnel.t.json.payload create mode 100644 tests/py/netdev/tunnel.t.payload create mode 100644 tests/shell/features/tunnel.nft create mode 100755 tests/shell/testcases/sets/0075tunnel_0 create mode 100644 tests/shell/testcases/sets/dumps/0075tunnel_0.json-nft create mode 100644 tests/shell/testcases/sets/dumps/0075tunnel_0.nft
Signature · 1 line
2.49.0
PATCH 1/7 src: add tunnel template support
From: Pablo Neira Ayuso <[email protected]>
This patch adds tunnel template support, this allows to attach a metadata template that provides the configuration for the tunnel driver.
Example of generic tunnel configuration:
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
}}
Joint work with Fernando.
--- include/parser.h | 1 + include/rule.h | 13 +++++++ src/cache.c | 2 + src/evaluate.c | 23 ++++++++++++ src/json.c | 7 ++++ src/mnl.c | 40 ++++++++++++++++++++ src/netlink.c | 81 ++++++++++++++++++++++++++++++++++++++++ src/parser_bison.y | 92 ++++++++++++++++++++++++++++++++++++++++++++-- src/parser_json.c | 8 ++++ src/rule.c | 74 ++++++++++++++++++++++++++++++++++++- src/scanner.l | 12 ++++++ 11 files changed, 349 insertions(+), 4 deletions(-)
include/parser.h +1 -0
@@ -51,6 +51,7 @@ enum startcond_type {PARSER_SC_SECMARK ,PARSER_SC_TCP ,PARSER_SC_TYPE , +PARSER_SC_TUNNEL ,PARSER_SC_VLAN ,PARSER_SC_XT , PARSER_SC_CMD_DESTROY,
include/rule.h +13 -0
@@ -490,6 +490,16 @@ struct secmark {char ctx[NFT_SECMARK_CTX_MAXLEN ]; }; +struct tunnel { +uint32_t id; +struct expr *src; +struct expr *dst; +uint16_t sport; +uint16_t dport; +uint8_t tos; +uint8_t ttl; +}; +/** * struct obj - nftables stateful object statement *
@@ -516,6 +526,7 @@ struct obj {struct secmark secmark;struct ct_expect ct_expect;struct synproxy synproxy; +struct tunnel tunnel; }; };
@@ -662,6 +673,8 @@ enum cmd_obj {CMD_OBJ_CT_EXPECTATIONS ,CMD_OBJ_SYNPROXY ,CMD_OBJ_SYNPROXYS , +CMD_OBJ_TUNNEL , +CMD_OBJ_TUNNELS , CMD_OBJ_HOOKS, };
src/cache.c +2 -0
@@ -443,6 +443,8 @@ static int nft_handle_validate(const struct cmd *cmd, struct list_head *msgs)case CMD_OBJ_CT_TIMEOUTS :case CMD_OBJ_CT_EXPECT :case CMD_OBJ_CT_EXPECTATIONS : +case CMD_OBJ_TUNNEL : +case CMD_OBJ_TUNNELS :if (h->table.name &&strlen (h->table.name) >NFT_NAME_MAXLEN ) { loc = &h->table.location;
src/evaluate.c +23 -0
@@ -5640,6 +5640,26 @@ static int ct_timeout_evaluate(struct eval_ctx *ctx, struct obj *obj)return 0 ; } +static int tunnel_evaluate (struct eval_ctx *ctx,struct obj *obj) +{ +if (obj->tunnel.src !=NULL ) { +__expr_set_context (&ctx->ectx, &ipaddr_type, +BYTEORDER_BIG_ENDIAN , +sizeof (struct in_addr ) *BITS_PER_BYTE ,0 ); +if (expr_evaluate (ctx, &obj->tunnel.src) <0 ) +return -1 ; + } +if (obj->tunnel.dst !=NULL ) { +__expr_set_context (&ctx->ectx, &ipaddr_type, +BYTEORDER_BIG_ENDIAN , +sizeof (struct in_addr ) *BITS_PER_BYTE ,0 ); +if (expr_evaluate (ctx, &obj->tunnel.dst) <0 ) +return -1 ; + } + +return 0 ; +} +static int obj_evaluate (struct eval_ctx *ctx,struct obj *obj) {struct table *table;
@@ -5658,6 +5678,8 @@ static int obj_evaluate(struct eval_ctx *ctx, struct obj *obj)return ct_timeout_evaluate (ctx, obj);case NFT_OBJECT_CT_EXPECT :return ct_expect_evaluate (ctx, obj); +case NFT_OBJECT_TUNNEL : +return tunnel_evaluate (ctx, obj);default :break ; }
@@ -5710,6 +5732,7 @@ static int cmd_evaluate_add(struct eval_ctx *ctx, struct cmd *cmd)case CMD_OBJ_SECMARK :case CMD_OBJ_CT_EXPECT :case CMD_OBJ_SYNPROXY : +case CMD_OBJ_TUNNEL :handle_merge (&cmd->object->handle, &cmd->handle);return obj_evaluate (ctx, cmd->object);default :
src/json.c +7 -0
@@ -468,6 +468,9 @@ static json_t *obj_print_json(const struct obj *obj)json_object_update (root, tmp);json_decref (tmp);break ; +case NFT_OBJECT_TUNNEL : +/* TODO */ +break ; }return json_pack ("{s:o}" , type, root);
@@ -1997,6 +2000,10 @@ int do_command_list_json(struct netlink_ctx *ctx, struct cmd *cmd)case CMD_OBJ_SYNPROXYS : root =do_list_obj_json (ctx, cmd,NFT_OBJECT_SYNPROXY );break ; +case CMD_OBJ_TUNNEL : +case CMD_OBJ_TUNNELS : + root =do_list_obj_json (ctx, cmd,NFT_OBJECT_TUNNEL ); +break ;case CMD_OBJ_FLOWTABLE : root =do_list_flowtable_json (ctx, cmd, table);break ;
src/mnl.c +40 -0
@@ -1453,6 +1453,7 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd, unsigned int flags) {struct obj *obj = cmd->object; +struct nft_data_linearize nld;struct nftnl_udata_buf *udbuf;struct nftnl_obj *nlo;struct nlmsghdr *nlh;
@@ -1541,6 +1542,45 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd,nftnl_obj_set_u32 (nlo,NFTNL_OBJ_SYNPROXY_FLAGS , obj->synproxy.flags);break ; +case NFT_OBJECT_TUNNEL : +nftnl_obj_set_u32 (nlo,NFTNL_OBJ_TUNNEL_ID , obj->tunnel.id); +if (obj->tunnel.sport) +nftnl_obj_set_u16 (nlo,NFTNL_OBJ_TUNNEL_SPORT , + obj->tunnel.sport); +if (obj->tunnel.dport) +nftnl_obj_set_u16 (nlo,NFTNL_OBJ_TUNNEL_DPORT , + obj->tunnel.dport); +if (obj->tunnel.tos) +nftnl_obj_set_u8 (nlo,NFTNL_OBJ_TUNNEL_TOS , + obj->tunnel.tos); +if (obj->tunnel.ttl) +nftnl_obj_set_u8 (nlo,NFTNL_OBJ_TUNNEL_TTL , + obj->tunnel.ttl); +if (obj->tunnel.src) { +netlink_gen_data (obj->tunnel.src, &nld); +if (nld.len ==sizeof (struct in_addr )) { +nftnl_obj_set_u32 (nlo, +NFTNL_OBJ_TUNNEL_IPV4_SRC , + nld.value[0 ]); + }else { +nftnl_obj_set_data (nlo, +NFTNL_OBJ_TUNNEL_IPV6_SRC , + nld.value, nld.len); + } + } +if (obj->tunnel.dst) { +netlink_gen_data (obj->tunnel.dst, &nld); +if (nld.len ==sizeof (struct in_addr )) { +nftnl_obj_set_u32 (nlo, +NFTNL_OBJ_TUNNEL_IPV4_DST , + nld.value[0 ]); + }else { +nftnl_obj_set_data (nlo, +NFTNL_OBJ_TUNNEL_IPV6_DST , + nld.value, nld.len); + } + } +break ;default :BUG ("Unknown type %d\n" , obj->type);break ;
src/netlink.c +81 -0
93 lines not on this page · raw message
src/parser_bison.y +89 -3
161 lines not on this page · raw message
src/parser_json.c +8 -0
@@ -3161,6 +3161,7 @@ static int string_to_nft_object(const char *str) [NFT_OBJECT_SECMARK] = "secmark", [NFT_OBJECT_CT_EXPECT] = "ct expectation", [NFT_OBJECT_SYNPROXY] = "synproxy", + [NFT_OBJECT_TUNNEL] = "tunnel", };unsigned int i;
@@ -3661,6 +3662,9 @@ static struct cmd *json_parse_cmd_add_object(struct json_ctx *ctx, obj->synproxy.flags |= flags;break ; +case CMD_OBJ_TUNNEL : +/* TODO */ +break ;default :BUG ("Invalid CMD '%d'" , cmd_obj); }
@@ -3697,6 +3701,7 @@ static struct cmd *json_parse_cmd_add(struct json_ctx *ctx, { "ct helper", NFT_OBJECT_CT_HELPER, json_parse_cmd_add_object }, { "ct timeout", NFT_OBJECT_CT_TIMEOUT, json_parse_cmd_add_object }, { "ct expectation", NFT_OBJECT_CT_EXPECT, json_parse_cmd_add_object }, + { "tunnel", NFT_OBJECT_TUNNEL, json_parse_cmd_add_object }, { "limit", CMD_OBJ_LIMIT, json_parse_cmd_add_object }, { "secmark", CMD_OBJ_SECMARK, json_parse_cmd_add_object }, { "synproxy", CMD_OBJ_SYNPROXY, json_parse_cmd_add_object }
@@ -3832,6 +3837,7 @@ static struct cmd *json_parse_cmd_list_multiple(struct json_ctx *ctx,case CMD_OBJ_SETS :case CMD_OBJ_COUNTERS :case CMD_OBJ_CT_HELPERS : +case CMD_OBJ_TUNNELS :if (!json_unpack (root,"{s:s}" ,"table" , &tmp)) h.table.name =xstrdup (tmp);break ;
@@ -3870,6 +3876,8 @@ static struct cmd *json_parse_cmd_list(struct json_ctx *ctx, { "ct helpers", CMD_OBJ_CT_HELPERS, json_parse_cmd_list_multiple }, { "ct timeout", NFT_OBJECT_CT_TIMEOUT, json_parse_cmd_add_object }, { "ct expectation", NFT_OBJECT_CT_EXPECT, json_parse_cmd_add_object }, + { "tunnel", NFT_OBJECT_TUNNEL, json_parse_cmd_add_object }, + { "tunnels", CMD_OBJ_TUNNELS, json_parse_cmd_list_multiple }, { "limit", CMD_OBJ_LIMIT, json_parse_cmd_add_object }, { "limits", CMD_OBJ_LIMIT, json_parse_cmd_list_multiple }, { "ruleset", CMD_OBJ_RULESET, json_parse_cmd_list_multiple },
src/rule.c +73 -1
128 lines not on this page · raw message
src/scanner.l +12 -0
@@ -223,6 +223,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) %s SCANSTATE_SECMARK %s SCANSTATE_TCP %s SCANSTATE_TYPE +%s SCANSTATE_TUNNEL %s SCANSTATE_VLAN %s SCANSTATE_XT %s SCANSTATE_CMD_DESTROY
@@ -403,6 +404,8 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "maps" { return MAPS; } "secmarks" { return SECMARKS; } "synproxys" { return SYNPROXYS; } + "tunnel" { return TUNNEL; } + "tunnels" { return TUNNELS; } "hooks" { return HOOKS; } }
@@ -807,6 +810,15 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "sack-perm" { return SACK_PERM; } } +"tunnel" { scanner_push_start_cond(yyscanner, SCANSTATE_TUNNEL); return TUNNEL; } +<SCANSTATE_TUNNEL>{ + "id" { return ID; } + "sport" { return SPORT; } + "dport" { return DPORT; } + "ttl" { return TTL; } + "tos" { return TOS; } +} + "notrack" { return NOTRACK; } "all" { return ALL; }
Signature · 1 line
2.49.0
PATCH 2/7 tunnel: add erspan support
In reply to Fernando Fernandez ManceraFrom: Pablo Neira Ayuso <[email protected]>
This patch extends the tunnel metadata object to define erspan tunnel specific configurations:
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
erspan {
version 1
index 2
}
}}
Joint work with Fernando.
--- include/rule.h | 18 ++++++++++++++++++ src/mnl.c | 24 ++++++++++++++++++++++++ src/netlink.c | 16 ++++++++++++++++ src/parser_bison.y | 46 +++++++++++++++++++++++++++++++++++++++++++++- src/rule.c | 26 ++++++++++++++++++++++++++ src/scanner.l | 5 +++++ 6 files changed, 134 insertions(+), 1 deletion(-)
include/rule.h +18 -0
@@ -490,6 +490,11 @@ struct secmark {char ctx[NFT_SECMARK_CTX_MAXLEN ]; }; +enum tunnel_type { +TUNNEL_UNSPEC =0 , +TUNNEL_ERSPAN , +}; +struct tunnel {uint32_t id;struct expr *src;
@@ -498,6 +503,19 @@ struct tunnel {uint16_t dport;uint8_t tos;uint8_t ttl; +enum tunnel_type type; +union { +struct { +uint32_t version; +struct { +uint32_t index; + } v1; +struct { +uint8_t direction; +uint8_t hwid; + } v2; + } erspan; + }; };/**
src/mnl.c +24 -0
@@ -1580,6 +1580,30 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd, nld.value, nld.len); } } +switch (obj->tunnel.type) { +case TUNNEL_ERSPAN : +nftnl_obj_set_u32 (nlo, +NFTNL_OBJ_TUNNEL_ERSPAN_VERSION , + obj->tunnel.erspan.version); +switch (obj->tunnel.erspan.version) { +case 1 : +nftnl_obj_set_u32 (nlo, +NFTNL_OBJ_TUNNEL_ERSPAN_V1_INDEX , + obj->tunnel.erspan.v1.index); +break ; +case 2 : +nftnl_obj_set_u8 (nlo, +NFTNL_OBJ_TUNNEL_ERSPAN_V2_DIR , + obj->tunnel.erspan.v2.direction); +nftnl_obj_set_u8 (nlo, +NFTNL_OBJ_TUNNEL_ERSPAN_V2_HWID , + obj->tunnel.erspan.v2.hwid); +break ; + } +break ; +case TUNNEL_UNSPEC : +break ; + }break ;default :BUG ("Unknown type %d\n" , obj->type);
src/netlink.c +16 -0
@@ -1885,6 +1885,22 @@ struct obj *netlink_delinearize_obj(struct netlink_ctx *ctx, obj->tunnel.dst =netlink_obj_tunnel_parse_addr (nlo,NFTNL_OBJ_TUNNEL_IPV6_DST ); } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_VERSION )) { + obj->tunnel.type =TUNNEL_ERSPAN ; + obj->tunnel.erspan.version =nftnl_obj_get_u32 (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_VERSION ); + } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V1_INDEX )) { + obj->tunnel.type =TUNNEL_ERSPAN ; + obj->tunnel.erspan.v1.index =nftnl_obj_get_u8 (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V1_INDEX ); + } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V2_DIR )) { + obj->tunnel.type =TUNNEL_ERSPAN ; + obj->tunnel.erspan.v2.direction =nftnl_obj_get_u8 (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V2_DIR ); + } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V2_HWID )) { + obj->tunnel.type =TUNNEL_ERSPAN ; + obj->tunnel.erspan.v2.hwid =nftnl_obj_get_u8 (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V2_HWID ); + }break ;default :netlink_io_error (ctx,NULL ,"Unknown object type %u" , type);
src/parser_bison.y +45 -1
70 lines not on this page · raw message
src/rule.c +26 -0
@@ -2005,6 +2005,32 @@ static void obj_print_data(const struct obj *obj, opts->nl, opts->tab, opts->tab, obj->tunnel.ttl); } +switch (obj->tunnel.type) { +case TUNNEL_ERSPAN : +nft_print (octx,"%s%s%serspan {" , + opts->nl, opts->tab, opts->tab); +nft_print (octx,"%s%s%s%sversion %u" , + opts->nl, opts->tab, opts->tab, opts->tab, + obj->tunnel.erspan.version); +if (obj->tunnel.erspan.version ==1 ) { +nft_print (octx,"%s%s%s%sindex %u" , + opts->nl, opts->tab, opts->tab, opts->tab, + obj->tunnel.erspan.v1.index); + }else { +nft_print (octx,"%s%s%s%sdirection %s" , + opts->nl, opts->tab, opts->tab, opts->tab, + obj->tunnel.erspan.v2.direction ?"egress" + :"ingress" ); +nft_print (octx,"%s%s%s%sid %u" , + opts->nl, opts->tab, opts->tab, opts->tab, + obj->tunnel.erspan.v2.hwid); + } +nft_print (octx,"%s%s%s}" , + opts->nl, opts->tab, opts->tab); +default : +break ; + } +nft_print (octx,"%s" , opts->stmt_separator);break ;default :
src/scanner.l +5 -0
@@ -817,6 +817,11 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "dport" { return DPORT; } "ttl" { return TTL; } "tos" { return TOS; } + "version" { return HDRVERSION; } + "direction" { return DIRECTION; } + "erspan" { return ERSPAN; } + "egress" { return EGRESS; } + "ingress" { return INGRESS; } } "notrack" { return NOTRACK; }
Signature · 1 line
2.49.0
PATCH 5/7 tunnel: add geneve support
In reply to Fernando Fernandez ManceraThis patch extends the tunnel metadata object to define geneve tunnel specific configurations:
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
geneve {
class 0x1010 opt-type 0x1 data "0x12345678"
class 0x1020 opt-type 0x2 data "0x87654321"
class 0x2020 opt-type 0x3 data "0x87654321abcdeffe"
}
}
}--- include/rule.h | 14 ++++++++++ src/mnl.c | 8 ++++++ src/netlink.c | 20 ++++++++++++++ src/parser_bison.y | 43 ++++++++++++++++++++++++++++- src/rule.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++ src/scanner.l | 3 ++ 6 files changed, 155 insertions(+), 1 deletion(-)
include/rule.h +14 -0
@@ -494,6 +494,15 @@ enum tunnel_type {TUNNEL_UNSPEC =0 ,TUNNEL_ERSPAN ,TUNNEL_VXLAN , + TUNNEL_GENEVE, +}; + +struct tunnel_geneve { +struct list_head list; +uint16_t geneve_class; +uint8_t type; +uint8_t data[NFTNL_TUNNEL_GENEVE_DATA_MAXLEN ]; +uint32_t data_len; }; struct tunnel {
@@ -519,9 +528,14 @@ struct tunnel {struct {uint32_t gbp; } vxlan; +struct list_head geneve_opts; }; }; +int tunnel_geneve_data_str2array (const char *hexstr, +uint8_t *out_data, +uint32_t *out_len); +/** * struct obj - nftables stateful object statement *
src/mnl.c +8 -0
@@ -1455,6 +1455,7 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd,struct obj *obj = cmd->object;struct nft_data_linearize nld;struct nftnl_udata_buf *udbuf; +struct tunnel_geneve *geneve;struct nftnl_obj *nlo;struct nlmsghdr *nlh;
@@ -1606,6 +1607,13 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd,NFTNL_OBJ_TUNNEL_VXLAN_GBP , obj->tunnel.vxlan.gbp);break ; +case TUNNEL_GENEVE : +list_for_each_entry (geneve, &obj->tunnel.geneve_opts, list) { +nftnl_obj_set_data (nlo, +NFTNL_OBJ_TUNNEL_GENEVE_OPTS , + geneve,sizeof (struct tunnel_geneve )); + } +break ;case TUNNEL_UNSPEC :break ; }
src/netlink.c +20 -0
@@ -1756,6 +1756,23 @@ static int obj_parse_udata_cb(const struct nftnl_udata *attr, void *data)return 0 ; } +static int netlink_parse_obj_tunnel_geneve (struct nftnl_obj_tunnel_geneve *e,void *data) +{ +struct tunnel_geneve *geneve; +struct obj *obj = data; + +if (!obj->tunnel.type) { +init_list_head (&obj->tunnel.geneve_opts); + obj->tunnel.type =TUNNEL_GENEVE ; + } + + geneve =xmalloc (sizeof (struct tunnel_geneve )); +memcpy (geneve, e,sizeof (struct tunnel_geneve )); +list_add_tail (&geneve->list, &obj->tunnel.geneve_opts); + +return 0 ; +} +struct obj *netlink_delinearize_obj (struct netlink_ctx *ctx,struct nftnl_obj *nlo) {
@@ -1905,6 +1922,9 @@ struct obj *netlink_delinearize_obj(struct netlink_ctx *ctx, obj->tunnel.type =TUNNEL_VXLAN ; obj->tunnel.vxlan.gbp =nftnl_obj_get_u32 (nlo,NFTNL_OBJ_TUNNEL_VXLAN_GBP ); } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_GENEVE_OPTS )) { +nftnl_obj_tunnel_geneve_opts_foreach (nlo, netlink_parse_obj_tunnel_geneve, obj); + }break ;default :netlink_io_error (ctx,NULL ,"Unknown object type %u" , type);
src/parser_bison.y +42 -1
67 lines not on this page · raw message
src/rule.c +68 -0
92 lines not on this page · raw message
src/scanner.l +3 -0
@@ -824,6 +824,9 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "ingress" { return INGRESS; } "path" { return PATH; } "gbp" { return GBP; } + "class" { return CLASS; } + "opt-type" { return OPTTYPE; } + "data" { return DATA; } } "notrack" { return NOTRACK; }
Signature · 1 line
2.49.0
PATCH 3/7 src: add tunnel statement and expression support
In reply to Fernando Fernandez ManceraFrom: Pablo Neira Ayuso <[email protected]>
This patch allows you to attach tunnel metadata through the tunnel statement.
The following example shows how to redirect traffic to the erspan0 tunnel device which will take the tunnel configuration that is specified by the ruleset.
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
erspan {
version 1
index 2
}
}
chain x {
type filter hook ingress device veth0 priority 0;
ip daddr 10.141.10.123 tunnel name y fwd to erspan0
}
}This patch also allows to match on tunnel metadata via tunnel expression.
Joint work with Fernando.
--- Makefile.am | 2 ++ include/expression.h | 6 ++++ include/tunnel.h | 33 +++++++++++++++++ src/evaluate.c | 7 ++++ src/expression.c | 1 + src/netlink_delinearize.c | 17 +++++++++ src/netlink_linearize.c | 14 ++++++++ src/parser_bison.y | 33 ++++++++++++++--- src/scanner.l | 3 +- src/statement.c | 1 + src/tunnel.c | 76 +++++++++++++++++++++++++++++++++++++++ 11 files changed, 187 insertions(+), 6 deletions(-) create mode 100644 include/tunnel.h create mode 100644 src/tunnel.c
Makefile.am +2 -0
@@ -99,6 +99,7 @@ noinst_HEADERS = \ include/socket.h \ include/statement.h \ include/tcpopt.h \ + include/tunnel.h \ include/utils.h \ include/xfrm.h \ include/xt.h \
@@ -241,6 +242,7 @@ src_libnftables_la_SOURCES = \ src/socket.c \ src/statement.c \ src/tcpopt.c \ + src/tunnel.c \ src/utils.c \ src/xfrm.c \ $(NULL)
include/expression.h +6 -0
@@ -77,6 +77,7 @@ enum expr_types {EXPR_NUMGEN ,EXPR_HASH ,EXPR_RT , +EXPR_TUNNEL ,EXPR_FIB ,EXPR_XFRM , EXPR_SET_ELEM_CATCHALL,
@@ -229,6 +230,7 @@ enum expr_flags {#include <hash.h> #include <ct.h> #include <socket.h> +#include <tunnel.h> #include <osf.h> #include <xfrm.h>
@@ -358,6 +360,10 @@ struct expr {enum nft_socket_keys key;uint32_t level; } socket; +struct { +/* EXPR_TUNNEL */ +enum nft_tunnel_keys key; + } tunnel;struct {/* EXPR_RT */ enum nft_rt_keys key;
include/tunnel.h new file +33 -0
@@ -0,0 +1,33 @@ +#ifndef NFTABLES_TUNNEL_H +#define NFTABLES_TUNNEL_H + +/** +* struct tunnel_template - template for tunnel expressions +* +* @token: parser token for the expression +* @dtype: data type of the expression +* @len: length of the expression +* @byteorder: byteorder +*/ +struct tunnel_template { +const char *token; +const struct datatype *dtype; +enum byteorder byteorder; +unsigned int len; +}; + +extern const struct tunnel_template tunnel_templates[]; + +#define TUNNEL_TEMPLATE (__token, __dtype, __len, __byteorder) { \ + .token = (__token), \ + .dtype = (__dtype), \ + .len = (__len), \ + .byteorder = (__byteorder), \ +} + +extern struct expr *tunnel_expr_alloc (const struct location *loc, +enum nft_tunnel_keys key); + +extern const struct expr_ops tunnel_expr_ops; + +#endif /* NFTABLES_TUNNEL_H */
src/evaluate.c +7 -0
@@ -2936,6 +2936,11 @@ static int expr_evaluate_osf(struct eval_ctx *ctx, struct expr **expr)return expr_evaluate_primary (ctx, expr); } +static int expr_evaluate_tunnel (struct eval_ctx *ctx,struct expr **exprp) +{ +return expr_evaluate_primary (ctx, exprp); +} +static int expr_evaluate_variable (struct eval_ctx *ctx,struct expr **exprp) {struct symbol *sym = (*exprp)->sym;
@@ -3037,6 +3042,8 @@ static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr)return expr_evaluate_meta (ctx, expr);case EXPR_SOCKET :return expr_evaluate_socket (ctx, expr); +case EXPR_TUNNEL : +return expr_evaluate_tunnel (ctx, expr);case EXPR_OSF :return expr_evaluate_osf (ctx, expr);case EXPR_FIB :
src/expression.c +1 -0
@@ -1761,6 +1761,7 @@ static const struct expr_ops *__expr_ops_by_type(enum expr_types etype)case EXPR_NUMGEN :return &numgen_expr_ops;case EXPR_HASH :return &hash_expr_ops;case EXPR_RT :return &rt_expr_ops; +case EXPR_TUNNEL :return &tunnel_expr_ops;case EXPR_FIB :return &fib_expr_ops;case EXPR_XFRM :return &xfrm_expr_ops;case EXPR_SET_ELEM_CATCHALL :return &set_elem_catchall_expr_ops;
src/netlink_delinearize.c +17 -0
@@ -940,6 +940,21 @@ static void netlink_parse_osf(struct netlink_parse_ctx *ctx,netlink_set_register (ctx, dreg, expr); } +static void netlink_parse_tunnel (struct netlink_parse_ctx *ctx, +const struct location *loc, +const struct nftnl_expr *nle) +{ +enum nft_registers dreg; +struct expr * expr; +uint32_t key; + + key =nftnl_expr_get_u32 (nle,NFTNL_EXPR_TUNNEL_KEY ); + expr =tunnel_expr_alloc (loc, key); + + dreg =netlink_parse_register (nle,NFTNL_EXPR_TUNNEL_DREG ); +netlink_set_register (ctx, dreg, expr); +} +static void netlink_parse_meta_stmt (struct netlink_parse_ctx *ctx,const struct location *loc,const struct nftnl_expr *nle)
@@ -1922,6 +1937,7 @@ static const struct expr_handler netlink_parsers[] = { { .name = "exthdr", .parse = netlink_parse_exthdr }, { .name = "meta", .parse = netlink_parse_meta }, { .name = "socket", .parse = netlink_parse_socket }, + { .name = "tunnel", .parse = netlink_parse_tunnel }, { .name = "osf", .parse = netlink_parse_osf }, { .name = "rt", .parse = netlink_parse_rt }, { .name = "ct", .parse = netlink_parse_ct },
@@ -3023,6 +3039,7 @@ static void expr_postprocess(struct rule_pp_ctx *ctx, struct expr **exprp)case EXPR_NUMGEN :case EXPR_FIB :case EXPR_SOCKET : +case EXPR_TUNNEL :case EXPR_OSF :case EXPR_XFRM :break ;
src/netlink_linearize.c +14 -0
@@ -334,6 +334,18 @@ static void netlink_gen_osf(struct netlink_linearize_ctx *ctx,nft_rule_add_expr (ctx, nle, &expr->location); } +static void netlink_gen_tunnel (struct netlink_linearize_ctx *ctx, +const struct expr *expr, +enum nft_registers dreg) +{ +struct nftnl_expr *nle; + + nle =alloc_nft_expr ("tunnel" ); +netlink_put_register (nle,NFTNL_EXPR_TUNNEL_DREG , dreg); +nftnl_expr_set_u32 (nle,NFTNL_EXPR_TUNNEL_KEY , expr->tunnel.key); +nftnl_rule_add_expr (ctx->nlr, nle); +} +static void netlink_gen_numgen (struct netlink_linearize_ctx *ctx,const struct expr *expr,enum nft_registers dreg)
@@ -932,6 +944,8 @@ static void netlink_gen_expr(struct netlink_linearize_ctx *ctx,return netlink_gen_fib (ctx, expr, dreg);case EXPR_SOCKET :return netlink_gen_socket (ctx, expr, dreg); +case EXPR_TUNNEL : +return netlink_gen_tunnel (ctx, expr, dreg);case EXPR_OSF :return netlink_gen_osf (ctx, expr, dreg);case EXPR_XFRM :
src/parser_bison.y +28 -5
@@ -320,6 +320,8 @@ int nft_lex(void *, void *, void *); %token RULESET "ruleset" %token TRACE "trace" +%token PATH "path" + %token INET "inet" %token NETDEV "netdev"
@@ -778,8 +780,8 @@ int nft_lex(void *, void *, void *); %destructor { stmt_free($$); } counter_stmt counter_stmt_alloc stateful_stmt last_stmt %type <stmt> limit_stmt_alloc quota_stmt_alloc last_stmt_alloc ct_limit_stmt_alloc %destructor { stmt_free($$); } limit_stmt_alloc quota_stmt_alloc last_stmt_alloc ct_limit_stmt_alloc -%type <stmt> objref_stmt objref_stmt_counter objref_stmt_limit objref_stmt_quota objref_stmt_ct objref_stmt_synproxy -%destructor { stmt_free($$); } objref_stmt objref_stmt_counter objref_stmt_limit objref_stmt_quota objref_stmt_ct objref_stmt_synproxy +%type <stmt> objref_stmt objref_stmt_counter objref_stmt_limit objref_stmt_quota objref_stmt_ct objref_stmt_synproxy objref_stmt_tunnel +%destructor { stmt_free($$); } objref_stmt objref_stmt_counter objref_stmt_limit objref_stmt_quota objref_stmt_ct objref_stmt_synproxy objref_stmt_tunnel %type <stmt> payload_stmt %destructor { stmt_free($$); } payload_stmt
@@ -939,9 +941,9 @@ int nft_lex(void *, void *, void *); %destructor { expr_free($$); } mh_hdr_expr %type <val> mh_hdr_field -%type <expr> meta_expr -%destructor { expr_free($$); } meta_expr -%type <val> meta_key meta_key_qualified meta_key_unqualified numgen_type +%type <expr> meta_expr tunnel_expr +%destructor { expr_free($$); } meta_expr tunnel_expr +%type <val> meta_key meta_key_qualified meta_key_unqualified numgen_type tunnel_key %type <expr> socket_expr %destructor { expr_free($$); } socket_expr
@@ -3203,6 +3205,14 @@ objref_stmt_synproxy : SYNPROXY NAME stmt_expr close_scope_synproxy } ; +objref_stmt_tunnel : TUNNEL NAME stmt_expr close_scope_tunnel + { + $$ = objref_stmt_alloc(&@$); + $$->objref.type = NFT_OBJECT_TUNNEL; + $$->objref.expr = $3; + } + ; + objref_stmt_ct : CT TIMEOUT SET stmt_expr close_scope_ct { $$ = objref_stmt_alloc(&@$);
@@ -3223,6 +3233,7 @@ objref_stmt : objref_stmt_counter | objref_stmt_quota | objref_stmt_synproxy | objref_stmt_ct + | objref_stmt_tunnel ; stateful_stmt : counter_stmt close_scope_counter
@@ -3901,6 +3912,7 @@ primary_stmt_expr : symbol_expr { $$ = $1; } | boolean_expr { $$ = $1; } | meta_expr { $$ = $1; } | rt_expr { $$ = $1; } + | tunnel_expr { $$ = $1; } | ct_expr { $$ = $1; } | numgen_expr { $$ = $1; } | hash_expr { $$ = $1; }
@@ -4377,6 +4389,7 @@ selector_expr : payload_expr { $$ = $1; } | exthdr_expr { $$ = $1; } | exthdr_exists_expr { $$ = $1; } | meta_expr { $$ = $1; } + | tunnel_expr { $$ = $1; } | socket_expr { $$ = $1; } | rt_expr { $$ = $1; } | ct_expr { $$ = $1; }
@@ -5471,6 +5484,16 @@ socket_key : TRANSPARENT { $$ = NFT_SOCKET_TRANSPARENT; } | WILDCARD { $$ = NFT_SOCKET_WILDCARD; } ; +tunnel_key : PATH { $$ = NFT_TUNNEL_PATH; } + | ID { $$ = NFT_TUNNEL_ID; } + ; + +tunnel_expr : TUNNEL tunnel_key + { + $$ = tunnel_expr_alloc(&@$, $2); + } + ; + offset_opt : /* empty */ { $$ = 0; } | OFFSET NUM { $$ = $2; } ;
src/scanner.l +2 -1
@@ -410,7 +410,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) } "counter" { scanner_push_start_cond(yyscanner, SCANSTATE_COUNTER); return COUNTER; } -<SCANSTATE_COUNTER,SCANSTATE_LIMIT,SCANSTATE_QUOTA,SCANSTATE_STMT_SYNPROXY,SCANSTATE_EXPR_OSF>"name" { return NAME; } +<SCANSTATE_COUNTER,SCANSTATE_LIMIT,SCANSTATE_QUOTA,SCANSTATE_STMT_SYNPROXY,SCANSTATE_EXPR_OSF,SCANSTATE_TUNNEL>"name" { return NAME; } <SCANSTATE_COUNTER,SCANSTATE_CT,SCANSTATE_LIMIT>"packets" { return PACKETS; } <SCANSTATE_COUNTER,SCANSTATE_CT,SCANSTATE_LIMIT,SCANSTATE_QUOTA>"bytes" { return BYTES; }
@@ -822,6 +822,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "erspan" { return ERSPAN; } "egress" { return EGRESS; } "ingress" { return INGRESS; } + "path" { return PATH; } } "notrack" { return NOTRACK; }
src/statement.c +1 -0
@@ -289,6 +289,7 @@ static const char *objref_type[NFT_OBJECT_MAX + 1] = { [NFT_OBJECT_QUOTA] = "quota", [NFT_OBJECT_CT_HELPER] = "ct helper", [NFT_OBJECT_LIMIT] = "limit", + [NFT_OBJECT_TUNNEL] = "tunnel", [NFT_OBJECT_CT_TIMEOUT] = "ct timeout", [NFT_OBJECT_SECMARK] = "secmark", [NFT_OBJECT_SYNPROXY] = "synproxy",
src/tunnel.c new file +76 -0
76 lines not on this page · raw message
Signature · 1 line
2.49.0
PATCH 6/7 tunnel: add tunnel object and statement json support
In reply to Fernando Fernandez Mancera--- include/json.h | 1 + include/tunnel.h | 4 + src/json.c | 94 +++++++++++++++++++++-- src/parser_json.c | 186 +++++++++++++++++++++++++++++++++++++++++++++- src/tunnel.c | 18 +++++ 5 files changed, 296 insertions(+), 7 deletions(-)
include/json.h +1 -0
@@ -31,6 +31,7 @@ json_t *binop_expr_json(const struct expr *expr, struct output_ctx *octx);json_t *relational_expr_json (const struct expr *expr,struct output_ctx *octx);json_t *range_expr_json (const struct expr *expr,struct output_ctx *octx);json_t *meta_expr_json (const struct expr *expr,struct output_ctx *octx); +json_t *tunnel_expr_json (const struct expr *expr,struct output_ctx *octx);json_t *payload_expr_json (const struct expr *expr,struct output_ctx *octx);json_t *ct_expr_json (const struct expr *expr,struct output_ctx *octx);json_t *concat_expr_json (const struct expr *expr,struct output_ctx *octx);
include/tunnel.h +4 -0
@@ -25,6 +25,10 @@ extern const struct tunnel_template tunnel_templates[]; .byteorder = (__byteorder), \ } +struct error_record *tunnel_key_parse (const struct location *loc, +const char *str, +unsigned int *value); +extern struct expr *tunnel_expr_alloc (const struct location *loc,enum nft_tunnel_keys key);
src/json.c +89 -5
130 lines not on this page · raw message
src/parser_json.c +184 -2
228 lines not on this page · raw message
src/tunnel.c +18 -0
@@ -6,6 +6,8 @@* published by the Free Software Foundation. */ +#include <nft.h> +#include <errno.h> #include <limits.h> #include <stddef.h>
@@ -38,6 +40,21 @@ const struct tunnel_template tunnel_templates[] = { 4 * 8, BYTEORDER_HOST_ENDIAN), }; +struct error_record *tunnel_key_parse (const struct location *loc, +const char *str, +unsigned int *value) +{ +for (unsigned int i =0 ; i <array_size (tunnel_templates); i++) { +if (!tunnel_templates[i].token ||strcmp (tunnel_templates[i].token, str)) +continue ; + + *value = i; +return NULL ; + } + +return error (loc,"syntax error, unexpected %s" , str); +} +static void tunnel_expr_print (const struct expr *expr,struct output_ctx *octx) { nft_print(octx, "tunnel %s",
@@ -58,6 +75,7 @@ const struct expr_ops tunnel_expr_ops = { .type = EXPR_TUNNEL, .name = "tunnel", .print = tunnel_expr_print, + .json = tunnel_expr_json, .cmp = tunnel_expr_cmp, .clone = tunnel_expr_clone, };
Signature · 1 line
2.49.0
PATCH 4/7 tunnel: add vxlan support
In reply to Fernando Fernandez ManceraThis patch extends the tunnel metadata object to define vxlan tunnel specific configurations:
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
vxlan {
gbp 200
}
}
}--- include/rule.h | 4 ++++ src/mnl.c | 5 +++++ src/netlink.c | 4 ++++ src/parser_bison.y | 28 +++++++++++++++++++++++++++- src/rule.c | 10 ++++++++++ src/scanner.l | 1 + 6 files changed, 51 insertions(+), 1 deletion(-)
include/rule.h +4 -0
@@ -493,6 +493,7 @@ struct secmark {enum tunnel_type {TUNNEL_UNSPEC =0 ,TUNNEL_ERSPAN , +TUNNEL_VXLAN , };struct tunnel {
@@ -515,6 +516,9 @@ struct tunnel {uint8_t hwid; } v2; } erspan; +struct { +uint32_t gbp; + } vxlan; }; };
src/mnl.c +5 -0
@@ -1601,6 +1601,11 @@ int mnl_nft_obj_add(struct netlink_ctx *ctx, struct cmd *cmd,break ; }break ; +case TUNNEL_VXLAN : +nftnl_obj_set_u32 (nlo, +NFTNL_OBJ_TUNNEL_VXLAN_GBP , + obj->tunnel.vxlan.gbp); +break ;case TUNNEL_UNSPEC :break ; }
src/netlink.c +4 -0
@@ -1901,6 +1901,10 @@ struct obj *netlink_delinearize_obj(struct netlink_ctx *ctx, obj->tunnel.type =TUNNEL_ERSPAN ; obj->tunnel.erspan.v2.hwid =nftnl_obj_get_u8 (nlo,NFTNL_OBJ_TUNNEL_ERSPAN_V2_HWID ); } +if (nftnl_obj_is_set (nlo,NFTNL_OBJ_TUNNEL_VXLAN_GBP )) { + obj->tunnel.type =TUNNEL_VXLAN ; + obj->tunnel.vxlan.gbp =nftnl_obj_get_u32 (nlo,NFTNL_OBJ_TUNNEL_VXLAN_GBP ); + }break ;default :netlink_io_error (ctx,NULL ,"Unknown object type %u" , type);
src/parser_bison.y +27 -1
@@ -611,6 +611,7 @@ int nft_lex(void *, void *, void *); %token ERSPAN "erspan" %token EGRESS "egress" %token INGRESS "ingress" +%token GBP "gbp" %token COUNTERS "counters" %token QUOTAS "quotas"
@@ -769,7 +770,7 @@ int nft_lex(void *, void *, void *); %type <flowtable> flowtable_block_alloc flowtable_block %destructor { flowtable_free($$); } flowtable_block_alloc -%type <obj> obj_block_alloc counter_block quota_block ct_helper_block ct_timeout_block ct_expect_block limit_block secmark_block synproxy_block tunnel_block erspan_block erspan_block_alloc +%type <obj> obj_block_alloc counter_block quota_block ct_helper_block ct_timeout_block ct_expect_block limit_block secmark_block synproxy_block tunnel_block erspan_block erspan_block_alloc vxlan_block vxlan_block_alloc %destructor { obj_free($$); } obj_block_alloc %type <list> stmt_list stateful_stmt_list set_elem_stmt_list
@@ -5001,6 +5002,27 @@ erspan_config : HDRVERSION NUM } ; +vxlan_block : /* empty */ { $$ = $<obj>-1; } + | vxlan_block common_block + | vxlan_block stmt_separator + | vxlan_block vxlan_config stmt_separator + { + $$ = $1; + } + ; + +vxlan_block_alloc : /* empty */ + { + $$ = $<obj>-1; + } + ; + +vxlan_config : GBP NUM + { + $<obj>0->tunnel.vxlan.gbp = $2; + } + ; + tunnel_config : ID NUM { $<obj>0->tunnel.id = $2;
@@ -5033,6 +5055,10 @@ tunnel_config : ID NUM { $<obj>0->tunnel.type = TUNNEL_ERSPAN; } + | VXLAN vxlan_block_alloc '{' vxlan_block '}' + { + $<obj>0->tunnel.type = TUNNEL_VXLAN; + } ; tunnel_block : /* empty */ { $$ = $<obj>-1; }
src/rule.c +10 -0
@@ -2027,6 +2027,16 @@ static void obj_print_data(const struct obj *obj, }nft_print (octx,"%s%s%s}" , opts->nl, opts->tab, opts->tab); +break ; +case TUNNEL_VXLAN : +nft_print (octx,"%s%s%svxlan {" , + opts->nl, opts->tab, opts->tab); +nft_print (octx,"%s%s%s%sgbp %u" , + opts->nl, opts->tab, opts->tab, opts->tab, + obj->tunnel.vxlan.gbp); +nft_print (octx,"%s%s%s}" , + opts->nl, opts->tab, opts->tab); +break ;default :break ; }
src/scanner.l +1 -0
@@ -823,6 +823,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr}) "egress" { return EGRESS; } "ingress" { return INGRESS; } "path" { return PATH; } + "gbp" { return GBP; } } "notrack" { return NOTRACK; }
Signature · 1 line
2.49.0
PATCH 7/7 tests: add tunnel shell and python tests
In reply to Fernando Fernandez ManceraAdd tests for tunnel statement and object support. Shell and python tests both cover standard nft output and json.
--- tests/py/netdev/tunnel.t | 7 + tests/py/netdev/tunnel.t.json | 45 +++++ tests/py/netdev/tunnel.t.json.payload | 12 ++ tests/py/netdev/tunnel.t.payload | 12 ++ tests/shell/features/tunnel.nft | 17 ++ tests/shell/testcases/sets/0075tunnel_0 | 75 ++++++++ .../sets/dumps/0075tunnel_0.json-nft | 171 ++++++++++++++++++ .../testcases/sets/dumps/0075tunnel_0.nft | 63 +++++++ 8 files changed, 402 insertions(+) create mode 100644 tests/py/netdev/tunnel.t create mode 100644 tests/py/netdev/tunnel.t.json create mode 100644 tests/py/netdev/tunnel.t.json.payload create mode 100644 tests/py/netdev/tunnel.t.payload create mode 100644 tests/shell/features/tunnel.nft create mode 100755 tests/shell/testcases/sets/0075tunnel_0 create mode 100644 tests/shell/testcases/sets/dumps/0075tunnel_0.json-nft create mode 100644 tests/shell/testcases/sets/dumps/0075tunnel_0.nft
tests/py/netdev/tunnel.t new file +7 -0
@@ -0,0 +1,7 @@ +:tunnelchain;type filter hook ingress device lo priority 0 + +*netdev;test-netdev;tunnelchain + +tunnel path exists;ok +tunnel path missing;ok +tunnel id 10;ok
tests/py/netdev/tunnel.t.json new file +45 -0
45 lines not on this page · raw message
tests/py/netdev/tunnel.t.json.payload new file +12 -0
@@ -0,0 +1,12 @@ +# tunnel path exists +netdev test-netdev tunnelchain + [ tunnel load path => reg 1 ] + [ cmp eq reg 1 0x00000001 ] +# tunnel path missing +netdev test-netdev tunnelchain + [ tunnel load path => reg 1 ] + [ cmp eq reg 1 0x00000000 ] +# tunnel id 10 +netdev test-netdev tunnelchain + [ tunnel load id => reg 1 ] + [ cmp eq reg 1 0x0000000a ]
tests/py/netdev/tunnel.t.payload new file +12 -0
@@ -0,0 +1,12 @@ +# tunnel path exists +netdev test-netdev tunnelchain + [ tunnel load path => reg 1 ] + [ cmp eq reg 1 0x00000001 ] +# tunnel path missing +netdev test-netdev tunnelchain + [ tunnel load path => reg 1 ] + [ cmp eq reg 1 0x00000000 ] +# tunnel id 10 +netdev test-netdev tunnelchain + [ tunnel load id => reg 1 ] + [ cmp eq reg 1 0x0000000a ]
tests/shell/features/tunnel.nft new file +17 -0
@@ -0,0 +1,17 @@ +# v5.7-rc1~146^2~137^2~26 +# 925d844696d9 ("netfilter: nft_tunnel: add support for geneve opts") +table netdev x { + tunnel y { + id 10 + ip saddr 192.168.2.10 + ip daddr 192.168.2.11 + sport 10 + dport 20 + ttl 10 + geneve { + class 0x1010 opt-type 0x1 data "0x12345678" + class 0x2010 opt-type 0x2 data "0x87654321" + class 0x2020 opt-type 0x3 data "0x87654321abcdeffe" + } + } +}
tests/shell/testcases/sets/0075tunnel_0 new file +75 -0
75 lines not on this page · raw message
tests/shell/testcases/sets/dumps/0075tunnel_0.json-nft new file +171 -0
171 lines not on this page · raw message
tests/shell/testcases/sets/dumps/0075tunnel_0.nft new file +63 -0
63 lines not on this page · raw message
Signature · 1 line
2.49.0
Florian Westphal
maintainerRe: [PATCH 1/7 nft] src: add tunnel template support
In reply to Fernando Fernandez ManceraQuoted 16 lines · Fernando Fernandez Mancera
From: Pablo Neira Ayuso <[email protected]>
This patch adds tunnel template support, this allows to attach a metadata template that provides the configuration for the tunnel driver.
Example of generic tunnel configuration:
table netdev x { tunnel y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 }
Quoted 1 line
}
Dumb question, how would such a 'generic' tunnel be used? Or is this just an intermediate step that adds the common code?
Florian Westphal
maintainerRe: [PATCH 2/7 nft] tunnel: add erspan support
In reply to Fernando Fernandez ManceraQuoted 18 lines · Fernando Fernandez Mancera
From: Pablo Neira Ayuso <[email protected]>
This patch extends the tunnel metadata object to define erspan tunnel specific configurations:
table netdev x { tunnel y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 erspan { version 1 index 2 } }
Quoted 1 line
}
Would it make sense to make this
tunnel erspan y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
version 1
index 2
}Or was the sub-section intentional to cleanly separate the common parts from the tunnel specific knobs?
In that case, maybe 'tunnel y {
...
type erspan { ... '?Or do you think its unecessarily verbose?
I think it might be good to make it clear that this is an either-or thing and multiple 'type' declarations aren't permitted.
Or are there plans to support
table netdev x {
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
erspan {
version 1
index 2
}
geneve {
...?
Re: [PATCH 2/7 nft] tunnel: add erspan support
Quoted 34 lines · Florian Westphal
Quoted 5 lines · Fernando Fernandez Mancera
From: Pablo Neira Ayuso <[email protected]>
This patch extends the tunnel metadata object to define erspan tunnel specific configurations:
Quoted 14 lines
table netdev x { tunnel y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 erspan { version 1 index 2 } } }Would it make sense to make this
tunnel erspan y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 version 1 index 2 }
Quoted 3 lines
Or was the sub-section intentional to cleanly separate the common parts from the tunnel specific knobs?
The sub-section was to cleanly separate it and easily understand what are the tunnel specific options configured.
Quoted 9 lines
In that case, maybe 'tunnel y {
... type erspan { ... '?Or do you think its unecessarily verbose?
I think it might be good to make it clear that this is an either-or thing and multiple 'type' declarations aren't permitted.
IMHO, adding "type erspan {" won't hurt but I thought it was clear enough. If you think adding the "type" keyword makes it clearer, I can do it for sure.
Please, notice that if more than one specific sub-section is set, the bison parser will complain.
Quoted 16 lines
Or are there plans to support
table netdev x { tunnel y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 erspan { version 1 index 2 } geneve { ...
Quoted 1 line
?
I do not think there are plans to support this at all.
Florian Westphal
maintainerRe: [PATCH 2/7 nft] tunnel: add erspan support
Quoted 11 lines · Fernando Fernandez Mancera
Quoted 11 lines
tunnel erspan y { id 10 ip saddr 192.168.2.10 ip daddr 192.168.2.11 sport 10 dport 20 ttl 10 version 1 index 2 }
Quoted 6 lines
Quoted 3 lines
Or was the sub-section intentional to cleanly separate the common parts from the tunnel specific knobs?
The sub-section was to cleanly separate it and easily understand what are the tunnel specific options configured.
Makes sense to me, thanks.
Quoted 6 lines
Quoted 6 lines
In that case, maybe 'tunnel y {
... type erspan { ... '?Or do you think its unecessarily verbose?
Quoted 7 lines
Quoted 3 lines
I think it might be good to make it clear that this is an either-or thing and multiple 'type' declarations aren't permitted.
IMHO, adding "type erspan {" won't hurt but I thought it was clear enough. If you think adding the "type" keyword makes it clearer, I can do it for sure.
I think its fine as long as we never add additional, common subsections. Else it will be confusing, e.g. if this is illegal:
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
erspan {
version 1
index 2
}
vxlan { ..
}
thats fine. But if we also allow something like this in the future:
tunnel y {
id 10
ip saddr 192.168.2.10
ip daddr 192.168.2.11
sport 10
dport 20
ttl 10
erspan {
version 1
index 2
}
extraops {
...
}
}
Then I think it would be confusing as to what kind of 'nested { bla }' are allowed to co-exist and whioch ones are mutually exclusive.
Thats why I mentioned the extra keyword. But I admit that as-is its not necessary.
Quoted 2 lines
Please, notice that if more than one specific sub-section is set, the bison parser will complain.
Good, thanks for explaining.