Skip to contentSkip to conversation

mm: Restrict the static definition of the per-CPU variable _shared_alloc_tag to s390 and alpha architectures only

PATCH In review Hao Ge 6 participants 8 messages Jun 16, 2025

Subsystems (7)
lore
Share & tools
lore

Hao Ge

author reviewer
#0 lore raw

v3 cover mm: Restrict the static definition of the per-CPU variable _shared_alloc_tag to s390 and alpha architectures only

From: Hao Ge <[email protected]>

Recently discovered this entry while checking kallsyms on ARM64:
ffff800083e509c0 D _shared_alloc_tag

If ARCH_NEEDS_WEAK_PER_CPU is not defined((it is only defined for s390 and alpha architectures),there's no need to statically define the percpu variable _shared_alloc_tag. As the number of CPUs increases,the wasted memory will grow correspondingly.

Therefore,we need to implement isolation for this purpose.

However,currently ARCH_NEEDS_WEAK_PER_CPU is a #define and is enclosed within the #if defined(MODULE) conditional block.

When building the core kernel code for s390 or alpha architectures, ARCH_NEEDS_WEAK_PER_CPU remains undefined (as it is gated by #if defined(MODULE)). However,when building modules for these architectures,the macro is explicitly defined.

Therefore,we need to make ARCH_NEEDS_WEAK_PER_CPU a Kconfig option. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU,MODULE_NEEDS_WEAK_PER_CPU might be a more accurate description,because it was only needed for modules. Then,when defining the percpu variable _shared_alloc_tag,wrap it with the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition.

The following version can be regarded as the most original version:
https://lore.kernel.org/all/[email protected]/
But unfortunately,it caused build errors on s390.
Based on Suren's guidance and suggestions,
I've refined it into this patch series.
Many thanks to Suren for his patient instruction.

Verify:

     1. On Arm64:
        nm vmlinux | grep "_shared_alloc_tag",no output is returned.
     2. On S390:
        Compile tested.
        nm vmlinux | grep "_shared_alloc_tag"
        00000000015605b4 r __crc__shared_alloc_tag
        0000000001585fef r __kstrtab__shared_alloc_tag
        0000000001586897 r __kstrtabns__shared_alloc_tag
        00000000014f6548 r __ksymtab__shared_alloc_tag
        0000000001a8fa28 D _shared_alloc_tag
        nm net/ceph/libceph.ko | grep "_shared"
        U _shared_alloc_tag
     3. On alpha
        Compile tested.
        nm vmlinux | grep "_shared_alloc_tag"
        fffffc0000b080fa r __kstrtab__shared_alloc_tag
        fffffc0000b07ee7 r __kstrtabns__shared_alloc_tag
        fffffc0000adee98 r __ksymtab__shared_alloc_tag
        fffffc0000b83d38 D _shared_alloc_tag
        nm crypto/cryptomgr.ko | grep "_share"
        U _shared_alloc_tag

v3:
Suren pointed out that patches 1-2 can be merged into a single patch in version 2. And the commit message for patch 3 can be made more concise.Make corresponding modifications based on the pointed-out issues and update the corresponding commit message.

v2:
Heiko pointed out that when defining MODULE_NEEDS_WEAK_PER_CPU, the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition in the v1 version should be removed,as it is always true for s390 and alpha architectures.And He also pointed out that patches 2-4 need to be merged into one patch. Modify the code according to the suggestions and update the corresponding commit message.

Hao Ge (2):
mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha
architectures
mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when
statically defining the percpu variable _shared_alloc_tag

 arch/alpha/Kconfig              | 1 +
 arch/alpha/include/asm/percpu.h | 2 +-
 arch/s390/Kconfig               | 1 +
 arch/s390/include/asm/percpu.h  | 2 +-
 include/linux/alloc_tag.h       | 6 +++---
 include/linux/percpu-defs.h     | 4 ++--
 lib/alloc_tag.c                 | 2 ++
 mm/Kconfig                      | 4 ++++
 8 files changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.1
author reviewer
#1 lore raw

PATCH v3 1/2 mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

From: Hao Ge <[email protected]>

Recently discovered this entry while checking kallsyms on ARM64:
ffff800083e509c0 D _shared_alloc_tag

If ARCH_NEEDS_WEAK_PER_CPU is not defined((it is only defined for s390 and alpha architectures),there's no need to statically define the percpu variable _shared_alloc_tag.

Therefore,we need to implement isolation for this purpose.

However,currently ARCH_NEEDS_WEAK_PER_CPU is a #define and is enclosed within the #if defined(MODULE) conditional block.

When building the core kernel code for s390 or alpha architectures, ARCH_NEEDS_WEAK_PER_CPU remains undefined (as it is gated by #if defined(MODULE)).However,when building modules for these architectures,the macro is explicitly defined.

Therefore,we need to make ARCH_NEEDS_WEAK_PER_CPU a Kconfig option. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU,MODULE_NEEDS_WEAK_PER_CPU might be a more accurate description,because it was only needed for modules. Then,when defining the percpu variable _shared_alloc_tag,wrap it with the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition.

Therefore, this patch does the following things:
Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file and enable it for the s390 and alpha architectures. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.

---
 arch/alpha/Kconfig              | 1 +
 arch/alpha/include/asm/percpu.h | 2 +-
 arch/s390/Kconfig               | 1 +
 arch/s390/include/asm/percpu.h  | 2 +-
 include/linux/alloc_tag.h       | 6 +++---
 include/linux/percpu-defs.h     | 4 ++--
 mm/Kconfig                      | 4 ++++
 7 files changed, 13 insertions(+), 7 deletions(-)
arch/alpha/Kconfig +1 -0
index 109a4cddcd13..ce9bc842e384 100644
@@ -7,6 +7,7 @@ config ALPHA
 	select ARCH_HAS_DMA_OPS if PCI
 	select ARCH_MIGHT_HAVE_PC_PARPORT
 	select ARCH_MIGHT_HAVE_PC_SERIO
+	select ARCH_NEEDS_WEAK_PER_CPU
 	select ARCH_NO_PREEMPT
 	select ARCH_NO_SG_CHAIN
 	select ARCH_USE_CMPXCHG_LOCKREF
arch/alpha/include/asm/percpu.h +1 -1
index 6923249f2d49..b164d3720e9e 100644
@@ -11,7 +11,7 @@
  * Always use weak definitions for percpu variables in modules.
  */
 #if defined(MODULE) && defined(CONFIG_SMP)
-#define ARCH_NEEDS_WEAK_PER_CPU
+#define MODULE_NEEDS_WEAK_PER_CPU
 #endif
 
 #include <asm-generic/percpu.h>
arch/s390/Kconfig +1 -0
index 0c16dc443e2f..716031d22346 100644
@@ -132,6 +132,7 @@ config S390
 	select ARCH_INLINE_WRITE_UNLOCK_IRQ
 	select ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE
 	select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
+	select ARCH_NEEDS_WEAK_PER_CPU
 	select ARCH_STACKWALK
 	select ARCH_SUPPORTS_ATOMIC_RMW
 	select ARCH_SUPPORTS_DEBUG_PAGEALLOC
arch/s390/include/asm/percpu.h +1 -1
index 84f6b8357b45..0afc7ce9c26f 100644
@@ -18,7 +18,7 @@
  * generate external references.
  */
 #if defined(MODULE)
-#define ARCH_NEEDS_WEAK_PER_CPU
+#define MODULE_NEEDS_WEAK_PER_CPU
 #endif
 
 /*
include/linux/alloc_tag.h +3 -3
index 8f7931eb7d16..f349cca0ebed 100644
@@ -88,7 +88,7 @@ static inline struct alloc_tag *ct_to_alloc_tag(struct codetag *ct)
 	return container_of(ct, struct alloc_tag, ct);
 }
 
-#ifdef ARCH_NEEDS_WEAK_PER_CPU
+#ifdef MODULE_NEEDS_WEAK_PER_CPU
 /*
  * When percpu variables are required to be defined as weak, static percpu
  * variables can't be used inside a function (see comments for DECLARE_PER_CPU_SECTION).
@@ -102,7 +102,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 		.ct = CODE_TAG_INIT,						\
 		.counters = &_shared_alloc_tag };
 
-#else /* ARCH_NEEDS_WEAK_PER_CPU */
+#else /* MODULE_NEEDS_WEAK_PER_CPU */
 
 #ifdef MODULE
 
@@ -123,7 +123,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 
 #endif /* MODULE */
 
-#endif /* ARCH_NEEDS_WEAK_PER_CPU */
+#endif /* MODULE_NEEDS_WEAK_PER_CPU */
 
 DECLARE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT,
 			mem_alloc_profiling_key);
include/linux/percpu-defs.h +2 -2
index 0aeb0e276a3e..b4ecfc3a7b2b 100644
@@ -64,13 +64,13 @@
  * 2. Static percpu variables cannot be defined inside a function.
  *
  * Archs which need weak percpu definitions should define
- * ARCH_NEEDS_WEAK_PER_CPU in asm/percpu.h when necessary.
+ * MODULE_NEEDS_WEAK_PER_CPU in asm/percpu.h when necessary.
  *
  * To ensure that the generic code observes the above two
  * restrictions, if CONFIG_DEBUG_FORCE_WEAK_PER_CPU is set weak
  * definition is used for all cases.
  */
-#if defined(ARCH_NEEDS_WEAK_PER_CPU) || defined(CONFIG_DEBUG_FORCE_WEAK_PER_CPU)
+#if defined(MODULE_NEEDS_WEAK_PER_CPU) || defined(CONFIG_DEBUG_FORCE_WEAK_PER_CPU)
 /*
  * __pcpu_scope_* dummy variable is used to enforce scope.  It
  * receives the static modifier when it's used in front of
mm/Kconfig +4 -0
index e113f713b493..2f55cc95cfcb 100644
@@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
 	def_bool y
 	depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
 
+# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION
+config ARCH_NEEDS_WEAK_PER_CPU
+       bool
+
 #
 # UP and nommu archs use km based percpu allocator
 #
Signature · 1 line
2.25.1
author reviewer
#7 lore raw

PATCH v3 2/2 mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag

In reply to Hao Ge

From: Hao Ge <[email protected]>

Given the introduction of the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro, we can now conditionally define the perpcu variable _shared_alloc_tag based on its value. This allows architectures(such as s390/alpha) that require weak definitions for percpu variables in modules to include the definition,while others can omit it via compile-time exclusion.

---
 lib/alloc_tag.c | 2 ++
 1 file changed, 2 insertions(+)
lib/alloc_tag.c +2 -0
index c7f602fa7b23..14fd66f26e42 100644
@@ -24,8 +24,10 @@ static bool mem_profiling_support;
 
 static struct codetag_type *alloc_tag_cttype;
 
+#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU
 DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 EXPORT_SYMBOL(_shared_alloc_tag);
+#endif
 
 DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT,
 			mem_alloc_profiling_key);
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

In reply to Hao Ge

mm/Kconfig config ARCH_SUPPORTS_PUD_PFNMAP · line 932

Quoted 6 lines · Hao Ge

+++ b/mm/Kconfig

mm/Kconfig +1 -0
@@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
 	def_bool y
 	depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
 
+# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION

This comment is inappropriate and should be removed.

Quoted 10 lines
mm/Kconfig +3 -0
+config ARCH_NEEDS_WEAK_PER_CPU
+       bool
+
 #
 # UP and nommu archs use km based percpu allocator
 #
Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

Quoted 9 lines · Matthew Wilcox

mm/Kconfig config ARCH_SUPPORTS_PUD_PFNMAP · line 932

Quoted 6 lines · Hao Ge

+++ b/mm/Kconfig

mm/Kconfig +1 -0
@@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
 	def_bool y
 	depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
 
+# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION

This comment is inappropriate and should be removed.

Inappropriate? That's not a word I'm accustomed to hearing as an engineering justification.

It's referring the reader to context they might want to know about, and other comments they might want to read. Looks like a good comment to me, if perhaps a bit terse.

#4 lore raw

Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

In reply to Hao Ge
Quoted 1 line · Hao Ge

From: Hao Ge <[email protected]>

subject is misleading: we are not optimizing anything in this patch, do we?

It should probably be called

"mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or sth. like that.

Quoted 5 lines

Recently discovered this entry while checking kallsyms on ARM64:
ffff800083e509c0 D _shared_alloc_tag

If ARCH_NEEDS_WEAK_PER_CPU is not defined((it is only defined for

"... is not defined (it is only defined for

Quoted 3 lines

s390 and alpha architectures),there's no need to statically define the percpu variable _shared_alloc_tag.

Quoted 1 line

Therefore,we need to implement isolation for this purpose.

In general, throw in a space after "." and "," to make this easier to parse.

Quoted 9 lines

However,currently ARCH_NEEDS_WEAK_PER_CPU is a #define and is enclosed within the #if defined(MODULE) conditional block.

When building the core kernel code for s390 or alpha architectures, ARCH_NEEDS_WEAK_PER_CPU remains undefined (as it is gated by #if defined(MODULE)).However,when building modules for these architectures,the macro is explicitly defined.

Quoted 8 lines

Therefore,we need to make ARCH_NEEDS_WEAK_PER_CPU a Kconfig option. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU,MODULE_NEEDS_WEAK_PER_CPU might be a more accurate description,because it was only needed for modules. Then,when defining the percpu variable _shared_alloc_tag,wrap it with the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition.

Therefore, this patch does the following things:

"this patch" should be avoided.

"Therefore, let's ..."

Quoted 4 lines

Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file and enable it for the s390 and alpha architectures. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.

Most of the description here should likely go to patch #2. See below.

Quoted 119 lines
---
  arch/alpha/Kconfig              | 1 +
  arch/alpha/include/asm/percpu.h | 2 +-
  arch/s390/Kconfig               | 1 +
  arch/s390/include/asm/percpu.h  | 2 +-
  include/linux/alloc_tag.h       | 6 +++---
  include/linux/percpu-defs.h     | 4 ++--
  mm/Kconfig                      | 4 ++++
  7 files changed, 13 insertions(+), 7 deletions(-)
arch/alpha/Kconfig +1 -0
index 109a4cddcd13..ce9bc842e384 100644
@@ -7,6 +7,7 @@ config ALPHA
  	select ARCH_HAS_DMA_OPS if PCI
  	select ARCH_MIGHT_HAVE_PC_PARPORT
  	select ARCH_MIGHT_HAVE_PC_SERIO
+	select ARCH_NEEDS_WEAK_PER_CPU
  	select ARCH_NO_PREEMPT
  	select ARCH_NO_SG_CHAIN
  	select ARCH_USE_CMPXCHG_LOCKREF
arch/alpha/include/asm/percpu.h +1 -1
index 6923249f2d49..b164d3720e9e 100644
@@ -11,7 +11,7 @@
   * Always use weak definitions for percpu variables in modules.
   */
  #if defined(MODULE) && defined(CONFIG_SMP)
-#define ARCH_NEEDS_WEAK_PER_CPU
+#define MODULE_NEEDS_WEAK_PER_CPU
  #endif
 
  #include <asm-generic/percpu.h>
arch/s390/Kconfig +1 -0
index 0c16dc443e2f..716031d22346 100644
@@ -132,6 +132,7 @@ config S390
  	select ARCH_INLINE_WRITE_UNLOCK_IRQ
  	select ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE
  	select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
+	select ARCH_NEEDS_WEAK_PER_CPU
  	select ARCH_STACKWALK
  	select ARCH_SUPPORTS_ATOMIC_RMW
  	select ARCH_SUPPORTS_DEBUG_PAGEALLOC
arch/s390/include/asm/percpu.h +1 -1
index 84f6b8357b45..0afc7ce9c26f 100644
@@ -18,7 +18,7 @@
   * generate external references.
   */
  #if defined(MODULE)
-#define ARCH_NEEDS_WEAK_PER_CPU
+#define MODULE_NEEDS_WEAK_PER_CPU
  #endif
 
  /*
include/linux/alloc_tag.h +3 -3
index 8f7931eb7d16..f349cca0ebed 100644
@@ -88,7 +88,7 @@ static inline struct alloc_tag *ct_to_alloc_tag(struct codetag *ct)
  	return container_of(ct, struct alloc_tag, ct);
  }
 
-#ifdef ARCH_NEEDS_WEAK_PER_CPU
+#ifdef MODULE_NEEDS_WEAK_PER_CPU
  /*
   * When percpu variables are required to be defined as weak, static percpu
   * variables can't be used inside a function (see comments for DECLARE_PER_CPU_SECTION).
@@ -102,7 +102,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
  		.ct = CODE_TAG_INIT,						\
  		.counters = &_shared_alloc_tag };
 
-#else /* ARCH_NEEDS_WEAK_PER_CPU */
+#else /* MODULE_NEEDS_WEAK_PER_CPU */
 
  #ifdef MODULE
 
@@ -123,7 +123,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 
  #endif /* MODULE */
 
-#endif /* ARCH_NEEDS_WEAK_PER_CPU */
+#endif /* MODULE_NEEDS_WEAK_PER_CPU */
 
  DECLARE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT,
  			mem_alloc_profiling_key);
include/linux/percpu-defs.h +2 -2
index 0aeb0e276a3e..b4ecfc3a7b2b 100644
@@ -64,13 +64,13 @@
   * 2. Static percpu variables cannot be defined inside a function.
   *
   * Archs which need weak percpu definitions should define
- * ARCH_NEEDS_WEAK_PER_CPU in asm/percpu.h when necessary.
+ * MODULE_NEEDS_WEAK_PER_CPU in asm/percpu.h when necessary.
   *
   * To ensure that the generic code observes the above two
   * restrictions, if CONFIG_DEBUG_FORCE_WEAK_PER_CPU is set weak
   * definition is used for all cases.
   */
-#if defined(ARCH_NEEDS_WEAK_PER_CPU) || defined(CONFIG_DEBUG_FORCE_WEAK_PER_CPU)
+#if defined(MODULE_NEEDS_WEAK_PER_CPU) || defined(CONFIG_DEBUG_FORCE_WEAK_PER_CPU)
  /*
   * __pcpu_scope_* dummy variable is used to enforce scope.  It
   * receives the static modifier when it's used in front of
mm/Kconfig +0 -0
index e113f713b493..2f55cc95cfcb 100644

mm/Kconfig config ARCH_SUPPORTS_PUD_PFNMAP · line 934

Quoted 6 lines
mm/Kconfig +3 -0
@@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
  	def_bool y
  	depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
 
+# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION
+config ARCH_NEEDS_WEAK_PER_CPU
+       bool

I agree with Willy that this commit is not ideal -- in particular the "s390 and alpha should be enabled" can get stale easily.

If you want to add a comment, rather give guidance why any architecture would want to set this, like:

/* Architectures that XXX should set this. */

XXX to be defined.

But the bigger problem with this patch is that XXX cannot even be properly defined, because this patch does not make use of CONFIG_ARCH_NEEDS_WEAK_PER_CPU at all.

... that is done in the second patch.

So what you could do is move the actual introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and limit this patch to the rename.

Similarly, teak the patch description to reflect only that.

Signature · 3 lines
Cheers,

David / dhildenb
reviewer
#5 lore raw

Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

Quoted 17 lines · David Hildenbrand
Quoted 1 line · Hao Ge

From: Hao Ge <[email protected]>

subject is misleading: we are not optimizing anything in this patch, do we?

It should probably be called

"mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or sth. like that.

Quoted 4 lines

Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file and enable it for the s390 and alpha architectures. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.

Most of the description here should likely go to patch #2. See below.

...

Quoted 5 lines

So what you could do is move the actual introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and limit this patch to the rename.

Similarly, teak the patch description to reflect only that.

Right, if the patch only renames ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU the description can be as simple as

mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU

as a preparation for introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU. No functional changes.

Quoted 5 lines
Signature · 3 lines
Cheers,

David / dhildenb
Signature · 2 lines
Sincerely yours,
Mike.
#6 lore raw

Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

Quoted 28 lines · Mike Rapoport
Quoted 17 lines · David Hildenbrand
Quoted 1 line · Hao Ge

From: Hao Ge <[email protected]>

subject is misleading: we are not optimizing anything in this patch, do we?

It should probably be called

"mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or sth. like that.

Quoted 4 lines

Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file and enable it for the s390 and alpha architectures. And replace all instances of ARCH_NEEDS_WEAK_PER_CPU in the kernel code with MODULE_NEEDS_WEAK_PER_CPU.

Most of the description here should likely go to patch #2. See below.

...

Quoted 5 lines

So what you could do is move the actual introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and limit this patch to the rename.

Similarly, teak the patch description to reflect only that.

Quoted 7 lines

Right, if the patch only renames ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU the description can be as simple as

mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU

as a preparation for introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU. No functional changes.

Yeah, the title is misleading and the description is too complicated.

Mike's suggested title sounds better to me and for description I would say something like:

ARCH_NEEDS_WEAK_PER_CPU is currently defined only for modules and therefore fails to represent requirements of the architecture. This prevents us using it for conditions which are applicable when building both modules and the kernel. To handle such conditions, make it a Kconfig option and add MODULE_NEEDS_WEAK_PER_CPU for the cases when the condition applies only to modules.

And now that I'm looking at the change I realize that we probably don't even need a separate MODULE_NEEDS_WEAK_PER_CPU. It will be used only in one place and can be replaced with:

#if defined(CONFIG_ARCH_NEEDS_WEAK_PER_CPU) && defined(MODULE)

The code inside arch/{alpha|s390}/include/asm/percpu.h that defines MODULE_NEEDS_WEAK_PER_CPU can be completely removed and in arch/alpha/Kconfig you can have:

select ARCH_NEEDS_WEAK_PER_CPU if CONFIG_SMP

to preserve CONFIG_SMP dependency.
That seems to me like a nicer cleanup.

Quoted 10 lines
Quoted 6 lines

--
Cheers,

David / dhildenb

--
Sincerely yours,
Mike.