Patch review
cover Patch review
Please review this set of changes for scarthgap and have comments back by end of day Thursday, June 19
Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/29/builds/1820
The following changes since commit f7ee6db8ca5dc72b7a468531e31403b60e6a0020:
testimage: get real os-release file (2025-06-09 08:06:42 -0700)
are available in the Git repository at:
https://git.openembedded.org/openembedded-core-contrib stable/scarthgap-nut
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/scarthgap-nut
Aleksandar Nikolic (1):
scripts/install-buildtools: Update to 5.0.10
Colin Pinnell McAllister (1):
ffmpeg: fix CVE-2025-1373
Deepesh Varatharajan (1):
gcc: Upgrade to GCC 13.4
Jiaying Song (1):
python3-requests: upgrade 2.32.3 -> 2.32.4
Peter Marko (1):
net-tools: patch CVE-2025-46836
Poonam Jadhav (1):
libpng: Add ptest
Sandeep Gundlupet Raju (1):
tune-cortexr52: Remove aarch64 for ARM Cortex-R52
Savvas Etairidis (1):
systemd: Rename systemd_v255.21 to systemd_255.21
meta/conf/distro/include/maintainers.inc | 2 +-
.../distro/include/ptest-packagelists.inc | 1 +
.../include/arm/armv8r/tune-cortexr52.inc | 5 +-
.../{systemd_v255.21.bb => systemd_255.21.bb} | 0
.../gcc/{gcc-13.3.inc => gcc-13.4.inc} | 8 +-
...ian_13.3.bb => gcc-cross-canadian_13.4.bb} | 0
.../{gcc-cross_13.3.bb => gcc-cross_13.4.bb} | 0
...-crosssdk_13.3.bb => gcc-crosssdk_13.4.bb} | 0
...cc-runtime_13.3.bb => gcc-runtime_13.4.bb} | 0
...itizers_13.3.bb => gcc-sanitizers_13.4.bb} | 0
...{gcc-source_13.3.bb => gcc-source_13.4.bb} | 0
...ix-c-tweak-for-Wrange-loop-construct.patch | 113 ----
...4fffe3fc82a710bea66ad651720d71c938b8.patch | 549 ------------------
.../gcc/{gcc_13.3.bb => gcc_13.4.bb} | 0
...initial_13.3.bb => libgcc-initial_13.4.bb} | 0
.../gcc/{libgcc_13.3.bb => libgcc_13.4.bb} | 0
...ibgfortran_13.3.bb => libgfortran_13.4.bb} | 0
...s_2.32.3.bb => python3-requests_2.32.4.bb} | 2 +-
.../net-tools/CVE-2025-46836-01.patch | 91 +++
.../net-tools/CVE-2025-46836-02.patch | 31 +
.../net-tools/net-tools_2.10.bb | 2 +
.../recipes-multimedia/ffmpeg/ffmpeg_6.1.2.bb | 4 +
.../recipes-multimedia/libpng/files/run-ptest | 7 +
.../libpng/libpng_1.6.42.bb | 42 +-
scripts/install-buildtools | 4 +-
25 files changed, 185 insertions(+), 676 deletions(-)
rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-13.3.inc => gcc-13.4.inc} (94%)
rename meta/recipes-devtools/gcc/{gcc-cross-canadian_13.3.bb => gcc-cross-canadian_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-cross_13.3.bb => gcc-cross_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-crosssdk_13.3.bb => gcc-crosssdk_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-runtime_13.3.bb => gcc-runtime_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-sanitizers_13.3.bb => gcc-sanitizers_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-source_13.3.bb => gcc-source_13.4.bb} (100%)
delete mode 100644 meta/recipes-devtools/gcc/gcc/0028-gcc-Fix-c-tweak-for-Wrange-loop-construct.patch
delete mode 100644 meta/recipes-devtools/gcc/gcc/gcc.git-ab884fffe3fc82a710bea66ad651720d71c938b8.patch
rename meta/recipes-devtools/gcc/{gcc_13.3.bb => gcc_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgcc-initial_13.3.bb => libgcc-initial_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgcc_13.3.bb => libgcc_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgfortran_13.3.bb => libgfortran_13.4.bb} (100%)
rename meta/recipes-devtools/python/{python3-requests_2.32.3.bb => python3-requests_2.32.4.bb} (91%)
create mode 100644 meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-01.patch
create mode 100644 meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-02.patch
create mode 100644 meta/recipes-multimedia/libpng/files/run-ptestSignature · 1 line
2.43.0
PATCH 1/8 net-tools: patch CVE-2025-46836
From: Peter Marko <[email protected]>
Backport patch for this CVE and also patch for its regression.
--- .../net-tools/CVE-2025-46836-01.patch | 91 +++++++++++++++++++ .../net-tools/CVE-2025-46836-02.patch | 31 +++++++ .../net-tools/net-tools_2.10.bb | 2 + 3 files changed, 124 insertions(+) create mode 100644 meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-01.patch create mode 100644 meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-02.patch
meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-01.patch new file +91 -0
@@ -0,0 +1,91 @@ +From 7a8f42fb20013a1493d8cae1c43436f85e656f2d Mon Sep 17 00:00:00 2001 +From: Zephkeks <[email protected]> +Date: Tue, 13 May 2025 11:04:17 +0200 +Subject: [PATCH] CVE-2025-46836: interface.c: Stack-based Buffer Overflow in + get_name() + +Coordinated as GHSA-pfwf-h6m3-63wf + +CVE: CVE-2025-46836 +Upstream-Status: Backport [https://sourceforge.net/p/net-tools/code/ci/7a8f42fb20013a1493d8cae1c43436f85e656f2d/] +Signed-off-by: Peter Marko <[email protected]> +--- + lib/interface.c | 63 ++++++++++++++++++++++++++++++------------------- + 1 file changed, 39 insertions(+), 24 deletions(-) + +diff --git a/lib/interface.c b/lib/interface.c +index 71d4163..a054f12 100644 +--- a/lib/interface.c ++++ b/lib/interface.c +@@ -211,32 +211,47 @@ out: + } + + static const char *get_name(char *name, const char *p) ++/* Safe version — guarantees at most IFNAMSIZ‑1 bytes are copied ++ and the destination buffer is always NUL‑terminated. */ + { +- while (isspace(*p)) +- p++; +- while (*p) { +- if (isspace(*p)) +- break; +- if (*p == ':') { /* could be an alias */ +- const char *dot = p++; +- while (*p && isdigit(*p)) p++; +- if (*p == ':') { +- /* Yes it is, backup and copy it. */ +- p = dot; +- *name++ = *p++; +- while (*p && isdigit(*p)) { +- *name++ = *p++; +- } +- } else { +- /* No, it isn't */ +- p = dot; +- } +- p++; +- break; +- } +- *name++ = *p++; ++ char *dst = name; /* current write ptr */ ++ const char *end = name + IFNAMSIZ - 1; /* last byte we may write */ ++ ++ /* Skip leading white‑space. */ ++ while (isspace((unsigned char)*p)) ++ ++p; ++ ++ /* Copy until white‑space, end of string, or buffer full. */ ++ while (*p && !isspace((unsigned char)*p) && dst < end) { ++ if (*p == ':') { /* possible alias veth0:123: */ ++ const char *dot = p; /* remember the colon */ ++ ++p; ++ while (*p && isdigit((unsigned char)*p)) ++ ++p; ++ ++ if (*p == ':') { /* confirmed alias */ ++ p = dot; /* rewind and copy it all */ ++ ++ /* copy the colon */ ++ if (dst < end) ++ *dst++ = *p++; ++ ++ /* copy the digits */ ++ while (*p && isdigit((unsigned char)*p) && dst < end) ++ *dst++ = *p++; ++ ++ if (*p == ':') /* consume trailing colon */ ++ ++p; ++ } else { /* if so treat as normal */ ++ p = dot; ++ } ++ break; /* interface name ends here */ ++ } ++ ++ *dst++ = *p++; /* ordinary character copy */ + } +- *name++ = '\0'; ++ ++ *dst = '\0'; /* always NUL‑terminate */ + return p; + } +
meta/recipes-extended/net-tools/net-tools/CVE-2025-46836-02.patch new file +31 -0
@@ -0,0 +1,31 @@ +From ddb0e375fb9ca95bb69335540b85bbdaa2714348 Mon Sep 17 00:00:00 2001 +From: Bernd Eckenfels <[email protected]> +Date: Sat, 17 May 2025 21:53:23 +0200 +Subject: [PATCH] Interface statistic regression after 7a8f42fb2 + +CVE: CVE-2025-46836 +Upstream-Status: Backport [https://sourceforge.net/p/net-tools/code/ci/ddb0e375fb9ca95bb69335540b85bbdaa2714348/] +Signed-off-by: Peter Marko <[email protected]> +--- + lib/interface.c | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/lib/interface.c b/lib/interface.c +index a054f12..ca4adf1 100644 +--- a/lib/interface.c ++++ b/lib/interface.c +@@ -239,12 +239,11 @@ static const char *get_name(char *name, const char *p) + /* copy the digits */ + while (*p && isdigit((unsigned char)*p) && dst < end) + *dst++ = *p++; +- +- if (*p == ':') /* consume trailing colon */ +- ++p; + } else { /* if so treat as normal */ + p = dot; + } ++ if (*p == ':') /* consume trailing colon */ ++ ++p; + break; /* interface name ends here */ + } +
meta/recipes-extended/net-tools/net-tools_2.10.bb +2 -0
@@ -11,6 +11,8 @@ SRC_URI = "git://git.code.sf.net/p/net-tools/code;protocol=https;branch=master \ file://net-tools-config.h \ file://net-tools-config.make \ file://Add_missing_headers.patch \ + file://CVE-2025-46836-01.patch \ + file://CVE-2025-46836-02.patch \ " S = "${WORKDIR}/git"
Signature · 1 line
2.43.0
PATCH 2/8 ffmpeg: fix CVE-2025-1373
In reply to Steve SakomanFrom: Colin Pinnell McAllister <[email protected]>
CVE-2025-1373 does not appear to affect ffmpeg 5.0.3. The CVE has been marked as "fixed-version".
--- meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.2.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.2.bb +4 -0
@@ -55,6 +55,10 @@ SRC_URI[sha256sum] = "3b624649725ecdc565c903ca6643d41f33bd49239922e45c9b1442c63d CVE_STATUS[CVE-2023-39018] = "cpe-incorrect: This issue belongs to ffmpeg-cli-wrapper \ (Java wrapper around the FFmpeg CLI) and not ffmepg itself." +# Introduced: https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/19f7dae81ab2c19643b97da7556383ee3f721e78 +# Fixed: https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/43be8d07281caca2e88bfd8ee2333633e1fb1a13 +CVE_STATUS[CVE-2025-1373] = "fixed-version: Vulnerable code not present in any release" + # Build fails when thumb is enabled: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7717 ARM_INSTRUCTION_SET:armv4 = "arm" ARM_INSTRUCTION_SET:armv5 = "arm"
Signature · 1 line
2.43.0
PATCH 3/8 python3-requests: upgrade 2.32.3 -> 2.32.4
In reply to Steve SakomanFrom: Jiaying Song <[email protected]>
Changelog:
https://requests.readthedocs.io/en/latest/community/updates/#release-history
---
.../{python3-requests_2.32.3.bb => python3-requests_2.32.4.bb} | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename meta/recipes-devtools/python/{python3-requests_2.32.3.bb => python3-requests_2.32.4.bb} (91%)meta/recipes-devtools/python/python3-requests_2.32.4.bb renamed from meta/recipes-devtools/python/python3-requests_2.32.3.bb +1 -1
@@ -7,7 +7,7 @@ SRC_URI:append:class-nativesdk = " \ file://environment.d-python3-requests.sh \ " -SRC_URI[sha256sum] = "55365417734eb18255590a9ff9eb97e9e1da868d4ccd6402399eaf68af20a760" +SRC_URI[sha256sum] = "27d0316682c8a29834d3264820024b62a36942083d52caf2f14c0591336d3422" inherit pypi python_setuptools_build_meta
Signature · 1 line
2.43.0
PATCH 4/8 scripts/install-buildtools: Update to 5.0.10
In reply to Steve SakomanFrom: Aleksandar Nikolic <[email protected]>
Update to the 5.0.10 release of the 5.0.10 series for buildtools
--- scripts/install-buildtools | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/install-buildtools +2 -2
@@ -57,8 +57,8 @@ logger = scriptutils.logger_create(PROGNAME, stream=sys.stdout) DEFAULT_INSTALL_DIR = os.path.join(os.path.split(scripts_path)[0],'buildtools') DEFAULT_BASE_URL = 'https://downloads.yoctoproject.org/releases/yocto' -DEFAULT_RELEASE = 'yocto-5.0.9' -DEFAULT_INSTALLER_VERSION = '5.0.9' +DEFAULT_RELEASE = 'yocto-5.0.10' +DEFAULT_INSTALLER_VERSION = '5.0.10' DEFAULT_BUILDDATE = '202110XX' # Python version sanity check
Signature · 1 line
2.43.0
PATCH 5/8 gcc: Upgrade to GCC 13.4
In reply to Steve SakomanFrom: Deepesh Varatharajan <[email protected]>
This is a bugfix release in GCC13 release series
100+ bugfixes
https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=13.4
Dropped the following patches:
0028-gcc-Fix-c-tweak-for-Wrange-loop-construct.patch
https://github.com/gcc-mirror/gcc/commit/179dc0f0fe01012675c1b430591b9891ce96c26e
gcc.git-ab884fffe3fc82a710bea66ad651720d71c938b8.patch
https://github.com/gcc-mirror/gcc/commit/5ceea2ac106d6dd1aa8175670b15a801316cf1c9
#GCC 13.3 #GCC 13.4 #Diff
No. of expected passes 148863 149440 +577
No. of unexpected failures 14 14 0
No. of expected failures 1415 1414 -1
No. of unresolved testcases 25384 25660 +276
No. of unsupported tests 2692 2689 -3
---
meta/conf/distro/include/maintainers.inc | 2 +-
.../gcc/{gcc-13.3.inc => gcc-13.4.inc} | 8 +-
...ian_13.3.bb => gcc-cross-canadian_13.4.bb} | 0
.../{gcc-cross_13.3.bb => gcc-cross_13.4.bb} | 0
...-crosssdk_13.3.bb => gcc-crosssdk_13.4.bb} | 0
...cc-runtime_13.3.bb => gcc-runtime_13.4.bb} | 0
...itizers_13.3.bb => gcc-sanitizers_13.4.bb} | 0
...{gcc-source_13.3.bb => gcc-source_13.4.bb} | 0
...ix-c-tweak-for-Wrange-loop-construct.patch | 113 ----
...4fffe3fc82a710bea66ad651720d71c938b8.patch | 549 ------------------
.../gcc/{gcc_13.3.bb => gcc_13.4.bb} | 0
...initial_13.3.bb => libgcc-initial_13.4.bb} | 0
.../gcc/{libgcc_13.3.bb => libgcc_13.4.bb} | 0
...ibgfortran_13.3.bb => libgfortran_13.4.bb} | 0
14 files changed, 4 insertions(+), 668 deletions(-)
rename meta/recipes-devtools/gcc/{gcc-13.3.inc => gcc-13.4.inc} (94%)
rename meta/recipes-devtools/gcc/{gcc-cross-canadian_13.3.bb => gcc-cross-canadian_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-cross_13.3.bb => gcc-cross_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-crosssdk_13.3.bb => gcc-crosssdk_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-runtime_13.3.bb => gcc-runtime_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-sanitizers_13.3.bb => gcc-sanitizers_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{gcc-source_13.3.bb => gcc-source_13.4.bb} (100%)
delete mode 100644 meta/recipes-devtools/gcc/gcc/0028-gcc-Fix-c-tweak-for-Wrange-loop-construct.patch
delete mode 100644 meta/recipes-devtools/gcc/gcc/gcc.git-ab884fffe3fc82a710bea66ad651720d71c938b8.patch
rename meta/recipes-devtools/gcc/{gcc_13.3.bb => gcc_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgcc-initial_13.3.bb => libgcc-initial_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgcc_13.3.bb => libgcc_13.4.bb} (100%)
rename meta/recipes-devtools/gcc/{libgfortran_13.3.bb => libgfortran_13.4.bb} (100%)meta/conf/distro/include/maintainers.inc +1 -1
@@ -190,7 +190,7 @@ RECIPE_MAINTAINER:pn-gcc-cross-canadian-${TRANSLATED_TARGET_ARCH} = "Khem Raj <r RECIPE_MAINTAINER:pn-gcc-crosssdk-${SDK_SYS} = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-gcc-runtime = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-gcc-sanitizers = "Khem Raj <[email protected]>" -RECIPE_MAINTAINER:pn-gcc-source-13.3.0 = "Khem Raj <[email protected]>" +RECIPE_MAINTAINER:pn-gcc-source-13.4.0 = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-gconf = "Ross Burton <[email protected]>" RECIPE_MAINTAINER:pn-gcr = "Alexander Kanavin <[email protected]>" RECIPE_MAINTAINER:pn-gdb = "Khem Raj <[email protected]>"
meta/recipes-devtools/gcc/gcc-13.4.inc renamed from meta/recipes-devtools/gcc/gcc-13.3.inc +3 -5
@@ -2,11 +2,11 @@ require gcc-common.inc # Third digit in PV should be incremented after a minor release -PV = "13.3.0" +PV = "13.4.0" # BINV should be incremented to a revision after a minor gcc release -BINV = "13.3.0" +BINV = "13.4.0" FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc:${FILE_DIRNAME}/gcc/backport:"
@@ -66,10 +66,8 @@ SRC_URI = "${BASEURI} \ file://0024-Avoid-hardcoded-build-paths-into-ppc-libgcc.patch \ file://0025-gcc-testsuite-tweaks-for-mips-OE.patch \ file://0027-Fix-gcc-vect-module-testcases.patch \ - file://0028-gcc-Fix-c-tweak-for-Wrange-loop-construct.patch \ - file://gcc.git-ab884fffe3fc82a710bea66ad651720d71c938b8.patch \ " -SRC_URI[sha256sum] = "0845e9621c9543a13f484e94584a49ffc0129970e9914624235fc1d061a0c083" +SRC_URI[sha256sum] = "9c4ce6dbb040568fdc545588ac03c5cbc95a8dbf0c7aa490170843afb59ca8f5" S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/${SOURCEDIR}" B = "${WORKDIR}/gcc-${PV}/build.${HOST_SYS}.${TARGET_SYS}"
meta/recipes-devtools/gcc/gcc-cross-canadian_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-cross-canadian_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc-cross_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-cross_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc-crosssdk_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-crosssdk_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc-runtime_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-runtime_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc-sanitizers_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-sanitizers_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc-source_13.4.bb renamed from meta/recipes-devtools/gcc/gcc-source_13.3.bb +0 -0
meta/recipes-devtools/gcc/gcc/0028-gcc-Fix-c-tweak-for-Wrange-loop-construct.patch deleted +0 -113
113 lines not on this page · raw message
meta/recipes-devtools/gcc/gcc/gcc.git-ab884fffe3fc82a710bea66ad651720d71c938b8.patch deleted +0 -549
549 lines not on this page · raw message
meta/recipes-devtools/gcc/gcc_13.4.bb renamed from meta/recipes-devtools/gcc/gcc_13.3.bb +0 -0
meta/recipes-devtools/gcc/libgcc-initial_13.4.bb renamed from meta/recipes-devtools/gcc/libgcc-initial_13.3.bb +0 -0
meta/recipes-devtools/gcc/libgcc_13.4.bb renamed from meta/recipes-devtools/gcc/libgcc_13.3.bb +0 -0
meta/recipes-devtools/gcc/libgfortran_13.4.bb renamed from meta/recipes-devtools/gcc/libgfortran_13.3.bb +0 -0
Signature · 1 line
2.43.0
PATCH 6/8 tune-cortexr52: Remove aarch64 for ARM Cortex-R52
In reply to Steve SakomanFrom: Sandeep Gundlupet Raju <[email protected]>
Remove aarch64 for ARM Cortex-R52 processor as it supports only 32-bit ISA but not 64-bit ISA. Also update ARMPKGARCH for cortexr52hf.
--- meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
meta/conf/machine/include/arm/armv8r/tune-cortexr52.inc +2 -3
@@ -10,11 +10,10 @@ require conf/machine/include/arm/arch-armv8r.inc AVAILTUNES += "cortexr52" ARMPKGARCH:tune-cortexr52 = "cortexr52" -# We do not want -march since -mcpu is added above to cover for it -TUNE_FEATURES:tune-cortexr52 = "aarch64 crc simd cortexr52" +TUNE_FEATURES:tune-cortexr52 = "${TUNE_FEATURES:tune-armv8r-crc-simd} cortexr52" PACKAGE_EXTRA_ARCHS:tune-cortexr52 = "${PACKAGE_EXTRA_ARCHS:tune-armv8r-crc-simd} cortexr52" AVAILTUNES += "cortexr52hf" -ARMPKGARCH:tune-cortexr52hf = "cortexr52" +ARMPKGARCH:tune-cortexr52hf = "cortexr52hf" TUNE_FEATURES:tune-cortexr52hf = "${TUNE_FEATURES:tune-cortexr52} callconvention-hard" PACKAGE_EXTRA_ARCHS:tune-cortexr52hf = "cortexr52hf"
Signature · 1 line
2.43.0
PATCH 7/8 libpng: Add ptest
In reply to Steve SakomanFrom: Poonam Jadhav <[email protected]>
Install libpng test-suite to run it as a ptest. As the test-suite takes more than 30 seconds to run, add libpng-ptest to PTESTS_SLOW in ptest-packagelists.inc
--- .../distro/include/ptest-packagelists.inc | 1 + .../recipes-multimedia/libpng/files/run-ptest | 7 ++++ .../libpng/libpng_1.6.42.bb | 42 ++++++++++++++++++- 3 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-multimedia/libpng/files/run-ptest
meta/conf/distro/include/ptest-packagelists.inc +1 -0
@@ -102,6 +102,7 @@ PTESTS_SLOW = "\ libevent \ libgcrypt \ libmodule-build-perl \ + libpng \ lttng-tools \ openssh \ openssl \
meta/recipes-multimedia/libpng/files/run-ptest new file +7 -0
@@ -0,0 +1,7 @@ +#!/bin/sh + +set -eux + +cd src + +make check-TESTS
meta/recipes-multimedia/libpng/libpng_1.6.42.bb +40 -2
58 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH 8/8 systemd: Rename systemd_v255.21 to systemd_255.21
In reply to Steve SakomanFrom: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in 29e623b2ad00555788412fa520fbb9ffec794cbb.
---
.../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)meta/recipes-core/systemd/systemd_255.21.bb renamed from meta/recipes-core/systemd/systemd_v255.21.bb +0 -0
Signature · 1 line
2.43.0
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.
Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE.
My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.
Regards,
Qi
Quoted 36 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218970): https://lists.openembedded.org/g/openembedded-core/message/218970
Mute This Topic: https://lists.openembedded.org/mt/113692551/7304865
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
Quoted 4 lines · ChenQi
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE. My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.
My main question would be if bumping PE is worse than breaking this recipe in this release. Maybe it is - I just didn't see much discussions over this.
Quoted 41 lines
Regards,
QiQuoted 36 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218970): https://lists.openembedded.org/g/openembedded-core/message/218970
Mute This Topic: https://lists.openembedded.org/mt/113692551/7304865
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
Quoted 8 lines · Gyorgy Sarvari
Quoted 4 lines · ChenQi
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE. My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.My main question would be if bumping PE is worse than breaking this recipe in this release. Maybe it is - I just didn't see much discussions over this.
Luckily, the commit that introduced this issue was not released yet.
poky [2][0] $ git describe --contains 417cecf76b
fatal: cannot describe '417cecf76b91f58a61e8cc9e4bc57ddda87aac58'
poky [2][0] $ git log --oneline scarthgap-5.0.10..417cecf76b | wc -l 31
Regards,
Qi
Quoted 41 lines
Quoted 41 lines
Regards,
QiQuoted 36 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218970): https://lists.openembedded.org/g/openembedded-core/message/218970
Mute This Topic: https://lists.openembedded.org/mt/113692551/7304865
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
Quoted 9 lines · ChenQi
Quoted 8 lines · Gyorgy Sarvari
Quoted 4 lines · ChenQi
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE. My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.My main question would be if bumping PE is worse than breaking this recipe in this release. Maybe it is - I just didn't see much discussions over this.
Quoted 7 lines
Luckily, the commit that introduced this issue was not released yet.
poky [2][0] $ git describe --contains
417cecf76b
fatal: cannot describe '417cecf76b91f58a61e8cc9e4bc57ddda87aac58'poky [2][0] $ git log --oneline scarthgap-5.0.10..417cecf76b | wc -l 31
Oh... indeed. I thought that this was tagged already long ago. Thanks for this, this does answer my concerns.
Quoted 43 lines
Regards,
QiQuoted 40 lines
Quoted 40 lines
Regards,
QiQuoted 36 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218970): https://lists.openembedded.org/g/openembedded-core/message/218970
Mute This Topic: https://lists.openembedded.org/mt/113692551/7304865
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
It's not tagged, but it was merged to scarthgap branch 13 days ago as:
https://git.openembedded.org/openembedded-core/commit/?h=scarthgap&id=29e623b2ad00555788412fa520fbb9ffec794cbb
We don't depend on package-manager upgrades, so version going backwards is not the real blocker for us, but PE bump in all active branches seems better fix than people not getting the next systemd upgrade (e.g. next systemd minor upgrade with security fixes) in projects which use package-manager on target and happened to build the package feed with this commit included (e.g. we don't wait for tagged "releases" from stable branches).
Regards,
Quoted 69 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 9 lines · ChenQi
Quoted 8 lines · Gyorgy Sarvari
Quoted 4 lines · ChenQi
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE. My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.My main question would be if bumping PE is worse than breaking this recipe in this release. Maybe it is - I just didn't see much discussions over this.
Quoted 7 lines
Luckily, the commit that introduced this issue was not released yet.
poky [2][0] $ git describe --contains
417cecf76b
fatal: cannot describe '417cecf76b91f58a61e8cc9e4bc57ddda87aac58'poky [2][0] $ git log --oneline scarthgap-5.0.10..417cecf76b | wc -l 31
Oh... indeed. I thought that this was tagged already long ago. Thanks for this, this does answer my concerns.
Quoted 37 lines
Regards,
QiQuoted 34 lines
Quoted 34 lines
Regards,
QiQuoted 30 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218975): https://lists.openembedded.org/g/openembedded-core/message/218975
Mute This Topic: https://lists.openembedded.org/mt/113692551/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][scarthgap 8/8] systemd: Rename systemd_v255.21 to systemd_255.21
This is a possible scenario, but it is theoretical and not likely at this point. And if someone is affected by this, then they can find a way to force a downgrade with the package manager, or maintain the bogus version with a bbappend, or issue a whole-image update.
I'd rather not force a PE bump on everybody, including the master oe-core branch.
Alex
Quoted 89 lines · Martin Jansa via lists.openembedded.org
It's not tagged, but it was merged to scarthgap branch 13 days ago as:
https://git.openembedded.org/openembedded-core/commit/?h=scarthgap&id=29e623b2ad00555788412fa520fbb9ffec794cbbWe don't depend on package-manager upgrades, so version going backwards is not the real blocker for us, but PE bump in all active branches seems better fix than people not getting the next systemd upgrade (e.g. next systemd minor upgrade with security fixes) in projects which use package-manager on target and happened to build the package feed with this commit included (e.g. we don't wait for tagged "releases" from stable branches).
Regards,
Quoted 13 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 11 lines · ChenQi
Quoted 8 lines · Gyorgy Sarvari
Quoted 4 lines · ChenQi
The author's V1 patch bumped PE.
I replied to that patch, asking the author to not bump PE. My reason is that we'll need to bump PE in later releases too (walnascar, master) if we bump PE in scarthgap.My main question would be if bumping PE is worse than breaking this recipe in this release. Maybe it is - I just didn't see much discussions over this.
Luckily, the commit that introduced this issue was not released yet.
Quoted 50 lines
Quoted 5 lines
poky [2][0] $ git describe --contains
417cecf76b
fatal: cannot describe '417cecf76b91f58a61e8cc9e4bc57ddda87aac58'poky [2][0] $ git log --oneline scarthgap-5.0.10..417cecf76b | wc -l 31
Oh... indeed. I thought that this was tagged already long ago. Thanks for this, this does answer my concerns.
Quoted 37 lines
Regards,
QiQuoted 34 lines
Quoted 34 lines
Regards,
QiQuoted 30 lines · Gyorgy Sarvari via lists.openembedded.org
Quoted 5 lines · Steve Sakoman via lists.openembedded.org
From: Savvas Etairidis <[email protected]>
The recipe was accidentally renamed with a 'v' prefix in
29e623b2ad00555788412fa520fbb9ffec794cbb.Quoted 7 lines
Signed-off-by Savvas Etairidis <[email protected]>Signed-off-by Steve Sakoman <[email protected]>--- .../systemd/{systemd_v255.21.bb => systemd_255.21.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-)rename meta/recipes-core/systemd/{systemd_v255.21.bb => systemd_255.21.bb} (100%)
Personally I'm not affected by this issue, and have no problem with this patch, but a few weeks ago there were people who were unhappy when a similar issue popped up in Walnascar with autoconf (though it was caught before merging), which makes me wonder if this is the way to go.
Systemd already has a PE[1], exactly because of the same situation: "v" was removed from the start of ${PV} - maybe it's time to bump.
Anyway, as this patch does no harm to me, this is not a complaint against it, but I thought it would be worth to mention it at least.
[1]:
https://git.yoctoproject.org/poky/commit/?id=f95bbe35b2aab929e50471db8ba50781d5027a01-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#218977): https://lists.openembedded.org/g/openembedded-core/message/218977
Mute This Topic: https://lists.openembedded.org/mt/113692551/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-