address violation of MISRA C Rule 5.5
PATCH v2 3/3 eclair: add deviations of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".
Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)
automation/eclair_analysis/ECLAIR/deviations.ecl +8 -0
@@ -117,6 +117,14 @@ it defines would (in the common case) be already defined. Peer reviewed by the c -config=MC3A2.R5.5,reports+={deliberate, "any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"} -doc_end +-doc_begin="Clashes between function names and macros are deliberate for bitops functions, pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions +and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function, +the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"} +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end + -doc_begin="The type \"ret_t\" is deliberately defined multiple times, depending on the guest." -config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(text(^.*ret_t.*$)))"}
docs/misra/deviations.rst +8 -0
@@ -142,6 +142,14 @@ Deviations related to MISRA C:2012 Rules: memmove. - Tagged as `deliberate` for ECLAIR. + * - R5.5 + - Clashes between function names and macros are deliberate for bitops functions, + pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions and needed + to have a function-like macro that acts as a wrapper for the function to be + called. Before calling the function, the macro adds additional checks or + adjusts the number of parameters depending on the configuration. + - Tagged as `deliberate` for ECLAIR. + * - R5.6 - The type ret_t is deliberately defined multiple times depending on the type of guest to service.
Signature · 1 line
2.43.0
PATCH v2 1/3 iommu: address violation of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Address a violation of MISRA C:2012 Rule 5.5:
"Identifiers shall be distinct from macro names".
Reports for service MC3A2.R5.5:xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine' xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'
There is a clash between function name and macro. Add an 'extern' declaration for 'iommu_quarantine' under the same preprocessor condition (#ifdef CONFIG_HAS_PCI). This ensures that the declaration is consistent
and only exposed when CONFIG_HAS_PCI is defined.
--- xen/include/xen/iommu.h | 2 ++ 1 file changed, 2 insertions(+)
xen/include/xen/iommu.h +2 -0
@@ -53,7 +53,9 @@ static inline bool dfn_eq(dfn_t x, dfn_t y)extern bool iommu_enable, iommu_enabled;extern bool force_iommu, iommu_verbose;/* Boolean except for the specific purposes of drivers/passthrough/iommu.c. */ +#ifdef CONFIG_HAS_PCI extern uint8_t iommu_quarantine; +#endif /* CONFIG_HAS_PCI */ #else #define iommu_enabled false#endif
Signature · 1 line
2.43.0
v2 cover address violation of MISRA C Rule 5.5
This patch series eliminates/deviates MISRA C Rule 5.5 violations for ARM64.
Thread discussion:
https://patchew.org/Xen/[email protected]/
Changes in v2:
- fixed code alignment in "device-tree: address violation of MISRA C Rule 5.5"
- updated commit message in "iommu: address violation of MISRA C Rule 5.5"
- other patches were squashed and MISRA rule was deviated
Dmytro Prokopchuk (3):
iommu: address violation of MISRA C Rule 5.5
device-tree: address violation of MISRA C Rule 5.5
eclair: add deviations of MISRA C Rule 5.5
automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ xen/common/device-tree/domain-build.c | 13 ++++++------- xen/include/xen/fdt-domain-build.h | 4 ++-- xen/include/xen/iommu.h | 2 ++ 5 files changed, 26 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.0
PATCH v2 2/3 device-tree: address violation of MISRA C Rule 5.5
Address a violation of MISRA C:2012 Rule 5.5:
"Identifiers shall be distinct from macro names".
Reports for service MC3A2.R5.5:xen/include/xen/fdt-domain-build.h: non-compliant parameter 'copy_to_guest' xen/include/xen/guest_access.h: non-compliant macro 'copy_to_guest'
Rename 'copy_to_guest' function parameter to 'cb' for compliance. No functional changes.
--- xen/common/device-tree/domain-build.c | 13 ++++++------- xen/include/xen/fdt-domain-build.h | 4 ++-- 2 files changed, 8 insertions(+), 9 deletions(-)
xen/common/device-tree/domain-build.c +6 -7
@@ -336,7 +336,7 @@ void __init allocate_memory(struct domain *d, struct kernel_info *kinfo) }void __init dtb_load (struct kernel_info *kinfo, -copy_to_guest_phys_cb copy_to_guest) +copy_to_guest_phys_cb cb) {unsigned long left;
@@ -344,9 +344,9 @@ void __init dtb_load(struct kernel_info *kinfo, kinfo->d, kinfo->dtb_paddr, kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt)); - left =copy_to_guest (kinfo->d, kinfo->dtb_paddr, - kinfo->fdt, -fdt_totalsize (kinfo->fdt)); + left =cb (kinfo->d, kinfo->dtb_paddr, + kinfo->fdt, +fdt_totalsize (kinfo->fdt));if ( left !=0 ) panic("Unable to copy the DTB to %pd memory (left = %lu bytes)\n",
@@ -355,7 +355,7 @@ void __init dtb_load(struct kernel_info *kinfo, }void __init initrd_load (struct kernel_info *kinfo, -copy_to_guest_phys_cb copy_to_guest) +copy_to_guest_phys_cb cb) {const struct boot_module *mod = kinfo->initrd;paddr_t load_addr = kinfo->initrd_paddr;
@@ -398,8 +398,7 @@ void __init initrd_load(struct kernel_info *kinfo,if ( !initrd )panic ("Unable to map the %pd initrd\n" , kinfo->d); - res =copy_to_guest (kinfo->d, load_addr, - initrd, len); + res =cb (kinfo->d, load_addr, initrd, len);if ( res !=0 )panic ("Unable to copy the initrd in the %pd memory\n" , kinfo->d);
xen/include/xen/fdt-domain-build.h +2 -2
@@ -50,10 +50,10 @@ typedef unsigned long (*copy_to_guest_phys_cb)(struct domain *d, unsigned int len);void initrd_load (struct kernel_info *kinfo, -copy_to_guest_phys_cb copy_to_guest); +copy_to_guest_phys_cb cb);void dtb_load (struct kernel_info *kinfo, -copy_to_guest_phys_cb copy_to_guest); +copy_to_guest_phys_cb cb); int find_unallocated_memory(const struct kernel_info *kinfo, const struct membanks *mem_banks[],
Signature · 1 line
2.43.0
CI tests:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/1917527911
Quoted 22 lines · On 7/10/25 00:38, Dmytro Prokopchuk1 wrote:
This patch series eliminates/deviates MISRA C Rule 5.5 violations for ARM64.
Thread discussion:
https://patchew.org/Xen/[email protected]/Changes in v2:
- fixed code alignment in "device-tree: address violation of MISRA C Rule 5.5"
- updated commit message in "iommu: address violation of MISRA C Rule 5.5"
- other patches were squashed and MISRA rule was deviatedDmytro Prokopchuk (3):
iommu: address violation of MISRA C Rule 5.5
device-tree: address violation of MISRA C Rule 5.5
eclair: add deviations of MISRA C Rule 5.5automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ xen/common/device-tree/domain-build.c | 13 ++++++------- xen/include/xen/fdt-domain-build.h | 4 ++-- xen/include/xen/iommu.h | 2 ++ 5 files changed, 26 insertions(+), 9 deletions(-)
Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Quoted 10 lines · On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
Address a violation of MISRA C:2012 Rule 5.5:
"Identifiers shall be distinct from macro names".Reports for service MC3A2.R5.5:
xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'There is a clash between function name and macro. Add an 'extern' declaration for '
iommu_quarantine' under the same preprocessor condition (#ifdefCONFIG_HAS_PCI).
Perhaps s/Add an/Put the/ or some such? You don't add any declaration, after all.
Quoted 4 lines
This ensures that the declaration is consistent
and only exposed whenCONFIG_HAS_PCIis defined.Signed-off-by Dmytro Prokopchuk <[email protected]>
With some suitable adjustment (happy to make while committing as long as you agree):
Jan
Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
Yes, sure. I'll update commit message.
Thanks!
Quoted 25 lines · Jan Beulich
Quoted 10 lines · On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
Address a violation of MISRA C:2012 Rule 5.5:
"Identifiers shall be distinct from macro names".Reports for service MC3A2.R5.5:
xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'There is a clash between function name and macro. Add an 'extern' declaration for '
iommu_quarantine' under the same preprocessor condition (#ifdefCONFIG_HAS_PCI).Perhaps s/Add an/Put the/ or some such? You don't add any declaration, after all.
Quoted 4 lines
This ensures that the declaration is consistent
and only exposed whenCONFIG_HAS_PCIis defined.Signed-off-by Dmytro Prokopchuk <[email protected]>With some suitable adjustment (happy to make while committing as long as you agree):
Reviewed-by Jan Beulich <[email protected]>Jan
Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
Jan, I don't mind, you can adjust it.
Please, go ahead.
Quoted 30 lines · Dmytro Prokopchuk
Yes, sure. I'll update commit message.
Thanks!Quoted 25 lines · Jan Beulich
Quoted 10 lines · On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
Address a violation of MISRA C:2012 Rule 5.5:
"Identifiers shall be distinct from macro names".Reports for service MC3A2.R5.5:
xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'There is a clash between function name and macro. Add an 'extern' declaration for '
iommu_quarantine' under the same preprocessor condition (#ifdefCONFIG_HAS_PCI).Perhaps s/Add an/Put the/ or some such? You don't add any declaration, after all.
Quoted 4 lines
This ensures that the declaration is consistent
and only exposed whenCONFIG_HAS_PCIis defined.Signed-off-by Dmytro Prokopchuk <[email protected]>With some suitable adjustment (happy to make while committing as long as you agree):
Reviewed-by Jan Beulich <[email protected]>Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Quoted 9 lines · On Wed, 9 Jul 2025, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>
Hi Dmytro,
I tried to apply the patch and run a pipeline but it only results clean on ARM but not on x86. There are 2087 outstanding violations:
https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/1919889048
Jan, Andrew, Roger,
About half of them are from bitops.h which could be deviated the same way xen/include/xen/bitops.h is deviated in this patch.
xen/arch/x86/include/asm/x86_64/page.h:virt_to_maddr could be deviated too.
I don't know how to handle the rest or even how to configure the deviation in Eclair. These are the results with those two deviations added:
We only have 49 left. Any suggestions on how to handle them so that we can mark the rule as "clean" and stop future regressions in the CI loop?
Quoted 46 lines
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +8
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be already defined. Peer reviewed by the c -config=MC3A2.R5.5,reports+={deliberate, "any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"} -doc_end +-doc_begin="Clashes between function names and macros are deliberate for bitops functions, pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions +and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function, +the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"} +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end + -doc_begin="The type \"ret_t\" is deliberately defined multiple times, depending on the guest." -config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(text(^.*ret_t.*$)))"}docs/misra/deviations.rst +8
-0@@ -142,6 +142,14 @@ Deviations related to MISRA C:2012 Rules: memmove. - Tagged as `deliberate` for ECLAIR. + * - R5.5 + - Clashes between function names and macros are deliberate for bitops functions, + pirq_cleanup_check, update_gnttab_par and parse_gnttab_limit functions and needed + to have a function-like macro that acts as a wrapper for the function to be + called. Before calling the function, the macro adds additional checks or + adjusts the number of parameters depending on the configuration. + - Tagged as `deliberate` for ECLAIR. + * - R5.6 - The type ret_t is deliberately defined multiple times depending on the type of guest to service.Signature · 1 line
2.43.0
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Quoted 24 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_end
Quoted 8 lines
+-doc_begin="Clashes between function names and macros are deliberate
for bitops functions,pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions +and needed to have a function-like macro that acts as a wrapper for
the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration."
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}
Bitops violations are not inside "xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"
Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Quoted 29 lines
-doc_begin="The type \"ret_t\" is deliberately defined multiple times, depending on the guest."
automation/eclair_analysis/ECLAIR/deviations.ecl +0
-1-config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(text(^.*ret_t.*$)))"}docs/misra/deviations.rst +3
-0@@ -142,6 +142,14 @@ Deviations related to MISRA C:2012 Rules: memmove. - Tagged as `deliberate` for ECLAIR. + * - R5.5 + - Clashes between function names and macros are deliberate for bitops functions, + pirq_cleanup_check, update_gnttab_par and parse_gnttab_limitfunctions and needed
+ to have a function-like macro that acts as a wrapper for the
function to be
+ called. Before calling the function, the macro adds additional
checks or
+ adjusts the number of parameters depending on the
configuration.docs/misra/deviations.rst +2
-0+ - Tagged as `deliberate` for ECLAIR. + * - R5.6 - The type ret_t is deliberately defined multiple times dependingon the
type of guest to service.
Signature · 4 lines
Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 47 lines · Nicola Vetrini
Quoted 25 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"}
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"}-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}
Jan, are you OK with it?
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 59 lines · Stefano Stabellini
Quoted 47 lines · Nicola Vetrini
Quoted 25 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
Quoted 12 lines
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"}
Thinking a bit more about it, this deviation is perhaps a bit too wide, though in this case it's probably fine. Probably what is actually wanted is "all_area(all_loc(...))" . This ensures that the decl area and the macro area of the report are in the same file, which is almost always the case for deliberate shadowing. If that turns out to be too strict, then we may do "all_area(any_loc(...))", ensuring that at least there is a loc for the macro and decl in that file.
Quoted 30 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}
Jan, are you OK with it?
Signature · 4 lines
Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
In reply to Stefano StabelliniQuoted 80 lines · Stefano Stabellini
Quoted 47 lines · Nicola Vetrini
Quoted 25 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-20-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}
Quoted 1 line
Jan, are you OK with it?
For many of them the scope (all_area) looks to be far too wide, especially for about everything involved in compat handling. I can only repeat that I think that we would be (far) better off not having wider than necessary deviations.
There are others which I may not understand, e.g. the genapic.h one. IOW I further think that such a change would need to come with a fair bit of explanation / justification.
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Hi Jan and Stefano.
Could we proceed with ARM deviations only so far?
I understand Stefano's preferences, but it can unblock me to address next ARM violations.
BR, Dmytro.
Quoted 93 lines · Jan Beulich
Quoted 80 lines · Stefano Stabellini
Quoted 47 lines · Nicola Vetrini
Quoted 25 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-20-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}Quoted 1 line
Jan, are you OK with it?
For many of them the scope (
all_area) looks to be far too wide, especially for about everything involved in compat handling. I can only repeat that I think that we would be (far) better off not having wider than necessary deviations.There are others which I may not understand, e.g. the
genapic.hone. IOW I further think that such a change would need to come with a fair bit of explanation / justification.Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 3 lines · On 15.07.2025 11:46, Dmytro Prokopchuk1 wrote:
Could we proceed with ARM deviations only so far?
I understand Stefano's preferences, but it can unblock me to address next ARM violations.
Hmm, ...
Quoted 73 lines · Jan Beulich
Quoted 72 lines · Stefano Stabellini
Quoted 71 lines · Nicola Vetrini
Quoted 47 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
Quoted 25 lines
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-12-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"}
Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
(quoted diff) +0
-8-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}
... in here, which of them are Arm-only?
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Dmytro.
Quoted 92 lines · Jan Beulich
Quoted 3 lines · On 15.07.2025 11:46, Dmytro Prokopchuk1 wrote:
Could we proceed with ARM deviations only so far?
I understand Stefano's preferences, but it can unblock me to address next ARM violations.Hmm, ...
Quoted 73 lines · Jan Beulich
Quoted 72 lines · Stefano Stabellini
Quoted 71 lines · Nicola Vetrini
Quoted 47 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
Quoted 25 lines
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-12-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"}Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
(quoted diff) +0
-8-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}... in here, which of them are Arm-only?
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 9 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Hmm, I'd call these "common code" ones, but I guess you meant "anything that would make Arm clean".
As an aside - please don't top-post.
Jan
Quoted 93 lines · Jan Beulich
Quoted 92 lines · On 15.07.2025 11:46, Dmytro Prokopchuk1 wrote:
Quoted 3 lines
Could we proceed with ARM deviations only so far?
I understand Stefano's preferences, but it can unblock me to address next ARM violations.Hmm, ...
Quoted 73 lines · Jan Beulich
Quoted 72 lines · Stefano Stabellini
Quoted 71 lines · Nicola Vetrini
Quoted 47 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
Quoted 25 lines
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,
"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-12-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"}Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
(quoted diff) +0
-8-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}... in here, which of them are Arm-only?
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 14 lines · Jan Beulich
Quoted 9 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}Hmm, I'd call these "common code" ones, but I guess you meant "anything that would make Arm clean".
Quoted 4 lines
As an aside - please don't top-post.
Jan
Yes, you are right. I meant "make ARM clean".
Sorry for inconvenience.
Dmytro.
Quoted 94 lines
Quoted 93 lines · Jan Beulich
Quoted 92 lines · On 15.07.2025 11:46, Dmytro Prokopchuk1 wrote:
Quoted 3 lines
Could we proceed with ARM deviations only so far?
I understand Stefano's preferences, but it can unblock me to address next ARM violations.Hmm, ...
Quoted 73 lines · Jan Beulich
Quoted 72 lines · Stefano Stabellini
Quoted 71 lines · Nicola Vetrini
Quoted 47 lines · On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote:
Quoted 25 lines
MISRA C Rule 5.5 states that: "Identifiers shall
be distinct from macro names".Update ECLAIR configuration to deviate:
- clashes in 'xen/include/xen/bitops.h';
- clashes in 'xen/include/xen/irq.h';
- clashes in 'xen/common/grant_table.c'.Signed-off-by Dmytro Prokopchuk <[email protected]>--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ docs/misra/deviations.rst | 8 ++++++++ 2 files changed, 16 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -117,6 +117,14 @@ it defines would (in the common case) be alreadydefined. Peer reviewed by the c
-config=MC3A2.R5.5,reports+={deliberate,"any_area(decl(kind(function))||any_loc(macro(name(memcpy||memset||memmove))))&&any_area(any_loc(file(^xen/common/libelf/libelf-private\\.h$)))"}
-doc_endQuoted 9 lines
+-doc_begin="Clashes between function names and macros are deliberate for bitops functions,
pirq_cleanup_check,update_gnttab_parandparse_gnttab_limitfunctions
+and needed to have a function-like macro that acts as a wrapper for the function to be called. Before calling the function,
+the macro adds additional checks or adjusts the number of parameters depending on the configuration." +-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}Bitops violations are not inside "
xen/include/xen/bitops.h", but rather "xen/arch/x86/include/asm/bitops.h"Quoted 2 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/irq\\.h$))&&context(name(pirq_cleanup_check)&&kind(function)))"}
I would rather do (untested)
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
Quoted 7 lines
Quoted 4 lines
+-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/common/grant_table\\.c$))&&context(name(update_gnttab_par||parse_gnttab_limit)&&kind(function)))"} +-doc_end+
same as above
Thanks Nicola! The following deviations are enough and sufficient to zero violations on both ARM and x86:
(quoted diff) +0
-12-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/bitops\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat\\.c$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^.*/compat/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/x86_emulate/.*$)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/arch/x86/include/asm/genapic\\.h$)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(virt_to_maddr))||macro(name(virt_to_maddr)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_px_pminfo))||macro(name(set_px_pminfo)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(set_cx_pminfo))||macro(name(set_cx_pminfo)))"}Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
(quoted diff) +0
-8-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_to_guest_ll))||macro(name(copy_to_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(copy_from_guest_ll))||macro(name(copy_from_guest_ll)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(edd_put_string))||macro(name(edd_put_string)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(cpu_has_amd_erratum))||macro(name(cpu_has_amd_erratum)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(page_list_entry))||macro(name(page_list_entry)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_physdev_op))||macro(name(do_physdev_op)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(do_platform_op))||macro(name(do_platform_op)))"}... in here, which of them are Arm-only?
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Quoted 3 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}
This one's probably fine.
Quoted 4 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
These two look too broad: They're affecting common/grant_table.c only, aren't they?
Quoted 2 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
This one also looks overly broad, but it's perhaps unavoidable to be that way.
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 15 lines · Jan Beulich
Quoted 3 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}This one's probably fine.
Quoted 4 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
These two look too broad: They're affecting
common/grant_table.conly, aren't they?
Quoted 6 lines
Quoted 2 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
This one also looks overly broad, but it's perhaps unavoidable to be that way.
Jan
Hi Jan.
Those deviations can be narrowed (specifying file name):
-config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/bitops\\.h$)) && macro(name(__test_and_set_bit||__test_and_clear_bit||__test_and_change_bit||test_bit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/common/grant_table\\.c$))&¯o(name(update_gnttab_par||parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/irq\\.h$))&¯o(name(pirq_cleanup_check)))"}
Are you OK with it?
Dmytro.
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 33 lines · On 16.07.2025 18:04, Dmytro Prokopchuk1 wrote:
Quoted 15 lines · Jan Beulich
Quoted 3 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}This one's probably fine.
Quoted 4 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
These two look too broad: They're affecting
common/grant_table.conly, aren't they?Quoted 4 lines
Quoted 2 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
This one also looks overly broad, but it's perhaps unavoidable to be that way.
Those deviations can be narrowed (specifying file name):
-config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/bitops\\.h$)) && macro(name(__test_and_set_bit||__test_and_clear_bit||__test_and_change_bit||test_bit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/common/grant_table\\.c$))&¯o(name(update_gnttab_par||parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/irq\\.h$))&¯o(name(pirq_cleanup_check)))"}
Quoted 1 line
Are you OK with it?
This looks acceptable to me, yes.
Jan
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
In reply to Dmytro Prokopchuk1Quoted 35 lines · On 2025-07-16 18:04, Dmytro Prokopchuk1 wrote:
Quoted 15 lines · Jan Beulich
Quoted 3 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}This one's probably fine.
Quoted 4 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(parse_gnttab_limit))||macro(name(parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(update_gnttab_par))||macro(name(update_gnttab_par)))"}
These two look too broad: They're affecting
common/grant_table.conly, aren't they?Quoted 6 lines
Quoted 2 lines
-config=MC3A2.R5.5,reports+={deliberate, "all_area(decl(name(pirq_cleanup_check))||macro(name(pirq_cleanup_check)))"}
This one also looks overly broad, but it's perhaps unavoidable to be that way.
Jan
Hi Jan.
Those deviations can be narrowed (specifying file name):
-config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/bitops\\.h$)) && macro(name(__test_and_set_bit||__test_and_clear_bit||__test_and_change_bit||test_bit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/common/grant_table\\.c$))&¯o(name(update_gnttab_par||parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/irq\\.h$))&¯o(name(pirq_cleanup_check)))"}
Quoted 2 lines
Are you OK with it?
s/any_loc/all_loc/ ? I don't expect these reports to have locations outside those header files, so this should have the same effect but with a narrower deviation.
Quoted 1 line
Dmytro.
Signature · 4 lines
Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5
Quoted 44 lines · Nicola Vetrini
Quoted 43 lines · On 2025-07-16 18:04, Dmytro Prokopchuk1 wrote:
Quoted 18 lines · Jan Beulich
Quoted 3 lines · On 15.07.2025 12:07, Dmytro Prokopchuk1 wrote:
ARM only are:
-config=MC3A2.R5.5,reports+={deliberate, "any_area(all_loc(file(^xen/include/xen/bitops\\.h$)))"}This one's probably fine.
Quoted 6 lines
-config=MC3A2.R5.5,reports+={deliberate,
"all_area(decl(name(parse_gnttab_limit))||
macro(name(parse_gnttab_limit)))"}
-config=MC3A2.R5.5,reports+={deliberate,
"all_area(decl(name(update_gnttab_par))||
macro(name(update_gnttab_par)))"}These two look too broad: They're affecting
common/grant_table.conly, aren't
they?Quoted 8 lines
Quoted 3 lines
-config=MC3A2.R5.5,reports+={deliberate,
"all_area(decl(name(pirq_cleanup_check))||
macro(name(pirq_cleanup_check)))"}This one also looks overly broad, but it's perhaps unavoidable to be that way.
Jan
Hi Jan.
Those deviations can be narrowed (specifying file name):
-config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/bitops\\.h$)) &&
macro(name(__test_and_set_bit||__test_and_clear_bit|| __test_and_change_bit||test_bit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/common/grant_table\
\.c$))&¯o(name(update_gnttab_par||parse_gnttab_limit)))"} -config=MC3A2.R5.5,reports+={deliberate, "any_area(any_loc(file(^xen/include/xen/irq\
\.h$))&¯o(name(pirq_cleanup_check)))"}
Quoted 6 lines
Quoted 2 lines
Are you OK with it?
s/any_loc/all_loc/ ? I don't expect these reports to have locations outside those header files, so this should have the same effect but with a narrower deviation.
Thanks, Nicola.
I updated my patch.
Quoted 3 lines
Quoted 2 lines
Dmytro.