Patch review
cover Patch review
Please review this set of changes for kirkstone and have comments back by end of day Thursday, August 21
Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/valkyrie/?#/builders/29/builds/2234
The following changes since commit fa45d6d5bec8fe503ff6b9166a3b4af31ea95369:
go-helloworld: fix license (2025-08-14 07:34:07 -0700)
are available in the Git repository at:
https://git.openembedded.org/openembedded-core-contrib stable/scarthgap-nut
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/scarthgap-nut
Daniel Turull (2):
xz: ignore CVE-2024-47611
libxml2: ignore CVE-2025-8732
Khem Raj (3):
e2fsprogs: Fix build failure with gcc 15
parted: Fix build with GCC 15
bash: Stick to C17 std
Martin Jansa (2):
cairo: fix build with gcc-15 on host
bash: use -std=gnu17 also for native CFLAGS
Peter Marko (2):
dropbear: patch CVE-2025-47203
glib-2.0: ignore CVE-2025-4056
Philip Lorenz (1):
cve-check: Add missing call to exit_if_errors
meta/classes/cve-check.bbclass | 1 + ...iable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch | 27 ++ ...-length-paths-and-commands-in-multih.patch | 63 +++ ...and-also-forward-this-when-multihop-.patch | 81 ++++ ...add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch | 29 ++ .../dropbear/dropbear/CVE-2025-47203.patch | 367 ++++++++++++++++++ .../recipes-core/dropbear/dropbear_2022.83.bb | 5 + meta/recipes-core/glib-2.0/glib-2.0_2.78.6.bb | 2 + meta/recipes-core/libxml/libxml2_2.12.10.bb | 4 + ...-libext2fs-fix-std-c23-build-failure.patch | 42 ++ .../e2fsprogs/e2fsprogs_1.47.0.bb | 1 + meta/recipes-extended/bash/bash_5.2.21.bb | 5 + ...CH-parted-fix-do_version-declaration.patch | 40 ++ meta/recipes-extended/parted/parted_3.6.bb | 1 + meta/recipes-extended/xz/xz_5.4.7.bb | 2 + .../cairo/cairo/0001-Require-C11.patch | 25 ++ .../cairo/cairo/0002-Meson-Require-C-11.patch | 22 ++ meta/recipes-graphics/cairo/cairo_1.18.0.bb | 2 + 18 files changed, 719 insertions(+) create mode 100644 meta/recipes-core/dropbear/dropbear/0001-Avoid-unused-variable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-Handle-arbitrary-length-paths-and-commands-in-multih.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-add-o-BatchMode-and-also-forward-this-when-multihop-.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-cli-runopts.c-add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch create mode 100644 meta/recipes-core/dropbear/dropbear/CVE-2025-47203.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-std-c23-build-failure.patch create mode 100644 meta/recipes-extended/parted/files/0001-bug-74444-PATCH-parted-fix-do_version-declaration.patch create mode 100644 meta/recipes-graphics/cairo/cairo/0001-Require-C11.patch create mode 100644 meta/recipes-graphics/cairo/cairo/0002-Meson-Require-C-11.patch
Signature · 1 line
2.43.0
PATCH 1/10 cve-check: Add missing call to exit_if_errors
From: Philip Lorenz <[email protected]>
check_cves may raise the cve_status_not_in_db QA check. Call exit_if_errors to make sure that the task is marked as failed when the check is categorized as an error.
cve_status_not_in_db was in the meantime dropped in OE-Core 452e605b55ad61c08f4af7089a5a9c576ca28f7d so this change is only required on scarthgap.
--- meta/classes/cve-check.bbclass | 1 + 1 file changed, 1 insertion(+)
meta/classes/cve-check.bbclass +1 -0
@@ -196,6 +196,7 @@ python do_cve_check () { else: bb.note("No CVE database found, skipping CVE check") + oe.qa.exit_if_errors(d) } addtask cve_check before do_build
Signature · 1 line
2.43.0
PATCH 2/10 dropbear: patch CVE-2025-47203
In reply to Steve SakomanFrom: Peter Marko <[email protected]>
Based on Debian patch for this CVE, pick the same commits as mentioned in kirkstone for this CVE except those already included in 2022.83.
https://salsa.debian.org/debian/dropbear/-/commit/7f48e75892c40cfc6336137d62581d2c4ca7d84c
--- ...iable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch | 27 ++ ...-length-paths-and-commands-in-multih.patch | 63 +++ ...and-also-forward-this-when-multihop-.patch | 81 ++++ ...add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch | 29 ++ .../dropbear/dropbear/CVE-2025-47203.patch | 367 ++++++++++++++++++ .../recipes-core/dropbear/dropbear_2022.83.bb | 5 + 6 files changed, 572 insertions(+) create mode 100644 meta/recipes-core/dropbear/dropbear/0001-Avoid-unused-variable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-Handle-arbitrary-length-paths-and-commands-in-multih.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-add-o-BatchMode-and-also-forward-this-when-multihop-.patch create mode 100644 meta/recipes-core/dropbear/dropbear/0001-cli-runopts.c-add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch create mode 100644 meta/recipes-core/dropbear/dropbear/CVE-2025-47203.patch
meta/recipes-core/dropbear/dropbear/0001-Avoid-unused-variable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch new file +27 -0
@@ -0,0 +1,27 @@ +From d59436a4d56de58b856142a5d489a4a8fc7382ed Mon Sep 17 00:00:00 2001 +From: Matt Johnston <[email protected]> +Date: Mon, 8 Apr 2024 22:01:21 +0800 +Subject: [PATCH] Avoid unused variable with DROPBEAR_CLI_PUBKEY_AUTH 0 + +Fixes PR #291 + +Upstream-Status: Backport [https://github.com/mkj/dropbear/commit/d59436a4d56de58b856142a5d489a4a8fc7382ed] +Signed-off-by: Peter Marko <[email protected]> +--- + cli-runopts.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/cli-runopts.c b/cli-runopts.c +index b853a13..6668aee 100644 +--- a/cli-runopts.c ++++ b/cli-runopts.c +@@ -533,7 +533,9 @@ static void loadidentityfile(const char* filename, int warnfail) { + static char* multihop_passthrough_args(void) { + char *args = NULL; + unsigned int len, total; ++#if DROPBEAR_CLI_PUBKEY_AUTH + m_list_elem *iter; ++#endif + /* Sufficient space for non-string args */ + len = 100; +
meta/recipes-core/dropbear/dropbear/0001-Handle-arbitrary-length-paths-and-commands-in-multih.patch new file +63 -0
63 lines not on this page · raw message
meta/recipes-core/dropbear/dropbear/0001-add-o-BatchMode-and-also-forward-this-when-multihop-.patch new file +81 -0
81 lines not on this page · raw message
meta/recipes-core/dropbear/dropbear/0001-cli-runopts.c-add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch new file +29 -0
@@ -0,0 +1,29 @@ +From dd03da772bfad6174425066ff9752b60e25ed183 Mon Sep 17 00:00:00 2001 +From: Sergey Ponomarev <[email protected]> +Date: Sun, 7 Apr 2024 21:16:50 +0300 +Subject: [PATCH] cli-runopts.c add missing DROPBEAR_CLI_PUBKEY_AUTH + +Upstream-Status: Backport [https://github.com/mkj/dropbear/commit/dd03da772bfad6174425066ff9752b60e25ed183] +Signed-off-by: Peter Marko <[email protected]> +--- + cli-runopts.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/cli-runopts.c b/cli-runopts.c +index 219fc53..b853a13 100644 +--- a/cli-runopts.c ++++ b/cli-runopts.c +@@ -541,11 +541,13 @@ static char* multihop_passthrough_args(void) { + if (cli_opts.proxycmd) { + len += strlen(cli_opts.proxycmd); + } ++#if DROPBEAR_CLI_PUBKEY_AUTH + for (iter = cli_opts.privkeys->first; iter; iter = iter->next) + { + sign_key * key = (sign_key*)iter->item; + len += 4 + strlen(key->filename); + } ++#endif + + args = m_malloc(len); + total = 0;
meta/recipes-core/dropbear/dropbear/CVE-2025-47203.patch new file +367 -0
367 lines not on this page · raw message
meta/recipes-core/dropbear/dropbear_2022.83.bb +5 -0
@@ -24,6 +24,11 @@ SRC_URI = "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.bz2 \ ${@bb.utils.contains('PACKAGECONFIG', 'disable-weak-ciphers', 'file://dropbear-disable-weak-ciphers.patch', '', d)} \ file://CVE-2023-36328.patch \ file://CVE-2023-48795.patch \ + file://0001-add-o-BatchMode-and-also-forward-this-when-multihop-.patch \ + file://0001-Handle-arbitrary-length-paths-and-commands-in-multih.patch \ + file://0001-cli-runopts.c-add-missing-DROPBEAR_CLI_PUBKEY_AUTH.patch \ + file://0001-Avoid-unused-variable-with-DROPBEAR_CLI_PUBKEY_AUTH-.patch \ + file://CVE-2025-47203.patch \ " SRC_URI[sha256sum] = "bc5a121ffbc94b5171ad5ebe01be42746d50aa797c9549a4639894a16749443b"
Signature · 1 line
2.43.0
PATCH 3/10 xz: ignore CVE-2024-47611
In reply to Steve SakomanFrom: Daniel Turull <[email protected]>
According to the NVD entry, it is only applicable when built for native Windows (MinGW-w64 or MSVC).
--- meta/recipes-extended/xz/xz_5.4.7.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-extended/xz/xz_5.4.7.bb +2 -0
@@ -35,6 +35,8 @@ SRC_URI[sha256sum] = "8db6664c48ca07908b92baedcfe7f3ba23f49ef2476864518ab5db6723 UPSTREAM_CHECK_REGEX = "releases/tag/v(?P<pver>\d+(\.\d+)+)" UPSTREAM_CHECK_URI = "https://github.com/tukaani-project/xz/releases/" +CVE_STATUS[CVE-2024-47611] = "not-applicable-platform: Issue only applies on Windows" + CACHED_CONFIGUREVARS += "gl_cv_posix_shell=/bin/sh" inherit autotools gettext ptest
Signature · 1 line
2.43.0
PATCH 4/10 glib-2.0: ignore CVE-2025-4056
In reply to Steve SakomanFrom: Peter Marko <[email protected]>
NVD report [1] says:
A flaw was found in GLib. A denial of service on **Windows platforms** may occur if an application attempts to spawn a program using long command lines.
The fix [3] (linked from [2]) also changes only files glib/gspawn-win32-helper.c glib/gspawn-win32.c
[1] https://nvd.nist.gov/vuln/detail/CVE-2025-4056
[2] https://gitlab.gnome.org/GNOME/glib/-/issues/3668
[3] https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4570
--- meta/recipes-core/glib-2.0/glib-2.0_2.78.6.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-core/glib-2.0/glib-2.0_2.78.6.bb +2 -0
@@ -66,3 +66,5 @@ def find_meson_cross_files(d): python () { find_meson_cross_files(d) } + +CVE_STATUS[CVE-2025-4056] = "not-applicable-platform: Issue only applies on Windows"
Signature · 1 line
2.43.0
PATCH 5/10 libxml2: ignore CVE-2025-8732
In reply to Steve SakomanFrom: Daniel Turull <[email protected]>
The code maintainer disputes the CVE as the issue can only be triggered with untrusted SGML catalogs and it makes absolutely no sense to use untrusted catalogs.
The issue triggers a crash if an invalid file is provided.
Source: https://gitlab.gnome.org/GNOME/libxml2/-/issues/958"
--- meta/recipes-core/libxml/libxml2_2.12.10.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-core/libxml/libxml2_2.12.10.bb +4 -0
@@ -32,6 +32,10 @@ SRC_URI[testtar.sha256sum] = "c6b2d42ee50b8b236e711a97d68e6c4b5c8d83e69a2be47223 # Disputed as a security issue, but fixed in d39f780 CVE_STATUS[CVE-2023-45322] = "disputed: issue requires memory allocation to fail" +# Disputed as a security issue, if attempts to process an invalid file, it fails +# https://gitlab.gnome.org/GNOME/libxml2/-/issues/958 +CVE_STATUS[CVE-2025-8732] = "disputed: the code maintainer explains, that the issue can only be triggered with untrusted SGML catalogs and it makes absolutely no sense to use untrusted catalogs. The issue triggers a crash if an invalid file is provided. https://gitlab.gnome.org/GNOME/libxml2/-/issues/958" + BINCONFIG = "${bindir}/xml2-config" PACKAGECONFIG ??= "python \
Signature · 1 line
2.43.0
PATCH 6/10 e2fsprogs: Fix build failure with gcc 15
In reply to Steve SakomanFrom: Khem Raj <[email protected]>
Backport a needed fix
--- ...-libext2fs-fix-std-c23-build-failure.patch | 42 +++++++++++++++++++ .../e2fsprogs/e2fsprogs_1.47.0.bb | 1 + 2 files changed, 43 insertions(+) create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-std-c23-build-failure.patch
meta/recipes-devtools/e2fsprogs/e2fsprogs/0001-libext2fs-fix-std-c23-build-failure.patch new file +42 -0
@@ -0,0 +1,42 @@ +From 72dcef02bee9924c4d5b3dc6e7ef4d07becebcc6 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Fri, 22 Nov 2024 12:36:32 +0000 +Subject: [PATCH] libext2fs: fix -std=c23 build failure + +gcc-15 switched to -std=c23 by default: + + https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 + +As a result `e2fsprogs` fails the build so only typedef int bool +for __STDC_VERSION__ <= 201710L (C17) + + ../../../lib/ext2fs/tdb.c:113:13: error: two or more data types in declaration specifiers + ../../../lib/ext2fs/tdb.c:113:1: warning: useless type name in empty declaration + 113 | typedef int bool; + | ^~~~~~~ + +https://github.com/tytso/e2fsprogs/issues/202 + +Upstream-Status: Backport [https://github.com/tytso/e2fsprogs/commit/49fd04d77b3244c6c6990be41142168eef373aef] +Signed-off-by: Rudi Heitbaum <[email protected]> +Link: https://lore.kernel.org/r/Z0B60JhdvT9bpSQ6@6f91903e89da +Signed-off-by: Theodore Ts'o <[email protected]> +Signed-off-by: Khem Raj <[email protected]> +--- + lib/ext2fs/tdb.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/lib/ext2fs/tdb.c b/lib/ext2fs/tdb.c +index b07b2917..98dc95d8 100644 +--- a/lib/ext2fs/tdb.c ++++ b/lib/ext2fs/tdb.c +@@ -110,7 +110,9 @@ static char *rep_strdup(const char *s) + #endif + #endif + ++#if defined __STDC__ && defined __STDC_VERSION__ && __STDC_VERSION__ <= 201710L + typedef int bool; ++#endif + + #include "tdb.h" +
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb +1 -0
@@ -4,6 +4,7 @@ SRC_URI += "file://remove.ldconfig.call.patch \ file://run-ptest \ file://ptest.patch \ file://mkdir_p.patch \ + file://0001-libext2fs-fix-std-c23-build-failure.patch \ " SRC_URI:append:class-native = " \ file://e2fsprogs-fix-missing-check-for-permission-denied.patch \
Signature · 1 line
2.43.0
PATCH 7/10 parted: Fix build with GCC 15
In reply to Steve SakomanFrom: Khem Raj <[email protected]>
--- ...CH-parted-fix-do_version-declaration.patch | 40 +++++++++++++++++++ meta/recipes-extended/parted/parted_3.6.bb | 1 + 2 files changed, 41 insertions(+) create mode 100644 meta/recipes-extended/parted/files/0001-bug-74444-PATCH-parted-fix-do_version-declaration.patch
meta/recipes-extended/parted/files/0001-bug-74444-PATCH-parted-fix-do_version-declaration.patch new file +40 -0
@@ -0,0 +1,40 @@ +From eb6bb2e8dfc78ca1a187d07ea29b23a805c61794 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Wed, 20 Nov 2024 12:22:22 +0000 +Subject: [PATCH] bug#74444: [PATCH] parted: fix do_version declaration + +With gcc 15-20241117 compile fails with the below error, update the +do_version declaration to match the header in command.h + +../../parted/parted.c: In function '_init_commands': +../../parted/parted.c:2469:9: error: passing argument 2 of 'command_create' from incompatible pointer type [-Wincompatible-pointer-types] + 2469 | do_version, + | ^~~~~~~~~~ + | | + | int (*)(void) +In file included from ../../parted/parted.c:28: +../../parted/command.h:35:39: note: expected 'int (*)(PedDevice **, PedDisk **)' {aka 'int (*)(struct _PedDevice **, struct _PedDisk **)'} but argument is of type 'int (*)(void)' + 35 | int (*method) (PedDevice** dev, PedDisk** diskp), + | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/parted.git/commit/?id=16343bda6ce0d41edf43f8dac368db3bbb63d271] +Signed-off-by: Rudi Heitbaum <[email protected]> +Signed-off-by: Brian C. Lane <[email protected]> +Signed-off-by: Khem Raj <[email protected]> +--- + parted/parted.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/parted/parted.c b/parted/parted.c +index 3abb52f..fc2aeba 100644 +--- a/parted/parted.c ++++ b/parted/parted.c +@@ -2172,7 +2172,7 @@ do_unit (PedDevice** dev, PedDisk** diskp) + } + + static int +-do_version () ++do_version (PedDevice** dev, PedDisk** diskp) + { + printf ("\n%s\n%s", + prog_name,
meta/recipes-extended/parted/parted_3.6.bb +1 -0
@@ -10,6 +10,7 @@ SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \ file://fix-doc-mandir.patch \ file://0001-fs-Add-libuuid-to-linker-flags-for-libparted-fs-resi.patch \ file://autoconf-2.73.patch \ + file://0001-bug-74444-PATCH-parted-fix-do_version-declaration.patch \ file://run-ptest \ "
Signature · 1 line
2.43.0
PATCH 8/10 cairo: fix build with gcc-15 on host
In reply to Steve SakomanFrom: Martin Jansa <[email protected]>
* backports from 1.18.2 used since:
https://git.openembedded.org/openembedded-core/commit/?id=070d79c8adec7e0a8862019cf61910a59b18613a
* fixes build on hosts with gcc-15 (e.g. ubuntu-25.10)
../cairo-1.18.0/test/pdiff/pdiff.h:22:13: error: âboolâ cannot be defined via âtypedefâ
22 | typedef int bool;
| ^~~~
../cairo-1.18.0/test/pdiff/pdiff.h:22:13: note: âboolâ is a keyword with â-std=c23â onwards
../cairo-1.18.0/test/pdiff/pdiff.h:22:1: warning: useless type name in empty declaration
22 | typedef int bool;
| ^~~~~~~--- .../cairo/cairo/0001-Require-C11.patch | 25 +++++++++++++++++++ .../cairo/cairo/0002-Meson-Require-C-11.patch | 22 ++++++++++++++++ meta/recipes-graphics/cairo/cairo_1.18.0.bb | 2 ++ 3 files changed, 49 insertions(+) create mode 100644 meta/recipes-graphics/cairo/cairo/0001-Require-C11.patch create mode 100644 meta/recipes-graphics/cairo/cairo/0002-Meson-Require-C-11.patch
meta/recipes-graphics/cairo/cairo/0001-Require-C11.patch new file +25 -0
@@ -0,0 +1,25 @@ +From de2452228814e804b103dfa7c2d37b3a216c6155 Mon Sep 17 00:00:00 2001 +From: Adrian Johnson <[email protected]> +Date: Sun, 28 Apr 2024 21:31:41 +0930 +Subject: [PATCH] Require C11 + +Upstream-Status: Backport [https://gitlab.freedesktop.org/cairo/cairo/-/commit/b60f47dfd5bbe98aec43f6c356ba3be9a1b7989e] +--- + meson.build | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/meson.build b/meson.build +index 9100152..f8432fd 100644 +--- a/meson.build ++++ b/meson.build +@@ -1,7 +1,8 @@ + project('cairo', 'c', 'cpp', +- meson_version: '>= 0.59.0', ++ meson_version: '>= 1.3.0', + version: run_command(find_program('version.py'), check: true).stdout().strip(), +- default_options: ['warning_level=2'], ++ default_options: ['c_std=gnu11,c11', ++ 'warning_level=2'], + ) + + freetype_required_version = '>= 9.7.3'
meta/recipes-graphics/cairo/cairo/0002-Meson-Require-C-11.patch new file +22 -0
@@ -0,0 +1,22 @@ +From d9cc95b94b2bb1e67f2095cda484d4a8a63aba10 Mon Sep 17 00:00:00 2001 +From: Luca Bacci <[email protected]> +Date: Thu, 16 Jan 2025 16:48:12 +0100 +Subject: [PATCH] Meson: Require C++11 + +Upstream-Status: Backport [https://gitlab.freedesktop.org/cairo/cairo/-/commit/dfd06ab3884d79de3b5bac782d1e8b2a0bd791ab] +--- + meson.build | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/meson.build b/meson.build +index f8432fd..85434d2 100644 +--- a/meson.build ++++ b/meson.build +@@ -2,6 +2,7 @@ project('cairo', 'c', 'cpp', + meson_version: '>= 1.3.0', + version: run_command(find_program('version.py'), check: true).stdout().strip(), + default_options: ['c_std=gnu11,c11', ++ 'cpp_std=gnu++11,c++11', + 'warning_level=2'], + ) +
meta/recipes-graphics/cairo/cairo_1.18.0.bb +2 -0
@@ -30,6 +30,8 @@ DEPENDS = "fontconfig freetype glib-2.0 libpng pixman zlib" SRC_URI = "http://cairographics.org/releases/cairo-${PV}.tar.xz \ file://cairo-get_bitmap_surface-bsc1036789-CVE-2017-7475.diff \ + file://0001-Require-C11.patch \ + file://0002-Meson-Require-C-11.patch \ " SRC_URI[sha256sum] = "243a0736b978a33dee29f9cca7521733b78a65b5418206fef7bd1c3d4cf10b64"
Signature · 1 line
2.43.0
Patchtest results for [OE-core][scarthgap 08/10] cairo: fix build with gcc-15 on host
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:
---
Testing patch /home/patchtest/share/mboxes/scarthgap-08-10-cairo-fix-build-with-gcc-15-on-host.patch
FAIL: test Signed-off-by presence: A patch file has been added without a Signed-off-by tag: '0001-Require-C11.patch' (test_patch.TestPatch.test_signed_off_by_presence)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
---
Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
PATCH 9/10 bash: Stick to C17 std
In reply to Steve SakomanFrom: Khem Raj <[email protected]>
GCC 15 defaults to C23 and bash is not yet ready for that so keep using C17 like GCC 14 for now
--- meta/recipes-extended/bash/bash_5.2.21.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-extended/bash/bash_5.2.21.bb +2 -0
@@ -22,4 +22,6 @@ SRC_URI[tarball.sha256sum] = "c8e31bdc59b69aaffc5b36509905ba3e5cbb12747091d27b4b DEBUG_OPTIMIZATION:append:armv4 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" DEBUG_OPTIMIZATION:append:armv5 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" +CFLAGS += "-std=gnu17" + BBCLASSEXTEND = "nativesdk"
Signature · 1 line
2.43.0
PATCH 10/10 bash: use -std=gnu17 also for native CFLAGS
In reply to Steve SakomanFrom: Martin Jansa <[email protected]>
* fixes builds on host with gcc-15:
http://errors.yoctoproject.org/Errors/Details/853016/
../../bash-5.2.37/builtins/mkbuiltins.c:268:29: error: too many arguments to function ‘xmalloc’; expected 0, have 1
268 | error_directory = xmalloc (2 + strlen (argv[arg_index]));
| ^~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~--- meta/recipes-extended/bash/bash_5.2.21.bb | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-extended/bash/bash_5.2.21.bb +3 -0
@@ -23,5 +23,8 @@ DEBUG_OPTIMIZATION:append:armv4 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb DEBUG_OPTIMIZATION:append:armv5 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" CFLAGS += "-std=gnu17" +# mkbuiltins.c is built with native toolchain and needs gnu17 as well: +# http://errors.yoctoproject.org/Errors/Details/853016/ +BUILD_CFLAGS += "-std=gnu17" BBCLASSEXTEND = "nativesdk"
Signature · 1 line
2.43.0