Skip to contentSkip to conversation

change "a mm_struct" to "an mm_struct" in comment

PATCH In review Joey Pabalinas 2 participants 5 messages Sep 4, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover change "a mm_struct" to "an mm_struct" in comment

The correct english is "an mm_struct" which is used everywhere else in the kernel.

Joey Pabalinas (2):
Hexagon: change "a mm_struct" to "an mm_struct" in comment
fork: change "a mm_struct" to "an mm_struct" in comment

 arch/hexagon/include/asm/mmu.h | 2 +-
 kernel/fork.c                  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
Cheers,
Joey Pabalinas
#1 lore raw

PATCH 1/2 Hexagon: change "a mm_struct" to "an mm_struct" in comment

The correct english is "an mm_struct" which is used everywhere else in the kernel.

---
 arch/hexagon/include/asm/mmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/hexagon/include/asm/mmu.h +1 -1
index dfa46660d695bb65b4..ce784218dc67c92a94 100644
@@ -7,11 +7,11 @@
 #define _ASM_MMU_H
 
 #include <asm/vdso.h>
 
 /*
- * Architecture-specific state for a mm_struct.
+ * Architecture-specific state for an mm_struct.
  * For the Hexagon Virtual Machine, it can be a copy
  * of the pointer to the page table base.
  */
 struct mm_context {
 	unsigned long long generation;
Signature · 2 lines
Cheers,
Joey Pabalinas
#2 lore raw

PATCH 2/2 fork: change "a mm_struct" to "an mm_struct" in comment

In reply to Joey Pabalinas

The correct english is "an mm_struct" which is used everywhere else in the kernel.

---
 kernel/fork.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/fork.c +3 -3
index af673856499dcaa35e..9a783cd46d097a2d68 100644
@@ -1397,18 +1397,18 @@ static int wait_for_vfork_done(struct task_struct *child,
 	put_task_struct(child);
 	return killed;
 }
 
 /* Please note the differences between mmput and mm_release.
- * mmput is called whenever we stop holding onto a mm_struct,
+ * mmput is called whenever we stop holding onto an mm_struct,
  * error success whatever.
  *
- * mm_release is called after a mm_struct has been removed
+ * mm_release is called after an mm_struct has been removed
  * from the current process.
  *
  * This difference is important for error handling, when we
- * only half set up a mm_struct for a new process and need to restore
+ * only half set up an mm_struct for a new process and need to restore
  * the old one.  Because we mmput the new mm_struct before
  * restoring the old one. . .
  * Eric Biederman 10 January 1998
  */
 static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
Signature · 2 lines
Cheers,
Joey Pabalinas
#3 lore raw
In reply to Joey Pabalinas
Quoted 2 lines · Joey Pabalinas

The correct english is "an mm_struct" which is used everywhere else in the kernel.

Hi Joey, this doesn't really warrant a patch, it's just not important and there isn't great RoI on the churcn here. It is also very silly to make this two patches, it should only be one.

Also please do run scripts/get_maintainers.pl when you're doing this, Kees is on the list but he is joined by many esteemed kernel colleagues ;))

Ingo Molnar <[email protected]> (maintainer:SCHEDULER)
Peter Zijlstra <[email protected]> (maintainer:SCHEDULER)
Juri Lelli <[email protected]> (maintainer:SCHEDULER)
Vincent Guittot <[email protected]> (maintainer:SCHEDULER) Dietmar Eggemann <[email protected]> (reviewer:SCHEDULER) Steven Rostedt <[email protected]> (reviewer:SCHEDULER)
Ben Segall <[email protected]> (reviewer:SCHEDULER)
Mel Gorman <[email protected]> (reviewer:SCHEDULER)
Valentin Schneider <[email protected]> (reviewer:SCHEDULER)
Kees Cook <[email protected]> (maintainer:EXEC & BINFMT API, ELF) Andrew Morton <[email protected]> (maintainer:MEMORY MANAGEMENT - CORE) David Hildenbrand <[email protected]> (maintainer:MEMORY MANAGEMENT - CORE) Lorenzo Stoakes <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) "Liam R. Howlett" <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) Vlastimil Babka <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) Mike Rapoport <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) Suren Baghdasaryan <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) Michal Hocko <[email protected]> (reviewer:MEMORY MANAGEMENT - CORE) Brian Cain <[email protected]> (maintainer:QUALCOMM HEXAGON ARCHITECTURE) [email protected] (open list:SCHEDULER) [email protected] (open list:EXEC & BINFMT API, ELF) [email protected] (open list:QUALCOMM HEXAGON ARCHITECTURE) EXEC & BINFMT API, ELF status: Supported
QUALCOMM HEXAGON ARCHITECTURE status: Supported

Quoted 5 lines

Joey Pabalinas (2):
Hexagon: change "a mm_struct" to "an mm_struct" in comment
fork: change "a mm_struct" to "an mm_struct" in comment

Quoted 10 lines
 arch/hexagon/include/asm/mmu.h | 2 +-
 kernel/fork.c                  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

--
Cheers,
Joey Pabalinas

So yeah I don't think we should take this, sorry! :(

Cheers, Lorenzo

#4 lore raw
Quoted 1 line · Lorenzo Stoakes

isn't great RoI on the churcn here. It is also very silly to make this two

Oops typo - should be "isn't great RoI on the _churn_ here" :)