Add support for Firefly ROC-RK3588-RT
Subsystems (2)
v3 cover Add support for Firefly ROC-RK3588-RT
This series add support for Firefly ROC-RK3588-RT.
Info of device can be found at:
https://en.t-firefly.com/product/industry/rocrk3588rt
Changes in v3:
- Change rgmii-rxid phy-mode to rgmii-id
Changes in v2:
- Add devicetree binding documentation for the Firefly ROC-RK3588-RT
- Update the description to match the device tree
- Adjust the descriptions of the model and compatible properties
- Add audio support for hdmi0 and hdmi1
- Adjust the attributes of sdhci in alphabetical order
Kaison Deng (2):
dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
.../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../arm64/boot/dts/rockchip/rk3588-roc-rt.dts | 1134 +++++++++++++++++ 3 files changed, 1140 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts
Signature · 1 line
2.25.1
PATCH v3 1/2 dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588 SoC.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -258,6 +258,11 @@ properties: - const: firefly,roc-rk3576-pc - const: rockchip,rk3576 + - description: Firefly ROC-RK3588-RT + items: + - const: firefly,roc-rk3588-rt + - const: rockchip,rk3588 + - description: Firefly Station M2 items: - const: firefly,rk3566-roc-pc
Signature · 1 line
2.25.1
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
Quoted 9 lines · Kaison Deng
This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588 SoC.
Signed-off-by Kaison Deng <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
Quoted 18 lines · Rob Herring (Arm)
Quoted 10 lines · Kaison Deng
This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588 SoC.
Signed-off-by Kaison Deng <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
Quoted 7 lines
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Ok. Do I need to resend the next version for the missed tags?
Kaison
Heiko Stübner
maintainerRe: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
Hi,
Am Dienstag, 16. September 2025, 05:28:33 Mitteleuropäische Sommerzeit schrieb Kaison Deng:
Quoted 21 lines · Rob Herring (Arm)
Quoted 20 lines · Kaison Deng
Quoted 10 lines
This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588 SoC.
Signed-off-by Kaison Deng <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.If a tag was not added on purpose, please state why and what changed.
Quoted 7 lines
Quoted 5 lines
Missing tags:
Ok. Do I need to resend the next version for the missed tags?
nope, that is not necessary, I can pick up the one from v2.
Heiko
PATCH v3 2/2 arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
In reply to Kaison DengThe Firefly ROC-RK3588-RT is RK3588 based SBC featuring:
- TF card slot
- SATA 2242 socket
- 1x USB 3.0 Port, 1x USB 2.0 Port, 1x Typec Port
- 1x HDMI 2.1 out, 1x HDMI 2.0 out
- 2x Gigabit Ethernet, 1x 2.5G Ethernet
- M.2 E-KEY for Extended WiFI and Bluetoolh
- ES8388 on-board sound codec - jack in/out
- RTC
- LED: WORK, DIY
---
Changes in v3:
- Change rgmii-rxid phy-mode to rgmii-id
Changes in v2:
- Update the description to match the device tree
- Adjust the descriptions of the model and compatible properties
- Add audio support for hdmi0 and hdmi1
- Adjust the properties of sdhci in alphabetical order
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../arm64/boot/dts/rockchip/rk3588-roc-rt.dts | 1134 +++++++++++++++++ 2 files changed, 1135 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -181,6 +181,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-max.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-plus.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-ultra.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-quartzpro64.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-roc-rt.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5-itx.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b-pcie-ep.dtbo
arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts new file +1134 -0
1,134 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v3 2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
Quoted 39 lines
+&gmac0 {
arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts new file +37
-0+ clock_in_out = "output"; + phy-handle = <&rgmii_phy0>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_miim + &gmac0_tx_bus2 + &gmac0_rx_bus2 + &gmac0_rgmii_clk + &gmac0_rgmii_bus>; + status = "okay"; +}; + +&gmac1 { + clock_in_out = "output"; + phy-handle = <&rgmii_phy1>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac1_miim + &gmac1_tx_bus2 + &gmac1_rx_bus2 + &gmac1_rgmii_clk + &gmac1_rgmii_bus>; + status = "okay"; +}; +&mdio0 { + rgmii_phy0: ethernet-phy@1 { + compatible = "ethernet-phy-id001c.c916"; + reg = <0x1>; + pinctrl-names = "default"; + pinctrl-0 = <&rtl8211f_0_rst>; + reset-assert-us = <20000>; + reset-deassert-us = <100000>; + reset-gpios = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>; + }; +}; + +&mdio1 {
arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts line 434
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3588-roc-rt.dts new file +10
-0+ rgmii_phy1: ethernet-phy@1 { + compatible = "ethernet-phy-id001c.c916"; + reg = <0x1>; + pinctrl-names = "default"; + pinctrl-0 = <&rtl8211f_1_rst>; + reset-assert-us = <20000>; + reset-deassert-us = <100000>; + reset-gpios = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; + }; +};
For these nodes only:
Andrew
Quoted 9 lines · Kaison Deng
This series add support for Firefly ROC-RK3588-RT.
Info of device can be found at:
https://en.t-firefly.com/product/industry/rocrk3588rtChanges in v3:
- Change rgmii-rxid phy-mode to rgmii-id[...]
Applied, thanks!
[1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
commit: 0bb8d67611b59740f47ad57658a8d2986c43f8c1
[2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
commit: 93781211e9ad9578787355147c2f28b7289a8ec6Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>