apei/ghes: don't go past allocated memory
PATCH v2 1/2 apei/ghes: don't go past the ARM processor CPER record buffer
In reply to a message not in the archiveThere's a logic inside ghes/cper to detect if the section_length is too small, but it doesn't detect if it is too big.
Currently, if the firmware receives an ARM processor CPER record like:
00000000 01 c2 bf 6e 76 b4 94 d7 b0 04 f5 32 e3 5e 89 23 ...nv......2.^.# 00000010 f6 4f 40 31 fd 70 3f 7c 0a 87 76 84 2f 4b 30 ff [email protected]?|..v./K0. 00000020 24 20 71 0d c0 92 4b 0f ae 9b 94 9d 78 8a 7f 6b $ q...K.....x..k 00000030 89 2f 10 8a 6a bf f4 01 96 12 b0 90 b3 9a 08 33 ./..j..........3 00000040 0d 01 61 ..a
It would produce a very long record, going past the buffer, as, in the above record, ERR_INFO_NUM is set to 46198.
Fix it by adding a logic to prevent it to go past the buffer if ERR_INFO_NUM is too big, reporting instead:
[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1 [Hardware Error]: event severity: recoverable
[Hardware Error]: Error 0, type: recoverable
[Hardware Error]: section_type: ARM processor error
[Hardware Error]: MIDR: 0xff304b2f8476870a
[Hardware Error]: section length: 854918320, CPER size: 67
[Hardware Error]: section length is too big
[Hardware Error]: firmware-generated error record is incorrect
[Hardware Error]: ERR_INFO_NUM is 46198
--- drivers/acpi/apei/ghes.c | 13 +++++++++++++ drivers/firmware/efi/cper-arm.c | 14 +++++++++----- drivers/firmware/efi/cper.c | 3 ++- include/linux/cper.h | 3 ++- 4 files changed, 26 insertions(+), 7 deletions(-)
drivers/acpi/apei/ghes.c +13 -0
@@ -557,6 +557,7 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, {struct cper_sec_proc_arm *err =acpi_hest_get_payload (gdata);int flags = sync ?MF_ACTION_REQUIRED :0 ; +int length = gdata->error_data_length;char error_type[120 ];bool queued = false;int sec_sev, i;
@@ -568,7 +569,12 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,return false; p = (char *)(err +1 ); + length -=sizeof (err); +for (i =0 ; i < err->err_info_num; i++) { +if (length <=0 ) +break ; +struct cper_arm_err_info *err_info = (struct cper_arm_err_info *)p;bool is_cache = err_info->type &CPER_ARM_CACHE_ERROR ;bool has_pa = (err_info->validation_bits &CPER_ARM_INFO_VALID_PHYSICAL_ADDR );
@@ -580,10 +586,17 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,* and don't filter out 'corrected' error here. */ if (is_cache && has_pa) { + length -= err_info->length; +if (length <0 ) +break ; queued =ghes_do_memory_failure (err_info->physical_fault_addr, flags); p += err_info->length; +continue ; } + length -= err_info->length; +if (length <0 ) +break ; cper_bits_to_str(error_type, sizeof(error_type), FIELD_GET(CPER_ARM_ERR_TYPE_MASK, err_info->type),
drivers/firmware/efi/cper-arm.c +9 -5
@@ -226,9 +226,10 @@ static void cper_print_arm_err_info(const char *pfx, u32 type, }void cper_print_proc_arm (const char *pfx, -const struct cper_sec_proc_arm *proc) +const struct cper_sec_proc_arm *proc, +u32 length) { -int i, len, max_ctx_type; +int len, i, max_ctx_type;struct cper_arm_err_info *err_info;struct cper_arm_ctx_info *ctx_info;char newpfx[64 ], infopfx[ARRAY_SIZE (newpfx) +1 ];
@@ -238,9 +239,12 @@ void cper_print_proc_arm(const char *pfx, len = proc->section_length - (sizeof (*proc) + proc->err_info_num * (sizeof (*err_info))); -if (len <0 ) { -printk ("%ssection length: %d\n" , pfx, proc->section_length); -printk ("%ssection length is too small\n" , pfx); + +if (len <0 || len > length) { +printk ("%ssection length: %d, CPER size: %d\n" , + pfx, proc->section_length, length); +printk ("%ssection length is too %s\n" , pfx, + (len > length) ?"big" :"small" );printk ("%sfirmware-generated error record is incorrect\n" , pfx);printk ("%sERR_INFO_NUM is %d\n" , pfx, proc->err_info_num);return ;
drivers/firmware/efi/cper.c +2 -1
@@ -659,7 +659,8 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdataprintk ("%ssection_type: ARM processor error\n" , newpfx);if (gdata->error_data_length >=sizeof (*arm_err)) -cper_print_proc_arm (newpfx, arm_err); +cper_print_proc_arm (newpfx, arm_err, + gdata->error_data_length);else goto err_section_too_small;#endif
include/linux/cper.h +2 -1
@@ -595,7 +595,8 @@ void cper_mem_err_pack(const struct cper_sec_mem_err *,const char *cper_mem_err_unpack (struct trace_seq *,struct cper_mem_err_compact *);void cper_print_proc_arm (const char *pfx, -const struct cper_sec_proc_arm *proc); +const struct cper_sec_proc_arm *proc, +u32 length);void cper_print_proc_ia (const char *pfx,const struct cper_sec_proc_ia *proc);int cper_mem_err_location (struct cper_mem_err_compact *mem,char *msg);
Signature · 1 line
2.52.0
PATCH v2 2/2 apei/ghes: don't go past allocated memory
In reply to a message not in the archiveIf the BIOS generates a very small ARM Processor Error, or an incomplete one, the current logic will fail to deferrence
err->section_length and ctx_info->size
Add checks to avoid that. With such changes, those GHESv2 records won't cause OOPSes:
GUID: e19e3d16-bc11-11e4-9caa-c2051d5d46b0
CPER:
00000000 23 da a0 ce 9a 1b 92 d7 08 2b 32 08 7b 56 1b 23 #........+2.{V.#
00000010 d5 c1 aa 23 b6 57 f3 d7 7a 72 32 ea 2b fd da bc ...#.W..zr2.+...
00000020 4e 52 e3 e4 15 21 53 75 e7 d0 30 22 de cc db ba NR...!Su..0"....
00000030 3c 24 56 99 6d 89 e4 f0 ac f3 4d 78 ba bc 5b 25 <$V.m.....Mx..[%
00000040 e5 9c 2c ac 20 ee 8a af d3 c1 09 02 fd a0 26 e4 ..,. .........&.
00000050 1b 4b d1 12 af af f1 fa ab 00 71 7d e5 7c 46 88 .K........q}.|F.
00000060 d7 35 6e 19 da 03 8f 5f 50 51 68 cf 59 1a 6d 91 .5n...._PQh.Y.m.
00000070 13 e8 53 5d 12 81 ee f4 7c de ae b3 c3 45 5c ef ..S]....|....E\.
00000080 29 21 c8 f1 c5 2a 0b 13 9f 17 56 cf f2 2b ec 32 )!...*....V..+.2
00000090 37 e0 2e bc ac 30 db 33 c0 89 da 7f 39 7c 0b ac 7....0.3....9|..
000000a0 4f f9 a5 e8 9a 0f 05 cb 96 cb 1a 73 1f 0a f4 b5 O..........s....
000000b0 0c 02 3f 6b cd 43 29 2f 9e bb 18 2a 2f 0d eb fb ..?k.C)/...*/...
000000c0 80 2a c1 46 f6 1a 12 8b 72 87 d0 94 17 b6 fc 2d .*.F....r......-
000000d0 4f 07 5a 5d 1d cf d1 81 d6 dd 41 f3 b2 9a 53 4a O.Z]......A...SJ
000000e0 7e ee c4 f7 6c 84 ~...l.
GUID: e19e3d16-bc11-11e4-9caa-c2051d5d46b0
CPER:
00000000 33 d7 b2 39 26 aa 70 4c bf cf bb d6 d5 31 59 4d 3..9&.pL.....1YM
00000010 7d e6 3e 5a 09 88 04 78 78 47 16 ae 3d b0 29 52 }.>Z...xxG..=.)R
00000020 3e 52 c2 d9 6e 04 61 70 42 83 c9 cd 45 ad c3 b6 >R..n.apB...E...
00000030 3d d0 36 a7 fb 4b f2 5f 8d 90 7f f2 77 05 27 15 =.6..K._....w.'.
00000040 c0 c8 72 18 7f 50 a8 5d 03 4f 21 27 06 e5 29 bd ..r..P.].O!'..).
00000050 02 34 6f d1 35 30 71 31 1f 22 1e 7c 74 90 da 38 .4o.50q1.".|t..8
00000060 70 5a e1 ed e0 6e 20 7f cb 05 82 02 a1 d9 75 66 pZ...n .......uf
00000070 c4 62 7d b9 60 95 b3 7a e8 c2 fc b9 ab ab 14 89 .b}.`..z........
00000080 52 83 65 9a c7 83 7a e6 74 2f c5 a4 6a 39 46 06 R.e...z.t/..j9F.
00000090 9e d4 7c b0 f4 f6 96 0e da 72 c5 d9 70 43 2c f0 ..|......r..pC,.
000000a0 0e ae 3f 87 b8 07 89 c2 dd 54 c4 3e 1a 0c ab ae ..?......T.>....
000000b0 53 89 5a bc 41 d7 80 c8 ff 28 ab 55 3c 4d 99 87 S.Z.A....(.U<M..
000000c0 42 ce 11 e8 2c f7 da 5d d3 99 4e 11 86 d7 fc 36 B...,..]..N....6
000000d0 d1 8f a0 59 46 ba 45 f6 41 03 53 3e 0d 92 f1 8f ...YF.E.A.S>....
000000e0 98 49 45 52 ae 5c cc 20 f7 08 2b 3b c0 3d 4c 16 .IER.\. ..+;.=L.
000000f0 95 b2 a8 f5 ec 1e 6a 12 3a 27 e4 5c d3 39 3f 2e ......j.:'.\.9?.
00000100 62 d7 9c ee 75 ea 12 0f cf 09 8a 06 02 23 e6 3a b...u........#.:
00000110 a2 ce 20 63 fa f7 10 ee 83 5c 51 12 94 7d b4 a0 .. c.....\Q..}..
00000120 a9 99 9a 69 92 ba e1 a1 60 d3 98 57 fb 88 34 7a ...i....`..W..4z
00000130 2e 61 d0 73 ae 2d 95 70 00 b5 32 a0 b1 57 b9 70 .a.s.-.p..2..W.p
00000140 f4 bc 37 78 14 a6 5d 1e fa a8 54 e8 8b 00 ea a9 ..7x..]...T.....
00000150 05 a4 e6 e9 e8 9b ee 31 18 b1 92 41 f1 05 3c d6 .......1...A..<.
00000160 fa 7d ed 4c 43 15 f1 0c 77 c2 27 54 2e e0 b6 44 .}.LC...w.'T...D
00000170 73 8c 5a fc d6 0a 63 61 b3 75 5b fe 46 24 7d b5 s.Z...ca.u[.F$}.
00000180 85 83 9a 7d 17 35 c5 1d 69 dc b0 1d 61 b3 10 95 ...}.5..i...a...
00000190 e1 46 f9 06 2c 52 09 27 c6 02 13 98 10 e0 2b 82 .F..,R.'......+.
000001a0 74 5c f1 7e b3 d4 a1 04 58 43 60 36 a8 7b 22 e7 t\.~....XC`6.{".
000001b0 e8 f2 9c fb ac 23 0b 89 18 49 aa 6a 20 04 a4 82 .....#...I.j ...
000001c0 c3 68 e7 96 42 85 d8 d9 fc d6 b3 a4 5b 97 02 f0 .h..B.......[...
000001d0 69 d3 86 63 aa 30 66 09 7a 1f 36 e2 b2 e6 32 d4 i..c.0f.z.6...2.
000001e0 8d 69 68 a2 3d e0 31 54 95 e6 82 76 13 0b 6c d2 .ih.=.1T...v..l.
000001f0 04 36 45 77 56 68 c3 ee b7 db a3 1c 0a 3d e7 00 .6EwVh.......=..
00000200 c0 da 99 b4 54 c4 78 e9 03 23 d3 fd f4 20 bd b2 ....T.x..#... ..
00000210 34 9c 63 83 04 a6 22 4c 95 8b 93 f8 bb b8 15 01 4.c..."L........
00000220 42 e6 11 22 fa 7f 3d b4 1e cc 3b c8 4b d7 b9 7c B.."..=...;.K..|
00000230 93 16 53 d9 2d 7c 3a aa 09 dd ee 58 cf 80 ef 22 ..S.-|:....X..."
00000240 e2 60 0b 8f 01 c6 e9 b3 a2 2c f2 a2 48 c2 16 ba .`.......,..H...
00000250 b5 62 42 fe 95 ad 80 24 b3 90 a7 23 7e 7d 4c de .bB....$...#~}L.
00000260 3e a6 c7 16 20 b9 0d 7b ef e2 21 d3 d9 fc dd d7 >... ..{..!.....
00000270 22 57 b3 97 a5 81 2f 18 22 06 83 bf cc e3 c3 12 "W..../.".......
00000280 09 fd 57 55 cd 08 42 14 4d e1 5c 42 02 ae 82 74 ..WU..B.M.\B...t
00000290 9f f2 3a 87 0e 61 65 d6 51 62 0d 99 38 75 06 30 ..:..ae.Qb..8u.0
000002a0 5a 98 82 11 9e 1b 40 44 14 34 06 d7 c1 24 b3 5e [email protected]...$.^
000002b0 06 f4 2a b1 7d ba bd 9b 9e ef 09 ed bf 5d ..*.}........]--- drivers/acpi/apei/ghes.c | 10 +++++++++- drivers/ras/ras.c | 6 +++++- 2 files changed, 14 insertions(+), 2 deletions(-)
drivers/acpi/apei/ghes.c +9 -1
@@ -564,7 +564,15 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,char *p; sec_sev =ghes_severity (gdata->error_severity); -log_arm_hw_error (err, sec_sev); +if (length >=sizeof (*err)) { +log_arm_hw_error (err, sec_sev); + }else { +pr_warn (FW_BUG "arm error length: %d\n" , length); +pr_warn (FW_BUG "length is too small\n" ); +pr_warn (FW_BUG "firmware-generated error record is incorrect\n" ); +return false; + } +if (sev !=GHES_SEV_RECOVERABLE || sec_sev !=GHES_SEV_RECOVERABLE )return false;
drivers/ras/ras.c +5 -1
@@ -72,7 +72,11 @@ void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev) ctx_err = (u8 *)ctx_info;for (n =0 ; n < err->context_info_num; n++) { - sz =sizeof (struct cper_arm_ctx_info ) + ctx_info->size; + sz =sizeof (struct cper_arm_ctx_info ); + +if (sz + (long )ctx_info - (long )err >= err->section_length) + sz += ctx_info->size; + ctx_info = (struct cper_arm_ctx_info *)((long )ctx_info + sz); ctx_len += sz; }
Signature · 1 line
2.52.0
Borislav Petkov
maintainerQuoted 7 lines · Mauro Carvalho Chehab
If the BIOS generates a very small ARM Processor Error, or an incomplete one, the current logic will fail to deferrence
err->section_length and ctx_info->size
Quoted 6 lines
Add checks to avoid that. With such changes, those GHESv2 records won't cause OOPSes:
GUID: e19e3d16-bc11-11e4-9caa-c2051d5d46b0 CPER: 00000000 23 da a0 ce 9a 1b 92 d7 08 2b 32 08 7b 56 1b 23 #........+2.{V.#
Surely you can summarize this gibberish instead of putting it in the commit message.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 11 lines · Borislav Petkov
Quoted 10 lines · Mauro Carvalho Chehab
If the BIOS generates a very small ARM Processor Error, or an incomplete one, the current logic will fail to deferrence
err->section_length and ctx_info->sizeAdd checks to avoid that. With such changes, those GHESv2 records won't cause OOPSes:
Quoted 6 lines
Quoted 3 lines
GUID: e19e3d16-bc11-11e4-9caa-c2051d5d46b0 CPER: 00000000 23 da a0 ce 9a 1b 92 d7 08 2b 32 08 7b 56 1b 23 #........+2.{V.#Surely you can summarize this gibberish instead of putting it in the commit message.
The dump is a summary. I can expand them if you prefer:
This one is:
Valid : cea0da23
Error Info num : 1b9a
Context Info num : d792
Section Length : 08322b08
Error affinity level : 7b
Reserved : 231b56MPIDR_EL1 : d7f357b623aac1d5MIDR_EL1 : bcdafd2bea32727a
Running State : e4e3524e
PSCI State : 75532115
Processor Error Info 0
Version : e7
Length : d0
valid : 2230
type : de
multiple-error : dbcc
flags : ba
error-info : f0e4896d9956243c
virt-addr : 255bbcba784df3ac
phy-addr : af8aee20ac2c9ce5
Processor Error Info 1
Version : d3
Length : c1
valid : 0209
type : fd
multiple-error : 26a0
flags : e4
error-info : faf1afaf12d14b1b
virt-addr : 88467ce57d7100ab
phy-addr : 5f8f03da196e35d7
Processor Error Info 2
Version : 50
Length : 51
valid : cf68
type : 59
multiple-error : 6d1a
flags : 91
error-info : f4ee81125d53e813
virt-addr : ef5c45c3b3aede7c
phy-addr : 130b2ac5f1c82129
Processor Error Info 3
Version : 9f
Length : 17
valid : cf56
type : f2
multiple-error : ec2b
flags : 32
error-info : 33db30acbc2ee037
virt-addr : ac0b7c397fda89c0
phy-addr : cb050f9ae8a5f94f
Processor Error Info 4
Version : 96
Length : cb
valid : 731a
type : 1f
multiple-error : f40a
flags : b5
error-info : 2f2943cd6b3f020c
virt-addr : fbeb0d2f2a18bb9e
phy-addr : 8b121af646c12a80
Processor Error Info 5
Version : 72
Length : 87
valid : 94d0
type : 17
multiple-error : fcb6
flags : 2d
error-info : 81d1cf1d5d5a074f
virt-addr : 4a539ab2f341ddd6
phy-addr : phy-addr: N/A
And the second one is:
Valid : 39b2d733
Error Info num : aa26
Context Info num : 4c70
Section Length : d6bbcfbf
Error affinity level : d5
Reserved : 4d5931MPIDR_EL1 : 780488095a3ee67dMIDR_EL1 : 5229b03dae164778
Running State : d9c2523e
PSCI State : 7061046e
Processor Error Info 0
Version : 42
Length : 83
valid : cdc9
type : 45
multiple-error : c3ad
flags : b6
error-info : 5ff24bfba736d03d
virt-addr : 15270577f27f908d
phy-addr : 5da8507f1872c8c0
Processor Error Info 1
Version : 03
Length : 4f
valid : 2721
type : 06
multiple-error : 29e5
flags : bd
error-info : 31713035d16f3402
virt-addr : 38da90747c1e221f
phy-addr : 7f206ee0ede15a70
Processor Error Info 2
Version : cb
Length : 05
valid : 0282
type : a1
multiple-error : 75d9
flags : 66
error-info : 7ab39560b97d62c4
virt-addr : 8914ababb9fcc2e8
phy-addr : e67a83c79a658352
Processor Error Info 3
Version : 74
Length : 2f
valid : a4c5
type : 6a
multiple-error : 4639
flags : 06
error-info : 0e96f6f4b07cd49e
virt-addr : f02c4370d9c572da
phy-addr : c28907b8873fae0e
Processor Error Info 4
Version : dd
Length : 54
valid : 3ec4
type : 1a
multiple-error : ab0c
flags : ae
error-info : c880d741bc5a8953
virt-addr : 87994d3c55ab28ff
phy-addr : 5ddaf72ce811ce42
Processor Error Info 5
Version : d3
Length : 99
valid : 114e
type : 86
multiple-error : fcd7
flags : 36
error-info : f645ba4659a08fd1
virt-addr : 8ff1920d3e530341
phy-addr : 20cc5cae52454998
Processor Error Info 6
Version : f7
Length : 08
valid : 3b2b
type : c0
multiple-error : 4c3d
flags : 16
error-info : 126a1eecf5a8b295
virt-addr : 2e3f39d35ce4273a
phy-addr : 0f12ea75ee9cd762
Processor Error Info 7
Version : cf
Length : 09
valid : 068a
type : 02
multiple-error : e623
flags : 3a
error-info : ee10f7fa6320cea2
virt-addr : a0b47d9412515c83
phy-addr : a1e1ba92699a99a9
Processor Error Info 8
Version : 60
Length : d3
valid : 5798
type : fb
multiple-error : 3488
flags : 7a
error-info : 70952dae73d0612e
virt-addr : 70b957b1a032b500
phy-addr : 1e5da6147837bcf4
Processor Error Info 9
Version : fa
Length : a8
valid : e854
type : 8b
multiple-error : ea00
flags : a9
error-info : 31ee9be8e9e6a405
virt-addr : d63c05f14192b118
phy-addr : 0cf115434ced7dfa
Processor Error Info 10
Version : 77
Length : c2
valid : 5427
type : 2e
multiple-error : b6e0
flags : 44
error-info : 61630ad6fc5a8c73
virt-addr : b57d2446fe5b75b3
phy-addr : 1dc535177d9a8385
Processor Error Info 11
Version : 69
Length : dc
valid : 1db0
type : 61
multiple-error : 10b3
flags : 95
error-info : 2709522c06f946e1
virt-addr : 822be010981302c6
phy-addr : 04a1d4b37ef15c74
Processor Error Info 12
Version : 58
Length : 43
valid : 3660
type : a8
multiple-error : 227b
flags : e7
error-info : 890b23acfb9cf2e8
virt-addr : 82a404206aaa4918
phy-addr : d9d8854296e768c3
Processor Error Info 13
Version : fc
Length : d6
valid : a4b3
type : 5b
multiple-error : 0297
flags : f0
error-info : 096630aa6386d369
virt-addr : d432e6b2e2361f7a
phy-addr : 5431e03da268698d
Processor Error Info 14
Version : 95
Length : e6
valid : 7682
type : 13
multiple-error : 6c0b
flags : d2
error-info : eec3685677453604
virt-addr : 00e73d0a1ca3dbb7
phy-addr : e978c454b499dac0
Processor Error Info 15
Version : 03
Length : 23
valid : fdd3
type : f4
multiple-error : bd20
flags : b2
error-info : 4c22a60483639c34
virt-addr : 0115b8bbf8938b95
phy-addr : b43d7ffa2211e642
Processor Error Info 16
Version : 1e
Length : cc
valid : c83b
type : 4b
multiple-error : b9d7
flags : 7c
error-info : aa3a7c2dd9531693
virt-addr : 22ef80cf58eedd09
phy-addr : b3e9c6018f0b60e2
Processor Error Info 17
Version : a2
Length : 2c
valid : a2f2
type : 48
multiple-error : 16c2
flags : ba
error-info : 2480ad95fe4262b5
virt-addr : de4c7d7e23a790b3
phy-addr : 7b0db92016c7a63e
Processor Error Info 18
Version : ef
Length : e2
valid : d321
type : d9
multiple-error : ddfc
flags : d7
error-info : 182f81a597b35722
virt-addr : 12c3e3ccbf830622
phy-addr : 144208cd5557fd09
Processor Error Info 19
Version : 4d
Length : e1
valid : 425c
type : 02
multiple-error : 82ae
flags : 74
error-info : d665610e873af29f
virt-addr : 30067538990d6251
phy-addr : 44401b9e1182985a
Processor Error Info 20
Version : 14
Length : 34
valid : d706
type : c1
multiple-error : b324
flags : 5e
error-info : 9bbdba7db12af406
virt-addr : virt-addr: N/A
phy-addr : phy-addr: N/A
Both are incomplete records, and were crafted to validate problems at the GHES parser.
On both dumps, "N/A" means it went past the buffer area.
The above output stops the dump before trying to parse a next struct once N/A is reached.
Signature · 2 lines
Thanks, Mauro
Borislav Petkov
maintainerQuoted 1 line · Mauro Carvalho Chehab
The dump is a summary. I can expand them if you prefer:
I said "summarize" not expand.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette