Support for Intel temperature sensors (DTS)
PATCH v3 1/3 x86/cpu-policy: Infrastructure for CPUID leaf 0x6
In reply to Teddy AstieFrom: Jan Beulich <[email protected]>
--- xen/include/xen/lib/x86/cpu-policy.h | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)
xen/include/xen/lib/x86/cpu-policy.h +26 -1
@@ -121,7 +121,32 @@ struct cpu_policy uint64_t :64, :64; /* Leaf 0x3 - PSN. */ uint64_t :64, :64; /* Leaf 0x4 - Structured Cache. */ uint64_t :64, :64; /* Leaf 0x5 - MONITOR. */ - uint64_t :64, :64; /* Leaf 0x6 - Therm/Perf. */ + +/* Leaf 0x6 - Therm/Perf. */ +struct { +uint32_t /* a */ + dts:1 , + turbo:1 , + arat:1, + :4 , + hwp:1 , + hwp_notification:1 , + hwp_activity_window:1 , + hwp_epp:1 , + hwp_plr:1, + :1 , + hdc:1, + :2 , + hwp_peci:1, + :2 , + hw_feedback:1, + :12 ; + uint32_t /* b */:32; + uint32_t /* c */ aperfmperf:1, + :31 ; + uint32_t /* d */:32; + } pm; + uint64_t :64, :64; /* Leaf 0x7 - Structured Features. */ uint64_t :64, :64; /* Leaf 0x8 - rsvd */ uint64_t :64, :64; /* Leaf 0x9 - DCA */
Signature · 10 lines
2.51.2 -- Teddy Astie | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
PATCH v3 3/3 xenpm: Add get-intel-temp subcommand
In reply to Teddy Astieget-intel-temp allows querying the per-core CPU temperature and per-package one on Intel processors (as usual Dom0 drivers cannot work due to misalignment between Dom0 vCPU and pCPUs).
--- tools/misc/xenpm.c | 91 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 90 insertions(+), 1 deletion(-)
tools/misc/xenpm.c +90 -1
@@ -30,6 +30,7 @@#include <inttypes.h> #include <sys/time.h> +#include <xen/asm/msr-index.h> #include <xen-tools/common-macros.h> #define MAX_PKG_RESIDENCIES 12
@@ -37,6 +38,7 @@static xc_interface *xc_handle;static unsigned int max_cpu_nr; +static xc_physinfo_t physinfo;/* help message */ void show_help (void )
@@ -93,6 +95,7 @@ void show_help(void)" units default to \"us\" if unspecified.\n" " truncates un-representable values.\n" " 0 lets the hardware decide.\n" +" get-intel-temp [cpuid] get Intel CPU temperature of <cpuid> or all\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n"
@@ -1354,6 +1357,92 @@ void enable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +static int fetch_dts_temp (xc_interface *xch,uint32_t cpu,bool package,int *temp) +{ +xc_resource_entry_t entries[2 ] = { + (xc_resource_entry_t ){ + .idx = package ?MSR_PACKAGE_THERM_STATUS :MSR_IA32_THERM_STATUS + }, + (xc_resource_entry_t ){ .idx =MSR_TEMPERATURE_TARGET }, + }; +struct xc_resource_op ops = { + .cpu = cpu, + .entries = entries, + .nr_entries =2 , + }; +int tjmax; + +int ret =xc_resource_op (xch,1 , &ops); + +if ( ret <=0 ) +/* This CPU isn't online or can't query this MSR */ +return ret ?: -EOPNOTSUPP ; + +if ( ret ==2 ) + tjmax = (entries[1 ].val >>16 ) &0xff ; +else + { +/* +* The CPU doesn't support MSR_IA32_TEMPERATURE_TARGET, we assume it's 100 which +* is correct aside a few selected Atom CPUs. Check coretemp source code for more +* information. +*/ +fprintf (stderr,"[CPU%d] MSR_IA32_TEMPERATURE_TARGET is not supported, assume " +"tjmax=100°C, readings may be incorrect\n" , cpu); + tjmax =100 ; + } + + *temp = tjmax - ((entries[0 ].val >>16 ) &0xff ); +return 0 ; +} + + +void get_intel_temp (int argc,char *argv[]) +{ +int temp, cpu =-1 ; +unsigned int socket; +bool has_data = false; + +if ( argc >0 ) +parse_cpuid (argv[0 ], &cpu); + +if ( cpu !=-1 ) + { +if ( !fetch_dts_temp (xc_handle, cpu, false, &temp) ) +printf ("CPU%d: %d°C\n" , cpu, temp); +else +printf ("No data\n" ); +return ; + } + +/* Per socket measurement */ +for ( socket =0 , cpu =0 ; cpu < max_cpu_nr; + socket++, cpu += physinfo.cores_per_socket * physinfo.threads_per_core ) + { +if ( !fetch_dts_temp (xc_handle, cpu, true, &temp) ) + { + has_data = true; +printf ("Package%d: %d°C\n" , socket, temp); + } + } + +if ( has_data ) +/* Avoid inserting a trailing line if we have nothing */ +printf ("\n" ); + +for ( cpu =0 ; cpu < max_cpu_nr; cpu += physinfo.threads_per_core ) + { +if (fetch_dts_temp (xc_handle, cpu, false, &temp) ) +continue ; + + has_data = true; +printf ("CPU%d: %d°C\n" , cpu, temp); + } + +if ( !has_data ) +printf ("No data\n" ); +} +void disable_turbo_mode (int argc,char *argv[]) {int cpuid =-1 ;
@@ -1618,12 +1707,12 @@ struct { { "set-max-cstate", set_max_cstate_func}, { "enable-turbo-mode", enable_turbo_mode }, { "disable-turbo-mode", disable_turbo_mode }, + { "get-intel-temp", get_intel_temp }, };int main (int argc,char *argv[]) {int i, ret =0 ; -xc_physinfo_t physinfo;int nr_matches =0 ;int matches_main_options[ARRAY_SIZE (main_options)];
--
2.51.2
--
Teddy Astie | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
v3 cover Support for Intel temperature sensors (DTS)
The idea here is to expose the DTS sensors through XENPF_resource_op and expose it for the user through xenpm.
v3:
- use msr-index.h instead of adding defines to MSRs in xenpm
v2:
- moved userland part to xenpm
- use cpu policy infrastructure instead of inline cpuid
Teddy Astie (3):
x86/cpu-policy: Infrastructure for CPUID leaf 0x6 x86/platform: Expose DTS sensors MSR
xenpm: Add get-intel-temp subcommand
tools/misc/xenpm.c | 91 +++++++++++++++++++++++++++- xen/arch/x86/include/asm/msr-index.h | 3 + xen/arch/x86/platform_hypercall.c | 6 ++ xen/include/xen/lib/x86/cpu-policy.h | 27 ++++++++- 4 files changed, 125 insertions(+), 2 deletions(-)
Signature · 10 lines
2.51.2 -- Teddy Astie | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
PATCH v3 2/3 x86/platform: Expose DTS sensors MSR
Intel provide CPU sensors through "DTS" MSRs. As there MSR are core-specific (or package-specific), we can't reliably fetch them from Dom0 directly. Expose these MSR (if supported) through XENPF_resource_op so that it is accessible through hypercall.
--- xen/arch/x86/include/asm/msr-index.h | 3 +++ xen/arch/x86/platform_hypercall.c | 6 ++++++ 2 files changed, 9 insertions(+)
xen/arch/x86/include/asm/msr-index.h +3 -0
@@ -115,6 +115,9 @@#define MCU_OPT_CTRL_GDS_MIT_DIS (_AC(1, ULL) << 4)#define MCU_OPT_CTRL_GDS_MIT_LOCK (_AC(1, ULL) << 5) +#define MSR_TEMPERATURE_TARGET 0x000001a2 +#define MSR_PACKAGE_THERM_STATUS 0x000001b1 +#define MSR_FRED_RSP_SL0 0x000001cc#define MSR_FRED_RSP_SL1 0x000001cd#define MSR_FRED_RSP_SL2 0x000001ce
xen/arch/x86/platform_hypercall.c +6 -0
@@ -27,6 +27,7 @@#include <asm/current.h> #include <public/platform.h> #include <acpi/cpufreq/processor_perf.h> +#include <asm/cpu-policy.h> #include <asm/edd.h> #include <asm/microcode.h> #include <asm/mtrr.h>
@@ -86,6 +87,11 @@ static bool msr_read_allowed(unsigned int msr)case MSR_MCU_OPT_CTRL :return cpu_has_srbds_ctrl; + +case MSR_IA32_THERM_STATUS : +case MSR_TEMPERATURE_TARGET : +case MSR_PACKAGE_THERM_STATUS : +return raw_cpu_policy.basic.pm.dts; }if ( ppin_msr && msr == ppin_msr )
Signature · 10 lines
2.51.2 -- Teddy Astie | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
Re: [PATCH v3 1/3] x86/cpu-policy: Infrastructure for CPUID leaf 0x6
In reply to Teddy AstieQuoted 4 lines · Teddy Astie
From: Jan Beulich <[email protected]>
Signed-off-by Jan Beulich <[email protected]>Signed-off-by Teddy Astie <[email protected]>
My patch has a different title and a terse, but non-empty description. Imo you will want to simply re-base over it, integrating the minimal delta into what is now patch 2.
Jan
Re: [PATCH v3 2/3] x86/platform: Expose DTS sensors MSR
In reply to Teddy AstieQuoted 1 line · Teddy Astie
Intel provide CPU sensors through "DTS" MSRs. As there MSR are core-specific
Nit: s/there MSR/these MSRs/ ?
xen/arch/x86/platform_hypercall.c static bool msr_read_allowed(unsigned int msr) · line 94
Quoted 9 lines
xen/arch/x86/platform_hypercall.c +5
-0@@ -86,6 +87,11 @@ static bool msr_read_allowed(unsigned int msr)case MSR_MCU_OPT_CTRL :return cpu_has_srbds_ctrl; + +case MSR_IA32_THERM_STATUS : +case MSR_TEMPERATURE_TARGET : +case MSR_PACKAGE_THERM_STATUS : +return raw_cpu_policy.basic.pm.dts;
I'm pretty sure it was indicated before that the raw policy is likely wrong to use for anything like this. The host policy wants using instead, or else specific justification should be provided.
Jan
Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand
In reply to Teddy Astietools/misc/xenpm.c line 33
Quoted 7 lines · Teddy Astie
tools/misc/xenpm.c +1
-0@@ -30,6 +30,7 @@#include <inttypes.h> #include <sys/time.h> +#include <xen/asm/msr-index.h>
For this to not break non-x86 builds, don't you need to constrain the building of the tool to CONFIG_X86? (I have no clue why it is being built for Arm as well right now, as I don't see how it could provide any value there.)
Quoted 17 lines
tools/misc/xenpm.c +2
-0@@ -37,6 +38,7 @@static xc_interface *xc_handle;static unsigned int max_cpu_nr; +static xc_physinfo_t physinfo;/* help message */ void show_help (void )@@ -93,6 +95,7 @@ void show_help(void)" units default to \"us\" if unspecified.\n" " truncates un-representable values.\n" " 0 lets the hardware decide.\n" +" get-intel-temp [cpuid] get Intel CPU temperature of <cpuid> or all\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n"
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1362
Quoted 6 lines
tools/misc/xenpm.c +3
-0@@ -1354,6 +1357,92 @@ void enable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +static int fetch_dts_temp (xc_interface *xch,uint32_t cpu,bool package,int *temp) +{ +xc_resource_entry_t entries[2 ] = {
Is the 2 actually useful to have here?
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1363
Quoted 1 line
tools/misc/xenpm.c +1
-0+ (xc_resource_entry_t ){
Why these type specifiers? They shouldn't be needed in initializers (while they would be needed in assignments)?
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1371
Quoted 8 lines
tools/misc/xenpm.c +8
-0+ .idx = package ? MSR_PACKAGE_THERM_STATUS : MSR_IA32_THERM_STATUS + }, + (xc_resource_entry_t){ .idx = MSR_TEMPERATURE_TARGET }, + }; +struct xc_resource_op ops = { + .cpu = cpu, + .entries = entries, + .nr_entries = 2,
ARRAY_SIZE() please.
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1379
Quoted 8 lines
tools/misc/xenpm.c +8
-0+ }; +int tjmax; + +int ret =xc_resource_op (xch,1 , &ops); + +if ( ret <=0 ) +/* This CPU isn't online or can't query this MSR */ +return ret ?: -EOPNOTSUPP ;
xc_resource_op() doesn't return errno values, so by using -EOPNOTSUPP here you put the caller into a difficult position when actually looking at the return
value: Does -1 mean -1 or -EPERM?
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1389
Quoted 9 lines
tools/misc/xenpm.c +9
-0+if ( ret ==2 ) + tjmax = (entries[1 ].val >>16 ) &0xff ; +else + { +/* +* The CPU doesn't support MSR_IA32_TEMPERATURE_TARGET, we assume it's 100 which +* is correct aside a few selected Atom CPUs. Check coretemp source code for more +* information. +*/
What is "coretemp source code" in xen.git context? (I understand you mean the Linux driver, but that also needs saying then.)
Further please respect line length limits, also ...
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1390
Quoted 1 line
tools/misc/xenpm.c +1
-0+ fprintf(stderr, "[CPU%d] MSR_IA32_TEMPERATURE_TARGET is not supported, assume "
... e.g. here.
Additionally there are still IA32 infixes here.
Finally, if this message triggers once on a system, it'll likely trigger once per get_intel_temp()'s loop iteration. Feels like a lot of (potential) noise.
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1400
Quoted 10 lines
tools/misc/xenpm.c +10
-0+ "tjmax=100°C, readings may be incorrect\n", cpu); + tjmax =100 ; + } + + *temp = tjmax - ((entries[0 ].val >>16 ) &0xff ); +return 0 ; +} + + +void get_intel_temp (int argc,char *argv[])
static?
Quoted 15 lines
tools/misc/xenpm.c +15
-0+{ +int temp, cpu =-1 ; +unsigned int socket; +bool has_data = false; + +if ( argc >0 ) +parse_cpuid (argv[0 ], &cpu); + +if ( cpu !=-1 ) + { +if ( !fetch_dts_temp (xc_handle, cpu, false, &temp) ) +printf ("CPU%d: %d°C\n" , cpu, temp); +else +printf ("No data\n" ); +return ;
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1425
Quoted 10 lines
tools/misc/xenpm.c +10
-0+ } + +/* Per socket measurement */ +for ( socket =0 , cpu =0 ; cpu < max_cpu_nr; + socket++, cpu += physinfo.cores_per_socket * physinfo.threads_per_core ) + { +if ( !fetch_dts_temp (xc_handle, cpu, true, &temp) ) + { + has_data = true; +printf ("Package%d: %d°C\n" , socket, temp);
%u please for socket.
Jan
Re: [PATCH v3 2/3] x86/platform: Expose DTS sensors MSR
In reply to Jan BeulichLe 10/12/2025 à 09:32, Jan Beulich a écrit :
Quoted 5 lines · Teddy Astie
Quoted 1 line
Intel provide CPU sensors through "DTS" MSRs. As there MSR are core-specific
Nit: s/there MSR/these MSRs/ ?
fixed
Quoted 14 lines
xen/arch/x86/platform_hypercall.c static bool msr_read_allowed(unsigned int msr) · line 94
Quoted 9 lines
xen/arch/x86/platform_hypercall.c +5
-0@@ -86,6 +87,11 @@ static bool msr_read_allowed(unsigned int msr)case MSR_MCU_OPT_CTRL :return cpu_has_srbds_ctrl; + +case MSR_IA32_THERM_STATUS : +case MSR_TEMPERATURE_TARGET : +case MSR_PACKAGE_THERM_STATUS : +return raw_cpu_policy.basic.pm.dts;I'm pretty sure it was indicated before that the raw policy is likely wrong to use for anything like this. The host policy wants using instead, or else specific justification should be provided.
Indeed, host_cpu_policy is intended here.
Quoted 1 line
Jan
--
Teddy Astie | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand
In reply to Jan BeulichLe 10/12/2025 à 09:50, Jan Beulich a écrit :
Quoted 7 lines · Teddy Astie
Quoted 6 lines
tools/misc/xenpm.c +0
-0@@ -30,6 +30,7 @@#include <inttypes.h> #include <sys/time.h>
Quoted 6 lines
tools/misc/xenpm.c line 33
Quoted 1 line
tools/misc/xenpm.c +1
-0+#include <xen/asm/msr-index.h> For this to not break non-x86 builds, don't you need to constrain the building of the tool to
CONFIG_X86? (I have no clue why it is being built for Arm as well right now, as I don't see how it could provide any value there.)
I don't know what are the plans on that area for ARM, the only thing that seems supported right now is "get-cpu-topology".
Quoted 26 lines
Quoted 17 lines
tools/misc/xenpm.c +2
-0@@ -37,6 +38,7 @@static xc_interface *xc_handle;static unsigned int max_cpu_nr; +static xc_physinfo_t physinfo;/* help message */ void show_help (void )@@ -93,6 +95,7 @@ void show_help(void)" units default to \"us\" if unspecified.\n" " truncates un-representable values.\n" " 0 lets the hardware decide.\n" +" get-intel-temp [cpuid] get Intel CPU temperature of <cpuid> or all\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n" tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1362
Quoted 6 lines
tools/misc/xenpm.c +3
-0@@ -1354,6 +1357,92 @@ void enable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +static int fetch_dts_temp (xc_interface *xch,uint32_t cpu,bool package,int *temp) +{ +xc_resource_entry_t entries[2 ] = {Is the 2 actually useful to have here?
Quoted 5 lines
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1363
Quoted 1 line
tools/misc/xenpm.c +1
-0+ (xc_resource_entry_t ){Why these type specifiers? They shouldn't be needed in initializers (while they would be needed in assignments)?
I wasn't aware that omitting this (xc_resource_entry_t) was accepted in this case.
Quoted 34 lines
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1371
Quoted 8 lines
tools/misc/xenpm.c +8
-0+ .idx = package ? MSR_PACKAGE_THERM_STATUS : MSR_IA32_THERM_STATUS + }, + (xc_resource_entry_t){ .idx = MSR_TEMPERATURE_TARGET }, + }; +struct xc_resource_op ops = { + .cpu = cpu, + .entries = entries, + .nr_entries = 2,
ARRAY_SIZE()please.tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1379
Quoted 8 lines
tools/misc/xenpm.c +8
-0+ }; +int tjmax; + +int ret =xc_resource_op (xch,1 , &ops); + +if ( ret <=0 ) +/* This CPU isn't online or can't query this MSR */ +return ret ?: -EOPNOTSUPP ;
xc_resource_op()doesn't return errno values, so by using-EOPNOTSUPPhere you put the caller into a difficult position when actually looking at the return
value: Does -1 mean -1 or-EPERM?tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1389
Quoted 9 lines
tools/misc/xenpm.c +9
-0+if ( ret ==2 ) + tjmax = (entries[1 ].val >>16 ) &0xff ; +else + { +/* +* The CPU doesn't support MSR_IA32_TEMPERATURE_TARGET, we assume it's 100 which +* is correct aside a few selected Atom CPUs. Check coretemp source code for more +* information. +*/
Quoted 3 lines
What is "coretemp source code" in xen.git context? (I understand you mean the Linux driver, but that also needs saying then.)
Is "Linux kernel's coretemp.c" better ?
Quoted 11 lines
Further please respect line length limits, also ...
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1390
Quoted 1 line
tools/misc/xenpm.c +1
-0+ fprintf(stderr, "[CPU%d] MSR_IA32_TEMPERATURE_TARGET is not supported, assume "... e.g. here.
Additionally there are still IA32 infixes here.
Finally, if this message triggers once on a system, it'll likely trigger once per get_intel_temp()'s loop iteration. Feels like a lot of (potential) noise.
In principle, different CPUs can have different results here. But we can still try to only display the message once (by using a static bool ?) as affected hardware will probably be quite uniform in that regard.
Quoted 32 lines
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1400
Quoted 10 lines
tools/misc/xenpm.c +10
-0+ "tjmax=100°C, readings may be incorrect\n", cpu); + tjmax =100 ; + } + + *temp = tjmax - ((entries[0 ].val >>16 ) &0xff ); +return 0 ; +} + + +void get_intel_temp (int argc,char *argv[])static?
Quoted 19 lines
tools/misc/xenpm.c +19
-0+{ +int temp, cpu =-1 ; +unsigned int socket; +bool has_data = false; + +if ( argc >0 ) +parse_cpuid (argv[0 ], &cpu); + +if ( cpu !=-1 ) + { +if ( !fetch_dts_temp (xc_handle, cpu, false, &temp) ) +printf ("CPU%d: %d°C\n" , cpu, temp); +else +printf ("No data\n" ); +return ; + } + +/* Per socket measurement */ + for ( socket = 0, cpu = 0; cpu < max_cpu_nr;
Quoted 9 lines
tools/misc/xenpm.c void enable_turbo_mode(int argc, char *argv[]) · line 1425
Quoted 6 lines
tools/misc/xenpm.c +6
-0+ socket++, cpu += physinfo.cores_per_socket * physinfo.threads_per_core ) + { +if ( !fetch_dts_temp (xc_handle, cpu, true, &temp) ) + { + has_data = true; +printf ("Package%d: %d°C\n" , socket, temp);%u please for socket.
Ok for this (and the other adjustments).
Quoted 1 line
Jan
--
Teddy Astie | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand
In reply to Jan BeulichLe 10/12/2025 à 09:50, Jan Beulich a écrit :
Quoted 3 lines
xc_resource_op()doesn't return errno values, so by using-EOPNOTSUPPhere you put the caller into a difficult position when actually looking at the return
value: Does -1 mean -1 or-EPERM?
That's a bit unfortunate as xc_resource_op() can return either -1 or some -errno; so -1 could be either -EPERM or a internal failure of xc_resource_op and we can't really know.
One thing is certain is that if xc_resource_op() returns ret >= 0, there is no failure aside that we may have no data (e.g no MSR yields a value).
--
Teddy Astie | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand
In reply to Teddy AstieQuoted 8 lines · Teddy Astie
Le 10/12/2025 à 09:50, Jan Beulich a écrit :
Quoted 7 lines · Teddy Astie
Quoted 6 lines
tools/misc/xenpm.c +0
-0@@ -30,6 +30,7 @@#include <inttypes.h> #include <sys/time.h>
Quoted 8 lines
Quoted 5 lines
tools/misc/xenpm.c line 33
Quoted 1 line
tools/misc/xenpm.c +1
-0+#include <xen/asm/msr-index.h> For this to not break non-x86 builds, don't you need to constrain the building of the tool to
CONFIG_X86? (I have no clue why it is being built for Arm as well right now, as I don't see how it could provide any value there.)I don't know what are the plans on that area for ARM, the only thing that seems supported right now is "get-cpu-topology".
Anthony and/or the Arm maintainers will then need to decide whether the tool wants to continue to be kept building for non-x86.
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
tools/misc/xenpm.c +9
-0+if ( ret ==2 ) + tjmax = (entries[1 ].val >>16 ) &0xff ; +else + { +/* +* The CPU doesn't support MSR_IA32_TEMPERATURE_TARGET, we assume it's 100 which +* is correct aside a few selected Atom CPUs. Check coretemp source code for more +* information. +*/
Quoted 4 lines
Quoted 2 lines
What is "coretemp source code" in xen.git context? (I understand you mean the Linux driver, but that also needs saying then.)
Is "Linux kernel's
coretemp.c" better ?
Yes.
Jan
Re: [PATCH v3 3/3] xenpm: Add get-intel-temp subcommand
In reply to Teddy AstieQuoted 8 lines · Teddy Astie
Le 10/12/2025 à 09:50, Jan Beulich a écrit :
Quoted 3 lines
xc_resource_op()doesn't return errno values, so by using-EOPNOTSUPPhere you put the caller into a difficult position when actually looking at the return
value: Does -1 mean -1 or-EPERM?That's a bit unfortunate as
xc_resource_op()can return either -1 or some -errno; so -1 could be either-EPERMor a internal failure ofxc_resource_opand we can't really know.
Can it? Assuming do_platform_op() and do_multicall_op() behave correctly, I can't see any problematic return.
Jan
Quoted 2 lines · Teddy Astie
The idea here is to expose the DTS sensors through
XENPF_resource_opand expose it for the user through xenpm.
If this is something exposed to users, I think we should update the CHANGELOG.
Thanks.
~ Oleksii
Quoted 19 lines
v3:
- usemsr-index.hinstead of adding defines to MSRs in xenpmv2:
- moved userland part to xenpm
- use cpu policy infrastructure instead of inline cpuidTeddy Astie (3):
x86/cpu-policy: Infrastructure for CPUID leaf0x6x86/platform: Expose DTS sensors MSR
xenpm: Add get-intel-temp subcommandtools/misc/xenpm.c | 91 +++++++++++++++++++++++++++- xen/arch/x86/include/asm/msr-index.h | 3 + xen/arch/x86/platform_hypercall.c | 6 ++ xen/include/xen/lib/x86/cpu-policy.h | 27 ++++++++- 4 files changed, 125 insertions(+), 2 deletions(-)