Skip to contentSkip to conversation

Add Device Tree binding and nodes for Agilex5/Agilex SOC FCS configuration.

PATCH In review [email protected] 3 participants 11 messages Dec 12, 2025 – Dec 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Add Device Tree binding and nodes for Agilex5/Agilex SOC FCS configuration.

From: "Wang, Hang Suan" <[email protected]>

This patch series introduces necessary Device Tree (DT) support for the Soc/Hardware FPGA Crypto Service (fcs) functionality across the Altera Agilex SoC families. This feature allows the kernel to identify, interact and communicate with the high-speed FPGA hardware without interruption or software overhead.

The series structured as follows:
Patch 1: Introduces the core YAML schema binding for a generic agilex5, soc-fcs-config miscellaneous device.
Patch 2: Add fcs property to the existing stratix10-svc firmware binding. Patch 3&4: Add the fcs nodes to the respective Agilex5 and Agilex DT files.

---
Notes:
This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

---
Wang, Hang Suan (4):
dt-bindings: misc: agilex5-soc-fcs-config: Add binding
dt-bindings: firmware: stratix10-svc: add fcs-config property
arm64: dts: socfpga: agilex5: add fcs node
arm64: dts: socfpga: agilex: add fcs node

 .../firmware/intel,stratix10-svc.yaml         |  4 +++
 .../misc/intel,agilex5-soc-fcs-config.yaml    | 32 +++++++++++++++++++
 MAINTAINERS                                   |  5 +++
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi |  4 +++
 .../arm64/boot/dts/intel/socfpga_agilex5.dtsi |  5 +++
 5 files changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/intel,agilex5-soc-fcs-config.yaml
Signature · 1 line
2.43.7
#1 lore raw

PATCH 1/4 dt-bindings: misc: agilex5-soc-fcs-config: Add binding

From: "Wang, Hang Suan" <[email protected]>

Soc/Hardware FPGA crypto services (fcs) by ensuring optimal performance, secure isolation, and robust system management. This will allow dedicated system resources to communicate with the high-speed FPGA hardware without interruption or software overhead.

This results in faster, more secure, and consistent cryptographic operations compared to running the services entirely on the general-purpose CPU.

---

---
 .../misc/intel,agilex5-soc-fcs-config.yaml    | 32 +++++++++++++++++++
 MAINTAINERS                                   |  5 +++
 2 files changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/intel,agilex5-soc-fcs-config.yaml
Documentation/devicetree/bindings/misc/intel,agilex5-soc-fcs-config.yaml new file +32 -0
new file mode 100644
index 000000000000..10cd793f8fc5
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/misc/intel,agilex5-soc-fcs-config.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Altera SoC FPGA Crypto Service features
+
+maintainers:
+  - Wang Hang Suan <[email protected]>
+  - Balsundar Ponnusamy <[email protected]>
+  - Sagar Khadgi <[email protected]>
+  - Santosh Male <[email protected]>
+  - Mahesh Rao <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - intel,agilex5-soc-fcs-config
+      - intel,agilex-soc-fcs-config
+
+additionalProperties: false
+
+required:
+  - compatible
+
+examples:
+  - |
+    fcs_config: fcs-config {
+      compatible = "intel,agilex5-soc-fcs-config";
+    };
+
MAINTAINERS +5 -0
index 46126ce2f968..2208d611f73f 100644
@@ -923,6 +923,11 @@ ALPS PS/2 TOUCHPAD DRIVER
 R:	Pali Rohár <[email protected]>
 F:	drivers/input/mouse/alps.*
 
+ALTERA FPGA CRYPTO SERVICE DRIVER
+M:	Hang Suan Wang <[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/misc/intel,agilex5-soc-fcs-config.yaml
+
 ALTERA MAILBOX DRIVER
 M:	Tien Sung Ang <[email protected]>
 S:	Maintained
Signature · 1 line
2.43.7
#5 lore raw

PATCH 3/4 arm64: dts: socfpga: agilex5: add fcs node

In reply to [email protected]

From: "Wang, Hang Suan" <[email protected]>

Altera new SoC/Hardware FPGA Crypto Service (fcs) provide hardware crypto features through mailbox. Hence, enable fcs driver inside the firmware node for agilex devices.

---

---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi +5 -0
index 1f5d560f97b2..05520f819ea8 100644
@@ -90,6 +90,11 @@ fpga_mgr: fpga-mgr {
 				compatible = "intel,agilex5-soc-fpga-mgr",
 					     "intel,agilex-soc-fpga-mgr";
 			};
+
+			fcs_config: fcs-config {
+				compatible = "intel,agilex5-soc-fcs-config";
+			};
+
 		};
 	};
 
Signature · 1 line
2.43.7
#3 lore raw

PATCH 2/4 dt-bindings: firmware: stratix10-svc: add fcs-config property

In reply to [email protected]

From: "Wang, Hang Suan" <[email protected]>

Altera SoC FPGA Crypto Service (fcs) provide hardware crypto features through mailbox. Fcs property has to be added to compliance with device tree schema fcs bindings and driver.

---

---
 .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml +4 -0
index b42cfa78b28b..c105f8dc4b7d 100644
@@ -62,6 +62,10 @@ properties:
     $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
     description: Optional child node for fpga manager to perform fabric configuration.
 
+  fcs-config:
+    $ref: /schemas/misc/intel,agilex5-soc-fcs-config.yaml
+    description: Optional child node for fcs Fpga Crypto Service (fcs) to perform SoC Crypto Engine.
+
 required:
   - compatible
   - method
Signature · 1 line
2.43.7
#6 lore raw

PATCH 4/4 arm64: dts: socfpga: agilex: add fcs node

In reply to [email protected]

From: "Wang, Hang Suan" <[email protected]>

Altera new SoC/Hardware FPGA Crypto Service (fcs) provide hardware crypto features through mailbox. Hence, enable fcs driver inside the firmware node for agilex devices.

---

---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +4 -0
index 0dfbafde8822..3ee2f7eb7ea3 100644
@@ -69,6 +69,10 @@ svc {
 			fpga_mgr: fpga-mgr {
 				compatible = "intel,agilex-soc-fpga-mgr";
 			};
+
+			fcs_config: fcs-config {
+				compatible = "intel,agilex-soc-fcs-config";
+			};
 		};
 	};
 
Signature · 1 line
2.43.7
#7 lore raw
In reply to [email protected]

Please disregard this submission.
Apologizes for inconvenience caused.

---

Quoted 34 lines · On 12/12/2025 7:35 pm, [email protected] wrote:

From: "Wang, Hang Suan" <[email protected]>

This patch series introduces necessary Device Tree (DT) support for the Soc/Hardware FPGA Crypto Service (fcs) functionality across the Altera Agilex SoC families. This feature allows the kernel to identify, interact and communicate with the high-speed FPGA hardware without interruption or software overhead.

The series structured as follows:
Patch 1: Introduces the core YAML schema binding for a generic agilex5, soc-fcs-config miscellaneous device.
Patch 2: Add fcs property to the existing stratix10-svc firmware binding. Patch 3&4: Add the fcs nodes to the respective Agilex5 and Agilex DT files.

---
Notes:
This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

---
Wang, Hang Suan (4):
dt-bindings: misc: agilex5-soc-fcs-config: Add binding
dt-bindings: firmware: stratix10-svc: add fcs-config property
arm64: dts: socfpga: agilex5: add fcs node
arm64: dts: socfpga: agilex: add fcs node

  .../firmware/intel,stratix10-svc.yaml         |  4 +++
  .../misc/intel,agilex5-soc-fcs-config.yaml    | 32 +++++++++++++++++++
  MAINTAINERS                                   |  5 +++
  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi |  4 +++
  .../arm64/boot/dts/intel/socfpga_agilex5.dtsi |  5 +++
  5 files changed, 50 insertions(+)

create mode 100644 Documentation/devicetree/bindings/misc/intel,agilex5-soc-fcs-config.yaml

#2 lore raw

Re: [PATCH 1/4] dt-bindings: misc: agilex5-soc-fcs-config: Add binding

In reply to [email protected]
Quoted 11 lines · On 12/12/2025 12:35, [email protected] wrote:

From: "Wang, Hang Suan" <[email protected]>

Soc/Hardware FPGA crypto services (fcs) by ensuring optimal performance, secure isolation, and robust system management. This will allow dedicated system resources to communicate with the high-speed FPGA hardware without interruption or software overhead.

This results in faster, more secure, and consistent cryptographic operations compared to running the services entirely on the general-purpose CPU.

You don't have resources there, so that's not a real device... And above explanation does not help me at all. Please carefully read slides for DTS 101 talk and writing bindings doc.

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH 2/4] dt-bindings: firmware: stratix10-svc: add fcs-config property

In reply to [email protected]
Quoted 5 lines · On 12/12/2025 12:35, [email protected] wrote:

From: "Wang, Hang Suan" <[email protected]>

Altera SoC FPGA Crypto Service (fcs) provide hardware crypto features through mailbox. Fcs property has to be added to compliance with device tree schema fcs bindings and driver.

Last sentence is completely redundant. If you add new devices for some "compliance" you do it wrong. We don't build hardware for "dt compliance"...

Quoted 12 lines

---

---
 .../devicetree/bindings/firmware/intel,stratix10-svc.yaml     | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml +0 -0
index b42cfa78b28b..c105f8dc4b7d 100644

Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml properties: · line 67

Quoted 6 lines
Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml +3 -0
@@ -62,6 +62,10 @@ properties:
     $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
     description: Optional child node for fpga manager to perform fabric configuration.
 
+  fcs-config:
+    $ref: /schemas/misc/intel,agilex5-soc-fcs-config.yaml
+    description: Optional child node for fcs Fpga Crypto Service (fcs) to perform SoC Crypto Engine.

You need to wrap according to Linux coding style. Anyway, above schema is NAKed so is this child.

Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml properties: · line 71

Quoted 4 lines
Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml +1 -0
+
 required:
   - compatible
   - method

Best regards,
Krzysztof

#8 lore raw
In reply to Wang, Hang Suan
Quoted 3 lines · Hang Suan

Please disregard this submission.
Apologizes for inconvenience caused.

I already wasted time on this and then found you don't want to post it... Recently Altera started sending poor quality patches, so can you get some internal trainings so you (as a company) follow correct process and know how to do upstream?

Best regards,
Krzysztof

#9 lore raw
In reply to [email protected]
Quoted 8 lines · On 12/12/2025 12:35, [email protected] wrote:

From: "Wang, Hang Suan" <[email protected]>

This patch series introduces necessary Device Tree (DT) support for the Soc/Hardware FPGA Crypto Service (fcs) functionality across the Altera Agilex SoC families. This feature allows the kernel to identify, interact and communicate with the high-speed FPGA hardware without interruption or software overhead.

Quoted 5 lines

The series structured as follows:
Patch 1: Introduces the core YAML schema binding for a generic agilex5, soc-fcs-config miscellaneous device.
Patch 2: Add fcs property to the existing stratix10-svc firmware binding. Patch 3&4: Add the fcs nodes to the respective Agilex5 and Agilex DT files.

You cc-ed fake addresses:

Your message to [email protected] couldn't be delivered.

Don't do this. Your internal stuff should never be mixed with upstream, because I do not see reason why we should keep filtering bounces from your internal email boces.

Best regards,
Krzysztof

#10 lore raw
In reply to [email protected]
Quoted 26 lines · On Fri, 12 Dec 2025, [email protected] wrote:

From: "Wang, Hang Suan" <[email protected]>

This patch series introduces necessary Device Tree (DT) support for the Soc/Hardware FPGA Crypto Service (fcs) functionality across the Altera Agilex SoC families. This feature allows the kernel to identify, interact and communicate with the high-speed FPGA hardware without interruption or software overhead.

The series structured as follows:
Patch 1: Introduces the core YAML schema binding for a generic agilex5, soc-fcs-config miscellaneous device.
Patch 2: Add fcs property to the existing stratix10-svc firmware binding. Patch 3&4: Add the fcs nodes to the respective Agilex5 and Agilex DT files.

---
Notes:
This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

---
Wang, Hang Suan (4):
dt-bindings: misc: agilex5-soc-fcs-config: Add binding
dt-bindings: firmware: stratix10-svc: add fcs-config property
arm64: dts: socfpga: agilex5: add fcs node
arm64: dts: socfpga: agilex: add fcs node

Quoted 5 lines
 .../firmware/intel,stratix10-svc.yaml         |  4 +++
 .../misc/intel,agilex5-soc-fcs-config.yaml    | 32 +++++++++++++++++++
 MAINTAINERS                                   |  5 +++
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi |  4 +++
 .../arm64/boot/dts/intel/socfpga_agilex5.dtsi |  5 +++

Why am I receiving this?

Signature · 1 line
Lee Jones [李琼斯]