Skip to contentSkip to conversation

Add eMMC support for Stratix 10 SoCDK

PATCH Superseded [email protected] 3 participants 6 messages Jan 26 – Feb 24

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover Add eMMC support for Stratix 10 SoCDK

From: Ng Tze Yee <[email protected]>

The first patch adds the device tree binding documentation for the new board compatible string. The second patch introduces a new base device tree include file (socfpga_stratix10_socdk.dtsi) containing common board configurations, and the eMMC-specific device tree file (socfpga_stratix10_socdk_emmc.dts) that includes the base dtsi along with eMMC controller configuration.

This follows a hierarchical structure:
- socfpga_stratix10.dtsi: SoC-level definitions
- socfpga_stratix10_socdk.dtsi: Board-level common configurations
- socfpga_stratix10_socdk_emmc.dts: eMMC daughter board specifics

Changes in v5:
- Move Acked-by's above the Signed-off-by: and remove the empty line between them.
- No code change

Changes in v4:
- Included Acked-by from Rob Herring and Krzysztof Kozlowski in the second patch commit message
- No code change

Changes in v3:
- Refactor socfpga_stratix10_socdk.dts to use the new common dtsi file, eliminating code duplication
- Move gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi to socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC daughter board variant
- Fix PHY address in socfpga_stratix10_socdk.dts from @0 to @4

Changes in v2:
- Introduced socfpga_stratix10_socdk.dtsi for common board settings
- Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the binding documentation for broader compatibility

Ng Tze Yee (2):
dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC
variant
arm64: dts: socfpga: stratix10: Add emmc support

 .../devicetree/bindings/arm/altera.yaml       |  6 ++
 arch/arm64/boot/dts/altera/Makefile           |  1 +
 .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +--------------
 .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++
 .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++++++
 5 files changed, 161 insertions(+), 65 deletions(-)
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v5 1/2 dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC variant

From: Ng Tze Yee <[email protected]>

Stratix 10 devkit support a separate eMMC daughter card. Add compatible string for the Stratix 10 SoCDK eMMC daughter board with "altr,socfpga-stratix10-socdk" as a fallback, since this variant is based on the standard SoCDK board.

---
Changes in v5:
- Move Acked-by's above the Signed-off-by: and remove the empty line between them.
- No code change

Changes in v4:
- Included Acked-by from Rob Herring and Krzysztof Kozlowski in the commit message
- No code change

Changes in v2:
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the binding documentation for broader compatibility

---
 Documentation/devicetree/bindings/arm/altera.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/altera.yaml +6 -0
index db61537b7115..2097f6a524c8 100644
@@ -81,6 +81,12 @@ properties:
               - altr,socfpga-stratix10-swvp
           - const: altr,socfpga-stratix10
 
+      - description: Stratix 10 SoCDK eMMC variant
+        items:
+          - const: altr,socfpga-stratix10-socdk-emmc
+          - const: altr,socfpga-stratix10-socdk
+          - const: altr,socfpga-stratix10
+
       - description: SoCFPGA VT
         items:
           - const: altr,socfpga-vt
Signature · 1 line
2.25.1
#2 lore raw

PATCH v5 2/2 arm64: dts: socfpga: stratix10: Add emmc support

In reply to [email protected]

From: Ng Tze Yee <[email protected]>

The Stratix10 devkit supports a separate eMMC daughter card. The eMMC daughter card replaces the SDMMC slot that is on the default daughter card and thus requires a separate board dts file.

---
Changes in v3:
- Refactored socfpga_stratix10_socdk.dts to use socfpga_stratix10_socdk.dtsi for common board configurations, eliminating code duplication
- Moved gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi back to socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC daughter board variant and not common to all Stratix 10 SoCDK boards
- Fixed PHY address in socfpga_stratix10_socdk.dts from @0 to @4

Changes in v2:
- Introduced socfpga_stratix10_socdk.dtsi for common board settings
- Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the socfpga_stratix10_socdk_emmc.dts

---
 arch/arm64/boot/dts/altera/Makefile           |  1 +
 .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +--------------
 .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++
 .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++++++
 4 files changed, 155 insertions(+), 65 deletions(-)
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
arch/arm64/boot/dts/altera/Makefile +1 -0
index 1bf0c472f6b4..540bb5ae746b 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
+				socfpga_stratix10_socdk_emmc.dtb \
 				socfpga_stratix10_socdk_nand.dtb \
 				socfpga_stratix10_swvp.dtb
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts +2 -65

95 lines not on this page · raw message

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi new file +71 -0

71 lines not on this page · raw message

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts new file +81 -0

81 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw
In reply to [email protected]
Quoted 43 lines · Tze Yee

From: Ng Tze Yee <[email protected]>

The first patch adds the device tree binding documentation for the new board compatible string. The second patch introduces a new base device tree include file (socfpga_stratix10_socdk.dtsi) containing common board configurations, and the eMMC-specific device tree file (socfpga_stratix10_socdk_emmc.dts) that includes the base dtsi along with eMMC controller configuration.

This follows a hierarchical structure:
- socfpga_stratix10.dtsi: SoC-level definitions
- socfpga_stratix10_socdk.dtsi: Board-level common configurations
- socfpga_stratix10_socdk_emmc.dts: eMMC daughter board specifics

Changes in v5:
- Move Acked-by's above the Signed-off-by: and remove the empty line between them.
- No code change

Changes in v4:
- Included Acked-by from Rob Herring and Krzysztof Kozlowski in the second patch commit message
- No code change

Changes in v3:
- Refactor socfpga_stratix10_socdk.dts to use the new common dtsi file, eliminating code duplication
- Move gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi to socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC daughter board variant
- Fix PHY address in socfpga_stratix10_socdk.dts from @0 to @4

Changes in v2:
- Introduced socfpga_stratix10_socdk.dtsi for common board settings
- Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the binding documentation for broader compatibility

Ng Tze Yee (2):
dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC
variant
arm64: dts: socfpga: stratix10: Add emmc support

Quoted 9 lines
  .../devicetree/bindings/arm/altera.yaml       |  6 ++
  arch/arm64/boot/dts/altera/Makefile           |  1 +
  .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +--------------
  .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++
  .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++++++
  5 files changed, 161 insertions(+), 65 deletions(-)

create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts

Hi maintainers,

I would like to gently ping on this patch series that was submitted. The series has received Acked-by from Rob Herring and Krzysztof Kozlowski for the dt-bindings patch in v4, and all requested changes have been addressed in v5.

Patch series link:
https://lore.kernel.org/all/[email protected]/

Could you please let me know if there are any concerns or additional changes needed for this series to be merged?

Thanks for your time and consideration.

Best regards,
Tze Yee

maintainer
#4 lore raw
Quoted 61 lines · Tze Yee
Quoted 43 lines · Tze Yee

From: Ng Tze Yee <[email protected]>

The first patch adds the device tree binding documentation for the new board compatible string. The second patch introduces a new base device tree include file (socfpga_stratix10_socdk.dtsi) containing common board configurations, and the eMMC-specific device tree file (socfpga_stratix10_socdk_emmc.dts) that includes the base dtsi along with eMMC controller configuration.

This follows a hierarchical structure:
- socfpga_stratix10.dtsi: SoC-level definitions
- socfpga_stratix10_socdk.dtsi: Board-level common configurations
- socfpga_stratix10_socdk_emmc.dts: eMMC daughter board specifics

Changes in v5:
- Move Acked-by's above the Signed-off-by: and remove the empty line between them.
- No code change

Changes in v4:
- Included Acked-by from Rob Herring and Krzysztof Kozlowski in the second patch commit message
- No code change

Changes in v3:
- Refactor socfpga_stratix10_socdk.dts to use the new common dtsi file, eliminating code duplication
- Move gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi to socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC daughter board variant
- Fix PHY address in socfpga_stratix10_socdk.dts from @0 to @4

Changes in v2:
- Introduced socfpga_stratix10_socdk.dtsi for common board settings
- Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the binding documentation for broader compatibility

Ng Tze Yee (2):
dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC
variant
arm64: dts: socfpga: stratix10: Add emmc support

Quoted 9 lines
   .../devicetree/bindings/arm/altera.yaml       |  6 ++
   arch/arm64/boot/dts/altera/Makefile           |  1 +
   .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +--------------
   .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++
   .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++++++
   5 files changed, 161 insertions(+), 65 deletions(-)

create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts

Hi maintainers,

I would like to gently ping on this patch series that was submitted. The series has received Acked-by from Rob Herring and Krzysztof Kozlowski for the dt-bindings patch in v4, and all requested changes have been addressed in v5.

Quoted 8 lines

Patch series link:
https://lore.kernel.org/all/[email protected]/

Could you please let me know if there are any concerns or additional changes needed for this series to be merged?

Thanks for your time and consideration.

This series look good to me, but can you rebase it to v7.0-rc1? I'm getting a conflict.

Thanks,
Dinh

#5 lore raw
Quoted 79 lines · Dinh Nguyen

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Quoted 73 lines · Tze Yee
Quoted 51 lines · Tze Yee

From: Ng Tze Yee <[email protected]>

The first patch adds the device tree binding documentation for the new board compatible string. The second patch introduces a new base device tree include file (socfpga_stratix10_socdk.dtsi) containing common board configurations, and the eMMC-specific device tree file (socfpga_stratix10_socdk_emmc.dts) that includes the base dtsi along with eMMC controller configuration.

This follows a hierarchical structure:
- socfpga_stratix10.dtsi: SoC-level definitions
- socfpga_stratix10_socdk.dtsi: Board-level common configurations
- socfpga_stratix10_socdk_emmc.dts: eMMC daughter board specifics

Changes in v5:
- Move Acked-by's above the Signed-off-by: and remove the empty line between them.
- No code change

Changes in v4:
- Included Acked-by from Rob Herring and Krzysztof Kozlowski in the second
    patch commit message
- No code change

Changes in v3:
- Refactor socfpga_stratix10_socdk.dts to use the new common dtsi file, eliminating code duplication
- Move gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi to socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC daughter board variant
- Fix PHY address in socfpga_stratix10_socdk.dts from @0 to @4

Changes in v2:
- Introduced socfpga_stratix10_socdk.dtsi for common board settings
- Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
- Added fallback compatible string "altr,socfpga-stratix10-socdk" in the binding documentation for broader compatibility

Ng Tze Yee (2):
    dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC
      variant
    arm64: dts: socfpga: stratix10: Add emmc support

   .../devicetree/bindings/arm/altera.yaml       |  6 ++ arch/arm64/boot/dts/altera/Makefile           |  1 + .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +-------------- .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++ .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++
++++

Quoted 6 lines
   5 files changed, 161 insertions(+), 65 deletions(-)

   create mode 100644 arch/arm64/boot/dts/altera/
socfpga_stratix10_socdk.dtsi
   create mode 100644 arch/arm64/boot/dts/altera/
socfpga_stratix10_socdk_emmc.dts

Hi maintainers,

I would like to gently ping on this patch series that was submitted. The series has received Acked-by from Rob Herring and Krzysztof Kozlowski for the dt-bindings patch in v4, and all requested changes have been addressed in v5.

Patch series link:
https://nam10.safelinks.protection.outlook.com/?
url=https%3A%2F%2Flore.kernel.org%2Fall%2Fcover.1769407657.git.tzeyee.ng%40altera.com%2F&data=05%7C02%7Ctze.yee.ng%40altera.com%7Ca5952cfcf8144658570108de730a160a%7Cfbd72e03d4a54110adce614d51f2077a%7C0%7C0%7C639074684367785778%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=8LCuZ3fAz%2BVHkMZsvtS75e5k0dnt5pC%2BhRUJpv3pCRk%3D&reserved=0

Could you please let me know if there are any concerns or additional changes needed for this series to be merged?

Quoted 8 lines
Quoted 2 lines

Thanks for your time and consideration.

This series look good to me, but can you rebase it to v7.0-rc1? I'm getting a conflict.

Thanks,
Dinh

Hi Dinh,

Sure! I've rebase to v7.0-rc1 and re-submit v6 patch. Patch series link:
https://lore.kernel.org/all/[email protected]/

Thanks,
Regards,
Tze Yee