Skip to contentSkip to conversation

efi_vars: Implement SPI Flash storage for EFI

PATCH Superseded Michal Simek 3 participants 10 messages Feb 3 – Feb 4

v6 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v6 cover efi_vars: Implement SPI Flash storage for EFI

This is updated series based on v3 version sent here
https://lore.kernel.org/all/[email protected]/

that's why I am continuing on v4 instead of starting from scratch.

Tested on kv260 with saving variables to location where User MTD partition is.
CONFIG_EFI_VARIABLE_SF_STORE=y
CONFIG_EFI_RT_VOLATILE_STORE=y CONFIG_EFI_VARIABLE_SF_OFFSET=0x22a0000

In Linux:

root@som:~# mount | grep efivars
none on /sys/firmware/efi/efivars type efivarfs (rw,relatime)
root@som:~# printf '\x07\x00\x00\x00Hello' \
  | sudo tee /sys/firmware/efi/efivars/TestVar-12345678-1234-1234-1234-123456789abc
Helloroot@som:~#
root@som:~# dd if=/sys/firmware/efi/efivars/VarToFile-b2ac5fc9-92b7-4acd-aeac-11e818c3130c \
       of=/tmp/vars skip=4 bs=1
1352+0 records in
1352+0 records out
1352 bytes (1.4 kB, 1.3 KiB) copied, 0.380992 s, 3.5 kB/s
root@som:~# flashcp /tmp/vars /dev/mtd16
root@som:~# reboot

Reboot and then in U-Boot:

ZynqMP> pri -e
...
TestVar:

    12345678-1234-1234-1234-123456789abc (12345678-1234-1234-1234-123456789abc)
    NV|BS|RT, DataSize = 0x5
    00000000: 48 65 6c 6c 6f                                   Hello

...

Thanks,
Michal

Changes in v6:
- Return EFI_SUCCESS in efi_set_variable_int() when CONFIG_EFI_VARIABLE_NO_STORE is enabled
- sed -i 's/efi_var_read/efi_var_from/g'
- sed -i 's/efi_var_write/efi_var_to_storage/g'
- sed -i 's/efi_var_read/efi_var_from/g'
- sed -i 's/efi_var_write/efi_var_to_storage/g'

Changes in v5:
- Invert logic in efi_variable.c and avoid #if

Changes in v4:
- New patch based on review comments from v3
- Extend Kconfig description
- Extend commit message and describe efivar missing part
- use unify methods for reading/writing variable

Changes in v3:
- Fixed compiler warnings.

Changes in v2:
- Refactored efi_var_file to move common parts out as requested
- Changed ifdefs to use CONFIG_IS_DEFINED
- Fixed typos

Michal Simek (1):
efi_var: Unify read/write access helper function

Shantur Rathore (2):
efi_var_file: refactor to move buffer functions
efi_vars: Implement SPI Flash store

 include/efi_variable.h          | 18 +++----
 lib/efi_loader/Kconfig          | 34 +++++++++++-
 lib/efi_loader/Makefile         |  3 +-
 lib/efi_loader/efi_var_common.c | 42 +++++++++++++++
 lib/efi_loader/efi_var_file.c   | 65 ++---------------------
 lib/efi_loader/efi_var_sf.c     | 92 +++++++++++++++++++++++++++++++++
 lib/efi_loader/efi_variable.c   | 19 ++++---
 7 files changed, 195 insertions(+), 78 deletions(-)
 create mode 100644 lib/efi_loader/efi_var_sf.c
Signature · 3 lines
2.43.0

base-commit: e206e3ab2ad266935b81f5e9d3af2ed47b866826
#2 lore raw

PATCH v6 2/3 efi_var: Unify read/write access helper function

efi_var_to/from_file() suggest method where variables are placed. But there is no reason for it and generic name can be used to wire also different locations for variables.

---

Changes in v6:
- sed -i 's/efi_var_read/efi_var_from/g'
- sed -i 's/efi_var_write/efi_var_to_storage/g'

Changes in v4:
- New patch based on review comments from v3

 include/efi_variable.h        | 13 ++++---------
 lib/efi_loader/efi_var_file.c |  8 ++++----
 lib/efi_loader/efi_variable.c |  4 ++--
 3 files changed, 10 insertions(+), 15 deletions(-)
include/efi_variable.h +4 -9
index ee68fa4a885f..2b06505b8654 100644
@@ -137,13 +137,11 @@ struct efi_var_file {
 };
 
 /**
- * efi_var_to_file() - save non-volatile variables as file
- *
- * File ubootefi.var is created on the EFI system partion.
+ * efi_var_to_storage() - save non-volatile variables
  *
  * Return:	status code
  */
-efi_status_t efi_var_to_file(void);
+efi_status_t efi_var_to_storage(void);
 
 /**
  * efi_var_collect() - collect variables in buffer
@@ -178,17 +176,14 @@ efi_status_t __maybe_unused efi_var_collect(struct efi_var_file **bufp, loff_t *
 efi_status_t efi_var_restore(struct efi_var_file *buf, bool safe);
 
 /**
- * efi_var_from_file() - read variables from file
- *
- * File ubootefi.var is read from the EFI system partitions and the variables
- * stored in the file are created.
+ * efi_var_from() - read variables
  *
  * In case the file does not exist yet or a variable cannot be set EFI_SUCCESS
  * is returned.
  *
  * Return:	status code
  */
-efi_status_t efi_var_from_file(void);
+efi_status_t efi_var_from(void);
 
 /**
  * efi_var_mem_init() - set-up variable list
lib/efi_loader/efi_var_file.c +4 -4
index d32edaac277d..d012d6a18b02 100644
@@ -43,13 +43,13 @@ static efi_status_t __maybe_unused efi_set_blk_dev_to_system_partition(void)
 }
 
 /**
- * efi_var_to_file() - save non-volatile variables as file
+ * efi_var_to_storage() - save non-volatile variables as file
  *
  * File ubootefi.var is created on the EFI system partion.
  *
  * Return:	status code
  */
-efi_status_t efi_var_to_file(void)
+efi_status_t efi_var_to_storage(void)
 {
 	efi_status_t ret;
 	struct efi_var_file *buf;
@@ -85,7 +85,7 @@ out:
 }
 
 /**
- * efi_var_from_file() - read variables from file
+ * efi_var_from() - read variables from file
  *
  * File ubootefi.var is read from the EFI system partitions and the variables
  * stored in the file are created.
@@ -98,7 +98,7 @@ out:
  *
  * Return:	status code
  */
-efi_status_t efi_var_from_file(void)
+efi_status_t efi_var_from(void)
 {
 	struct efi_var_file *buf;
 	loff_t len;
lib/efi_loader/efi_variable.c +2 -2
index 6e45134c61bf..42f3ba901556 100644
@@ -404,7 +404,7 @@ efi_status_t efi_set_variable_int(const u16 *variable_name,
 		if (IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE))
 			return EFI_SUCCESS;
 
-		efi_var_to_file();
+		efi_var_to_storage();
 	}
 
 	return EFI_SUCCESS;
@@ -599,7 +599,7 @@ efi_status_t efi_init_variables(void)
 		return ret;
 
 	if (!IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE)) {
-		ret = efi_var_from_file();
+		ret = efi_var_from();
 		if (ret != EFI_SUCCESS)
 			return ret;
 	}
Signature · 1 line
2.43.0
#9 lore raw

PATCH v6 3/3 efi_vars: Implement SPI Flash store

In reply to Michal Simek

From: Shantur Rathore <[email protected]>

Currently U-Boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash.

https://github.com/rhboot/efivar
is not updated to support this location that's why you can mimic it by running:
dd if=/sys/firmware/efi/efivars/VarToFile-b2ac5fc9-92b7-4acd-aeac-11e818c3130c \
of=/tmp/vars skip=4 bs=1
flashcp /tmp/vars /dev/mtdX

where mtdX should match location defined by CONFIG_EFI_VARIABLE_SF_OFFSET/CONFIG_EFI_VAR_BUF_SIZE.

---

Changes in v6:
- sed -i 's/efi_var_read/efi_var_from/g'
- sed -i 's/efi_var_write/efi_var_to_storage/g'

Changes in v4:
- Extend Kconfig description
- Extend commit message and describe efivar missing part
- use unify methods for reading/writing variable

Changes in v3:
- Fixed compiler warnings.

Changes in v2:
- Refactored efi_var_file to move common parts out as requested
- Changed ifdefs to use CONFIG_IS_DEFINED
- Fixed typos

 lib/efi_loader/Kconfig      | 34 +++++++++++++-
 lib/efi_loader/Makefile     |  1 +
 lib/efi_loader/efi_var_sf.c | 92 +++++++++++++++++++++++++++++++++++++
 3 files changed, 126 insertions(+), 1 deletion(-)
 create mode 100644 lib/efi_loader/efi_var_sf.c
lib/efi_loader/Kconfig +33 -1
index 13e44be1d067..bb40cc899a13 100644
@@ -123,6 +123,24 @@ config EFI_VARIABLE_FILE_STORE
 	  Select this option if you want non-volatile UEFI variables to be
 	  stored as file /ubootefi.var on the EFI system partition.
 
+config EFI_VARIABLE_SF_STORE
+	bool "Store non-volatile UEFI variables in SPI Flash"
+	depends on SPI_FLASH
+	help
+	  Select this option if you want non-volatile UEFI variables to be
+	  stored in SPI Flash.
+
+	  Define CONFIG_EFI_VARIABLE_SF_OFFSET as offset in SPI Flash to use as
+	  the storage for variables. CONFIG_EFI_VAR_BUF_SIZE defines the space
+	  needed.
+
+	  Note that SPI Flash devices have a limited number of program/erase
+	  cycles. Frequent updates to UEFI variables may cause excessive wear
+	  and can permanently damage the flash device, particularly on SPI NAND
+	  or low-end SPI NOR parts without wear leveling. This option should be
+	  used with care on such systems, and is not recommended for platforms
+	  where UEFI variables are updated frequently.
+
 config EFI_MM_COMM_TEE
 	bool "UEFI variables storage service via the trusted world"
 	depends on OPTEE
@@ -152,7 +170,7 @@ endchoice
 
 config EFI_RT_VOLATILE_STORE
 	bool "Allow variable runtime services in volatile storage (e.g RAM)"
-	depends on EFI_VARIABLE_FILE_STORE
+	depends on EFI_VARIABLE_FILE_STORE || EFI_VARIABLE_SF_STORE
 	help
 	  When EFI variables are stored on file we don't allow SetVariableRT,
 	  since the OS doesn't know how to write that file. At the same time
@@ -193,6 +211,20 @@ config FFA_SHARED_MM_BUF_ADDR
 	  the MM SP in secure world.
 	  It is assumed that the MM SP knows the address of the shared MM communication buffer.
 
+config EFI_VARIABLE_SF_OFFSET
+	hex "EFI variables in SPI flash offset"
+	depends on EFI_VARIABLE_SF_STORE
+	help
+	  Offset from the start of the SPI Flash where EFI variables will be stored.
+	  This should be aligned to the sector size of SPI Flash.
+
+config EFI_VARIABLE_SF_DEVICE_INDEX
+	int "Device Index for target SPI Flash"
+	default 0
+	help
+	  The index of SPI Flash device used for storing EFI variables. This would be
+	  needed if there are more than 1 SPI Flash devices available to use.
+
 config EFI_VARIABLES_PRESEED
 	bool "Initial values for UEFI variables"
 	depends on !COMPILE_TEST
lib/efi_loader/Makefile +1 -0
index ca1775eb03be..d73ad43951b1 100644
@@ -54,6 +54,7 @@ obj-y += efi_variable_tee.o
 else
 obj-y += efi_variable.o
 obj-$(CONFIG_EFI_VARIABLE_FILE_STORE) += efi_var_file.o
+obj-$(CONFIG_EFI_VARIABLE_SF_STORE) += efi_var_sf.o
 obj-$(CONFIG_EFI_VARIABLES_PRESEED) += efi_var_seed.o
 endif
 obj-y += efi_watchdog.o
lib/efi_loader/efi_var_sf.c new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
2.43.0
#1 lore raw

PATCH v6 1/3 efi_var_file: refactor to move buffer functions

In reply to Michal Simek

From: Shantur Rathore <[email protected]>

Currently efi_var_file.c has functions to store/read EFI variables to/from memory buffer. These functions can be used with other EFI variable stores so move them out to efi_var_common.c

---

Changes in v6:
- Return EFI_SUCCESS in efi_set_variable_int() when CONFIG_EFI_VARIABLE_NO_STORE is enabled

Changes in v5:
- Invert logic in efi_variable.c and avoid #if

 include/efi_variable.h          |  5 +++
 lib/efi_loader/Makefile         |  2 +-
 lib/efi_loader/efi_var_common.c | 42 ++++++++++++++++++++++++
 lib/efi_loader/efi_var_file.c   | 57 ---------------------------------
 lib/efi_loader/efi_variable.c   | 17 +++++++---
 5 files changed, 60 insertions(+), 63 deletions(-)
include/efi_variable.h +5 -0
index 4065cf45ecaf..ee68fa4a885f 100644
@@ -161,6 +161,11 @@ efi_status_t efi_var_to_file(void);
 efi_status_t __maybe_unused efi_var_collect(struct efi_var_file **bufp, loff_t *lenp,
 					    u32 check_attr_mask);
 
+/* GUID used by Shim to store the MOK database */
+#define SHIM_LOCK_GUID \
+	EFI_GUID(0x605dab50, 0xe046, 0x4300, \
+		 0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b, 0x23)
+
 /**
  * efi_var_restore() - restore EFI variables from buffer
  *
lib/efi_loader/Makefile +1 -1
index f490081f6542..ca1775eb03be 100644
@@ -53,7 +53,7 @@ ifeq ($(CONFIG_EFI_MM_COMM_TEE),y)
 obj-y += efi_variable_tee.o
 else
 obj-y += efi_variable.o
-obj-y += efi_var_file.o
+obj-$(CONFIG_EFI_VARIABLE_FILE_STORE) += efi_var_file.o
 obj-$(CONFIG_EFI_VARIABLES_PRESEED) += efi_var_seed.o
 endif
 obj-y += efi_watchdog.o
lib/efi_loader/efi_var_common.c +42 -0

51 lines not on this page · raw message

lib/efi_loader/efi_var_file.c +0 -57

89 lines not on this page · raw message

lib/efi_loader/efi_variable.c +12 -5
index f3533f4def3a..6e45134c61bf 100644
@@ -397,11 +397,15 @@ efi_status_t efi_set_variable_int(const u16 *variable_name,
 		ret = EFI_SUCCESS;
 
 	/*
-	 * Write non-volatile EFI variables to file
+	 * Write non-volatile EFI variables
 	 * TODO: check if a value change has occured to avoid superfluous writes
 	 */
-	if (attributes & EFI_VARIABLE_NON_VOLATILE)
+	if (attributes & EFI_VARIABLE_NON_VOLATILE) {
+		if (IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE))
+			return EFI_SUCCESS;
+
 		efi_var_to_file();
+	}
 
 	return EFI_SUCCESS;
 }
@@ -594,9 +598,12 @@ efi_status_t efi_init_variables(void)
 	if (ret != EFI_SUCCESS)
 		return ret;
 
-	ret = efi_var_from_file();
-	if (ret != EFI_SUCCESS)
-		return ret;
+	if (!IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE)) {
+		ret = efi_var_from_file();
+		if (ret != EFI_SUCCESS)
+			return ret;
+	}
+
 	if (IS_ENABLED(CONFIG_EFI_VARIABLES_PRESEED)) {
 		ret = efi_var_restore((struct efi_var_file *)
 				      __efi_var_file_begin, true);
Signature · 1 line
2.43.0
#3 lore raw

RE: [PATCH v6 2/3] efi_var: Unify read/write access helper function

In reply to Michal Simek

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Maarten

Quoted 134 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Michal Simek
Sent: Tuesday 3 February 2026 8:58
To: [email protected]; [email protected]
Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini <[email protected]>
Subject: [PATCH v6 2/3] efi_var: Unify read/write access helper function

efi_var_to/from_file() suggest method where variables are placed. But there is no reason for it and generic name can be used to wire also different locations for variables.

---

Changes in v6:
- sed -i 's/efi_var_read/efi_var_from/g'
- sed -i 's/efi_var_write/efi_var_to_storage/g'

Changes in v4:
- New patch based on review comments from v3

 include/efi_variable.h        | 13 ++++---------
 lib/efi_loader/efi_var_file.c |  8 ++++----
 lib/efi_loader/efi_variable.c |  4 ++--
 3 files changed, 10 insertions(+), 15 deletions(-)
include/efi_variable.h +2 -4
index ee68fa4a885f..2b06505b8654 100644
@@ -137,13 +137,11 @@ struct efi_var_file {
 };
 
 /**
- * efi_var_to_file() - save non-volatile variables as file
- *
- * File ubootefi.var is created on the EFI system partion.
+ * efi_var_to_storage() - save non-volatile variables
  *
  * Return:	status code
  */
-efi_status_t efi_var_to_file(void);
+efi_status_t efi_var_to_storage(void);
 
 /**
  * efi_var_collect() - collect variables in buffer
@@ -178,17 +176,14 @@ efi_status_t __maybe_unused

efi_var_collect(struct efi_var_file **bufp, loff_t *
efi_status_t efi_var_restore(struct efi_var_file *buf, bool safe);

/**
- * efi_var_from_file() - read variables from file
- *
- * File ubootefi.var is read from the EFI system partitions and the variables
- * stored in the file are created.
+ * efi_var_from() - read variables
*
* In case the file does not exist yet or a variable cannot be set EFI_SUCCESS
* is returned.
*
* Return: status code
*/

include/efi_variable.h +1 -1
-efi_status_t efi_var_from_file(void);
+efi_status_t efi_var_from(void);
 
 /**
  * efi_var_mem_init() - set-up variable list
lib/efi_loader/efi_var_file.c +2 -2
index d32edaac277d..d012d6a18b02 100644
@@ -43,13 +43,13 @@ static efi_status_t __maybe_unused
 efi_set_blk_dev_to_system_partition(void)
 }
 
 /**
- * efi_var_to_file() - save non-volatile variables as file
+ * efi_var_to_storage() - save non-volatile variables as file
  *
  * File ubootefi.var is created on the EFI system partion.
  *
  * Return:	status code
  */
-efi_status_t efi_var_to_file(void)
+efi_status_t efi_var_to_storage(void)
 {
 	efi_status_t ret;
lib/efi_loader/efi_var_file.c +2 -2
 	struct efi_var_file *buf;
@@ -85,7 +85,7 @@ out:
 }
 
 /**
- * efi_var_from_file() - read variables from file
+ * efi_var_from() - read variables from file
  *
  * File ubootefi.var is read from the EFI system partitions and the variables
  * stored in the file are created.
@@ -98,7 +98,7 @@ out:
  *
  * Return:	status code
  */
-efi_status_t efi_var_from_file(void)
+efi_status_t efi_var_from(void)
 {
 	struct efi_var_file *buf;
 	loff_t len;
lib/efi_loader/efi_variable.c +1 -1
index 6e45134c61bf..42f3ba901556 100644
@@ -404,7 +404,7 @@ efi_status_t efi_set_variable_int(const u16
 *variable_name,
 		if (IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE))
 			return EFI_SUCCESS;
 
-		efi_var_to_file();
+		efi_var_to_storage();
 	}
 
lib/efi_loader/efi_variable.c +1 -2
 	return EFI_SUCCESS;
@@ -599,7 +599,7 @@ efi_status_t efi_init_variables(void)
 		return ret;
 
 	if (!IS_ENABLED(CONFIG_EFI_VARIABLE_NO_STORE)) {
-		ret = efi_var_from_file();
+		ret = efi_var_from();
 		if (ret != EFI_SUCCESS)
 			return ret;
 	}
--

2.43.0

#4 lore raw

Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Hi,

Quoted 4 lines · Maarten Brock

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Ilias was asking about these names in v5 review.

Thanks,
Michal

#5 lore raw

RE: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Quoted 12 lines

-----Original Message-----
From: Michal Simek <[email protected]>
Sent: Tuesday 3 February 2026 11:10
To: Maarten Brock <[email protected]>; [email protected]; [email protected]
Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Hi,

Quoted 7 lines
Quoted 4 lines · Maarten Brock

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Ilias was asking about these names in v5 review.

I'm sure he meant something different from what you implemented.

Quoted 6 lines

I am ok with this with a small nit.
Can we rename efi_var_read/write to efi_var_from/to_storage? I want to make it clealer what these functions are used for

With the changes above

I think Ilias meant to use:
efi_var_from_storage & efi_var_to_storage
and not:
efi_var_from & efi_var_to_storage

Quoted 3 lines

Thanks,
Michal

Kind regards,
Maarten

#6 lore raw

Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Quoted 26 lines · Maarten Brock
Quoted 12 lines

-----Original Message-----
From: Michal Simek <[email protected]>
Sent: Tuesday 3 February 2026 11:10
To: Maarten Brock <[email protected]>; [email protected]; [email protected]
Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Hi,

Quoted 7 lines
Quoted 4 lines · Maarten Brock

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Ilias was asking about these names in v5 review.

I'm sure he meant something different from what you implemented.

Quoted 4 lines

I am ok with this with a small nit.
Can we rename efi_var_read/write to efi_var_from/to_storage? I want to make it clealer what these functions are used for

Quoted 7 lines
Quoted 2 lines

With the changes above

I think Ilias meant to use:
efi_var_from_storage & efi_var_to_storage
and not:
efi_var_from & efi_var_to_storage

You are likely right. Let me fix that.

Thanks,
Michal

#7 lore raw

Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

In reply to Maarten Brock
Quoted 27 lines · Maarten Brock
Quoted 13 lines

-----Original Message-----
From: Michal Simek <[email protected]>
Sent: Tuesday 3 February 2026 11:10
To: Maarten Brock <[email protected]>; [email protected]; [email protected]
Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Hi,

Quoted 7 lines
Quoted 4 lines · Maarten Brock

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Ilias was asking about these names in v5 review.

I'm sure he meant something different from what you implemented.

Quoted 4 lines

I am ok with this with a small nit.
Can we rename efi_var_read/write to efi_var_from/to_storage? I want to make it clealer what these functions are used for

Quoted 5 lines
Quoted 2 lines

With the changes above

I think Ilias meant to use:
efi_var_from_storage & efi_var_to_storage

Yes , thanks for claryfying this

/Ilias

Quoted 9 lines

and not:
efi_var_from & efi_var_to_storage

Quoted 3 lines

Thanks,
Michal

Kind regards,
Maarten

#8 lore raw

Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Quoted 28 lines · Ilias Apalodimas
Quoted 27 lines · Maarten Brock
Quoted 13 lines

-----Original Message-----
From: Michal Simek <[email protected]>
Sent: Tuesday 3 February 2026 11:10
To: Maarten Brock <[email protected]>; [email protected]; [email protected]
Cc: Ilias Apalodimas <[email protected]>; Heinrich Schuchardt <[email protected]>; Shantur Rathore <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v6 2/3] efi_var: Unify read/write access helper function

Hi,

Quoted 7 lines
Quoted 4 lines · Maarten Brock

Hello Michal,

Why are the new function names non-symmetrical?
efi_var_to_storage <-> efi_var_from ...

Ilias was asking about these names in v5 review.

I'm sure he meant something different from what you implemented.

Quoted 4 lines

I am ok with this with a small nit.
Can we rename efi_var_read/write to efi_var_from/to_storage? I want to make it clealer what these functions are used for

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

With the changes above

I think Ilias meant to use:
efi_var_from_storage & efi_var_to_storage

Yes , thanks for claryfying this

Take a look at v7.

M