Skip to contentSkip to conversation

riscv: dts: spacemit: Add PMIC regulators usb pcie

PATCH Superseded Han Gao 3 participants 9 messages Apr 2 – Apr 7

Subsystems (3)
Device tree bindings RISC-V RISC-V SpacemiT SoC Support

v5 of 10 Superseded Latest is v10 →

lore
Share & tools
lore

Han Gao

author
#0 lore raw

v5 cover riscv: dts: spacemit: Add PMIC regulators usb pcie

Changes in v5:
- Add Chukun Pan as co-author
- patch 2:
Rename regulator using Chukun version
Restore vcc_5v0
Restore vin-supply in vcc4v0
- patch 3:
Restore usb3_hub_5v and use the Chukun version, now called vcc5v0_usb30 Restore vdd-supply from USB hub nodes
- Link to v4: https://lore.kernel.org/linux-riscv/[email protected]/

Han Gao (3):
riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
riscv: dts: spacemit: Define the P1 PMIC regulators for OrangePi RV2
riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 193 ++++++++++++++++++
 1 file changed, 193 insertions(+)

base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
prerequisite-patch-id: ef6e9c7b5854d0c08066b72f9a7868db8c2140eb
prerequisite-patch-id: cfe3800f8c791ec4c63e070af9628e88e0fc31b9
prerequisite-patch-id: b76493e625ae257c8adcd67874178458420e4d47
prerequisite-patch-id: 88e01dc92c83bd88ddeb78891d3088209fed8d6b
prerequisite-patch-id: 60336d10ab8322c70596d0f046b6b5c54bb24b54
prerequisite-patch-id: 68c4d869548687dc115dd91e2ffb8f4c11482d86
prerequisite-patch-id: fdadcf964c2cb3406160edb579d99a8d5695f8e6
prerequisite-patch-id: 73b9e745338b0499b849fa4f7f9508987ab39a59
prerequisite-patch-id: cd26770c2160c3c31a406bd8a6b01ab666180ae0
prerequisite-patch-id: e5dfddc32cefae195692da8b80e19adf086e4ad7
prerequisite-patch-id: 7fd53cbe4977598f26148a4bb1cf692bbdb79a09
prerequisite-patch-id: 96ebac57bb29619b97fe95422206a685825618e9
prerequisite-patch-id: 00fac16b52f60383db3140e2885f3f7f8d14dd1a
prerequisite-patch-id: 3b7a60047b922c48e93599f621cb738856f42354
prerequisite-patch-id: 275c030b963be05dd1041451f539a130ce614277
prerequisite-patch-id: 93963424b0871e64276af0e0b2199b52e29b4603
prerequisite-patch-id: 8383188b1c01ed6280629faaa29c37d699ade241
prerequisite-patch-id: 5f8126b912b924d63d4a1e0c5eb42d212eb0d369
prerequisite-patch-id: e80af628a2e0b5f2eeb3cb1b5e7133d08bdd2c4e
prerequisite-patch-id: 0234a6dca15eb91f98a45a46604ce5b4935048a5

Signature · 1 line
2.47.3
author
#1 lore raw

PATCH v5 1/3 riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2

The adapter is used to access the SpacemiT P1 PMIC present in this board.

Signed-off-by Han Gao <[email protected]>
---
 arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +6 -0
index 7b7331cb3c72..93880ba7bdfe 100644
@@ -87,6 +87,12 @@ &pdma {
 	status = "okay";
 };
 
+&i2c8 {
+	pinctrl-0 = <&i2c8_cfg>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
Signature · 1 line
2.47.3
author
#2 lore raw

PATCH v5 2/3 riscv: dts: spacemit: Define the P1 PMIC regulators for OrangePi RV2

In reply to Han Gao

Define the DC power input and the 4v power as fixed regulator supplies.

Define the SpacemiT P1 PMIC voltage regulators and their constraints.

Co-developed-by Chukun Pan <[email protected]>
Signed-off-by Chukun Pan <[email protected]>
Signed-off-by Han Gao <[email protected]>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 107 ++++++++++++++++++
 1 file changed, 107 insertions(+)
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +107 -0
index 93880ba7bdfe..a6de3753b876 100644
@@ -23,6 +23,25 @@ chosen {
 		stdout-path = "serial0";
 	};
 
+	vcc_5v0: regulator-vcc-5v0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_5v0";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+
+	vcc4v0: regulator-vcc4v0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc4v0";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <4000000>;
+		regulator-max-microvolt = <4000000>;
+		vin-supply = <&vcc_5v0>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 

@@ -91,6 +110,94 @@ &i2c8 {
 	pinctrl-0 = <&i2c8_cfg>;
 	pinctrl-names = "default";
 	status = "okay";
+
+	pmic@41 {
+		compatible = "spacemit,p1";
+		reg = <0x41>;
+		interrupts = <64>;
+		vin1-supply = <&vcc4v0>;
+		vin2-supply = <&vcc4v0>;
+		vin3-supply = <&vcc4v0>;
+		vin4-supply = <&vcc4v0>;
+		vin5-supply = <&vcc4v0>;
+		vin6-supply = <&vcc4v0>;
+		aldoin-supply = <&vcc4v0>;
+		dldoin1-supply = <&buck5>;
+		dldoin2-supply = <&buck5>;
+
+		regulators {
+			buck1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck2 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck3_1v8: buck3 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck4 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck5: buck5 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck6 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			aldo1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+			};
+
+			dldo1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+			};
+
+			dldo4 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-always-on;
+			};
+
+			dldo5 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			dldo6 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-always-on;
+			};
+		};
+	};
 };
 
 &uart0 {
Signature · 1 line
2.47.3
author
#4 lore raw

PATCH v5 3/3 riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

In reply to Han Gao

Enable the DWC3 USB 3.0 controller and its associated usbphy2 on the OrangePi RV2 board.

The board utilizes a Genesys Logic GL3523 USB3.0 hub.

Define a 3.3v fixed voltage regulator for PCIe and enable PCIe and PHY-related Device Tree nodes for the OrangePi RV2.

Co-developed-by Chukun Pan <[email protected]>
Signed-off-by Chukun Pan <[email protected]>
Signed-off-by Han Gao <[email protected]>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +80 -0
index a6de3753b876..c19952e70c31 100644
@@ -23,6 +23,15 @@ chosen {
 		stdout-path = "serial0";
 	};
 
+	pcie_vcc_3v3: regulator-pcie-vcc3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "pcie_vcc3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
 	vcc_5v0: regulator-vcc-5v0 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_5v0";

@@ -42,6 +51,16 @@ vcc4v0: regulator-vcc4v0 {
 		vin-supply = <&vcc_5v0>;
 	};
 
+	vcc5v0_usb30: regulator-vcc5v0-usb30 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_usb30";
+		enable-active-high;
+		gpios = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc_5v0>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 

@@ -54,6 +73,10 @@ led1 {
 	};
 };
 
+&combo_phy {
+	status = "okay";
+};
+
 &eth0 {
 	phy-handle = <&rgmii0>;
 	phy-mode = "rgmii-id";

@@ -200,8 +223,65 @@ dldo6 {
 	};
 };
 
+&pcie1_phy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie1_3_cfg>;
+	status = "okay";
+};
+
+&pcie1_port {
+	phys = <&pcie1_phy>;
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+};
+
+&pcie1 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+	status = "okay";
+};
+
+&pcie2_phy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie2_4_cfg>;
+	status = "okay";
+};
+
+&pcie2_port {
+	phys = <&pcie2_phy>;
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+};
+
+&pcie2 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
 	status = "okay";
 };
+
+&usbphy2 {
+	status = "okay";
+};
+
+&usb_dwc3 {
+	dr_mode = "host";
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	hub_2_0: hub@1 {
+		compatible = "usb5e3,610";
+		reg = <0x1>;
+		peer-hub = <&hub_3_0>;
+		vdd-supply = <&vcc5v0_usb30>;
+	};
+
+	hub_3_0: hub@2 {
+		compatible = "usb5e3,620";
+		reg = <0x2>;
+		peer-hub = <&hub_2_0>;
+		vdd-supply = <&vcc5v0_usb30>;
+	};
+};
Signature · 1 line
2.47.3
maintainer
#5 lore raw

Re: [PATCH v5 3/3] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

Hi Han,

Quoted 104 lines · Han Gao

Enable the DWC3 USB 3.0 controller and its associated usbphy2 on the OrangePi RV2 board.

The board utilizes a Genesys Logic GL3523 USB3.0 hub.

Define a 3.3v fixed voltage regulator for PCIe and enable PCIe and PHY-related Device Tree nodes for the OrangePi RV2.

Co-developed-by Chukun Pan <[email protected]>
Signed-off-by Chukun Pan <[email protected]>
Signed-off-by Han Gao <[email protected]>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +55 -0
index a6de3753b876..c19952e70c31 100644
@@ -23,6 +23,15 @@ chosen {
 		stdout-path = "serial0";
 	};
 
+	pcie_vcc_3v3: regulator-pcie-vcc3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "pcie_vcc3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
 	vcc_5v0: regulator-vcc-5v0 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_5v0";

@@ -42,6 +51,16 @@ vcc4v0: regulator-vcc4v0 {
 		vin-supply = <&vcc_5v0>;
 	};
 
+	vcc5v0_usb30: regulator-vcc5v0-usb30 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_usb30";
+		enable-active-high;
+		gpios = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc_5v0>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 

@@ -54,6 +73,10 @@ led1 {
 	};
 };
 
+&combo_phy {
+	status = "okay";
+};
+
 &eth0 {
 	phy-handle = <&rgmii0>;
 	phy-mode = "rgmii-id";

@@ -200,8 +223,65 @@ dldo6 {
 	};
 };
 
+&pcie1_phy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie1_3_cfg>;
+	status = "okay";
+};
+
+&pcie1_port {
+	phys = <&pcie1_phy>;
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+};
+
+&pcie1 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+	status = "okay";
+};
+
+&pcie2_phy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie2_4_cfg>;
+	status = "okay";
+};
+
+&pcie2_port {
+	phys = <&pcie2_phy>;
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+};
+
+&pcie2 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
 	status = "okay";
 };

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts dldo6 { · line 272

Quoted 10 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +10 -0
+
+&usbphy2 {
+	status = "okay";
+};
+
+&usb_dwc3 {
+	dr_mode = "host";
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";

Can you put vbus-supply here? see Chukun's patch
http://lore.kernel.org/r/[email protected]

Quoted 5 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +5 -0
+
+	hub_2_0: hub@1 {
+		compatible = "usb5e3,610";
+		reg = <0x1>;
+		peer-hub = <&hub_3_0>;

..

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts

Quoted 1 line
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +1 -0
+		vdd-supply = <&vcc5v0_usb30>;

I think the vdd is vcc_5v0, while vcc5v0_usb30 is the vbus, if we check page 16 of RV2 schematics, GL3523-QFN75 (USB HUB)'s pin V5, VDDP directly connect to VCC_5V0

Quoted 13 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +9 -0
+	};
+
+	hub_3_0: hub@2 {
+		compatible = "usb5e3,620";
+		reg = <0x2>;
+		peer-hub = <&hub_2_0>;
+		vdd-supply = <&vcc5v0_usb30>;
+	};
+};
Signature · 1 line
2.47.3
Signature · 1 line
Yixun Lan (dlan)
#3 lore raw

Re: [PATCH v5 2/3] riscv: dts: spacemit: Define the P1 PMIC regulators for OrangePi RV2

In reply to Han Gao

Hi,

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts &i2c8 { · line 112

Quoted 4 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +0 -0
@@ -91,6 +110,94 @@ &i2c8 {
 	pinctrl-0 = <&i2c8_cfg>;
 	pinctrl-names = "default";
 	status = "okay";

Perhaps the previous i2c8 enabling patch could be merged with this one. For the floating sections, I suggest marking them as "not connected":

```
		regulators {
			buck1 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck2 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck3_1v8: buck3 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <1800000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck4_3v3: buck4 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3300000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck5: buck5 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			buck6 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3450000>;
				regulator-ramp-delay = <5000>;
				regulator-always-on;
			};

			aldo1 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3400000>;
				regulator-boot-on;
			};

			aldo2 {
				/* not connected */
			};

			aldo3 {
				/* not connected */
			};

			aldo4 {
				/* not connected */
			};

			dldo1 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3400000>;
				regulator-boot-on;
			};

			dldo2 {
				/* not connected */
			};

			dldo3 {
				/* not connected */
			};

			dldo4 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3400000>;
				regulator-always-on;
			};

			dldo5 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3400000>;
			};

			dldo6 {
				regulator-min-microvolt = <500000>;
				regulator-max-microvolt = <3400000>;
				regulator-always-on;
			};

			dldo7 {
				/* not connected */
			};
		};
```

Thanks,
Chukun

#6 lore raw

Re: [PATCH v5 3/3] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

In reply to Han Gao

Hi,

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts chosen { · line 33

Quoted 8 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +8 -0
+	pcie_vcc_3v3: regulator-pcie-vcc3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "pcie_vcc3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};

I would like to maintain the same property order as the regulator below, and add vin-supply:

```
	pcie_vcc3v3: pcie-vcc3v3 {
		compatible = "regulator-fixed";
		enable-active-high;
		gpios = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
		regulator-name = "pcie_vcc3v3";
		regulator-min-microvolt = <3300000>;
		regulator-max-microvolt = <3300000>;
		vin-supply = <&vcc_5v0>;
	};
```

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts dldo6 { · line 254

Quoted 5 lines

+&pcie1 {

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +3 -0
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
 
+&pcie2 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;

I think vpcie3v3-supply is not needed here. [1]

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts dldo6 { · line 278

Quoted 5 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +5 -0
+	hub_2_0: hub@1 {
+		compatible = "usb5e3,610";
+		reg = <0x1>;
+		peer-hub = <&hub_3_0>;
+		vdd-supply = <&vcc5v0_usb30>;

vdd-supply = <&vcc_5v0>;

Please refer to the schematic. [2]

[1] https://lore.kernel.org/linux-pci/u53qfrubgrcamiz35ox6lcdpp5bbzfwcsic466z5r6yyx6xz3n@c64nw2pegtfe/
[2] https://drive.google.com/drive/folders/1pcI_U0C3VJKTCg8A1zj08CwNbohnONSR

Thanks,
Chukun

maintainer
#7 lore raw

Re: [PATCH v5 3/3] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

Hi Chukun,

Quoted 13 lines · Chukun Pan

Hi,

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts chosen { · line 33

Quoted 8 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +8 -0
+	pcie_vcc_3v3: regulator-pcie-vcc3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "pcie_vcc3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};

I would like to maintain the same property order as the regulator below,

..

Quoted 2 lines

and add vin-supply:

I think Krzysztof will have objection on this, which isn't used by any device, so not really useful, see similar comment for "reg_dc_in" here
https://lore.kernel.org/all/[email protected]/

Quoted 2 lines

```

	pcie_vcc3v3: pcie-vcc3v3 {

please keep "regulator-" prefix, which is
pcie_vcc_3v3: regulator-pcie-vcc3v3 {

Quoted 7 lines
		compatible = "regulator-fixed";
		enable-active-high;
		gpios = <&gpio K1_GPIO(116) GPIO_ACTIVE_HIGH>;
		regulator-name = "pcie_vcc3v3";
		regulator-min-microvolt = <3300000>;
		regulator-max-microvolt = <3300000>;
		vin-supply = <&vcc_5v0>;

I'm not sure if there is any enforced rules on this? I can understand you are trying to sort them in alphabet order.. but I would personally prefer old way - in slightly logical order.. but I do have no strong preference..

Quoted 10 lines
	};

```

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts dldo6 { · line 254

Quoted 5 lines

+&pcie1 {

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +3 -0
+	vpcie3v3-supply = <&pcie_vcc_3v3>;
 
+&pcie2 {
+	vpcie3v3-supply = <&pcie_vcc_3v3>;

I think vpcie3v3-supply is not needed here. [1]

You right, can you send a patch to fix the same issue in tree? I was trying to fix vpcie3v3 warning, but realized not fixed all..

Quoted 8 lines

arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts dldo6 { · line 278

Quoted 6 lines
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +5 -0
+	hub_2_0: hub@1 {
+		compatible = "usb5e3,610";
+		reg = <0x1>;
+		peer-hub = <&hub_3_0>;
+		vdd-supply = <&vcc5v0_usb30>;

vdd-supply = <&vcc_5v0>;

right, I agree

Quoted 8 lines

Please refer to the schematic. [2]

[1] https://lore.kernel.org/linux-pci/u53qfrubgrcamiz35ox6lcdpp5bbzfwcsic466z5r6yyx6xz3n@c64nw2pegtfe/
[2] https://drive.google.com/drive/folders/1pcI_U0C3VJKTCg8A1zj08CwNbohnONSR

Thanks,
Chukun

Signature · 1 line
Yixun Lan (dlan)
#8 lore raw

Re: [PATCH v5 3/3] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2

Hi,

Quoted 2 lines

I think Krzysztof will have objection on this, which isn't used by any device, so not really useful, see similar comment for "reg_dc_in" here

Currently, at least it's used for USB hub vdd-supply. Since there's only this one, indicating a power source, I think it's acceptable.

Quoted 4 lines

I'm not sure if there is any enforced rules on this? I can understand you are trying to sort them in alphabet order.. but I would personally prefer old way - in slightly logical order.. but I do have no strong preference..

There are no strict rules, but I think it would be better to keep the same order as the regulators below within the same DT.

Thanks,
Chukun