net/smc: avoid early lgr access in smc_clc_wait_msg
Subsystems (5)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 net/smc: avoid early lgr access in smc_clc_wait_msg
From: Ruijie Li <[email protected]>
A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group.
The decline handling in smc_clc_wait_msg() updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged.
This preserves the existing sync_err handling for established link-group contexts and avoids touching link-group state before it is available.
--- net/smc/smc_clc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/smc/smc_clc.c +2 -2
@@ -788,8 +788,8 @@ int smc_clc_wait_msg(struct smc_sock *smc, void *buf, int buflen, dclc = (struct smc_clc_msg_decline *)clcm; reason_code =SMC_CLC_DECL_PEERDECL ; smc->peer_diagnosis =ntohl (dclc->peer_diagnosis); -if (((struct smc_clc_msg_decline *)buf)->hdr.typev2 & -SMC_FIRST_CONTACT_MASK ) { +if ((dclc->hdr.typev2 &SMC_FIRST_CONTACT_MASK ) && + smc->conn.lgr) { smc->conn.lgr->sync_err =1 ;smc_lgr_terminate_sched (smc->conn.lgr); }
Signature · 1 line
2.34.1
Quoted 13 lines · Ren Wei
From: Ruijie Li <[email protected]>
A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group.
The decline handling in
smc_clc_wait_msg()updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged.This preserves the existing
sync_errhandling for established link-group contexts and avoids touching link-group state before it is available.
Quoted 8 lines
Fixes 0cfdd8f92cac ("smc: connection and link group creation")Reported-by Yuan Tan <[email protected]>Reported-by Yifan Wu <[email protected]>Reported-by Juefei Pu <[email protected]>Reported-by Xin Liu <[email protected]>Signed-off-by Ruijie Li <[email protected]>Signed-off-by Ren Wei <[email protected]>
Best regards,
Dust
Quoted 21 lines
---
net/smc/smc_clc.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)net/smc/smc_clc.c +2
-2@@ -788,8 +788,8 @@ int smc_clc_wait_msg(struct smc_sock *smc, void *buf, int buflen, dclc = (struct smc_clc_msg_decline *)clcm; reason_code =SMC_CLC_DECL_PEERDECL ; smc->peer_diagnosis =ntohl (dclc->peer_diagnosis); -if (((struct smc_clc_msg_decline *)buf)->hdr.typev2 & -SMC_FIRST_CONTACT_MASK ) { +if ((dclc->hdr.typev2 &SMC_FIRST_CONTACT_MASK ) && + smc->conn.lgr) { smc->conn.lgr->sync_err =1 ;smc_lgr_terminate_sched (smc->conn.lgr); }Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Wed, 22 Apr 2026 23:40:18 +0800 you wrote:
From: Ruijie Li <[email protected]>
A CLC decline can be received while the handshake is still in an early stage, before the connection has been associated with a link group.
The decline handling in
smc_clc_wait_msg()updates link-group level sync state for first-contact declines, but that state only exists after link group setup has completed. Guard the link-group update accordingly and keep the per-socket peer diagnosis handling unchanged.[...]
Here is the summary with links:
- [net,1/1] net/smc: avoid early lgr access in smc_clc_wait_msg
https://git.kernel.org/netdev/net/c/5a8db80f721d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html