Skip to contentSkip to conversation

sc5xx Environment Cleanup and Fixes

PATCH Superseded Caleb Ethridge 2 participants 2 messages Apr 25 – Apr 29

lore
Share & tools
lore
#0 lore raw

v5 cover sc5xx Environment Cleanup and Fixes

This series performs a general cleanup of the default U-boot environment for sc5xx boards, stemming from the decision to no longer store the environment in the SPI flash. The environments for each board have been edited to contain the minimum number of commands needed for all supported boot modes to avoid confusion, and the default boot command synced to spi for all boards that support it. The filesystem for the SPI flash has also been changed from jffs2 to ubifs.

A bug with the Ethernet reset line on the sc594 has been fixed, and the sc573 has been renamed from the EZKIT to the EZLITE to match the name of the publically available board. EZKIT was only used internally before release. Preliminary binman support for sc5xx boards has been removed as it was unused and full support never added.

Changes in v5:
- Updated several commit messages for clarity
- Corrected load addresses for sc594-ezlite
- Added sc584-ezkit to USB support
- Removed now unused Kconfig options including SC5XX_FITIMAGE_OFFSET

Caleb Ethridge (14):
configs: sc5xx: Do not store environment in SPI flash
mach-sc5xx: Remove update commands from default environment
mach-sc5xx: Update boot commands
mach-sc5xx: Switch from tftp to wget
mach-sc5xx: Add USB boot command
mach-sc5xx: Remove preliminary binman support
dts: sc594: Fix gige-reset line on EZKIT
mach-sc5xx: sc573: Rename EZKIT board to EZLITE
mach-sc5xx: Update image load address
mach-sc5xx: Update SPI bootargs for ubifs
configs: sc5xx: Set default bootcmd to SPI boot
arm: sc5xx: Remove SC5XX_LOADADDR
arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and ramdisk_addr_r
mach-sc5xx: Remove unused image offset Kconfig options

Ozan Durgut (1):
arm: sc5xx: add missing boot env selectors

 arch/arm/dts/Makefile                         |   2 +-
 .../dts/{sc573-ezkit.dts => sc573-ezlite.dts} |   4 +-
 arch/arm/dts/sc594-som-ezkit.dts              |   2 +-
 arch/arm/dts/sc5xx.dtsi                       |  41 -------
 arch/arm/mach-sc5xx/Kconfig                   |  71 +-----------
 arch/arm/mach-sc5xx/init/dmcinit.c            |   2 +-
 board/adi/sc573-ezkit/sc573-ezkit.env         |  17 ---
 .../adi/{sc573-ezkit => sc573-ezlite}/Kconfig |   8 +-
 .../{sc573-ezkit => sc573-ezlite}/Makefile    |   2 +-
 .../sc573-ezlite.c}                           |   0
 board/adi/sc573-ezlite/sc573-ezlite.env       |  16 +++
 board/adi/sc584-ezkit/sc584-ezkit.env         |   9 +-
 board/adi/sc589-ezkit/sc589-ezkit.env         |   9 +-
 board/adi/sc589-mini/sc589-mini.env           |   9 +-
 board/adi/sc594-som-ezkit/sc594-som-ezkit.env |   9 +-
 .../adi/sc594-som-ezlite/sc594-som-ezlite.env |   8 +-
 board/adi/sc598-som-ezkit/sc598-som-ezkit.env |   9 +-
 .../adi/sc598-som-ezlite/sc598-som-ezlite.env |  14 ++-
 ...ezkit_defconfig => sc573-ezlite_defconfig} |   9 +-
 configs/sc584-ezkit_defconfig                 |  10 +-
 configs/sc589-ezkit_defconfig                 |  12 +-
 configs/sc589-mini_defconfig                  |  12 +-
 configs/sc594-som-ezkit-spl_defconfig         |   7 +-
 configs/sc594-som-ezlite-spl_defconfig        |   7 +-
 configs/sc598-som-ezkit-spl_defconfig         |   5 +-
 configs/sc598-som-ezlite-spl_defconfig        |   5 +-
 .../arm/adi/adi,sc5xx.yaml                    |   2 +-
 .../configs/{sc573-ezkit.h => sc573-ezlite.h} |   4 +-
 include/env/adi/adi_boot.env                  | 104 +++++-------------
 29 files changed, 106 insertions(+), 303 deletions(-)
 rename arch/arm/dts/{sc573-ezkit.dts => sc573-ezlite.dts} (98%)
 delete mode 100644 board/adi/sc573-ezkit/sc573-ezkit.env
 rename board/adi/{sc573-ezkit => sc573-ezlite}/Kconfig (92%)
 rename board/adi/{sc573-ezkit => sc573-ezlite}/Makefile (79%)
 rename board/adi/{sc573-ezkit/sc573-ezkit.c => sc573-ezlite/sc573-ezlite.c} (100%)
 create mode 100644 board/adi/sc573-ezlite/sc573-ezlite.env
 rename configs/{sc573-ezkit_defconfig => sc573-ezlite_defconfig} (88%)
 rename include/configs/{sc573-ezkit.h => sc573-ezlite.h} (79%)
Signature · 1 line
2.34.1
#1 lore raw

Hi Caleb,

Quoted 81 lines · Caleb Ethridge

This series performs a general cleanup of the default U-boot environment for sc5xx boards, stemming from the decision to no longer store the environment in the SPI flash. The environments for each board have been edited to contain the minimum number of commands needed for all supported boot modes to avoid confusion, and the default boot command synced to spi for all boards that support it. The filesystem for the SPI flash has also been changed from jffs2 to ubifs.

A bug with the Ethernet reset line on the sc594 has been fixed, and the sc573 has been renamed from the EZKIT to the EZLITE to match the name of the publically available board. EZKIT was only used internally before release. Preliminary binman support for sc5xx boards has been removed as it was unused and full support never added.

Changes in v5:
- Updated several commit messages for clarity
- Corrected load addresses for sc594-ezlite
- Added sc584-ezkit to USB support
- Removed now unused Kconfig options including SC5XX_FITIMAGE_OFFSET

Caleb Ethridge (14):
configs: sc5xx: Do not store environment in SPI flash
mach-sc5xx: Remove update commands from default environment
mach-sc5xx: Update boot commands
mach-sc5xx: Switch from tftp to wget
mach-sc5xx: Add USB boot command
mach-sc5xx: Remove preliminary binman support
dts: sc594: Fix gige-reset line on EZKIT
mach-sc5xx: sc573: Rename EZKIT board to EZLITE
mach-sc5xx: Update image load address
mach-sc5xx: Update SPI bootargs for ubifs
configs: sc5xx: Set default bootcmd to SPI boot
arm: sc5xx: Remove SC5XX_LOADADDR
arm: sc5xx: Add fdt_addr_r, kernel_addr_r, and ramdisk_addr_r
mach-sc5xx: Remove unused image offset Kconfig options

Ozan Durgut (1):
arm: sc5xx: add missing boot env selectors

 arch/arm/dts/Makefile                         |   2 +-
 .../dts/{sc573-ezkit.dts => sc573-ezlite.dts} |   4 +-
 arch/arm/dts/sc594-som-ezkit.dts              |   2 +-
 arch/arm/dts/sc5xx.dtsi                       |  41 -------
 arch/arm/mach-sc5xx/Kconfig                   |  71 +-----------
 arch/arm/mach-sc5xx/init/dmcinit.c            |   2 +-
 board/adi/sc573-ezkit/sc573-ezkit.env         |  17 ---
 .../adi/{sc573-ezkit => sc573-ezlite}/Kconfig |   8 +-
 .../{sc573-ezkit => sc573-ezlite}/Makefile    |   2 +-
 .../sc573-ezlite.c}                           |   0
 board/adi/sc573-ezlite/sc573-ezlite.env       |  16 +++
 board/adi/sc584-ezkit/sc584-ezkit.env         |   9 +-
 board/adi/sc589-ezkit/sc589-ezkit.env         |   9 +-
 board/adi/sc589-mini/sc589-mini.env           |   9 +-
 board/adi/sc594-som-ezkit/sc594-som-ezkit.env |   9 +-
 .../adi/sc594-som-ezlite/sc594-som-ezlite.env |   8 +-
 board/adi/sc598-som-ezkit/sc598-som-ezkit.env |   9 +-
 .../adi/sc598-som-ezlite/sc598-som-ezlite.env |  14 ++-
 ...ezkit_defconfig => sc573-ezlite_defconfig} |   9 +-
 configs/sc584-ezkit_defconfig                 |  10 +-
 configs/sc589-ezkit_defconfig                 |  12 +-
 configs/sc589-mini_defconfig                  |  12 +-
 configs/sc594-som-ezkit-spl_defconfig         |   7 +-
 configs/sc594-som-ezlite-spl_defconfig        |   7 +-
 configs/sc598-som-ezkit-spl_defconfig         |   5 +-
 configs/sc598-som-ezlite-spl_defconfig        |   5 +-
 .../arm/adi/adi,sc5xx.yaml                    |   2 +-
 .../configs/{sc573-ezkit.h => sc573-ezlite.h} |   4 +-
 include/env/adi/adi_boot.env                  | 104 +++++-------------
 29 files changed, 106 insertions(+), 303 deletions(-)
 rename arch/arm/dts/{sc573-ezkit.dts => sc573-ezlite.dts} (98%)
 delete mode 100644 board/adi/sc573-ezkit/sc573-ezkit.env
 rename board/adi/{sc573-ezkit => sc573-ezlite}/Kconfig (92%)
 rename board/adi/{sc573-ezkit => sc573-ezlite}/Makefile (79%)
 rename board/adi/{sc573-ezkit/sc573-ezkit.c => sc573-ezlite/sc573-ezlite.c} (100%)
 create mode 100644 board/adi/sc573-ezlite/sc573-ezlite.env
 rename configs/{sc573-ezkit_defconfig => sc573-ezlite_defconfig} (88%)
 rename include/configs/{sc573-ezkit.h => sc573-ezlite.h} (79%)
Quoted 3 lines

--
2.34.1

This looks good to me. I've given it another look through and made a few more minor comments.

Regards,
SImon