Skip to contentSkip to conversation

Fix and add some spi-nor flash parts

PATCH Superseded Weijie Gao 2 participants 13 messages Apr 28

Subsystems (2)

v1 of 10 Superseded Latest is v10 →

lore
Share & tools
lore

Weijie Gao

author
#0 lore raw

cover Fix and add some spi-nor flash parts

This patch series correct some existing flash parts and add some new parts.

Weijie Gao (6):
mtd: spi-nor-ids: Correct flash flags for ESMT/EON flashes
mtd: spi-nor-ids: Add support for ESMT/EON

    EN25QX128A/EN25QH256/EN25QX256A

mtd: spi-nor-ids: Add support for GigaDevice GD25Q256
mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E
mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove W25Q256FW
mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

 drivers/mtd/spi/spi-nor-core.c |  1 +
 drivers/mtd/spi/spi-nor-ids.c  | 33 ++++++++++++++++++++++++---------
 include/linux/mtd/spi-nor.h    |  1 +
 3 files changed, 26 insertions(+), 9 deletions(-)
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH 1/6 mtd: spi-nor-ids: Correct flash flags for ESMT/EON flashes

All currently supported ESMT/EON flashes supports 4KB page and dual/quad read.

Datasheets can be found here:
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25Q80B.pdf
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25QH128A%20(2TC).pdf
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25S64A(2SC).pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/mtd/spi/spi-nor-ids.c +6 -6
index c0fa98424aa..7d96adab4fd 100644
@@ -90,12 +90,12 @@ const struct flash_info spi_nor_ids[] = {
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	/* EON -- en25xxx */
-	{ INFO("en25q80b",   0x1c3014, 0, 64 * 1024,   16, SECT_4K) },
-	{ INFO("en25q32b",   0x1c3016, 0, 64 * 1024,   64, 0) },
-	{ INFO("en25q64",    0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
-	{ INFO("en25q128b",  0x1c3018, 0, 64 * 1024,  256, 0) },
-	{ INFO("en25qh128",  0x1c7018, 0, 64 * 1024,  256, 0) },
-	{ INFO("en25s64",    0x1c3817, 0, 64 * 1024,  128, SECT_4K) },
+	{ INFO("en25q80b",   0x1c3014, 0, 64 * 1024,   16, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25q32b",   0x1c3016, 0, 64 * 1024,   64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25q64",    0x1c3017, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25q128b",  0x1c3018, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25qh128",  0x1c7018, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25s64",    0x1c3817, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 #endif
 #ifdef CONFIG_SPI_FRAM_FUJITSU
 	/* Fujitsu MB85RS256TY */
Signature · 1 line
2.45.2
author
#2 lore raw

PATCH 2/6 mtd: spi-nor-ids: Add support for ESMT/EON EN25QX128A/EN25QH256/EN25QX256A

In reply to Weijie Gao

Datasheets can be found here:
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25QX128A(2V).pdf
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25QH256A(2R).pdf

---
 drivers/mtd/spi/spi-nor-core.c | 1 +
 drivers/mtd/spi/spi-nor-ids.c  | 5 +++++
 include/linux/mtd/spi-nor.h    | 1 +
 3 files changed, 7 insertions(+)
drivers/mtd/spi/spi-nor-core.c +1 -0
index 937d79af64e..e4f78e740ba 100644
@@ -758,6 +758,7 @@ static int set_4byte(struct spi_nor *nor, const struct flash_info *info,
 	case SNOR_MFR_ISSI:
 	case SNOR_MFR_MACRONIX:
 	case SNOR_MFR_WINBOND:
+	case SNOR_MFR_EON:
 		if (need_wren)
 			write_enable(nor);
 
drivers/mtd/spi/spi-nor-ids.c +5 -0
index 7d96adab4fd..fcc546fb5ae 100644
@@ -95,6 +95,11 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("en25q64",    0x1c3017, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("en25q128b",  0x1c3018, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("en25qh128",  0x1c7018, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25qx128a", 0x1c7118, 0, 64 * 1024,  256,
+	       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ INFO("en25qh256",  0x1c7019, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("en25qx256a", 0x1c7119, 0, 64 * 1024,  512,
+	       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 	{ INFO("en25s64",    0x1c3817, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 #endif
 #ifdef CONFIG_SPI_FRAM_FUJITSU
include/linux/mtd/spi-nor.h +1 -0
index 4eef4ab0488..02fa72fb401 100644
@@ -33,6 +33,7 @@
 #define SNOR_MFR_SST		CFI_MFR_SST
 #define SNOR_MFR_WINBOND	0xef /* Also used by some Spansion */
 #define SNOR_MFR_CYPRESS	0x34
+#define SNOR_MFR_EON		CFI_MFR_EON
 
 /*
  * Note on opcode nomenclature: some opcodes have a format like
Signature · 1 line
2.45.2
author
#3 lore raw

PATCH 3/6 mtd: spi-nor-ids: Add support for GigaDevice GD25Q256

In reply to Weijie Gao

The datasheet can be found here:
https://download.gigadevice.com/Datasheet/DS-00526-GD25Q256E-Rev1.3.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +5 -0
index fcc546fb5ae..8b74fbd4946 100644
@@ -147,6 +147,11 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("gd25q256", 0xc84019, 0, 64 * 1024, 512,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	/* adding these 3V QSPI flash parts */
 	{INFO("gd25b256", 0xc84019, 0, 64 * 1024, 512,	SECT_4K |
 	SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_4B_OPCODES)	},
Signature · 1 line
2.45.2
author
#4 lore raw

PATCH 4/6 mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E

In reply to Weijie Gao

The datasheet can be found here:
https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,%203V,%20256Mb,%20v1.3.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/spi-nor-ids.c +1 -1
index 8b74fbd4946..a157e370b89 100644
@@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("mx25u51245g", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |
 	       SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
-	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("mx25u25635f", 0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
 	{ INFO("mx25v8035f",  0xc22314, 0, 64 * 1024,  16, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("mx25r1635f",  0xc22815, 0, 64 * 1024,  32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
Signature · 1 line
2.45.2
maintainer
#5 lore raw

Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E

Hi,

Quoted 2 lines · Weijie Gao

The datasheet can be found here:
https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,%203V,%20256Mb,%20v1.3.pdf

You can be a little more verbose here, about the why we need this?

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 334

Quoted 7 lines
drivers/mtd/spi/spi-nor-ids.c +1 -1
@@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("mx25u51245g", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |
 	       SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
-	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SECT_4K |
 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Is this something you really need to flag? Isn't it already provided by the SFDP tables?

Quoted 3 lines
drivers/mtd/spi/spi-nor-ids.c +0 -0
 	{ INFO("mx25u25635f", 0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
 	{ INFO("mx25v8035f",  0xc22314, 0, 64 * 1024,  16, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

{ INFO("mx25r1635f", 0xc22815, 0, 64 * 1024, 32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Thanks,
Miquèl

author
#6 lore raw

Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix MX25L25635E

Quoted 7 lines · Miquel Raynal

Hi,

Quoted 2 lines · Weijie Gao

The datasheet can be found here:

https://urldefense.com/v3/__https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,*203V,*20256Mb,*20v1.3.pdf__;JSUl!!CTRNKA9wMg0ARbw!lYeaxwC-knJH61lKpIB1VNkNkvLBAAyzS5JwtDo-x9YDy7jngWucI28Yjx2wnzvEsuVLYPR4LkWiSKXNWrnIq93KhJw$

Quoted 4 lines
Quoted 1 line

You can be a little more verbose here, about the why we need this?

Quoted 13 lines

Review const struct flash_info spi_nor_ids[] = { · line 336

Quoted 9 lines
(quoted diff) +1 -1
@@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("mx25u51245g", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |
 	       SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 SPI_NOR_4B_OPCODES) },
 	{ INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
-	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512,
 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SECT_4K |
 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Is this something you really need to flag? Isn't it already provided by
the SFDP tables?

I need to use this without enabling SFDP to save some space. So it's still necessary to add this flag. I can add this description to the commit message.

Quoted 10 lines
Quoted 7 lines

{ INFO("mx25u25635f", 0xc22539, 0, 64 * 1024, 512, SECT_4K |
SPI_NOR_4B_OPCODES) },
{ INFO("mx25v8035f", 0xc22314, 0, 64 * 1024, 16, SECT_4K |
SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ INFO("mx25r1635f", 0xc22815, 0, 64 * 1024, 32, SECT_4K |
SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

Thanks,
Miquèl

author
#7 lore raw

PATCH 5/6 mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove W25Q256FW

In reply to Weijie Gao

There's no part named W25Q256FW, only W25Q256JW (Non-DTR version) exists with ID ef6019.

The datasheet can be found here:
https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/mtd/spi/spi-nor-ids.c +1 -6
index a157e370b89..492411a90f5 100644
@@ -610,12 +610,7 @@ const struct flash_info spi_nor_ids[] = {
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
 	{
-		INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
-			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
-			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
-	},
-	{
-		INFO("w25q256jw", 0xef7019, 0, 64 * 1024, 512,
+		INFO("w25q256jw", 0xef6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
Signature · 1 line
2.45.2
maintainer Reviewed-by on v1 5/6
#8 lore raw

Re: [PATCH 5/6] mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove W25Q256FW

Quoted 16 lines · Weijie Gao

There's no part named W25Q256FW, only W25Q256JW (Non-DTR version) exists with ID ef6019.

The datasheet can be found here:
https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index a157e370b89..492411a90f5 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 618

Quoted 9 lines
drivers/mtd/spi/spi-nor-ids.c +0 -6
@@ -610,12 +610,7 @@ const struct flash_info spi_nor_ids[] = {
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
 	{
-		INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
-			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
-			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
-	},
-	{
-		INFO("w25q256jw", 0xef7019, 0, 64 * 1024, 512,

FYI, this ID is W25Q256JV-M.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 616

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
+		INFO("w25q256jw", 0xef6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
author
#9 lore raw

PATCH 6/6 mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

In reply to Weijie Gao

Datasheets can be found here:
https://www.winbond.com/resource-files/W25Q256JV%20DTR%20RevK%2010202025%20Plus.pdf
https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +10 -0
index 492411a90f5..dc62a0e034a 100644
@@ -609,11 +609,21 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q256jv", 0xef7019, 0, 64 * 1024, 512,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q256jw", 0xef6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q512jv", 0xef7020, 0, 64 * 1024, 1024,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q512nwq", 0xef6020, 0, 64 * 1024, 1024,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Signature · 1 line
2.45.2
maintainer
#10 lore raw

Re: [PATCH 6/6] mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

Quoted 19 lines · Weijie Gao

Datasheets can be found here:
https://www.winbond.com/resource-files/W25Q256JV%20DTR%20RevK%2010202025%20Plus.pdf
https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf

---
 drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -0
index 492411a90f5..dc62a0e034a 100644
@@ -609,11 +609,21 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q256jv", 0xef7019, 0, 64 * 1024, 512,

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 623

Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +5 -0
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q256jw", 0xef6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q512jv", 0xef7020, 0, 64 * 1024, 1024,

This is JV-M (here and above).

These chips also happen to conflict with W25QxxRV-M chips. Is this support for these new chips that you are targeting?

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 629

Quoted 6 lines
drivers/mtd/spi/spi-nor-ids.c +3 -0
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q512nwq", 0xef6020, 0, 64 * 1024, 1024,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |

I would rather group them by family (ef60xx then ef70xx).

Thanks,
Miquèl

author
#11 lore raw

Re: [PATCH 6/6] mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

Quoted 5 lines · Miquel Raynal
Quoted 2 lines · Weijie Gao

Datasheets can be found here:

https://urldefense.com/v3/__https://www.winbond.com/resource-files/W25Q256JV*20DTR*20RevK*2010202025*20Plus.pdf__;JSUlJQ!!CTRNKA9wMg0ARbw!hPu0SggaVM2sVfZIIpmauqFfldb_a2CUsdY8EXtlYmCrlPsgfbAHiUVQjb7RsCxDyHKNzQ_IeQino7kbe_I8YtAtzN5pOGJalR6BUZ0$

Quoted 2 lines
Quoted 2 lines

https://urldefense.com/v3/__https://www.winbond.com/resource-files/W25Q512JV*20DTR*20RevD*2006292020*20133.pdf__;JSUlJQ!!CTRNKA9wMg0ARbw!hPu0SggaVM2sVfZIIpmauqFfldb_a2CUsdY8EXtlYmCrlPsgfbAHiUVQjb7RsCxDyHKNzQ_IeQino7kbe_I8YtAtzN5pOGJaaukqJvM$

Quoted 25 lines
Quoted 25 lines
---
 drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/mtd/spi/spi- renamed from drivers/mtd/spi/spi-nor-ids.c +0 -0

nor-ids.c
index 492411a90f5..dc62a0e034a 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -609,11 +609,21 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ

|

drivers/mtd/spi/spi-nor-ids.c +3 -0
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q256jv", 0xef7019, 0, 64 * 1024, 512,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ

|

drivers/mtd/spi/spi-nor-ids.c +2 -0
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q256jw", 0xef6019, 0, 64 * 1024, 512,
Quoted 8 lines

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 623

Quoted 6 lines

SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ
|

drivers/mtd/spi/spi-nor-ids.c +2 -0
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q512jv", 0xef7020, 0, 64 * 1024, 1024,

This is JV-M (here and above).

Of course. I didn't test the -Q version but I already saw related parts like w25q512jvq existed.

Perhaps naming these -M series with 'm' suffix is better.

Quoted 3 lines

These chips also happen to conflict with W25QxxRV-M chips. Is this support for these new chips that you are targeting?

I didn't use RV series now. w25q256jv/w25q512jv are tested on MediaTek's filogic platform.

As winbond doesn't provide the actual contents of the SFDP table, I'm not sure if there's a way to distinguish between these two families.

Quoted 11 lines
Quoted 9 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ

|

drivers/mtd/spi/spi-nor-ids.c +2 -0
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q512nwq", 0xef6020, 0, 64 * 1024, 1024,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ

|

I would rather group them by family (ef60xx then ef70xx).

It's OK.

Quoted 3 lines

Thanks,
Miquèl

maintainer
#12 lore raw

Re: [PATCH 6/6] mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

Quoted 10 lines
Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+	{
+		INFO("w25q512jv", 0xef7020, 0, 64 * 1024, 1024,

This is JV-M (here and above).

Of course. I didn't test the -Q version but I already saw related parts like w25q512jvq existed.

Perhaps naming these -M series with 'm' suffix is better.

I'm fine with both, I prefer -m in this case, because there are letters in between:
- 2 or 3 letters for the package type
- I or J for the temperature range

Quoted 5 lines
Quoted 2 lines

These chips also happen to conflict with W25QxxRV-M chips. Is this support for these new chips that you are targeting?

I didn't use RV series now. w25q256jv/w25q512jv are tested on MediaTek's filogic platform.

This is worth mentioning in your commit log.

Quoted 3 lines

As winbond doesn't provide the actual contents of the SFDP table, I'm not sure if there's a way to distinguish between these two families.

There is one, I will contribute it to Linux/U-Boot soon, but both are very similar in their behaviour, so it's okay like that.

Thanks,
Miquèl