fstests: add test coverage for cloned filesystem ids
v4 cover fstests: add test coverage for cloned filesystem ids
v4:
In _loop_image_create_clone() (Patch 1/9):
. Added _require_fs_space $TEST_DIR $((size * 1024)).
. Switched to the _create_file_sized() helper.
. Used the loop device in mkfs instead of the image file directly. . Added a sync on the loop device before copying to ensure consistency.
For test cases (Patches 3/9 to 9/9):
. Added _require_block_device $TEST_DEV.
For test case (Patch 4/9):
. Removed the ext4 patch reference in _fixed_by_kernel_commit since
that part of the plan was dropped.
v3:
https://lore.kernel.org/fstests/[email protected]
Anand Jain (9):
fstests: add _loop_image_create_clone() helper
fstests: add _clone_mount_option() helper
fstests: add test for inotify isolation on cloned devices
fstests: verify fanotify isolation on cloned filesystems
fstests: verify f_fsid for cloned filesystems
fstests: verify libblkid resolution of duplicate UUIDs
fstests: verify IMA isolation on cloned filesystems
fstests: verify exportfs file handles on cloned filesystems
fstests: btrfs: test UUID consistency for clones with metadata_uuid
common/config | 2 + common/rc | 61 +++++++++++++++++++++++ tests/btrfs/348 | 92 ++++++++++++++++++++++++++++++++++ tests/btrfs/348.out | 19 +++++++ tests/generic/800 | 89 +++++++++++++++++++++++++++++++++ tests/generic/800.out | 7 +++ tests/generic/801 | 113 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/801.out | 7 +++ tests/generic/802 | 62 +++++++++++++++++++++++ tests/generic/802.out | 7 +++ tests/generic/803 | 76 ++++++++++++++++++++++++++++ tests/generic/803.out | 19 +++++++ tests/generic/804 | 103 ++++++++++++++++++++++++++++++++++++++ tests/generic/804.out | 10 ++++ tests/generic/805 | 73 +++++++++++++++++++++++++++ tests/generic/805.out | 2 + 16 files changed, 742 insertions(+) create mode 100644 tests/btrfs/348 create mode 100644 tests/btrfs/348.out create mode 100644 tests/generic/800 create mode 100644 tests/generic/800.out create mode 100644 tests/generic/801 create mode 100644 tests/generic/801.out create mode 100644 tests/generic/802 create mode 100644 tests/generic/802.out create mode 100644 tests/generic/803 create mode 100644 tests/generic/803.out create mode 100644 tests/generic/804 create mode 100644 tests/generic/804.out create mode 100644 tests/generic/805 create mode 100644 tests/generic/805.out
Signature · 1 line
2.43.0
PATCH v4 1/9 fstests: add _loop_image_create_clone() helper
Introduce _loop_image_create_clone() and _loop_image_destroy() to mkfs an image file and clone it to another image file, and attach a loop device to them. And its destroy part.
--- common/rc | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
common/rc +47 -0
@@ -1503,6 +1503,53 @@ _scratch_resvblks() esac } +_loop_image_create_clone() +{ + local -n _ret=$1 + local pre_clone_tune_func=$2 + local img_file=$TEST_DIR/${seq}.img + local img_file_clone=$TEST_DIR/${seq}_clone.img + local size=$(_small_fs_size_mb 128) # Smallest possible + local loop_devs + + _require_fs_space $TEST_DIR $((size * 1024)) + + _create_file_sized $((size * 1024 * 1024)) $img_file || + _fail "Failed: Create $img_file $size" + + loop_devs=$(_create_loop_device $img_file) + _ret=($loop_devs) + + case $FSTYP in + xfs) + _mkfs_dev "-s size=4096" ${loop_devs[0]} + ;; + btrfs) + _mkfs_dev ${loop_devs[0]} + ;; + *) + _mkfs_dev ${loop_devs[0]} + ;; + esac + + ($pre_clone_tune_func) + + sync ${loop_devs[0]} + cp $img_file $img_file_clone + + loop_devs="$loop_devs $(_create_loop_device $img_file_clone)" + + _ret=($loop_devs) +} + +_loop_image_destroy() +{ + for d in "$@"; do + local f=$(losetup --noheadings --output BACK-FILE $d) + _destroy_loop_device "$d" + [ -n "$f" ] && rm -f "$f" + done +} # Repair scratch filesystem. Returns 0 if the FS is good to go (either no # errors found or errors were fixed) and nonzero otherwise; also spits out
Signature · 1 line
2.43.0
PATCH v4 2/9 fstests: add _clone_mount_option() helper
In reply to Anand JainAdds _clone_mount_option() helper function to handle filesystem-specific requirements for mounting cloned devices. Abstract the need for -o nouuid on XFS.
--- common/rc | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
common/rc +14 -0
@@ -397,6 +397,20 @@ _scratch_mount_options() $SCRATCH_DEV $SCRATCH_MNT } +_clone_mount_option() +{ + local mount_opts="" + + case "$FSTYP" in + xfs) + mount_opts="-o nouuid" + ;; + *) + esac + + echo $mount_opts +} + _supports_filetype() { local dir=$1
Signature · 1 line
2.43.0
PATCH v4 3/9 fstests: add test for inotify isolation on cloned devices
In reply to Anand JainAdd a new test, to verify that the kernel correctly differentiates between two block devices sharing the same FSID/UUID.
--- common/config | 1 + tests/generic/800 | 89 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/800.out | 7 ++++ 3 files changed, 97 insertions(+) create mode 100644 tests/generic/800 create mode 100644 tests/generic/800.out
common/config +1 -0
@@ -242,6 +242,7 @@ export BTRFS_MAP_LOGICAL_PROG=$(type -P btrfs-map-logical) export PARTED_PROG="$(type -P parted)" export XFS_PROPERTY_PROG="$(type -P xfs_property)" export FSCRYPTCTL_PROG="$(type -P fscryptctl)" +export INOTIFYWAIT_PROG="$(type -P inotifywait)" # udev wait functions. #
tests/generic/800 new file +89 -0
89 lines not on this page · raw message
tests/generic/800.out new file +7 -0
@@ -0,0 +1,7 @@ +QA output created by 800 +Setup inotify watchers on both mnt1 and mnt2 +Trigger file creation on mnt1 +Trigger file creation on mnt2 +Verify inotify isolation +SUCCESS: mnt1 events isolated. +SUCCESS: mnt2 events isolated.
Signature · 1 line
2.43.0
PATCH v4 4/9 fstests: verify fanotify isolation on cloned filesystems
In reply to Anand JainVerify that fanotify events are correctly routed to the appropriate watcher when cloned filesystems are mounted.
Helps verify kernel's event notification distinguishes between devices sharing the same FSID/UUID.
--- common/config | 1 + tests/generic/801 | 113 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/801.out | 7 +++ 3 files changed, 121 insertions(+) create mode 100644 tests/generic/801 create mode 100644 tests/generic/801.out
common/config +1 -0
@@ -243,6 +243,7 @@ export PARTED_PROG="$(type -P parted)" export XFS_PROPERTY_PROG="$(type -P xfs_property)" export FSCRYPTCTL_PROG="$(type -P fscryptctl)" export INOTIFYWAIT_PROG="$(type -P inotifywait)" +export FSNOTIFYWAIT_PROG="$(type -P fsnotifywait)" # udev wait functions. #
tests/generic/801 new file +113 -0
113 lines not on this page · raw message
tests/generic/801.out new file +7 -0
@@ -0,0 +1,7 @@ +QA output created by 801 +Setup FID fanotify watchers on both mnt1 and mnt2 +Trigger file creation on mnt1 +Trigger file creation on mnt2 +Verify fsid in the fanotify +SUCCESS: mnt1 events found +SUCCESS: mnt2 events found
Signature · 1 line
2.43.0
PATCH v4 5/9 fstests: verify f_fsid for cloned filesystems
In reply to Anand JainVerify that the cloned filesystem provides an f_fsid that is persistent across mount cycles, yet unique from the original filesystem's f_fsid.
--- tests/generic/802 | 62 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/802.out | 7 +++++ 2 files changed, 69 insertions(+) create mode 100644 tests/generic/802 create mode 100644 tests/generic/802.out
tests/generic/802 new file +62 -0
@@ -0,0 +1,62 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Anand Jain <[email protected]>. All Rights Reserved. +# +# FS QA Test 802 +# Verify f_fsid and s_uuid of cloned filesystems across mount cycle. + +. ./common/preamble + +_begin_fstest auto quick mount clone + +_require_test +_require_block_device $TEST_DEV +_require_loop + +[ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit xxxxxxxxxxxx \ + "btrfs: use on-disk uuid for s_uuid in temp_fsid mounts" +[ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit xxxxxxxxxxxx \ + "btrfs: derive f_fsid from on-disk fsuuid and dev_t" + +_cleanup() +{ + cd / + rm -r -f $tmp.* + umount $mnt1 $mnt2 2>/dev/null + _loop_image_destroy "${devs[@]}" 2> /dev/null +} + +devs=() +_loop_image_create_clone devs +mkdir -p $TEST_DIR/$seq +mnt1=$TEST_DIR/$seq/mnt1 +mnt2=$TEST_DIR/$seq/mnt2 +mkdir -p $mnt1 +mkdir -p $mnt2 + +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" + +fsid_scratch=$(stat -f -c "%i" $mnt1) +fsid_clone=$(stat -f -c "%i" $mnt2) + +echo "**** fsid initially ****" +echo $fsid_scratch | sed -e "s/$fsid_scratch/FSID_SCRATCH/g" +echo $fsid_clone | sed -e "s/$fsid_clone/FSID_CLONE/g" + +# Make sure fsid still match across a mount cycle, also reverse the order. +echo "**** fsid after mount cycle ****" +_unmount $mnt1 +_unmount $mnt2 +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" + +stat -f -c "%i" $mnt1 | sed -e "s/$fsid_scratch/FSID_SCRATCH/g" +stat -f -c "%i" $mnt2 | sed -e "s/$fsid_clone/FSID_CLONE/g" + +status=0 +exit
tests/generic/802.out new file +7 -0
@@ -0,0 +1,7 @@ +QA output created by 802 +**** fsid initially **** +FSID_SCRATCH +FSID_CLONE +**** fsid after mount cycle **** +FSID_SCRATCH +FSID_CLONE
Signature · 1 line
2.43.0
PATCH v4 6/9 fstests: verify libblkid resolution of duplicate UUIDs
In reply to Anand JainVerify how findmnt, df (libblkid) resolve device paths when multiple block devices share the same FSUUID.
--- tests/generic/803 | 76 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/803.out | 19 +++++++++++ 2 files changed, 95 insertions(+) create mode 100644 tests/generic/803 create mode 100644 tests/generic/803.out
tests/generic/803 new file +76 -0
@@ -0,0 +1,76 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Anand Jain <[email protected]>. All Rights Reserved. +# +# FS QA Test 803 +# Verify how libblkid resolve devices when multiple devices sharing the +# same FSUUID. + +. ./common/preamble +. ./common/filter + +_begin_fstest auto quick mount clone + +_require_test +_require_block_device $TEST_DEV +_require_loop + +_cleanup() +{ + cd / + rm -r -f $tmp.* + umount $mnt1 $mnt2 2>/dev/null + _loop_image_destroy "${devs[@]}" 2> /dev/null +} + +filter_pool() +{ + sed -e "s|${devs[0]}|DEV1|g" -e "s|${mnt1}|MNT1|g" \ + -e "s|${devs[1]}|DEV2|g" -e "s|${mnt2}|MNT2|g" | _filter_spaces +} + +print_info() +{ + local mntpt=$1 + local tgt=$(findmnt -no SOURCE $mntpt) + local fsuuid=$(blkid -s UUID -o value $tgt) + + echo "mntpt=$mntpt tgt=$tgt fsuuid=$fsuuid" >> $seqres.full + echo + findmnt -o SOURCE,TARGET,UUID "$tgt" | tail -n +2 | \ + sed -e "s/${fsuuid}/FSUUID/g" | filter_pool + awk -v dev="$tgt" '$1 == dev { print $1, $2 }' /proc/self/mounts | \ + filter_pool + df --all --output=source,target "$tgt" | tail -n +2 | filter_pool +} + +devs=() +_loop_image_create_clone devs +mkdir -p $TEST_DIR/$seq +mnt1=$TEST_DIR/$seq/mnt1 +mnt2=$TEST_DIR/$seq/mnt2 +mkdir -p $mnt1 +mkdir -p $mnt2 + +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" + +print_info $mnt1 +print_info $mnt2 + +echo +echo "**** mount cycle ****" +_unmount $mnt1 +_unmount $mnt2 +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" + +print_info $mnt1 +print_info $mnt2 + +status=0 +exit
tests/generic/803.out new file +19 -0
@@ -0,0 +1,19 @@ +QA output created by 803 + +DEV1 MNT1 FSUUID +DEV1 MNT1 +DEV1 MNT1 + +DEV2 MNT2 FSUUID +DEV2 MNT2 +DEV2 MNT2 + +**** mount cycle **** + +DEV1 MNT1 FSUUID +DEV1 MNT1 +DEV1 MNT1 + +DEV2 MNT2 FSUUID +DEV2 MNT2 +DEV2 MNT2
Signature · 1 line
2.43.0
PATCH v4 7/9 fstests: verify IMA isolation on cloned filesystems
In reply to Anand JainAdd testcase to verify IMA measurement isolation when multiple devices share the same FSUUID.
--- tests/generic/804 | 103 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/804.out | 10 ++++ 2 files changed, 113 insertions(+) create mode 100644 tests/generic/804 create mode 100644 tests/generic/804.out
tests/generic/804 new file +103 -0
@@ -0,0 +1,103 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Anand Jain <[email protected]>. All Rights Reserved. +# +# FS QA Test 804 +# Verify IMA isolation on cloned filesystems: +# . Mount two devices sharing the same FSUUID (cloned). +# . Apply an IMA policy to measure files based on that FSUUID. +# . Create unique files on each mount point to trigger measurements. +# . Confirm the IMA log correctly attributes events to the respective mounts. + +. ./common/preamble +. ./common/filter + +_begin_fstest auto quick clone + +_require_test +_require_block_device $TEST_DEV +_require_loop + +[ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit xxxxxxxxxxxx \ + "btrfs: use on-disk uuid for s_uuid in temp_fsid mounts" +[ "$FSTYP" = "btrfs" ] && _fixed_by_kernel_commit xxxxxxxxxxxx \ + "btrfs: derive f_fsid from on-disk fsuuid and dev_t" + +_cleanup() +{ + cd / + rm -r -f $tmp.* + _unmount $mnt1 2>/dev/null + _unmount $mnt2 2>/dev/null + _loop_image_destroy "${devs[@]}" 2> /dev/null +} + +filter_pool() +{ + sed -e "s|${devs[0]}|DEV1|g" -e "s|$mnt1|MNT1|g" \ + -e "s|${devs[1]}|DEV2|g" -e "s|$mnt2|MNT2|g" | _filter_spaces +} + +do_ima() +{ + local ima_policy="/sys/kernel/security/ima/policy" + local ima_log="/sys/kernel/security/ima/ascii_runtime_measurements" + local fsuuid + local mnt=$1 + local enable=$2 + + # Since the in-memory IMA audit log is only cleared upon reboot, + # use unique random filenames to avoid log collisions. + local foofile=$(mktemp --dry-run foobar_XXXXX) + + echo $mnt $enable | filter_pool + + [ -w "$ima_policy" ] || _notrun "IMA policy not writable" + + fsuuid=$(blkid -s UUID -o value ${devs[0]}) + + # Load IMA policy to measure file access specifically for this + # filesystem UUID. + if [[ $enable -eq 1 ]]; then + echo "measure func=FILE_CHECK fsuuid=$fsuuid" > "$ima_policy" || \ + _notrun "Policy rejected" + fi + + # Create a file to trigger measurement and verify its entry in + # the IMA log. + echo "test_data" > $mnt/$foofile + + # For $ima_log column entry please ref to + grep $foofile "$ima_log" | awk '{ print $5 }' | filter_pool | \ + sed "s/$foofile/FOOBAR_FILE/" + + echo "dbg: $mnt $fsuuid $foofile" >> $seqres.full + cat $ima_log | tail -1 >> $seqres.full + echo >> $seqres.full +} + +devs=() +_loop_image_create_clone devs +mnt1=$TEST_DIR/$seq/mnt1 +mnt2=$TEST_DIR/$seq/mnt2 +mkdir -p $mnt1 +mkdir -p $mnt2 + +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" + +do_ima $mnt1 1 +do_ima $mnt2 0 + +# Btrfs uses in-memory dynamic temp_fsid +echo mount cycle +_unmount $mnt2 +_mount $mount_opts ${devs[1]} $mnt2 || _fail "Failed to mount dev2" + +do_ima $mnt1 0 +do_ima $mnt2 0 + +status=0 +exit
tests/generic/804.out new file +10 -0
@@ -0,0 +1,10 @@ +QA output created by 804 +MNT1 1 +MNT1/FOOBAR_FILE +MNT2 0 +MNT2/FOOBAR_FILE +mount cycle +MNT1 0 +MNT1/FOOBAR_FILE +MNT2 0 +MNT2/FOOBAR_FILE
Signature · 1 line
2.43.0
PATCH v4 8/9 fstests: verify exportfs file handles on cloned filesystems
In reply to Anand JainEnsure that exportfs can correctly decode file handles on a cloned filesystem across a mount cycle, by file handles generated on a cloned device remain valid after mount cycle.
--- tests/generic/805 | 73 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/805.out | 2 ++ 2 files changed, 75 insertions(+) create mode 100644 tests/generic/805 create mode 100644 tests/generic/805.out
tests/generic/805 new file +73 -0
@@ -0,0 +1,73 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Anand Jain <[email protected]>. All Rights Reserved. +# +# FS QA Test No. 805 + +. ./common/preamble + +_begin_fstest auto quick exportfs clone + +_require_test +_require_block_device $TEST_DEV +_require_exportfs +_require_loop +_require_test_program "open_by_handle" + +_cleanup() +{ + cd / + rm -r -f $tmp.* + _unmount $mnt1 2>/dev/null + _unmount $mnt2 2>/dev/null + _loop_image_destroy "${devs[@]}" 2> /dev/null +} + +# Create test dir and test files, encode file handles and store to tmp file +create_test_files() +{ + rm -rf $testdir + mkdir -p $testdir + $here/src/open_by_handle -cwp -o $tmp.handles_file $testdir $NUMFILES +} + +# Decode file handles loaded from tmp file +test_file_handles() +{ + local opt=$1 + local when=$2 + + echo test_file_handles after $when + $here/src/open_by_handle $opt -i $tmp.handles_file $mnt2 $NUMFILES +} + +devs=() +_loop_image_create_clone devs +mkdir -p $TEST_DIR/$seq +mnt1=$TEST_DIR/$seq/mnt1 +mnt2=$TEST_DIR/$seq/mnt2 +mkdir -p $mnt1 +mkdir -p $mnt2 + +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" + +NUMFILES=1 +testdir=$mnt2/testdir + +# Decode file handles of files/dir after cycle mount +create_test_files + +_unmount $mnt1 +_unmount $mnt2 +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" + +test_file_handles -rp "cycle mount" + +status=0 +exit
tests/generic/805.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 805 +test_file_handles after cycle mount
Signature · 1 line
2.43.0
PATCH v4 9/9 fstests: btrfs: test UUID consistency for clones with metadata_uuid
In reply to Anand JainBtrfs uses the metadata_uuid superblock feature to change the on-disk UUID without rewriting every block header. This patch adds a sanity check to ensure UUID consistency when a filesystem with metadata_uuid enabled is cloned.
--- tests/btrfs/348 | 92 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/348.out | 19 ++++++++++ 2 files changed, 111 insertions(+) create mode 100644 tests/btrfs/348 create mode 100644 tests/btrfs/348.out
tests/btrfs/348 new file +92 -0
@@ -0,0 +1,92 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Anand Jain <[email protected]>. All Rights Reserved. +# +# FS QA Test 348 +# +# Verify that the cloned filesystem UUID remains consistent, even when the +# `metadata_uuid` feature is enabled. +# + +. ./common/preamble +. ./common/filter + +_begin_fstest auto quick mount clone + +_require_test +_require_block_device $TEST_DEV +_require_loop + +_cleanup() +{ + cd / + rm -r -f $tmp.* + umount $mnt1 $mnt2 2>/dev/null + _loop_image_destroy "${devs[@]}" 2> /dev/null +} + +filter_pool() +{ + sed -e "s|${devs[0]}|DEV1|g" -e "s|${mnt1}|MNT1|g" \ + -e "s|${devs[1]}|DEV2|g" -e "s|${mnt2}|MNT2|g" | _filter_spaces +} + +pre_clone_tune() +{ + local temp_mnt=$TEST_DIR/${seq}_mnt + + _require_command "$BTRFS_TUNE_PROG" btrfstune + mkdir -p $temp_mnt + _mount ${devs[0]} $temp_mnt + $BTRFS_UTIL_PROG subvolume create $temp_mnt/sv1 &> /dev/null + _unmount $temp_mnt + rm -r -f $temp_mnt + + $BTRFS_TUNE_PROG -m ${devs[0]} +} + +print_info() +{ + local mntpt=$1 + local tgt=$(findmnt -no SOURCE $mntpt) + local fsuuid=$(blkid -s UUID -o value $tgt) + + echo "mntpt=$mntpt tgt=$tgt fsuuid=$fsuuid" >> $seqres.full + echo + findmnt -o SOURCE,TARGET,UUID "$tgt" | tail -n +2 | \ + sed -e "s/${fsuuid}/FSUUID/g" | filter_pool + awk -v dev="$tgt" '$1 == dev { print $1, $2 }' /proc/self/mounts | \ + filter_pool + df --all --output=source,target "$tgt" | tail -n +2 | filter_pool +} + +devs=() +_loop_image_create_clone devs pre_clone_tune +mkdir -p $TEST_DIR/$seq +mnt1=$TEST_DIR/$seq/mnt1 +mnt2=$TEST_DIR/$seq/mnt2 +mkdir -p $mnt1 +mkdir -p $mnt2 + +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" + +print_info $mnt1 +print_info $mnt2 + +echo +echo "**** mount cycle ****" +_unmount $mnt1 +_unmount $mnt2 +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ + _fail "Failed to mount dev2" +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]} $mnt1 || \ + _fail "Failed to mount dev1" + +print_info $mnt1 +print_info $mnt2 + +status=0 +exit
tests/btrfs/348.out new file +19 -0
@@ -0,0 +1,19 @@ +QA output created by 348 + +DEV1 MNT1 FSUUID +DEV1 MNT1 +DEV1 MNT1 + +DEV2 MNT2 FSUUID +DEV2 MNT2 +DEV2 MNT2 + +**** mount cycle **** + +DEV1 MNT1 FSUUID +DEV1 MNT1 +DEV1 MNT1 + +DEV2 MNT2 FSUUID +DEV2 MNT2 +DEV2 MNT2
Signature · 1 line
2.43.0
This is missing a real cover letter saying what this series is trying to archive.
Quoted 49 lines · Anand Jain
v4:
In_loop_image_create_clone()(Patch 1/9):
. Added_require_fs_space$TEST_DIR $((size * 1024)).
. Switched to the_create_file_sized()helper.
. Used the loop device in mkfs instead of the image file directly. . Added a sync on the loop device before copying to ensure consistency.
For test cases (Patches 3/9 to 9/9):
. Added_require_block_device$TEST_DEV.
For test case (Patch 4/9):
. Removed the ext4 patch reference in_fixed_by_kernel_commitsince
that part of the plan was dropped.v3:
https://lore.kernel.org/fstests/[email protected]Anand Jain (9):
fstests: add_loop_image_create_clone()helper
fstests: add_clone_mount_option()helper
fstests: add test for inotify isolation on cloned devices
fstests: verify fanotify isolation on cloned filesystems
fstests: verifyf_fsidfor cloned filesystems
fstests: verify libblkid resolution of duplicate UUIDs
fstests: verify IMA isolation on cloned filesystems
fstests: verify exportfs file handles on cloned filesystems
fstests: btrfs: test UUID consistency for clones withmetadata_uuidcommon/config | 2 + common/rc | 61 +++++++++++++++++++++++ tests/btrfs/348 | 92 ++++++++++++++++++++++++++++++++++ tests/btrfs/348.out | 19 +++++++ tests/generic/800 | 89 +++++++++++++++++++++++++++++++++ tests/generic/800.out | 7 +++ tests/generic/801 | 113 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/801.out | 7 +++ tests/generic/802 | 62 +++++++++++++++++++++++ tests/generic/802.out | 7 +++ tests/generic/803 | 76 ++++++++++++++++++++++++++++ tests/generic/803.out | 19 +++++++ tests/generic/804 | 103 ++++++++++++++++++++++++++++++++++++++ tests/generic/804.out | 10 ++++ tests/generic/805 | 73 +++++++++++++++++++++++++++ tests/generic/805.out | 2 + 16 files changed, 742 insertions(+) create mode 100644 tests/btrfs/348 create mode 100644 tests/btrfs/348.out create mode 100644 tests/generic/800 create mode 100644 tests/generic/800.out create mode 100644 tests/generic/801 create mode 100644 tests/generic/801.out
Quoted 12 lines
create mode 100644 tests/generic/802 create mode 100644 tests/generic/802.out create mode 100644 tests/generic/803 create mode 100644 tests/generic/803.out create mode 100644 tests/generic/804 create mode 100644 tests/generic/804.out create mode 100644 tests/generic/805 create mode 100644 tests/generic/805.outSignature · 1 line
2.43.0
---end quoted text---
Re: [PATCH v4 4/9] fstests: verify fanotify isolation on cloned filesystems
In reply to Anand JainQuoted 4 lines · Anand Jain
Verify that fanotify events are correctly routed to the appropriate watcher when cloned filesystems are mounted.
Helps verify kernel's event notification distinguishes between devices sharing the same FSID/UUID.
Do these tests pass with all major file systems? Or does this reproduce the previous btrfs issues in this area?
Re: [PATCH v4 9/9] fstests: btrfs: test UUID consistency for clones with metadata_uuid
In reply to Anand JainQuoted 4 lines · Anand Jain
Btrfs uses the
metadata_uuidsuperblock feature to change the on-disk UUID without rewriting every block header. This patch adds a sanity check to ensure UUID consistency when a filesystem withmetadata_uuidenabled is cloned.
xfs does the same.
Can we abstract out the uuid change and generalize the test?
Quoted 2 lines · Christoph Hellwig
This is missing a real cover letter saying what this series is trying to archive.
I should have copied from v1. See below [1]
SCRATCH_DEV_POOL support for non-btrfs was dropped in v2. Instead, using the newly added helper _loop_image_create_clone().
[1]
https://lore.kernel.org/fstests/[email protected]/
-----
This series adds fstests infrastructure and test cases to verify correct filesystem identity behaviour when a filesystem is cloned (e.g. via block-level copy), covering inotify, fanotify, f_fsid, libblkid, IMA, and exportfs file handles.
- SCRATCH_DEV_POOL support extended to non-Btrfs filesystems
- _mkfs_scratch_sized_clone() helper to create a cloned filesystem
- _clone_mount_option() helper to apply per-filesystem clone mount options
New tests verify:
- inotify and fanotify events are isolated between cloned filesystems
- f_fsid is unique across cloned filesystem instances
- libblkid correctly resolves duplicate UUIDs to distinct devices
- IMA distinct identity for each cloned filesystem
- exportfs file handles resolve correctly on cloned filesystems
-----
Re: [PATCH v4 4/9] fstests: verify fanotify isolation on cloned filesystems
In reply to Christoph HellwigQuoted 8 lines · Christoph Hellwig
Quoted 4 lines · Anand Jain
Verify that fanotify events are correctly routed to the appropriate watcher when cloned filesystems are mounted.
Helps verify kernel's event notification distinguishes between devices sharing the same FSID/UUID.Do these tests pass with all major file systems? Or does this reproduce the previous btrfs issues in this area?
Yes. The major FSs (BTRFS, EXT4, XFS, and F2FS) all pass, except EXT4 does not run generic/801 because statfs f_fsid is not unique when the cloned FS is mounted. Also, BTRFS requires the kernel patch mentioned in test cases generic/802 and generic/804.
generic/801 fails in an SELinux environment; this can be fixed with the following changes in generic/801 I'll add this change in v5.
-------
tests/generic/801 +7 -0
@@ -23,6 +23,10 @@ _cleanup() umount $mnt1 $mnt2 2>/dev/null _loop_image_destroy "${devs[@]}" 2> /dev/null rm -r -f $tmp.* + + if [ -n "$old_selinux_state" ]; then + setenforce "$old_selinux_state" + fi } monitor_fanotify()
@@ -49,6 +53,14 @@ mnt2=$TEST_DIR/$seq/mnt2 mkdir -p $mnt1 mkdir -p $mnt2 +# Setting SELINUX_MOUNT_OPTIONS to null still fails fanotify with +# permission failure, so set SELinux to permissive if it is enforcing. +if command -v getenforce &>/dev/null && [ "$(getenforce)" = "Enforcing"
]; then
+ old_selinux_state="Enforcing"
+ setenforce Permissive
+else
+ old_selinux_state=""
+fi
_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[0]}
$mnt1 || \
_fail "Failed to mount dev1"
_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]}
$mnt2 || \
(END)
-------
Re: [PATCH v4 9/9] fstests: btrfs: test UUID consistency for clones with metadata_uuid
In reply to Christoph HellwigQuoted 9 lines · Christoph Hellwig
Quoted 4 lines · Anand Jain
Btrfs uses the
metadata_uuidsuperblock feature to change the on-disk UUID without rewriting every block header. This patch adds a sanity check to ensure UUID consistency when a filesystem withmetadata_uuidenabled is cloned.xfs does the same.
Can we abstract out the uuid change and generalize the test?
Sure. let me try.
Thanks.