dt-bindings: clean up tab and trailing whitespace from examples
Subsystems (22)
cover dt-bindings: clean up tab and trailing whitespace from examples
The earlier RFC of an automated DTS example style checker [1] is being respun. Its v2 will ship a default 'relaxed' rule set that is intended to produce zero output on the current tree, so it can be wired into make dt_binding_check without a tail of warnings.
These two patches fix the only existing violations of the relaxed
rules: a single trailing whitespace and 15 files with literal tabs in their DTS examples. With these applied, the v2 checker passes treewide in default mode.
Posting separately so the cleanup can land independently of the tool.
[1] https://lore.kernel.org/all/[email protected]/
Daniel Golle (2):
dt-bindings: misc: fsl,qoriq-mc: drop trailing whitespace
dt-bindings: drop tab characters from DTS examples
.../bindings/i2c/opencores,i2c-ocores.yaml | 8 ++--- .../bindings/iio/adc/st,spear600-adc.yaml | 2 +- .../devicetree/bindings/input/imx-keypad.yaml | 32 +++++++++---------- .../bindings/input/microchip,cap11xx.yaml | 12 +++---- .../input/touchscreen/ti,ads7843.yaml | 4 +-- .../devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- .../media/mediatek,vcodec-encoder.yaml | 2 +- .../media/mediatek,vcodec-subdev-decoder.yaml | 2 +- .../memory-controllers/nvidia,tegra20-mc.yaml | 4 +-- .../samsung,exynos5422-dmc.yaml | 2 +- .../bindings/misc/fsl,qoriq-mc.yaml | 2 +- .../bindings/pci/mediatek-pcie-mt7623.yaml | 4 +-- .../bindings/pci/samsung,exynos-pcie.yaml | 2 +- .../bindings/sound/davinci-mcasp-audio.yaml | 4 +-- .../bindings/sound/simple-card.yaml | 6 ++-- .../devicetree/bindings/usb/ti,j721e-usb.yaml | 8 ++--- 16 files changed, 48 insertions(+), 48 deletions(-)
Signature · 1 line
2.54.0
PATCH 1/2 dt-bindings: misc: fsl,qoriq-mc: drop trailing whitespace
Drop trailing whitespace from example.
--- Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml +1 -1
@@ -166,7 +166,7 @@ examples: */ ranges = <0x0 0x0 0x8 0x0c000000 0x4000000 0x1 0x0 0x8 0x18000000 0x8000000>; - + /* define map for ICIDs 23-64 */ iommu-map = <23 &smmu 23 41>; /* define msi map for ICIDs 23-64 */
Signature · 1 line
2.54.0
PATCH 2/2 dt-bindings: drop tab characters from DTS examples
In reply to Daniel GolleYAML literal block scalars cannot use tabs for indent. Replace tab separators (mostly between values and trailing /* ... */ comments) with single spaces.
--- .../bindings/i2c/opencores,i2c-ocores.yaml | 8 ++--- .../bindings/iio/adc/st,spear600-adc.yaml | 2 +- .../devicetree/bindings/input/imx-keypad.yaml | 32 +++++++++---------- .../bindings/input/microchip,cap11xx.yaml | 12 +++---- .../input/touchscreen/ti,ads7843.yaml | 4 +-- .../devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- .../media/mediatek,vcodec-encoder.yaml | 2 +- .../media/mediatek,vcodec-subdev-decoder.yaml | 2 +- .../memory-controllers/nvidia,tegra20-mc.yaml | 4 +-- .../samsung,exynos5422-dmc.yaml | 2 +- .../bindings/pci/mediatek-pcie-mt7623.yaml | 4 +-- .../bindings/pci/samsung,exynos-pcie.yaml | 2 +- .../bindings/sound/davinci-mcasp-audio.yaml | 4 +-- .../bindings/sound/simple-card.yaml | 6 ++-- .../devicetree/bindings/usb/ti,j721e-usb.yaml | 8 ++--- 15 files changed, 47 insertions(+), 47 deletions(-)
Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml +4 -4
@@ -95,8 +95,8 @@ examples: interrupts = <10>; opencores,ip-clock-frequency = <20000000>; - reg-shift = <0>; /* 8 bit registers */ - reg-io-width = <1>; /* 8 bit read/write */ + reg-shift = <0>; /* 8 bit registers */ + reg-io-width = <1>; /* 8 bit read/write */ }; i2c@b0000000 {
@@ -108,7 +108,7 @@ examples: clocks = <&osc>; clock-frequency = <400000>; /* i2c bus frequency 400 KHz */ - reg-shift = <0>; /* 8 bit registers */ - reg-io-width = <1>; /* 8 bit read/write */ + reg-shift = <0>; /* 8 bit registers */ + reg-io-width = <1>; /* 8 bit read/write */ }; ...
Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml +1 -1
@@ -65,5 +65,5 @@ examples: interrupt-parent = <&vic1>; interrupts = <6>; sampling-frequency = <5000000>; - vref-external = <2500>; /* 2.5V VRef */ + vref-external = <2500>; /* 2.5V VRef */ };
Documentation/devicetree/bindings/input/imx-keypad.yaml +16 -16
@@ -66,20 +66,20 @@ examples: clocks = <&clks 0>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_kpp_1>; - linux,keymap = <0x00000067 /* KEY_UP */ - 0x0001006c /* KEY_DOWN */ - 0x00020072 /* KEY_VOLUMEDOWN */ - 0x00030066 /* KEY_HOME */ - 0x0100006a /* KEY_RIGHT */ - 0x01010069 /* KEY_LEFT */ - 0x0102001c /* KEY_ENTER */ - 0x01030073 /* KEY_VOLUMEUP */ - 0x02000040 /* KEY_F6 */ - 0x02010042 /* KEY_F8 */ - 0x02020043 /* KEY_F9 */ - 0x02030044 /* KEY_F10 */ - 0x0300003b /* KEY_F1 */ - 0x0301003c /* KEY_F2 */ - 0x0302003d /* KEY_F3 */ - 0x03030074>; /* KEY_POWER */ + linux,keymap = <0x00000067 /* KEY_UP */ + 0x0001006c /* KEY_DOWN */ + 0x00020072 /* KEY_VOLUMEDOWN */ + 0x00030066 /* KEY_HOME */ + 0x0100006a /* KEY_RIGHT */ + 0x01010069 /* KEY_LEFT */ + 0x0102001c /* KEY_ENTER */ + 0x01030073 /* KEY_VOLUMEUP */ + 0x02000040 /* KEY_F6 */ + 0x02010042 /* KEY_F8 */ + 0x02020043 /* KEY_F9 */ + 0x02030044 /* KEY_F10 */ + 0x0300003b /* KEY_F1 */ + 0x0301003c /* KEY_F2 */ + 0x0302003d /* KEY_F3 */ + 0x03030074>; /* KEY_POWER */ };
Documentation/devicetree/bindings/input/microchip,cap11xx.yaml +6 -6
@@ -197,12 +197,12 @@ examples: microchip,sensitivity-delta-sense = <16>; microchip,input-threshold = <21>, <18>, <46>, <46>, <46>, <21>; - linux,keycodes = <103>, /* KEY_UP */ - <106>, /* KEY_RIGHT */ - <108>, /* KEY_DOWN */ - <105>, /* KEY_LEFT */ - <109>, /* KEY_PAGEDOWN */ - <104>; /* KEY_PAGEUP */ + linux,keycodes = <103>, /* KEY_UP */ + <106>, /* KEY_RIGHT */ + <108>, /* KEY_DOWN */ + <105>, /* KEY_LEFT */ + <109>, /* KEY_PAGEDOWN */ + <104>; /* KEY_PAGEUP */ #address-cells = <1>; #size-cells = <0>;
Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml +2 -2
@@ -165,9 +165,9 @@ examples: touchscreen@0 { compatible = "ti,tsc2046"; - reg = <0>; /* CS0 */ + reg = <0>; /* CS0 */ interrupt-parent = <&gpio1>; - interrupts = <8 0>; /* BOOT6 / GPIO 8 */ + interrupts = <8 0>; /* BOOT6 / GPIO 8 */ pendown-gpio = <&gpio1 8 0>; spi-max-frequency = <1000000>; vcc-supply = <®_vcc3>;
Documentation/devicetree/bindings/leds/leds-lp55xx.yaml +1 -1
@@ -183,7 +183,7 @@ examples: compatible = "ti,lp8501"; reg = <0x32>; clock-mode = /bits/ 8 <2>; - pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ + pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ ti,charge-pump-mode = <LP55XX_CP_BYPASS>; led@0 {
Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +1 -1
@@ -160,7 +160,7 @@ examples: vcodec_enc_vp8: vcodec@19002000 { compatible = "mediatek,mt8173-vcodec-enc-vp8"; - reg = <0x19002000 0x1000>; /* VENC_LT_SYS */ + reg = <0x19002000 0x1000>; /* VENC_LT_SYS */ interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_LOW>; iommus = <&iommu M4U_PORT_VENC_RCPU_SET2>, <&iommu M4U_PORT_VENC_REC_FRM_SET2>,
Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml +1 -1
@@ -232,7 +232,7 @@ examples: #address-cells = <2>; #size-cells = <2>; ranges = <0 0 0 0x16000000 0 0x40000>; - reg = <0 0x16000000 0 0x1000>; /* VDEC_SYS */ + reg = <0 0x16000000 0 0x1000>; /* VDEC_SYS */ video-codec@10000 { compatible = "mediatek,mtk-vcodec-lat"; reg = <0 0x10000 0 0x800>;
Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.yaml +2 -2
@@ -66,8 +66,8 @@ examples: - | memory-controller@7000f000 { compatible = "nvidia,tegra20-mc-gart"; - reg = <0x7000f000 0x400>, /* Controller registers */ - <0x58000000 0x02000000>; /* GART aperture */ + reg = <0x7000f000 0x400>, /* Controller registers */ + <0x58000000 0x02000000>; /* GART aperture */ clocks = <&clock_controller 32>; clock-names = "mc";
Documentation/devicetree/bindings/memory-controllers/samsung,exynos5422-dmc.yaml +1 -1
@@ -128,7 +128,7 @@ examples: "mout_mx_mspll_ccore", "mout_mclk_cdrex"; operating-points-v2 = <&dmc_opp_table>; - devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, + devfreq-events = <&ppmu_event3_dmc0_0>, <&ppmu_event3_dmc0_1>, <&ppmu_event3_dmc1_0>, <&ppmu_event3_dmc1_1>; device-handle = <&samsung_K3QF2F20DB>; vdd-supply = <&buck1_reg>;
Documentation/devicetree/bindings/pci/mediatek-pcie-mt7623.yaml +2 -2
@@ -125,8 +125,8 @@ examples: phy-names = "pcie-phy0", "pcie-phy1", "pcie-phy2"; power-domains = <&scpsys MT2701_POWER_DOMAIN_HIF>; bus-range = <0x00 0xff>; - ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000>, /* I/O space */ - <0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */ + ranges = <0x81000000 0 0x1a160000 0 0x1a160000 0 0x00010000>, /* I/O space */ + <0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */ pcie@0,0 { device_type = "pci";
Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml +1 -1
@@ -109,7 +109,7 @@ examples: num-lanes = <1>; num-viewport = <3>; bus-range = <0x00 0xff>; - ranges = <0x81000000 0 0 0x0c001000 0 0x00010000>, + ranges = <0x81000000 0 0 0x0c001000 0 0x00010000>, <0x82000000 0 0x0c011000 0x0c011000 0 0x03feefff>; vdd10-supply = <&ldo6_reg>; vdd18-supply = <&ldo7_reg>;
Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml +2 -2
@@ -248,13 +248,13 @@ examples: reg-names = "mpu"; interrupts = <82>, <83>; interrupt-names = "tx", "rx"; - op-mode = <0>; /* MCASP_IIS_MODE */ + op-mode = <0>; /* MCASP_IIS_MODE */ tdm-slots = <2>; ti,async-mode; dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>; dma-names = "tx", "rx"; serial-dir = < - 0 0 0 0 /* 0: INACTIVE, 1: TX, 2: RX */ + 0 0 0 0 /* 0: INACTIVE, 1: TX, 2: RX */ 0 0 0 0 0 0 0 1 2 0 0 0 >;
Documentation/devicetree/bindings/sound/simple-card.yaml +3 -3
@@ -315,7 +315,7 @@ examples: #address-cells = <1>; #size-cells = <0>; - simple-audio-card,dai-link@0 { /* I2S - HDMI */ + simple-audio-card,dai-link@0 { /* I2S - HDMI */ reg = <0>; format = "i2s"; cpu {
@@ -326,7 +326,7 @@ examples: }; }; - simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ + simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ reg = <1>; cpu { sound-dai = <&audio1>;
@@ -336,7 +336,7 @@ examples: }; }; - simple-audio-card,dai-link@2 { /* S/PDIF - S/PDIF */ + simple-audio-card,dai-link@2 { /* S/PDIF - S/PDIF */ reg = <2>; cpu { sound-dai = <&audio2>;
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +4 -4
@@ -88,7 +88,7 @@ examples: power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>; clocks = <&k3_clks 288 15>, <&k3_clks 288 3>; clock-names = "ref", "lpm"; - assigned-clocks = <&k3_clks 288 15>; /* USB2_REFCLK */ + assigned-clocks = <&k3_clks 288 15>; /* USB2_REFCLK */ assigned-clock-parents = <&k3_clks 288 16>; /* HFOSC0 */ #address-cells = <2>; #size-cells = <2>;
@@ -99,9 +99,9 @@ examples: <0x00 0x6010000 0x00 0x10000>, <0x00 0x6020000 0x00 0x10000>; reg-names = "otg", "xhci", "dev"; - interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */ - <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, /* irq.6 */ - <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; /* otgirq.0 */ + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */ + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, /* irq.6 */ + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; /* otgirq.0 */ interrupt-names = "host", "peripheral", "otg";
Signature · 1 line
2.54.0
Re: [PATCH 2/2] dt-bindings: drop tab characters from DTS examples
Quoted 14 lines · Daniel Golle
YAML literal block scalars cannot use tabs for indent. Replace tab separators (mostly between values and trailing /* ... */ comments) with single spaces.
Signed-off-by Daniel Golle <[email protected]>--- .../bindings/i2c/opencores,i2c-ocores.yaml | 8 ++--- .../bindings/iio/adc/st,spear600-adc.yaml | 2 +- .../devicetree/bindings/input/imx-keypad.yaml | 32 +++++++++---------- .../bindings/input/microchip,cap11xx.yaml | 12 +++---- .../input/touchscreen/ti,ads7843.yaml | 4 +-- .../devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- .../media/mediatek,vcodec-encoder.yaml | 2 +- .../media/mediatek,vcodec-subdev-decoder.yaml | 2 +-
Quoted 8 lines
.../memory-controllers/nvidia,tegra20-mc.yaml | 4 +-- .../samsung,exynos5422-dmc.yaml | 2 +- .../bindings/pci/mediatek-pcie-mt7623.yaml | 4 +-- .../bindings/pci/samsung,exynos-pcie.yaml | 2 +- .../bindings/sound/davinci-mcasp-audio.yaml | 4 +-- .../bindings/sound/simple-card.yaml | 6 ++-- .../devicetree/bindings/usb/ti,j721e-usb.yaml | 8 ++--- 15 files changed, 47 insertions(+), 47 deletions(-)
Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: misc: fsl,qoriq-mc: drop trailing whitespace
In reply to Daniel GolleQuoted 7 lines · Daniel Golle
Drop trailing whitespace from example.
Signed-off-by Daniel Golle <[email protected]>--- Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: misc: fsl,qoriq-mc: drop trailing whitespace
In reply to Daniel GolleQuoted 7 lines · Daniel Golle
Drop trailing whitespace from example.
Signed-off-by Daniel Golle <[email protected]>--- Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Re: [PATCH 2/2] dt-bindings: drop tab characters from DTS examples
In reply to Daniel GolleQuoted 14 lines · Daniel Golle
YAML literal block scalars cannot use tabs for indent. Replace tab separators (mostly between values and trailing /* ... */ comments) with single spaces.
Signed-off-by Daniel Golle <[email protected]>--- .../bindings/i2c/opencores,i2c-ocores.yaml | 8 ++--- .../bindings/iio/adc/st,spear600-adc.yaml | 2 +- .../devicetree/bindings/input/imx-keypad.yaml | 32 +++++++++---------- .../bindings/input/microchip,cap11xx.yaml | 12 +++---- .../input/touchscreen/ti,ads7843.yaml | 4 +-- .../devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- .../media/mediatek,vcodec-encoder.yaml | 2 +- .../media/mediatek,vcodec-subdev-decoder.yaml | 2 +-
Quoted 9 lines
.../memory-controllers/nvidia,tegra20-mc.yaml | 4 +-- .../samsung,exynos5422-dmc.yaml | 2 +- .../bindings/pci/mediatek-pcie-mt7623.yaml | 4 +-- .../bindings/pci/samsung,exynos-pcie.yaml | 2 +- .../bindings/sound/davinci-mcasp-audio.yaml | 4 +-- .../bindings/sound/simple-card.yaml | 6 ++-- .../devicetree/bindings/usb/ti,j721e-usb.yaml | 8 ++--- 15 files changed, 47 insertions(+), 47 deletions(-)
Applied, thanks!