bpf: Maximum combined stack depth
Subsystems (4)
v3 cover bpf: Maximum combined stack depth
This patchset dumps the maximum combined stack depth in verifier logs and parses it in veristat.
Changes in v3:
- Increment spec_cnt field in veristat for new MAX_STACK id (AI bot).
Changes in v2:
- Remove unnecessary max_stack_depth assignment (Eduard).
- Fix and test incorrect handling of private stacks.
- Add veristat metric (Eduard).
Paul Chaignon (3):
bpf: Report maximum combined stack depth
selftests/bpf: Test reported max stack depth
veristat: Report max stack depth
include/linux/bpf_verifier.h | 2 ++ kernel/bpf/verifier.c | 6 +++++- .../selftests/bpf/progs/verifier_bpf_fastcall.c | 3 +-- .../selftests/bpf/progs/verifier_private_stack.c | 15 +++++++++++++++ tools/testing/selftests/bpf/veristat.c | 13 +++++++++---- 5 files changed, 32 insertions(+), 7 deletions(-)
Signature · 1 line
2.43.0
PATCH v3 1/3 bpf: Report maximum combined stack depth
We've hit the 512 bytes limit on stack depth a few times in Cilium recently. As a result, we started reporting in CI our current maximum stack depth across all configurations for each BPF program.
Unfortunately, that is not trivial to compute in userspace. The verifier reports the stack depths of individual subprogs at the end of the logs. However the maximum combined stack depth also depends on the callgraph of those subprogs (the max combined stack depth is the height of the callgraph weighted by per-subprog stack depths). We can compute a callgraph in userspace from the loaded instructions, but it often doesn't match the verifier's own callgraph because of dead code elimination. Our current approach relies on dumping the BPF_LOG_LEVEL2 logs, but this feels overkill considering the verifier already has the information we need.
The patch lets the verifier dump the maximum combined stack depth in the logs, on the same line as the per-subprog stack depths:
stack depth 16+256 max 272
The per-subprog stack depths and the new max stack depth are not directly comparable. The former is sometimes updated during fixups, while the latter is not. As a result, even with a single subprog, we may end up with two slightly different values. The aim of the new max value is to be closest to what is actually enforced by the verifier.
--- include/linux/bpf_verifier.h | 2 ++ kernel/bpf/verifier.c | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-)
include/linux/bpf_verifier.h +2 -0
@@ -952,6 +952,8 @@ struct bpf_verifier_env {u32 prev_insn_processed, insn_processed;/* number of jmps, calls, exits analyzed so far */ u32 prev_jmps_processed, jmps_processed; +/* maximum combined stack depth */ +u32 max_stack_depth;/* total verification time */ u64 verification_time;/* maximum number of verifier states kept in 'branching' instructions */
kernel/bpf/verifier.c +5 -1
@@ -5038,6 +5038,8 @@ static int check_max_stack_depth_subprog(struct bpf_verifier_env *env, int idx, }if (subprog[idx].priv_stack_mode ==PRIV_STACK_ADAPTIVE ) { +if (subprog_depth > env->max_stack_depth) + env->max_stack_depth = subprog_depth;if (subprog_depth >MAX_BPF_STACK ) {verbose (env,"stack size of subprog %d is %d. Too large\n" , idx, subprog_depth);
@@ -5045,6 +5047,8 @@ static int check_max_stack_depth_subprog(struct bpf_verifier_env *env, int idx, } }else { depth += subprog_depth; +if (depth > env->max_stack_depth) + env->max_stack_depth = depth;if (depth >MAX_BPF_STACK ) { total =0 ;for (tmp = idx; tmp >=0 ; tmp = dinfo[tmp].caller)
@@ -18289,7 +18293,7 @@ static void print_verification_stats(struct bpf_verifier_env *env)verbose (env,"stack depth %d" , env->subprog_info[0 ].stack_depth);for (i =1 ; i < subprog_cnt; i++)verbose (env,"+%d" , env->subprog_info[i].stack_depth); -verbose (env,"\n" ); +verbose (env," max %d\n" , env->max_stack_depth);verbose (env,"insns processed %d" , env->subprog_info[0 ].insn_processed);for (i =1 ; i < subprog_cnt; i++)if (bpf_subprog_is_global (env, i))
Signature · 1 line
2.43.0
PATCH v3 2/3 selftests/bpf: Test reported max stack depth
In reply to Paul ChaignonThis patch tests the maximum stack depth reporting in verifier logs, with a couple special cases covered: fastcall, private stacks (main subprog & callee), and rounding up to 16 bytes. For that last one, we need to skip the test when JIT compilation is disabled as the rounding is then to 32 bytes.
--- .../selftests/bpf/progs/verifier_bpf_fastcall.c | 3 +-- .../selftests/bpf/progs/verifier_private_stack.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/progs/verifier_bpf_fastcall.c +1 -2
@@ -799,8 +799,7 @@ __naked int bpf_loop_interaction2(void) SEC("raw_tp") __arch_x86_64 -__log_level(4) -__msg("stack depth 512+0") +__log_level(4) __msg("stack depth 512+0 max 512")/* just to print xlated version when debugging */ __xlated ("r0 = &(void __percpu *)(r0)" ) __success
tools/testing/selftests/bpf/progs/verifier_private_stack.c +15 -0
@@ -86,6 +86,7 @@ __naked static void cumulative_stack_depth_subprog(void) SEC("kprobe") __description("Private stack, subtree > MAX_BPF_STACK") __success +__log_level(4) __msg("stack depth 512+32 max 512") __arch_x86_64 /* private stack fp for the main prog */ __jited(" movabsq $0x{{.*}}, %r9")
@@ -324,6 +325,8 @@ int private_stack_async_callback_1(void) SEC("fentry/bpf_fentry_test9") __description("Private stack, async callback, potential nesting") __success __retval(0) +__load_if_JITed() +__log_level(4) __msg("stack depth 8+0+256+0 max 272") __arch_x86_64 __jited(" subq $0x100, %rsp") __arch_arm64
@@ -344,6 +347,18 @@ int private_stack_async_callback_2(void)return 0 ; } +SEC("fentry/bpf_fentry_test9") +__description("private stack, max stack depth is private stack") +__success +__log_level(4) __msg("stack depth 8+256+0 max 256") +int private_stack_max_depth (void ) +{ +int x =0 ; + +subprog1 (&x); +return 0 ; +} +#else SEC ("kprobe" )
Signature · 1 line
2.43.0
PATCH v3 3/3 veristat: Report max stack depth
In reply to Paul ChaignonThis patch adds a new "Max stack depth" field to the set of gathered statistics. This field reports the maximum combined stack depth compared to the 512 bytes limit. It is null for rejected programs.
--- tools/testing/selftests/bpf/veristat.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/veristat.c +9 -4
@@ -48,6 +48,7 @@ enum stat_id {SIZE ,JITED_SIZE ,STACK , +MAX_STACK ,PROG_TYPE ,ATTACH_TYPE , MEMORY_PEAK,
@@ -789,13 +790,13 @@ static int append_file_from_file(const char *path) }static const struct stat_specs default_csv_output_spec = { - .spec_cnt =15 , + .spec_cnt =16 , .ids = {FILE_NAME ,PROG_NAME ,VERDICT ,DURATION ,TOTAL_INSNS ,TOTAL_STATES ,PEAK_STATES ,MAX_STATES_PER_INSN ,MARK_READ_MAX_LEN ,SIZE ,JITED_SIZE ,PROG_TYPE ,ATTACH_TYPE , -STACK ,MEMORY_PEAK , +STACK ,MAX_STACK ,MEMORY_PEAK , }, };
@@ -834,6 +835,7 @@ static struct stat_def { [SIZE] = { "Program size", {"prog_size"}, }, [JITED_SIZE] = { "Jited size", {"prog_size_jited"}, }, [STACK] = {"Stack depth", {"stack_depth", "stack"}, }, + [MAX_STACK] = {"Max stack depth", {"max_stack_depth"}, }, [PROG_TYPE] = { "Program type", {"prog_type"}, }, [ATTACH_TYPE] = { "Attach type", {"attach_type", }, }, [MEMORY_PEAK] = { "Peak memory (MiB)", {"mem_peak", }, },
@@ -1023,7 +1025,7 @@ static int parse_verif_log(char * const buf, size_t buf_sz, struct verif_stats * &s->stats[MARK_READ_MAX_LEN]))continue ; -if (1 ==sscanf (cur,"stack depth %511s" , stack)) +if (2 ==sscanf (cur,"stack depth %511s max %ld" , stack, &s->stats[MAX_STACK ]))continue ; }while ((token =strtok_r (cnt++ ?NULL : stack,"+" , &state))) {
@@ -2278,6 +2280,7 @@ static int cmp_stat(const struct verif_stats *s1, const struct verif_stats *s2,case SIZE :case JITED_SIZE :case STACK : +case MAX_STACK :case VERDICT :case DURATION :case TOTAL_INSNS :
@@ -2512,6 +2515,7 @@ static void prepare_value(const struct verif_stats *s, enum stat_id id,case MAX_STATES_PER_INSN :case MARK_READ_MAX_LEN :case STACK : +case MAX_STACK :case SIZE :case JITED_SIZE :case MEMORY_PEAK :
@@ -2602,7 +2606,8 @@ static int parse_stat_value(const char *str, enum stat_id id, struct verif_statscase SIZE :case JITED_SIZE :case MEMORY_PEAK : -case STACK : { +case STACK : +case MAX_STACK : {long val;int err, n;
Signature · 1 line
2.43.0
Eduard Zingerman
maintainerRe: [PATCH bpf-next v3 3/3] veristat: Report max stack depth
On Wed, 2026-05-13 at 21:35 +0200, Paul Chaignon wrote:
[...]
Quoted 9 lines
tools/testing/selftests/bpf/veristat.c +1
-0@@ -834,6 +835,7 @@ static struct stat_def { [SIZE] = { "Program size", {"prog_size"}, }, [JITED_SIZE] = { "Jited size", {"prog_size_jited"}, }, [STACK] = {"Stack depth", {"stack_depth", "stack"}, }, + [MAX_STACK] = {"Max stack depth", {"max_stack_depth"}, }, [PROG_TYPE] = { "Program type", {"prog_type"}, }, [ATTACH_TYPE] = { "Attach type", {"attach_type", }, }, [MEMORY_PEAK] = { "Peak memory (MiB)", {"mem_peak", }, },
tools/testing/selftests/bpf/veristat.c static int parse_verif_log(char * const buf, size_t buf_sz, struct verif_stats * · line 1031
Quoted 8 lines
tools/testing/selftests/bpf/veristat.c +1
-1@@ -1023,7 +1025,7 @@ static int parse_verif_log(char * const buf, size_t buf_sz, struct verif_stats * &s->stats[MARK_READ_MAX_LEN]))continue ; -if (1 ==sscanf (cur,"stack depth %511s" , stack)) +if (2 ==sscanf (cur,"stack depth %511s max %ld" , stack, &s->stats[MAX_STACK ]))continue ; }while ((token =strtok_r (cnt++ ?NULL : stack,"+" , &state))) {
Thinking about it some more I think that the meaning of the STACK/"Stack depth" metric should swapped for max stack depth.
[...]
Re: [PATCH bpf-next v3 1/3] bpf: Report maximum combined stack depth
In reply to Paul ChaignonQuoted 20 lines · Paul Chaignon
We've hit the 512 bytes limit on stack depth a few times in Cilium recently. As a result, we started reporting in CI our current maximum stack depth across all configurations for each BPF program.
Unfortunately, that is not trivial to compute in userspace. The verifier reports the stack depths of individual subprogs at the end of the logs. However the maximum combined stack depth also depends on the callgraph of those subprogs (the max combined stack depth is the height of the callgraph weighted by per-subprog stack depths). We can compute a callgraph in userspace from the loaded instructions, but it often doesn't match the verifier's own callgraph because of dead code elimination. Our current approach relies on dumping the
BPF_LOG_LEVEL2logs, but this feels overkill considering the verifier already has the information we need.The patch lets the verifier dump the maximum combined stack depth in the logs, on the same line as the per-subprog stack depths:
stack depth 16+256 max 272
Quoted 8 lines
The per-subprog stack depths and the new max stack depth are not directly comparable. The former is sometimes updated during fixups, while the latter is not. As a result, even with a single subprog, we may end up with two slightly different values. The aim of the new max value is to be closest to what is actually enforced by the verifier.
Signed-off-by Paul Chaignon <[email protected]>---
[...]
Re: [PATCH bpf-next v3 2/3] selftests/bpf: Test reported max stack depth
In reply to Paul ChaignonQuoted 8 lines · Paul Chaignon
This patch tests the maximum stack depth reporting in verifier logs, with a couple special cases covered: fastcall, private stacks (main subprog & callee), and rounding up to 16 bytes. For that last one, we need to skip the test when JIT compilation is disabled as the rounding is then to 32 bytes.
Signed-off-by Paul Chaignon <[email protected]>---
[...]
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 11 lines · On Wed, 13 May 2026 21:33:41 +0200 you wrote:
This patchset dumps the maximum combined stack depth in verifier logs and parses it in veristat.
Changes in v3:
- Incrementspec_cntfield in veristat for newMAX_STACKid (AI bot).
Changes in v2:
- Remove unnecessarymax_stack_depthassignment (Eduard).
- Fix and test incorrect handling of private stacks.
- Add veristat metric (Eduard).[...]
Here is the summary with links:
- [bpf-next,v3,1/3] bpf: Report maximum combined stack depth
https://git.kernel.org/bpf/bpf-next/c/f41f34ec6474 - [bpf-next,v3,2/3] selftests/bpf: Test reported max stack depth https://git.kernel.org/bpf/bpf-next/c/2a5b22e87ba5 - [bpf-next,v3,3/3] veristat: Report max stack depth https://git.kernel.org/bpf/bpf-next/c/f0015ffbf40c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH bpf-next v3 3/3] veristat: Report max stack depth
In reply to Eduard ZingermanQuoted 16 lines · Eduard Zingerman
On Wed, 2026-05-13 at 21:35 +0200, Paul Chaignon wrote:
[...]
Quoted 12 lines
tools/testing/selftests/bpf/veristat.c +1
-0@@ -834,6 +835,7 @@ static struct stat_def { [SIZE] = { "Program size", {"prog_size"}, }, [JITED_SIZE] = { "Jited size", {"prog_size_jited"}, }, [STACK] = {"Stack depth", {"stack_depth", "stack"}, }, + [MAX_STACK] = {"Max stack depth", {"max_stack_depth"}, }, [PROG_TYPE] = { "Program type", {"prog_type"}, }, [ATTACH_TYPE] = { "Attach type", {"attach_type", }, }, [MEMORY_PEAK] = { "Peak memory (MiB)", {"mem_peak", }, },@@ -1023,7 +1025,7 @@ static int parse_verif_log(char * const buf, size_t buf_sz, struct verif_stats * &s->stats[MARK_READ_MAX_LEN]))continue ;
Quoted 8 lines
tools/testing/selftests/bpf/veristat.c static int parse_verif_log(char * const buf, size_t buf_sz, struct verif_stats * · line 1031
Quoted 5 lines
tools/testing/selftests/bpf/veristat.c +1
-1-if (1 ==sscanf (cur,"stack depth %511s" , stack)) +if (2 ==sscanf (cur,"stack depth %511s max %ld" , stack, &s->stats[MAX_STACK ]))continue ; }while ((token =strtok_r (cnt++ ?NULL : stack,"+" , &state))) {Thinking about it some more I think that the meaning of the STACK/"Stack depth" metric should swapped for max stack depth.
Hm, I was a bit worried that might be considered a breaking change (ex., if someone is tracking the STACK metric over time), but if you think it's alright, I can send a followup to replace STACK with MAX_STACK. I agree it would be better as the STACK metric may not correspond to anything real at the moment (ex., if the callgraph may be all flat).
Quoted 2 lines
[...]