locking: contended_release tracepoint instrumentation
Subsystems (4)
v7 cover locking: contended_release tracepoint instrumentation
The existing contention_begin/contention_end tracepoints fire on the waiter side. The lock holder's identity and stack can be captured at contention_begin time (e.g. perf lock contention --lock-owner), but only for locks whose owner it reads: mutex and rwsem. Other lock types have none it can read, so they get no holder-side attribution today.
This series adds a contended_release tracepoint that fires on the holder side when a lock with waiters is released. This provides:
- Hold time estimation: when the holder's own acquisition was contended, its contention_end (acquisition) and contended_release can be correlated to measure how long the lock was held under contention.
- The holder's stack at release time, which may differ from what perf lock contention --lock-owner captures if the holder does significant work between the waiter's arrival and the unlock.
Note: for reader/writer locks, the tracepoint fires for every reader releasing while a writer is waiting, not only for the last reader.
v6 -> v7:
- Dropped spinlocks instrumentation patches, I'll rework them based on Peter's static call idea. See [2].
v5 -> v6:
- Use trace_call__contended_release() instead of trace_contended_release(), where appropriate to avoid a redundant static branch check when the caller already guards with trace_contended_release_enabled().
- Added acked-by from Paul.
- Rebase on top of the fresh locking/core.
v4 -> v5:
- Split the combined spinning locks patch into separate qspinlock and qrwlock patches (Paul E. McKenney).
- Factor out __queued_read_unlock()/__queued_write_unlock() as a separate preparatory commit, mirroring the queued_spin_release() split (Paul E. McKenney).
- Updated binary size numbers for qspinlock-only change.
- Added Acked-by and Reviewed-by tags where appropriate.
v3 -> v4:
- Fix spurious events in __percpu_up_read(): guard with rcuwait_active(&sem->writer) to avoid tracing during the RCU grace period after a writer releases (Sashiko).
- Fix possible use-after-free in semaphore up(): move trace_contended_release() inside the sem->lock critical section (Sashiko).
- Fix build failure with CONFIG_PARAVIRT_SPINLOCKS=y: introduce queued_spin_release() as the arch-overridable unlock primitive, so queued_spin_unlock() can be a generic tracing wrapper. Convert x86 (paravirt) and MIPS overrides (Sashiko).
- Add EXPORT_TRACEPOINT_SYMBOL_GPL(contended_release) for module support (Sashiko).
- Split spinning locks patch: factor out queued_spin_release() as a separate preparatory commit (Sashiko).
- Make read unlock tracepoint behavior consistent across all reader/writer lock types: fire for every reader releasing while a writer is waiting (rwsem, rwbase_rt were previously last-reader only).
v2 -> v3:
- Added new patch: extend contended_release tracepoint to queued spinlocks and queued rwlocks (marked as RFC, requesting feedback). This is prompted by Matthew Wilcox's suggestion to try to come up with generic instrumentation, instead of instrumenting each "special" lock manually. See [1] for the discussion.
- Reworked tracepoint placement to fire before the lock is released and before the waiter is woken where possible, for consistency with spinning locks where there is no explicit wake (inspired by Usama Arif's suggestion).
- Remove unnecessary linux/sched.h include from trace/events/lock.h.
RFC -> v2:
- Add trace_contended_release_enabled() guard before waiter checks that exist only for the tracepoint (Steven Rostedt).
- Rename __percpu_up_read_slowpath() to __percpu_up_read() (Peter Zijlstra).
- Add extern for __percpu_up_read() (Peter Zijlstra).
- Squashed tracepoint introduction and usage commits (Masami Hiramatsu).
v6: https://lore.kernel.org/all/[email protected]/
v5: https://lore.kernel.org/all/[email protected]/
v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
RFC: https://lore.kernel.org/all/[email protected]/
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/
Dmitry Ilvokhin (3):
tracing/lock: Remove unnecessary linux/sched.h include locking/percpu-rwsem: Extract __percpu_up_read()
locking: Add contended_release tracepoint to sleepable locks
include/linux/percpu-rwsem.h | 15 +++------------ include/trace/events/lock.h | 18 +++++++++++++++++- kernel/locking/mutex.c | 4 ++++ kernel/locking/percpu-rwsem.c | 29 +++++++++++++++++++++++++++++ kernel/locking/rtmutex.c | 1 + kernel/locking/rwbase_rt.c | 6 ++++++ kernel/locking/rwsem.c | 10 ++++++++-- kernel/locking/semaphore.c | 4 ++++ 8 files changed, 72 insertions(+), 15 deletions(-)
Signature · 1 line
2.53.0-Meta
PATCH v7 1/3 tracing/lock: Remove unnecessary linux/sched.h include
None of the trace events in lock.h reference anything from linux/sched.h. Remove the unnecessary include.
--- include/trace/events/lock.h | 1 - 1 file changed, 1 deletion(-)
include/trace/events/lock.h +0 -1
@@ -5,7 +5,6 @@#if !defined(_TRACE_LOCK_H) || defined(TRACE_HEADER_MULTI_READ )#define _TRACE_LOCK_H -#include <linux/sched.h> #include <linux/tracepoint.h> /* flags for lock:contention_begin */
Signature · 1 line
2.53.0-Meta
[tip: locking/core] tracing/lock: Remove unnecessary linux/sched.h include
The following commit has been merged into the locking/core branch of tip:
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 76080d81e511f66eeb094b204e1e217bff674922 Gitweb: https://git.kernel.org/tip/76080d81e511f66eeb094b204e1e217bff674922 Author: Dmitry Ilvokhin <[email protected]> AuthorDate: Thu, 04 Jun 2026 07:15:05 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 11 Jun 2026 13:41:24 +02:00
tracing/lock: Remove unnecessary linux/sched.h include
None of the trace events in lock.h reference anything from linux/sched.h. Remove the unnecessary include.
--- include/trace/events/lock.h | 1 - 1 file changed, 1 deletion(-)
include/trace/events/lock.h +0 -1
@@ -5,7 +5,6 @@#if !defined(_TRACE_LOCK_H) || defined(TRACE_HEADER_MULTI_READ )#define _TRACE_LOCK_H -#include <linux/sched.h> #include <linux/tracepoint.h> /* flags for lock:contention_begin */
PATCH v7 2/3 locking/percpu-rwsem: Extract __percpu_up_read()
In reply to Dmitry IlvokhinMove the percpu_up_read() slowpath out of the inline function into a new __percpu_up_read() to avoid binary size increase from adding a tracepoint to an inlined function.
--- include/linux/percpu-rwsem.h | 15 +++------------ kernel/locking/percpu-rwsem.c | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+), 12 deletions(-)
include/linux/percpu-rwsem.h +3 -12
@@ -107,6 +107,8 @@ static inline bool percpu_down_read_trylock(struct percpu_rw_semaphore *sem)return ret; } +extern void __percpu_up_read (struct percpu_rw_semaphore *sem); +static inline void percpu_up_read (struct percpu_rw_semaphore *sem) {rwsem_release (&sem->dep_map, _RET_IP_);
@@ -118,18 +120,7 @@ static inline void percpu_up_read(struct percpu_rw_semaphore *sem)if (likely (rcu_sync_is_idle (&sem->rss))) {this_cpu_dec (*sem->read_count); }else { -/* -* slowpath; reader will only ever wake a single blocked -* writer. -*/ -smp_mb ();/* B matches C */ -/* -* In other words, if they see our decrement (presumably to -* aggregate zero, as that is the only time it matters) they -* will also see our critical section. -*/ -this_cpu_dec (*sem->read_count); -rcuwait_wake_up (&sem->writer); +__percpu_up_read (sem); }preempt_enable (); }
kernel/locking/percpu-rwsem.c +18 -0
@@ -288,3 +288,21 @@ void percpu_up_write(struct percpu_rw_semaphore *sem)rcu_sync_exit (&sem->rss); }EXPORT_SYMBOL_GPL (percpu_up_write); + +void __percpu_up_read (struct percpu_rw_semaphore *sem) +{ +lockdep_assert_preemption_disabled (); +/* +* slowpath; reader will only ever wake a single blocked +* writer. +*/ +smp_mb ();/* B matches C */ +/* +* In other words, if they see our decrement (presumably to +* aggregate zero, as that is the only time it matters) they +* will also see our critical section. +*/ +this_cpu_dec (*sem->read_count); +rcuwait_wake_up (&sem->writer); +} +EXPORT_SYMBOL_GPL (__percpu_up_read);
Signature · 1 line
2.53.0-Meta
[tip: locking/core] locking/percpu-rwsem: Extract __percpu_up_read()
The following commit has been merged into the locking/core branch of tip:
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 7cfa62cf9432df67b1c95a59984a03a3bc023f98 Gitweb: https://git.kernel.org/tip/7cfa62cf9432df67b1c95a59984a03a3bc023f98 Author: Dmitry Ilvokhin <[email protected]> AuthorDate: Thu, 04 Jun 2026 07:15:06 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 11 Jun 2026 13:41:25 +02:00
locking/percpu-rwsem: Extract __percpu_up_read()
Move the percpu_up_read() slowpath out of the inline function into a new __percpu_up_read() to avoid binary size increase from adding a tracepoint to an inlined function.
--- include/linux/percpu-rwsem.h | 15 +++------------ kernel/locking/percpu-rwsem.c | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+), 12 deletions(-)
include/linux/percpu-rwsem.h +3 -12
@@ -107,6 +107,8 @@ static inline bool percpu_down_read_trylock(struct percpu_rw_semaphore *sem)return ret; } +extern void __percpu_up_read (struct percpu_rw_semaphore *sem); +static inline void percpu_up_read (struct percpu_rw_semaphore *sem) {rwsem_release (&sem->dep_map, _RET_IP_);
@@ -118,18 +120,7 @@ static inline void percpu_up_read(struct percpu_rw_semaphore *sem)if (likely (rcu_sync_is_idle (&sem->rss))) {this_cpu_dec (*sem->read_count); }else { -/* -* slowpath; reader will only ever wake a single blocked -* writer. -*/ -smp_mb ();/* B matches C */ -/* -* In other words, if they see our decrement (presumably to -* aggregate zero, as that is the only time it matters) they -* will also see our critical section. -*/ -this_cpu_dec (*sem->read_count); -rcuwait_wake_up (&sem->writer); +__percpu_up_read (sem); }preempt_enable (); }
kernel/locking/percpu-rwsem.c +18 -0
@@ -288,3 +288,21 @@ void percpu_up_write(struct percpu_rw_semaphore *sem)rcu_sync_exit (&sem->rss); }EXPORT_SYMBOL_GPL (percpu_up_write); + +void __percpu_up_read (struct percpu_rw_semaphore *sem) +{ +lockdep_assert_preemption_disabled (); +/* +* slowpath; reader will only ever wake a single blocked +* writer. +*/ +smp_mb ();/* B matches C */ +/* +* In other words, if they see our decrement (presumably to +* aggregate zero, as that is the only time it matters) they +* will also see our critical section. +*/ +this_cpu_dec (*sem->read_count); +rcuwait_wake_up (&sem->writer); +} +EXPORT_SYMBOL_GPL (__percpu_up_read);
PATCH v7 3/3 locking: Add contended_release tracepoint to sleepable locks
In reply to Dmitry IlvokhinAdd the contended_release trace event. This tracepoint fires on the holder side when a contended lock is released, complementing the existing contention_begin/contention_end tracepoints which fire on the waiter side.
This enables correlating lock hold time under contention with waiter events by lock address.
Add trace_contended_release()/trace_call__contended_release() calls to the slowpath unlock paths of sleepable locks: mutex, rtmutex, semaphore, rwsem, percpu-rwsem, and RT-specific rwbase locks.
Where possible, trace_contended_release() fires before the lock is released and before the waiter is woken. For some lock types, the tracepoint fires after the release but before the wake. Making the placement consistent across all lock types is not worth the added complexity.
For reader/writer locks, the tracepoint fires for every reader releasing while a writer is waiting, not only for the last reader.
--- include/trace/events/lock.h | 17 +++++++++++++++++ kernel/locking/mutex.c | 4 ++++ kernel/locking/percpu-rwsem.c | 11 +++++++++++ kernel/locking/rtmutex.c | 1 + kernel/locking/rwbase_rt.c | 6 ++++++ kernel/locking/rwsem.c | 10 ++++++++-- kernel/locking/semaphore.c | 4 ++++ 7 files changed, 51 insertions(+), 2 deletions(-)
include/trace/events/lock.h +17 -0
@@ -137,6 +137,23 @@ TRACE_EVENT(contention_end,TP_printk ("%p (ret=%d)" , __entry->lock_addr, __entry->ret) ); +TRACE_EVENT (contended_release, + +TP_PROTO (void *lock), + +TP_ARGS (lock), + +TP_STRUCT__entry ( + __field(void *, lock_addr) + ), + +TP_fast_assign ( + __entry->lock_addr = lock; + ), + +TP_printk ("%p" , __entry->lock_addr) +); +#endif /* _TRACE_LOCK_H */ /* This part must be outside protection */
kernel/locking/mutex.c +4 -0
@@ -1023,6 +1023,9 @@ static noinline void __sched __mutex_unlock_slowpath(struct mutex *lock, unsignewake_q_add (&wake_q, next); } +if (trace_contended_release_enabled () && waiter) +trace_call__contended_release (lock); +if (owner &MUTEX_FLAG_HANDOFF )__mutex_handoff (lock, next);
@@ -1220,6 +1223,7 @@ EXPORT_SYMBOL(ww_mutex_lock_interruptible);EXPORT_TRACEPOINT_SYMBOL_GPL (contention_begin);EXPORT_TRACEPOINT_SYMBOL_GPL (contention_end); +EXPORT_TRACEPOINT_SYMBOL_GPL (contended_release);/** * atomic_dec_and_mutex_lock - return holding mutex if we dec to 0
kernel/locking/percpu-rwsem.c +11 -0
@@ -263,6 +263,9 @@ void percpu_up_write(struct percpu_rw_semaphore *sem) {rwsem_release (&sem->dep_map, _RET_IP_); +if (trace_contended_release_enabled () &&wq_has_sleeper (&sem->waiters)) +trace_call__contended_release (sem); +/* * Signal the writer is done, no fast path yet. *
@@ -292,6 +295,14 @@ EXPORT_SYMBOL_GPL(percpu_up_write);void __percpu_up_read (struct percpu_rw_semaphore *sem) {lockdep_assert_preemption_disabled (); +/* +* After percpu_up_write() completes, rcu_sync_is_idle() can still +* return false during the grace period, forcing readers into this +* slowpath. Only trace when a writer is actually waiting for +* readers to drain. +*/ +if (trace_contended_release_enabled () &&rcuwait_active (&sem->writer)) +trace_call__contended_release (sem);/* * slowpath; reader will only ever wake a single blocked * writer.
kernel/locking/rtmutex.c +1 -0
@@ -1470,6 +1470,7 @@ static void __sched rt_mutex_slowunlock(struct rt_mutex_base *lock)raw_spin_lock_irqsave (&lock->wait_lock, flags); } +trace_contended_release (lock);/* * The wakeup next waiter path does not suffer from the above * race. See the comments there.
kernel/locking/rwbase_rt.c +6 -0
@@ -174,6 +174,8 @@ static void __sched __rwbase_read_unlock(struct rwbase_rt *rwb, static __always_inline void rwbase_read_unlock(struct rwbase_rt *rwb,unsigned int state) { +if (trace_contended_release_enabled () &&rt_mutex_owner (&rwb->rtmutex)) +trace_call__contended_release (rwb);/* * rwb->readers can only hit 0 when a writer is waiting for the * active readers to leave the critical section.
@@ -205,6 +207,8 @@ static inline void rwbase_write_unlock(struct rwbase_rt *rwb)unsigned long flags;raw_spin_lock_irqsave (&rtm->wait_lock, flags); +if (trace_contended_release_enabled () &&rt_mutex_has_waiters (rtm)) +trace_call__contended_release (rwb);__rwbase_write_unlock (rwb,WRITER_BIAS , flags); }
@@ -214,6 +218,8 @@ static inline void rwbase_write_downgrade(struct rwbase_rt *rwb)unsigned long flags;raw_spin_lock_irqsave (&rtm->wait_lock, flags); +if (trace_contended_release_enabled () &&rt_mutex_has_waiters (rtm)) +trace_call__contended_release (rwb);/* Release it and account current as reader */ __rwbase_write_unlock (rwb,WRITER_BIAS -1 , flags); }
kernel/locking/rwsem.c +8 -2
@@ -1387,6 +1387,8 @@ static inline void __up_read(struct rw_semaphore *sem)rwsem_clear_reader_owned (sem); tmp =atomic_long_add_return_release (-RWSEM_READER_BIAS , &sem->count);DEBUG_RWSEMS_WARN_ON (tmp <0 , sem); +if (trace_contended_release_enabled () && (tmp &RWSEM_FLAG_WAITERS )) +trace_call__contended_release (sem);if (unlikely ((tmp & (RWSEM_LOCK_MASK |RWSEM_FLAG_WAITERS )) ==RWSEM_FLAG_WAITERS )) {clear_nonspinnable (sem);
@@ -1413,8 +1415,10 @@ static inline void __up_write(struct rw_semaphore *sem)preempt_disable ();rwsem_clear_owner (sem); tmp =atomic_long_fetch_add_release (-RWSEM_WRITER_LOCKED , &sem->count); -if (unlikely (tmp &RWSEM_FLAG_WAITERS )) +if (unlikely (tmp &RWSEM_FLAG_WAITERS )) { +trace_contended_release (sem);rwsem_wake (sem); + }preempt_enable (); }
@@ -1437,8 +1441,10 @@ static inline void __downgrade_write(struct rw_semaphore *sem) tmp =atomic_long_fetch_add_release ( -RWSEM_WRITER_LOCKED +RWSEM_READER_BIAS , &sem->count);rwsem_set_reader_owned (sem); -if (tmp &RWSEM_FLAG_WAITERS ) +if (tmp &RWSEM_FLAG_WAITERS ) { +trace_contended_release (sem);rwsem_downgrade_wake (sem); + }preempt_enable (); }
kernel/locking/semaphore.c +4 -0
@@ -230,6 +230,10 @@ void __sched up(struct semaphore *sem) sem->count++; else __up(sem, &wake_q); + +if (trace_contended_release_enabled () && !wake_q_empty (&wake_q)) +trace_call__contended_release (sem); +raw_spin_unlock_irqrestore (&sem->lock, flags);if (!wake_q_empty (&wake_q))wake_up_q (&wake_q);
Signature · 1 line
2.53.0-Meta
Re: [PATCH v7 3/3] locking: Add contended_release tracepoint to sleepable locks
Quoted 18 lines · On Thu, 4 Jun 2026 07:15:07 +0000 Dmitry Ilvokhin <[email protected]> wrote:
Add the
contended_releasetrace event. This tracepoint fires on the holder side when a contended lock is released, complementing the existing contention_begin/contention_end tracepoints which fire on the waiter side.This enables correlating lock hold time under contention with waiter events by lock address.
Add trace_contended_release()/trace_call__contended_release() calls to the slowpath unlock paths of sleepable locks: mutex, rtmutex, semaphore, rwsem, percpu-rwsem, and RT-specific rwbase locks.
Where possible,
trace_contended_release()fires before the lock is released and before the waiter is woken. For some lock types, the tracepoint fires after the release but before the wake. Making the placement consistent across all lock types is not worth the added complexity.
Quoted 5 lines
For reader/writer locks, the tracepoint fires for every reader releasing while a writer is waiting, not only for the last reader.
Signed-off-by Dmitry Ilvokhin <[email protected]>Acked-by Paul E. McKenney <[email protected]>
[tip: locking/core] locking: Add contended_release tracepoint to sleepable locks
In reply to Dmitry IlvokhinThe following commit has been merged into the locking/core branch of tip:
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 4f070ccb4dc4692e3b6757819fb80655f58b4f12 Gitweb: https://git.kernel.org/tip/4f070ccb4dc4692e3b6757819fb80655f58b4f12 Author: Dmitry Ilvokhin <[email protected]> AuthorDate: Thu, 04 Jun 2026 07:15:07 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 11 Jun 2026 13:41:25 +02:00
locking: Add contended_release tracepoint to sleepable locks
Add the contended_release trace event. This tracepoint fires on the holder side when a contended lock is released, complementing the existing contention_begin/contention_end tracepoints which fire on the waiter side.
This enables correlating lock hold time under contention with waiter events by lock address.
Add trace_contended_release()/trace_call__contended_release() calls to the slowpath unlock paths of sleepable locks: mutex, rtmutex, semaphore, rwsem, percpu-rwsem, and RT-specific rwbase locks.
Where possible, trace_contended_release() fires before the lock is released and before the waiter is woken. For some lock types, the tracepoint fires after the release but before the wake. Making the placement consistent across all lock types is not worth the added complexity.
For reader/writer locks, the tracepoint fires for every reader releasing while a writer is waiting, not only for the last reader.
--- include/trace/events/lock.h | 17 +++++++++++++++++ kernel/locking/mutex.c | 4 ++++ kernel/locking/percpu-rwsem.c | 11 +++++++++++ kernel/locking/rtmutex.c | 1 + kernel/locking/rwbase_rt.c | 6 ++++++ kernel/locking/rwsem.c | 10 ++++++++-- kernel/locking/semaphore.c | 4 ++++ 7 files changed, 51 insertions(+), 2 deletions(-)
include/trace/events/lock.h +17 -0
@@ -137,6 +137,23 @@ TRACE_EVENT(contention_end,TP_printk ("%p (ret=%d)" , __entry->lock_addr, __entry->ret) ); +TRACE_EVENT (contended_release, + +TP_PROTO (void *lock), + +TP_ARGS (lock), + +TP_STRUCT__entry ( + __field(void *, lock_addr) + ), + +TP_fast_assign ( + __entry->lock_addr = lock; + ), + +TP_printk ("%p" , __entry->lock_addr) +); +#endif /* _TRACE_LOCK_H */ /* This part must be outside protection */
kernel/locking/mutex.c +4 -0
@@ -1023,6 +1023,9 @@ static noinline void __sched __mutex_unlock_slowpath(struct mutex *lock, unsignewake_q_add (&wake_q, next); } +if (trace_contended_release_enabled () && waiter) +trace_call__contended_release (lock); +if (owner &MUTEX_FLAG_HANDOFF )__mutex_handoff (lock, next);
@@ -1220,6 +1223,7 @@ EXPORT_SYMBOL(ww_mutex_lock_interruptible);EXPORT_TRACEPOINT_SYMBOL_GPL (contention_begin);EXPORT_TRACEPOINT_SYMBOL_GPL (contention_end); +EXPORT_TRACEPOINT_SYMBOL_GPL (contended_release);/** * atomic_dec_and_mutex_lock - return holding mutex if we dec to 0
kernel/locking/percpu-rwsem.c +11 -0
@@ -263,6 +263,9 @@ void percpu_up_write(struct percpu_rw_semaphore *sem) {rwsem_release (&sem->dep_map, _RET_IP_); +if (trace_contended_release_enabled () &&wq_has_sleeper (&sem->waiters)) +trace_call__contended_release (sem); +/* * Signal the writer is done, no fast path yet. *
@@ -293,6 +296,14 @@ void __percpu_up_read(struct percpu_rw_semaphore *sem) {lockdep_assert_preemption_disabled ();/* +* After percpu_up_write() completes, rcu_sync_is_idle() can still +* return false during the grace period, forcing readers into this +* slowpath. Only trace when a writer is actually waiting for +* readers to drain. +*/ +if (trace_contended_release_enabled () &&rcuwait_active (&sem->writer)) +trace_call__contended_release (sem); +/* * slowpath; reader will only ever wake a single blocked * writer. */
kernel/locking/rtmutex.c +1 -0
@@ -1470,6 +1470,7 @@ static void __sched rt_mutex_slowunlock(struct rt_mutex_base *lock)raw_spin_lock_irqsave (&lock->wait_lock, flags); } +trace_contended_release (lock);/* * The wakeup next waiter path does not suffer from the above * race. See the comments there.
kernel/locking/rwbase_rt.c +6 -0
@@ -174,6 +174,8 @@ static void __sched __rwbase_read_unlock(struct rwbase_rt *rwb, static __always_inline void rwbase_read_unlock(struct rwbase_rt *rwb,unsigned int state) { +if (trace_contended_release_enabled () &&rt_mutex_owner (&rwb->rtmutex)) +trace_call__contended_release (rwb);/* * rwb->readers can only hit 0 when a writer is waiting for the * active readers to leave the critical section.
@@ -205,6 +207,8 @@ static inline void rwbase_write_unlock(struct rwbase_rt *rwb)unsigned long flags;raw_spin_lock_irqsave (&rtm->wait_lock, flags); +if (trace_contended_release_enabled () &&rt_mutex_has_waiters (rtm)) +trace_call__contended_release (rwb);__rwbase_write_unlock (rwb,WRITER_BIAS , flags); }
@@ -214,6 +218,8 @@ static inline void rwbase_write_downgrade(struct rwbase_rt *rwb)unsigned long flags;raw_spin_lock_irqsave (&rtm->wait_lock, flags); +if (trace_contended_release_enabled () &&rt_mutex_has_waiters (rtm)) +trace_call__contended_release (rwb);/* Release it and account current as reader */ __rwbase_write_unlock (rwb,WRITER_BIAS -1 , flags); }
kernel/locking/rwsem.c +8 -2
@@ -1387,6 +1387,8 @@ static inline void __up_read(struct rw_semaphore *sem)rwsem_clear_reader_owned (sem); tmp =atomic_long_add_return_release (-RWSEM_READER_BIAS , &sem->count);DEBUG_RWSEMS_WARN_ON (tmp <0 , sem); +if (trace_contended_release_enabled () && (tmp &RWSEM_FLAG_WAITERS )) +trace_call__contended_release (sem);if (unlikely ((tmp & (RWSEM_LOCK_MASK |RWSEM_FLAG_WAITERS )) ==RWSEM_FLAG_WAITERS )) {clear_nonspinnable (sem);
@@ -1413,8 +1415,10 @@ static inline void __up_write(struct rw_semaphore *sem)preempt_disable ();rwsem_clear_owner (sem); tmp =atomic_long_fetch_add_release (-RWSEM_WRITER_LOCKED , &sem->count); -if (unlikely (tmp &RWSEM_FLAG_WAITERS )) +if (unlikely (tmp &RWSEM_FLAG_WAITERS )) { +trace_contended_release (sem);rwsem_wake (sem); + }preempt_enable (); }
@@ -1437,8 +1441,10 @@ static inline void __downgrade_write(struct rw_semaphore *sem) tmp =atomic_long_fetch_add_release ( -RWSEM_WRITER_LOCKED +RWSEM_READER_BIAS , &sem->count);rwsem_set_reader_owned (sem); -if (tmp &RWSEM_FLAG_WAITERS ) +if (tmp &RWSEM_FLAG_WAITERS ) { +trace_contended_release (sem);rwsem_downgrade_wake (sem); + }preempt_enable (); }
kernel/locking/semaphore.c +4 -0
@@ -230,6 +230,10 @@ void __sched up(struct semaphore *sem) sem->count++; else __up(sem, &wake_q); + +if (trace_contended_release_enabled () && !wake_q_empty (&wake_q)) +trace_call__contended_release (sem); +raw_spin_unlock_irqrestore (&sem->lock, flags);if (!wake_q_empty (&wake_q))wake_up_q (&wake_q);