hw/arm/sabrelite: Add FlexCAN support
Subsystems (2)
v6 cover hw/arm/sabrelite: Add FlexCAN support
This series adds emulation of the FlexCAN CAN controller, version 2, found in NXP i.MX6 series SoCs. The controller is integrated into fsl-imx6 and the Sabrelite ARM board.
The chip has two FlexCAN controllers, but the Linux Sabrelite device tree enables only one by default. Linux kernel with both controllers enabled has been tested to work properly (using a custom device tree).
See docs/system/devices/can.rst for an example of QEMU command line invocation.
More information about the implementation can be found in my bachelor thesis [1].
Changes from v5:
- fixed buffer overflow due to unchecked input in flexcan_enabled_mailbox_count
- rebased onto latest master
- Link to v5: https://lore.kernel.org/qemu-devel/[email protected]/
Changes from v4 to v5:
- renamed can in fsl-imx6 to flexcan
- corrected attribution for definitions borrowed from the Linux kernel
- rebased onto latest master
- Link to v4: https://lore.kernel.org/qemu-devel/[email protected]/
Changes from v3 to v4:
- corrected attribution for definitions borrowed from the Linux kernel
- rebased onto latest master
- Link to v3: https://lore.kernel.org/qemu-devel/[email protected]/
Changes from v2 to v3:
- moved variable declarations to the top-of-the-block
- cleanup
- removed redundant license boilerplate
- rebased onto latest master
- Link to v2: https://lore.kernel.org/qemu-devel/[email protected]/
Changes from v1 to v2:
- removed DPRINTF (turned into traces or guest errors)
- removed gotos and unnecessary continues
- register memory region shortened to actual length w/o padding
- make flexcan_* fns private
- used DEVICE(s)->canonical_path instead of allocating new strings
- changed DEVICE_NATIVE_ENDIAN to DEVICE_LITTLE_ENDIAN
- removed ugly USE macro
- used enums instead of define sequences in flexcan.c
- fixed FlexCAN KConfig conf (fixes build on non-arm-softmmu)
- fixed style and other issues from Bernhard's review
- better wording in docs
- rebased onto latest master
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]
Thanks Bernhard Beschow for the review and his patience. I borrowed some fixes from his flexcan branch at [2].
[1] http://dspace.cvut.cz/bitstream/handle/10467/122654/F3-BP-2025-Bobek-Matyas-BP_Bobek_FlexCAN_final_4.pdf
[2] https://github.com/shentok/qemu/tree/flexcan
Matyáš Bobek (7):
hw/arm/sabrelite: Open code DEFINE_MACHINE_ARM hw/arm/sabrelite: Introduce class SabreliteMachineState hw/misc/imx6_ccm: Add PLL3 and CAN clock hw/net/can/flexcan: NXP FlexCAN core emulation hw/arm: Plug FlexCAN into FSL_IMX6 and Sabrelite
tests: Add qtests for FlexCAN docs/arm/sabrelite: Mention FlexCAN support
MAINTAINERS | 9 + docs/system/arm/sabrelite.rst | 1 + docs/system/devices/can.rst | 24 + hw/arm/Kconfig | 1 + hw/arm/fsl-imx6.c | 29 + hw/arm/sabrelite.c | 68 +- hw/misc/imx6_ccm.c | 24 + hw/misc/trace-events | 2 + hw/net/Kconfig | 5 + hw/net/can/flexcan.c | 1396 +++++++++++++++++++++++++++++++++ hw/net/can/flexcan_regs.h | 197 +++++ hw/net/can/meson.build | 1 + hw/net/can/trace-events | 18 + include/hw/arm/fsl-imx6.h | 6 + include/hw/misc/imx6_ccm.h | 4 + include/hw/misc/imx_ccm.h | 1 + include/hw/net/flexcan.h | 145 ++++ tests/qtest/flexcan-test.c | 421 ++++++++++ tests/qtest/meson.build | 1 + 19 files changed, 2343 insertions(+), 10 deletions(-) create mode 100644 hw/net/can/flexcan.c create mode 100644 hw/net/can/flexcan_regs.h create mode 100644 include/hw/net/flexcan.h create mode 100644 tests/qtest/flexcan-test.c
Signature · 1 line
2.54.0
PATCH v6 1/7 hw/arm/sabrelite: Open code DEFINE_MACHINE_ARM
Open code the DEFINE_MACHINE_ARM macro in preparation of creating SabreliteMachineState class.
--- hw/arm/sabrelite.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
hw/arm/sabrelite.c +18 -2
@@ -104,8 +104,10 @@ static void sabrelite_init(MachineState *machine) } } -static void sabrelite_machine_init (MachineClass *mc) +static void sabrelite_machine_class_init (ObjectClass *oc,const void *data) { +MachineClass *mc =MACHINE_CLASS (oc); + mc->desc ="Freescale i.MX6 Quad SABRE Lite Board (Cortex-A9)" ; mc->init = sabrelite_init; mc->max_cpus =FSL_IMX6_NUM_CPUS ;
@@ -114,4 +116,18 @@ static void sabrelite_machine_init(MachineClass *mc) mc->auto_create_sdcard = true; } -DEFINE_MACHINE_ARM ("sabrelite" , sabrelite_machine_init) +static const TypeInfo sabrelite_machine_init_typeinfo = { + .name =MACHINE_TYPE_NAME ("sabrelite" ), + .parent =TYPE_MACHINE , + .class_init = sabrelite_machine_class_init, + .instance_size =sizeof (MachineState), + .abstract = false, + .interfaces = arm_machine_interfaces, +}; + +static void sabrelite_machine_init_register_types (void ) +{ +type_register_static (&sabrelite_machine_init_typeinfo); +} + +type_init (sabrelite_machine_init_register_types)
Signature · 1 line
2.54.0
PATCH v6 3/7 hw/misc/imx6_ccm: Add PLL3 and CAN clock
In reply to Matyáš BobekAdd fixed frequency (480 MHz) PLL3, of which the FlexCAN clock is derived, and compute FlexCAN frequency based on the divider configuration (CCM_CSCMR2).
The clock frequency will be used for computing timestamps in FlexCAN emulator.
--- hw/misc/imx6_ccm.c | 24 ++++++++++++++++++++++++ hw/misc/trace-events | 2 ++ include/hw/misc/imx6_ccm.h | 4 ++++ include/hw/misc/imx_ccm.h | 1 + 4 files changed, 31 insertions(+)
hw/misc/imx6_ccm.c +24 -0
@@ -257,6 +257,15 @@ static uint64_t imx6_analog_get_pll2_clk(IMX6CCMState *dev)return freq; } +static uint64_t imx6_analog_get_pll3_clk (IMX6CCMState *dev) +{ +uint64_t freq =480000000 ; + +trace_imx6_analog_get_pll3_clk (freq); + +return freq; +} +static uint64_t imx6_analog_get_pll2_pfd0_clk (IMX6CCMState *dev) {uint64_t freq =0 ;
@@ -344,6 +353,18 @@ static uint64_t imx6_ccm_get_per_clk(IMX6CCMState *dev)return freq; } +static uint64_t imx6_ccm_get_can_clk (IMX6CCMState *dev) +{ +uint64_t freq =0 ; + + freq =imx6_analog_get_pll3_clk (dev) /8 ; + freq /= (1 +EXTRACT (dev->ccm[CCM_CSCMR2 ],CAN_CLK_PODF )); + +trace_imx6_ccm_get_can_clk (freq); + +return freq; +} +static uint32_t imx6_ccm_get_clock_frequency (IMXCCMState *dev,IMXClk clock) {uint32_t freq =0 ;
@@ -358,6 +379,9 @@ static uint32_t imx6_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)case CLK_IPG_HIGH : freq =imx6_ccm_get_per_clk (s);break ; +case CLK_CAN : + freq =imx6_ccm_get_can_clk (s); +break ;case CLK_32k: freq =CKIL_FREQ ;break ;
hw/misc/trace-events +2 -0
@@ -242,11 +242,13 @@ imx6_analog_get_periph_clk(uint32_t freq) "freq = %u Hz" imx6_analog_get_pll2_clk(uint32_t freq) "freq = %u Hz" imx6_analog_get_pll2_pfd0_clk(uint32_t freq) "freq = %u Hz" imx6_analog_get_pll2_pfd2_clk(uint32_t freq) "freq = %u Hz" +imx6_analog_get_pll3_clk(uint32_t freq) "freq = %u Hz" imx6_analog_read(const char *reg, uint32_t value) "reg[%s] => 0x%" PRIx32 imx6_analog_write(const char *reg, uint32_t value) "reg[%s] <= 0x%" PRIx32 imx6_ccm_get_ahb_clk(uint32_t freq) "freq = %u Hz" imx6_ccm_get_ipg_clk(uint32_t freq) "freq = %u Hz" imx6_ccm_get_per_clk(uint32_t freq) "freq = %u Hz" +imx6_ccm_get_can_clk(uint32_t freq) "freq = %u Hz" imx6_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(Clock = %d) = %u" imx6_ccm_read(const char *reg, uint32_t value) "reg[%s] => 0x%" PRIx32 imx6_ccm_reset(void) ""
include/hw/misc/imx6_ccm.h +4 -0
@@ -164,6 +164,10 @@#define PERCLK_PODF_SHIFT (0)#define PERCLK_PODF_LENGTH (6) +/* CCM_CSCMR2 */ +#define CAN_CLK_PODF_SHIFT (2) +#define CAN_CLK_PODF_LENGTH (6) +/* CCM_ANALOG_PFD_528 */ #define PFD0_FRAC_SHIFT (0)#define PFD0_FRAC_LENGTH (6)
include/hw/misc/imx_ccm.h +1 -0
@@ -46,6 +46,7 @@ typedef enum {CLK_EXT ,CLK_HIGH_DIV ,CLK_HIGH , +CLK_CAN , } IMXClk; struct IMXCCMClass {
Signature · 1 line
2.54.0
PATCH v6 2/7 hw/arm/sabrelite: Introduce class SabreliteMachineState
In reply to Matyáš BobekCreate full class SabreliteMachineState extending MachineState.
Previously, Sabrelite board MachineState was declared indirectly by the DEFINE_MACHINE_ARM macro. FslIMX6State was only instantiated in the sabrelite_init function. For FlexCAN device, machine properties will be used to select QEMU CAN buses. A custom class is therefore required, so the CanBusState "connections" can then be added as fields.
--- hw/arm/sabrelite.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-)
hw/arm/sabrelite.c +18 -10
@@ -20,6 +20,15 @@#include "qemu/error-report.h" #include "system/qtest.h" +struct SabreliteMachineState { +MachineState parent_obj; + +FslIMX6State soc; +}; + +#define TYPE_SABRELITE_MACHINE MACHINE_TYPE_NAME("sabrelite") +OBJECT_DECLARE_SIMPLE_TYPE(SabreliteMachineState, SABRELITE_MACHINE) +static struct arm_boot_info sabrelite_binfo = {/* DDR memory start */ .loader_start =FSL_IMX6_MMDC_ADDR ,
@@ -41,7 +50,7 @@ static void sabrelite_reset_secondary(ARMCPU *cpu,static void sabrelite_init (MachineState *machine) { -FslIMX6State *s; +SabreliteMachineState *s =SABRELITE_MACHINE (machine);/* Check the amount of memory is compatible with the SOC */ if (machine->ram_size >FSL_IMX6_MMDC_SIZE ) {
@@ -50,13 +59,12 @@ static void sabrelite_init(MachineState *machine)exit (1 ); } - s =FSL_IMX6 (object_new (TYPE_FSL_IMX6 )); -object_property_add_child (OBJECT (machine),"soc" ,OBJECT (s)); +object_initialize_child (OBJECT (machine),"soc" , &s->soc,TYPE_FSL_IMX6 );/* Ethernet PHY address is 6 */ -object_property_set_int (OBJECT (s),"fec-phy-num" ,6 , &error_fatal); +object_property_set_int (OBJECT (&s->soc),"fec-phy-num" ,6 , &error_fatal); -qdev_realize (DEVICE (s),NULL , &error_fatal); +qdev_realize (DEVICE (&s->soc),NULL , &error_fatal);memory_region_add_subregion (get_system_memory (),FSL_IMX6_MMDC_ADDR , machine->ram);
@@ -70,7 +78,7 @@ static void sabrelite_init(MachineState *machine)/* Add the sst25vf016b NOR FLASH memory to first SPI */ Object *spi_dev; - spi_dev =object_resolve_path_component (OBJECT (s),"spi1" ); + spi_dev =object_resolve_path_component (OBJECT (&s->soc),"spi1" );if (spi_dev) {SSIBus *spi_bus;
@@ -89,7 +97,7 @@ static void sabrelite_init(MachineState *machine)qdev_realize_and_unref (flash_dev,BUS (spi_bus), &error_fatal); cs_line =qdev_get_gpio_in_named (flash_dev,SSI_GPIO_CS ,0 ); -qdev_connect_gpio_out (DEVICE (&s->gpio[2 ]),19 , cs_line); +qdev_connect_gpio_out (DEVICE (&s->soc.gpio[2 ]),19 , cs_line); } } }
@@ -100,7 +108,7 @@ static void sabrelite_init(MachineState *machine) sabrelite_binfo.secondary_cpu_reset_hook = sabrelite_reset_secondary;if (!qtest_enabled ()) { -arm_load_kernel (&s->cpu[0 ], machine, &sabrelite_binfo); +arm_load_kernel (&s->soc.cpu[0 ], machine, &sabrelite_binfo); } }
@@ -117,10 +125,10 @@ static void sabrelite_machine_class_init(ObjectClass *oc, const void *data) }static const TypeInfo sabrelite_machine_init_typeinfo = { - .name =MACHINE_TYPE_NAME ("sabrelite" ), + .name =TYPE_SABRELITE_MACHINE , .parent =TYPE_MACHINE , .class_init = sabrelite_machine_class_init, - .instance_size =sizeof (MachineState), + .instance_size =sizeof (SabreliteMachineState), .abstract = false, .interfaces = arm_machine_interfaces, };
Signature · 1 line
2.54.0
PATCH v6 5/7 hw/arm: Plug FlexCAN into FSL_IMX6 and Sabrelite
In reply to Matyáš BobekFlexcanState is added to the FslIMX6State struct like other peripherals.
Add two new machine properties to Sabrelite machine for linking the embedded FlexCAN instances to QEMU CAN buses by name. No other machine uses FslIMX6State.
--- hw/arm/Kconfig | 1 + hw/arm/fsl-imx6.c | 29 +++++++++++++++++++++++++++++ hw/arm/sabrelite.c | 24 ++++++++++++++++++++++++ include/hw/arm/fsl-imx6.h | 6 ++++++ 4 files changed, 60 insertions(+)
hw/arm/Kconfig +1 -0
@@ -520,6 +520,7 @@ config FSL_IMX6 select IMX_FEC select IMX_I2C select IMX_USBPHY + select CAN_FLEXCAN select WDT_IMX2 select PL310 # cache controller select PCI_EXPRESS_DESIGNWARE
hw/arm/fsl-imx6.c +29 -0
@@ -90,6 +90,10 @@ static void fsl_imx6_init(Object *obj)snprintf (name,NAME_SIZE ,"spi%d" , i +1 );object_initialize_child (obj, name, &s->spi[i],TYPE_IMX_SPI ); } +for (i =0 ; i <FSL_IMX6_NUM_CANS ; i++) { +snprintf (name,NAME_SIZE ,"flexcan%d" , i +1 ); +object_initialize_child (obj, name, &s->flexcan[i],TYPE_CAN_FLEXCAN ); + }for (i =0 ; i <FSL_IMX6_NUM_WDTS ; i++) {snprintf (name,NAME_SIZE ,"wdt%d" , i);object_initialize_child (obj, name, &s->wdt[i],TYPE_IMX2_WDT );
@@ -377,6 +381,27 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp) qdev_get_gpio_in(gic, spi_table[i].irq)); } +/* Initialize all FLEXCANs */ +for (i =0 ; i <FSL_IMX6_NUM_CANS ; i++) { +static const struct { +hwaddr addr; +unsigned int irq; + } flexcan_table[FSL_IMX6_NUM_CANS ] = { + {FSL_IMX6_CAN1_ADDR ,FSL_IMX6_FLEXCAN1_IRQ }, + {FSL_IMX6_CAN2_ADDR ,FSL_IMX6_FLEXCAN2_IRQ }, + }; + + s->flexcan[i].ccm =IMX_CCM (&s->ccm); +object_property_set_link (OBJECT (&s->flexcan[i]),"canbus" , +OBJECT (s->canbus[i]), &error_abort); + +sysbus_realize (SYS_BUS_DEVICE (&s->flexcan[i]), &error_abort); + +sysbus_mmio_map (SYS_BUS_DEVICE (&s->flexcan[i]),0 , flexcan_table[i].addr); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->flexcan[i]),0 , +qdev_get_gpio_in (gic, flexcan_table[i].irq)); + } +object_property_set_uint (OBJECT (&s->eth),"phy-num" , s->phy_num, &error_abort);qemu_configure_nic_device (DEVICE (&s->eth), true,NULL );
@@ -480,6 +505,10 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp)static const Property fsl_imx6_properties[] = {DEFINE_PROP_UINT32 ("fec-phy-num" , FslIMX6State, phy_num,0 ), +DEFINE_PROP_LINK ("canbus0" , FslIMX6State, canbus[0 ],TYPE_CAN_BUS , + CanBusState *), +DEFINE_PROP_LINK ("canbus1" , FslIMX6State, canbus[1 ],TYPE_CAN_BUS , + CanBusState *), };static void fsl_imx6_class_init (ObjectClass *oc,const void *data)
hw/arm/sabrelite.c +24 -0
@@ -24,6 +24,7 @@ struct SabreliteMachineState {MachineState parent_obj;FslIMX6State soc; +CanBusState *canbus[FSL_IMX6_NUM_CANS ]; };#define TYPE_SABRELITE_MACHINE MACHINE_TYPE_NAME("sabrelite")
@@ -64,6 +65,13 @@ static void sabrelite_init(MachineState *machine)/* Ethernet PHY address is 6 */ object_property_set_int (OBJECT (&s->soc),"fec-phy-num" ,6 , &error_fatal); +for (int i =0 ; i <FSL_IMX6_NUM_CANS ; i++) { + g_autofree char *bus_name = g_strdup_printf("canbus%d", i); + +object_property_set_link (OBJECT (&s->soc), bus_name, +OBJECT (s->canbus[i]), &error_fatal); + } +qdev_realize (DEVICE (&s->soc),NULL , &error_fatal); memory_region_add_subregion(get_system_memory(), FSL_IMX6_MMDC_ADDR,
@@ -112,6 +120,21 @@ static void sabrelite_init(MachineState *machine) } } +static void sabrelite_machine_instance_init (Object *obj) +{ +SabreliteMachineState *s =SABRELITE_MACHINE (obj); + +object_property_add_link (obj,"canbus0" ,TYPE_CAN_BUS , + (Object **)&s->canbus[0 ], + object_property_allow_set_link, +0 ); + +object_property_add_link (obj,"canbus1" ,TYPE_CAN_BUS , + (Object **)&s->canbus[1 ], + object_property_allow_set_link, +0 ); +} +static void sabrelite_machine_class_init (ObjectClass *oc,const void *data) {MachineClass *mc =MACHINE_CLASS (oc);
@@ -128,6 +151,7 @@ static const TypeInfo sabrelite_machine_init_typeinfo = { .name = TYPE_SABRELITE_MACHINE, .parent = TYPE_MACHINE, .class_init = sabrelite_machine_class_init, + .instance_init = sabrelite_machine_instance_init, .instance_size = sizeof(SabreliteMachineState), .abstract = false, .interfaces = arm_machine_interfaces,
include/hw/arm/fsl-imx6.h +6 -0
@@ -30,12 +30,14 @@#include "hw/sd/sdhci.h" #include "hw/ssi/imx_spi.h" #include "hw/net/imx_fec.h" +#include "hw/net/flexcan.h" #include "hw/usb/chipidea.h" #include "hw/usb/imx-usb-phy.h" #include "hw/pci-host/designware.h" #include "hw/core/or-irq.h" #include "system/memory.h" #include "target/arm/cpu.h" +#include "net/can_emu.h" #include "qom/object.h" #define TYPE_FSL_IMX6 "fsl-imx6"
@@ -51,6 +53,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(FslIMX6State, FSL_IMX6)#define FSL_IMX6_NUM_WDTS 2#define FSL_IMX6_NUM_USB_PHYS 2#define FSL_IMX6_NUM_USBS 4 +#define FSL_IMX6_NUM_CANS 2struct FslIMX6State {/*< private >*/
@@ -73,6 +76,7 @@ struct FslIMX6State {IMXUSBPHYState usbphy[FSL_IMX6_NUM_USB_PHYS ];ChipideaState usb[FSL_IMX6_NUM_USBS ];IMXFECState eth; +FlexcanState flexcan[FSL_IMX6_NUM_CANS ];DesignwarePCIEHost pcie;OrIRQState pcie4_msi_irq;MemoryRegion rom;
@@ -80,6 +84,8 @@ struct FslIMX6State {MemoryRegion ocram;MemoryRegion ocram_alias;uint32_t phy_num; + +CanBusState *canbus[FSL_IMX6_NUM_CANS ]; };
Signature · 1 line
2.54.0
PATCH v6 4/7 hw/net/can/flexcan: NXP FlexCAN core emulation
In reply to Matyáš BobekAdded the FlexCAN2 emulator implementation core, with CAN_FLEXCAN Kconfig flag and MAINTAINERS entry.
FlexCAN2 version can be found in i.MX6 SoCs and others.
More information about the implementation can be found in [1].
Some macro and struct defintions were borrowed from the Linux kernel. The original authors agreed with relicensing them to GPL-2.0-or-later on the qemu-devel mailing list.
--- MAINTAINERS | 8 + hw/net/Kconfig | 5 + hw/net/can/flexcan.c | 1396 +++++++++++++++++++++++++++++++++++++ hw/net/can/flexcan_regs.h | 197 ++++++ hw/net/can/meson.build | 1 + hw/net/can/trace-events | 18 + include/hw/net/flexcan.h | 145 ++++ 7 files changed, 1770 insertions(+) create mode 100644 hw/net/can/flexcan.c create mode 100644 hw/net/can/flexcan_regs.h create mode 100644 include/hw/net/flexcan.h
MAINTAINERS +8 -0
@@ -2106,6 +2106,14 @@ F: hw/net/can/xlnx-* F: include/hw/net/xlnx-* F: tests/qtest/xlnx-can*-test* +FlexCAN +M: Matyas Bobek <[email protected]> +M: Pavel Pisa <[email protected]> +S: Maintained +F: hw/net/can/flexcan.c +F: hw/net/can/flexcan_regs.h +F: include/hw/net/flexcan.h + EDU M: Jiri Slaby <[email protected]> S: Maintained
hw/net/Kconfig +5 -0
@@ -157,3 +157,8 @@ config CAN_CTUCANFD_PCI default y if PCI_DEVICES depends on PCI && CAN_CTUCANFD select CAN_BUS + +config CAN_FLEXCAN + bool + depends on IMX + select CAN_BUS
hw/net/can/flexcan.c new file +1396 -0
1,396 lines not on this page · raw message
hw/net/can/flexcan_regs.h new file +197 -0
197 lines not on this page · raw message
hw/net/can/meson.build +1 -0
@@ -6,3 +6,4 @@ system_ss.add(when: 'CONFIG_CAN_CTUCANFD', if_true: files('ctucan_core.c')) system_ss.add(when: 'CONFIG_CAN_CTUCANFD_PCI', if_true: files('ctucan_pci.c')) system_ss.add(when: 'CONFIG_XLNX_ZYNQMP', if_true: files('xlnx-zynqmp-can.c')) system_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files('xlnx-versal-canfd.c')) +system_ss.add(when: 'CONFIG_CAN_FLEXCAN', if_true: files('flexcan.c'))
hw/net/can/trace-events +18 -0
@@ -1,3 +1,21 @@ +# flexcan.c +flexcan_irq_update(const char *inst, uint32_t mb_irqs1, uint32_t mb_irqs2, int setting) "%s: irqs1 0x%08x irqs2 0x%08x request %i" +flexcan_set_mcr(const char *inst, const char *enabled, const char *freeze, const char *fifo, const char *rdy, const char *sync) "%s: %s %s %s %s %s" +flexcan_mb_write(const char *inst, int mbidx, const char *code, int is_mailbox, uint32_t ctrl, uint32_t id) "%s: mbidx %i code %s is_mailbox %i ctrl 0x%08x id 0x%08x" +flexcan_mb_lock(const char *inst, int mbidx, int had_rx_code) "%s: mbidx %i had_rx_code %i" +flexcan_mb_unlock(const char *inst, int mbidx, const char *pending_frame) "%s: mbidx %i%s" +flexcan_fifo_pop(const char *inst, int non_empty_before, int non_empty_after) "%s: non_empty before %i non_empty_after %i" +flexcan_fifo_push(const char *inst, int n_occupied) "%s: n_slots_occupied %i" +flexcan_reset(const char *inst) "%s: resetting" +flexcan_mem_op(const char *inst, const char *op, uint32_t v, int offset, const char *reg_name, int size) "%s: %s 0x%08x at offset %i register %s size %i" +flexcan_get_timestamp(const char *inst, int64_t time_elapsed_ms, uint32_t bitrate, uint64_t cycles, uint32_t shift, uint32_t timestamp) "%s: time_elapsed %" PRIi64 "ms bitrate %ub/s cycles %" PRIu64 " shift %u timestamp 0x%04x" +flexcan_get_bitrate(const char *inst, uint32_t pe_freq, uint32_t prediv, uint32_t s_freq, uint32_t tseg1, uint32_t tseg2, uint32_t quata_per_bit, uint32_t bitrate) "%s: pe_freq %uHz prescaler %u s_freq %uHz tseg1 %uq tseg2 %uq total %uq/b bitrate %ub/s" +flexcan_timer_start(const char *inst, uint32_t bitrate, uint32_t value) "%s: bitrate %ub/s value 0x%04x" +flexcan_timer_stop(const char *inst, uint32_t bitrate, uint32_t value) "%s: bitrate %ub/s value 0x%04x" +flexcan_timer_overflow(const char *inst, int64_t current_time, int64_t timer_start, int64_t elapsed_ns) "%s: current_time %" PRIi64 "timer_start %" PRIi64 "elapsed_ns %" PRIi64 +flexcan_mb_rx_check_mb(const char *inst, int mbidx, const char *code, int is_matched, int is_ftr, int is_serviced, int is_locked) "%s: checking mb %i code %s is_matched %i is_free_to_receive %i is_serviced %i is_locked %i" +flexcan_receive(const char *inst, size_t n_frames) "%s: received %zu frames" + # xlnx-zynqmp-can.c xlnx_can_update_irq(uint32_t isr, uint32_t ier, uint32_t irq) "ISR: 0x%08x IER: 0x%08x IRQ: 0x%08x" xlnx_can_reset(uint32_t val) "Resetting controller with value = 0x%08x"
include/hw/net/flexcan.h new file +145 -0
145 lines not on this page · raw message
Signature · 1 line
2.54.0
PATCH v6 6/7 tests: Add qtests for FlexCAN
In reply to Matyáš BobekThe tests do not test all of the FlexCAN emulator functionality.
--- MAINTAINERS | 1 + tests/qtest/flexcan-test.c | 421 +++++++++++++++++++++++++++++++++++++ tests/qtest/meson.build | 1 + 3 files changed, 423 insertions(+) create mode 100644 tests/qtest/flexcan-test.c
MAINTAINERS +1 -0
@@ -2113,6 +2113,7 @@ S: Maintained F: hw/net/can/flexcan.c F: hw/net/can/flexcan_regs.h F: include/hw/net/flexcan.h +F: tests/qtest/flexcan-test.c EDU M: Jiri Slaby <[email protected]>
tests/qtest/flexcan-test.c new file +421 -0
421 lines not on this page · raw message
tests/qtest/meson.build +1 -0
@@ -250,6 +250,7 @@ qtests_arm = \ (config_all_devices.has_key('CONFIG_MICROBIT') ? ['microbit-test'] : []) + \ (config_all_devices.has_key('CONFIG_STM32L4X5_SOC') ? qtests_stm32l4x5 : []) + \ (config_all_devices.has_key('CONFIG_FSI_APB2OPB_ASPEED') ? ['aspeed_fsi-test'] : []) + \ + (config_all_devices.has_key('CONFIG_CAN_FLEXCAN') ? ['flexcan-test'] : []) + \ (config_all_devices.has_key('CONFIG_STM32L4X5_SOC') and config_all_devices.has_key('CONFIG_DM163')? ['dm163-test'] : []) + \ ['arm-cpu-features',
Signature · 1 line
2.54.0
PATCH v6 7/7 docs/arm/sabrelite: Mention FlexCAN support
In reply to Matyáš BobekAlso added example command line usage of the Sabrelite board with FlexCAN controllers.
--- docs/system/arm/sabrelite.rst | 1 + docs/system/devices/can.rst | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+)
docs/system/arm/sabrelite.rst +1 -0
@@ -24,6 +24,7 @@ The SABRE Lite machine supports the following devices: * 4 SDHC storage controllers * 4 USB 2.0 host controllers * 5 ECSPI controllers + * 2 FlexCAN CAN controllers * 1 SST 25VF016B flash Please note above list is a complete superset the QEMU SABRE Lite machine can
docs/system/devices/can.rst +24 -0
@@ -173,6 +173,30 @@ The test can also be run the other way around, generating messages in the guest system and capturing them in the host system. Other combinations are also possible. +Examples on how to use CAN emulation for FlexCAN on SabreLite board +------------------------------------------------------------------- +FlexCANs are connected to QEMU CAN buses by passing the bus IDs as machine +properties: + +* property ``canbus0`` for connecting ``flexcan1`` +* property ``canbus1`` for connecting ``flexcan2`` + +Note that upstream Linux SabreLite DTs have only a single FlexCAN (``flexcan1``) +enabled. + +An example command to run QEMU emulating a Sabrelite development board +with both FlexCANs connected to a single QEMU CAN bus (called ``qcan0``), +bridged to host system ``can0`` interface:: + + qemu-system-arm -M sabrelite -smp 4 -m 1G \ + -object can-bus,id=qcan0 \ + -machine canbus0=qcan0 -machine canbus1=qcan0 \ + -object can-host-socketcan,if=can0,canbus=qcan0,id=qcan0-socketcan \ + -kernel ... -dtb ... -initrd ... + +Note that in the Linux guest, bitrate for the FlexCAN device is ignored, +but needs to be set via the ``ip`` command. + Links to other resources ------------------------
Signature · 1 line
2.54.0
Peter Maydell
AppliedQuoted 12 lines · Matyáš Bobek
This series adds emulation of the FlexCAN CAN controller, version 2, found in NXP i.MX6 series SoCs. The controller is integrated into fsl-imx6 and the Sabrelite ARM board.
The chip has two FlexCAN controllers, but the Linux Sabrelite device tree enables only one by default. Linux kernel with both controllers enabled has been tested to work properly (using a custom device tree).
Seedocs/system/devices/can.rstfor an example of QEMU command line invocation.
Quoted 8 lines
More information about the implementation can be found in my bachelor thesis [1].
Changes from v5:
- fixed buffer overflow due to unchecked input inflexcan_enabled_mailbox_count
- rebased onto latest master
- Link to v5: https://lore.kernel.org/qemu-devel/[email protected]/
Applied to target-arm.next, thanks.
-- PMM