arm: socfpga: Add Arria 10 SoCDK QSPI and NAND board variants
Subsystems (3)
cover arm: socfpga: Add Arria 10 SoCDK QSPI and NAND board variants
From: Dinesh Maniyam <[email protected]>
This series adds U-Boot support for two new Arria 10 SoCDK boot variants (Cadence QSPI and Denali NAND) and refreshes the matching U-Boot handoff data so the existing Arria 10 boards keep building cleanly:
1/4 arm: dts: socfpga: Update Arria 10 SoCDK U-Boot handoff data
Refresh the U-Boot-only handoff dtsi and the generated headers, and rename the CONFIG_IO_* macros to CFG_IO_* on both the producer (qts-filter-a10.sh) and consumer (handoff dtsi / Chameleon V3 270_3 and 480_2 headers) sides so the device tree compiler stops emitting "Unexpected 'CONFIG_IO_*'" lexical errors when building the Arria 10 SoCDK and Chameleon V3 DTBs.
2/4 ARM: socfpga: Add default FIT images for Arria 10 SoCDK
Add default FIT image templates for SPL/U-Boot and the Linux kernel under board/altera/arria10-socdk/ so the SoCDK can boot via a single mkimage-generated FIT.
3/4 arm: socfpga: Add Arria 10 SoCDK QSPI and NAND boards
Add the two new in-tree DTS files, the U-Boot dtsi overlays, handoff headers, defconfigs and shared board config bits for the QSPI (Cadence QSPI) and NAND (Denali NAND) boot variants. The boards intentionally stay on the in-tree DTS rather than CONFIG_OF_UPSTREAM because the upstream Linux Arria 10 device tree does not expose the clkmgr (and related) labels that arch/arm/dts/socfpga_arria10-u-boot.dtsi already references.
4/4 doc: socfpga: Describe Arria 10 SoCDK QSPI U-Boot and SPL build
flow
Document how to build SPL + U-Boot, assemble the default FIT images and lay them out on QSPI flash.
Hardware tested
---------------
- Intel Arria 10 SoCDK rev C, Cadence QSPI flash, SPL + U-Boot
- Intel Arria 10 SoCDK rev C, Denali NAND flash, SPL + U-Boot
Dependencies
------------
This series depends on three earlier U-Boot NAND prerequisite changes already posted to the list:
1) "mtd: nand: raw: Cadence NAND cleanup" series (2 patches)
https://lore.kernel.org/u-boot/[email protected]/
2) "mtd: rawnand: denali: add NAND_DENALI_SKIP_BBTSCAN_SPL Kconfig"
https://lore.kernel.org/u-boot/[email protected]/
3) "mtd: rawnand: allow SYS_NAND_BLOCK_SIZE when SPL_NAND_CADENCE
is set"
https://lore.kernel.org/u-boot/[email protected]/Without (1) the SPL Cadence NAND build does not select the right MTD header and Kconfig dependencies; without (2)/(3) the new Arria 10 NAND defconfig cannot disable the Denali BBT scan in SPL or pick its own SYS_NAND_BLOCK_SIZE.
Dinesh Maniyam (4):
arm: dts: socfpga: Update Arria 10 SoCDK U-Boot handoff data
ARM: socfpga: Add default FIT images for Arria 10 SoCDK
arm: socfpga: Add Arria 10 SoCDK QSPI and NAND boards
doc: socfpga: Describe Arria 10 SoCDK QSPI U-Boot and SPL build flow
arch/arm/dts/socfpga_arria10-handoff.dtsi | 36 +-- ...ocfpga_arria10_chameleonv3_270_3_handoff.h | 250 +++++++------- ...ocfpga_arria10_chameleonv3_480_2_handoff.h | 250 +++++++------- .../socfpga_arria10_socdk_nand-u-boot.dtsi | 42 +++ arch/arm/dts/socfpga_arria10_socdk_nand.dts | 26 ++ .../dts/socfpga_arria10_socdk_nand_handoff.h | 305 ++++++++++++++++++ .../socfpga_arria10_socdk_qspi-u-boot.dtsi | 48 +++ arch/arm/dts/socfpga_arria10_socdk_qspi.dts | 11 + .../dts/socfpga_arria10_socdk_qspi_handoff.h | 305 ++++++++++++++++++ .../dts/socfpga_arria10_socdk_sdmmc_handoff.h | 262 +++++++-------- arch/arm/mach-socfpga/qts-filter-a10.sh | 22 +- .../altera/arria10-socdk/fit_kernel_nand.its | 44 +++ .../altera/arria10-socdk/fit_kernel_qspi.its | 44 +++ board/altera/arria10-socdk/fit_uboot.its | 43 +++ configs/socfpga_arria10_nand_defconfig | 95 ++++++ configs/socfpga_arria10_qspi_defconfig | 86 +++++ doc/README.socfpga_arria10_qspi_socdk | 56 ++++ include/configs/socfpga_arria10_socdk.h | 27 ++ 18 files changed, 1542 insertions(+), 410 deletions(-) create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand.dts create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand_handoff.h create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi.dts create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi_handoff.h create mode 100644 board/altera/arria10-socdk/fit_kernel_nand.its create mode 100644 board/altera/arria10-socdk/fit_kernel_qspi.its create mode 100644 board/altera/arria10-socdk/fit_uboot.its create mode 100644 configs/socfpga_arria10_nand_defconfig create mode 100644 configs/socfpga_arria10_qspi_defconfig create mode 100644 doc/README.socfpga_arria10_qspi_socdk
Signature · 1 line
2.43.7
PATCH 1/4 arm: dts: socfpga: Update Arria 10 SoCDK U-Boot handoff data
From: Dinesh Maniyam <[email protected]>
Update the U-Boot-only handoff data for the Arria 10 SoCDK platforms and refresh the headers it generates.
Rename CONFIG_IO_* references to CFG_IO_* in the shared arch/arm/dts/socfpga_arria10-handoff.dtsi consumer and in the two existing Chameleon V3 handoff headers (270_3, 480_2) so that all producers and consumers of the IO_* macros agree on the new CFG_IO_* names. This also keeps the device tree compiler from emitting "Unexpected 'CONFIG_IO_*'" lexical errors when building the Arria 10 SoCDK and Chameleon V3 DTBs.
Update arch/arm/mach-socfpga/qts-filter-a10.sh so the generator script emits CFG_IO_* macro names matching the consumer side.
--- arch/arm/dts/socfpga_arria10-handoff.dtsi | 36 +-- ...ocfpga_arria10_chameleonv3_270_3_handoff.h | 250 +++++++------- ...ocfpga_arria10_chameleonv3_480_2_handoff.h | 250 +++++++------- .../socfpga_arria10_socdk_nand-u-boot.dtsi | 42 +++ .../dts/socfpga_arria10_socdk_nand_handoff.h | 305 ++++++++++++++++++ .../socfpga_arria10_socdk_qspi-u-boot.dtsi | 48 +++ .../dts/socfpga_arria10_socdk_qspi_handoff.h | 305 ++++++++++++++++++ .../dts/socfpga_arria10_socdk_sdmmc_handoff.h | 262 +++++++-------- arch/arm/mach-socfpga/qts-filter-a10.sh | 22 +- 9 files changed, 1110 insertions(+), 410 deletions(-) create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand_handoff.h create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi-u-boot.dtsi create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi_handoff.h
arch/arm/dts/socfpga_arria10-handoff.dtsi +18 -18
@@ -189,24 +189,24 @@ pinctrl-single,register-width = <32>; pinctrl-single,function-mask = <0x003f3f3f>; pinctrl-single,pins = - <0x00000100 CONFIG_IO_BANK_VSEL>, - <0x00000104 CONFIG_IO_MACRO (CONFIG_IO_1)>, - <0x00000108 CONFIG_IO_MACRO (CONFIG_IO_2)>, - <0x0000010c CONFIG_IO_MACRO (CONFIG_IO_3)>, - <0x00000110 CONFIG_IO_MACRO (CONFIG_IO_4)>, - <0x00000114 CONFIG_IO_MACRO (CONFIG_IO_5)>, - <0x00000118 CONFIG_IO_MACRO (CONFIG_IO_6)>, - <0x0000011c CONFIG_IO_MACRO (CONFIG_IO_7)>, - <0x00000120 CONFIG_IO_MACRO (CONFIG_IO_8)>, - <0x00000124 CONFIG_IO_MACRO (CONFIG_IO_9)>, - <0x00000128 CONFIG_IO_MACRO (CONFIG_IO_10)>, - <0x0000012c CONFIG_IO_MACRO (CONFIG_IO_11)>, - <0x00000130 CONFIG_IO_MACRO (CONFIG_IO_12)>, - <0x00000134 CONFIG_IO_MACRO (CONFIG_IO_13)>, - <0x00000138 CONFIG_IO_MACRO (CONFIG_IO_14)>, - <0x0000013c CONFIG_IO_MACRO (CONFIG_IO_15)>, - <0x00000140 CONFIG_IO_MACRO (CONFIG_IO_16)>, - <0x00000144 CONFIG_IO_MACRO (CONFIG_IO_17)>; + <0x00000100 CFG_IO_BANK_VSEL>, + <0x00000104 CFG_IO_MACRO (CFG_IO_1)>, + <0x00000108 CFG_IO_MACRO (CFG_IO_2)>, + <0x0000010c CFG_IO_MACRO (CFG_IO_3)>, + <0x00000110 CFG_IO_MACRO (CFG_IO_4)>, + <0x00000114 CFG_IO_MACRO (CFG_IO_5)>, + <0x00000118 CFG_IO_MACRO (CFG_IO_6)>, + <0x0000011c CFG_IO_MACRO (CFG_IO_7)>, + <0x00000120 CFG_IO_MACRO (CFG_IO_8)>, + <0x00000124 CFG_IO_MACRO (CFG_IO_9)>, + <0x00000128 CFG_IO_MACRO (CFG_IO_10)>, + <0x0000012c CFG_IO_MACRO (CFG_IO_11)>, + <0x00000130 CFG_IO_MACRO (CFG_IO_12)>, + <0x00000134 CFG_IO_MACRO (CFG_IO_13)>, + <0x00000138 CFG_IO_MACRO (CFG_IO_14)>, + <0x0000013c CFG_IO_MACRO (CFG_IO_15)>, + <0x00000140 CFG_IO_MACRO (CFG_IO_16)>, + <0x00000144 CFG_IO_MACRO (CFG_IO_17)>; bootph-all; };
arch/arm/dts/socfpga_arria10_chameleonv3_270_3_handoff.h +125 -125
264 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_chameleonv3_480_2_handoff.h +125 -125
264 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_socdk_nand-u-boot.dtsi new file +42 -0
42 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_socdk_nand_handoff.h new file +305 -0
305 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_socdk_qspi-u-boot.dtsi new file +48 -0
48 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_socdk_qspi_handoff.h new file +305 -0
305 lines not on this page · raw message
arch/arm/dts/socfpga_arria10_socdk_sdmmc_handoff.h +131 -131
285 lines not on this page · raw message
arch/arm/mach-socfpga/qts-filter-a10.sh +11 -11
@@ -25,11 +25,11 @@ process_a10_hps_config() { (cat << EOF // SPDX-License-Identifier: BSD-3-Clause /* - * Intel Arria 10 SoCFPGA configuration + * Altera Arria 10 SoCFPGA configuration */ -#ifndef __SOCFPGA_ARRIA10_CONFIG_H__ -#define __SOCFPGA_ARRIA10_CONFIG_H__ +#ifndef __SOCFPGA_ARRIA10_CFG_H__ +#define __SOCFPGA_ARRIA10_CFG_H__ EOF
@@ -84,7 +84,7 @@ EOF sed 's/SHARED_3V_IO_GRP_//' | sed 's/FPGA_INTERFACE_GRP_//' | sed 's/DEDICATED_IO_GRP_//' | - sed 's/CONFIGURATION_DEDICATED/CONFIG/' | + sed 's/CONFIGURATION_DEDICATED/CFG/' | sort echo
@@ -98,14 +98,14 @@ EOF sort echo - echo "/* Voltage Select for Config IO */" - echo "#define CONFIG_IO_BANK_VSEL \\" - echo " (((CONFIG_IO_BANK_VOLTAGE_SEL_CLKRST_IO & 0x3) << 8) | \\" - echo " (CONFIG_IO_BANK_VOLTAGE_SEL_PERI_IO & 0x3))" + echo "/* Voltage Select for CFG IO */" + echo "#define CFG_IO_BANK_VSEL \\" + echo " (((CFG_IO_BANK_VOLTAGE_SEL_CLKRST_IO & 0x3) << 8) | \\" + echo " (CFG_IO_BANK_VOLTAGE_SEL_PERI_IO & 0x3))" echo - echo "/* Macro for Config IO bit mapping */" - echo -n "#define CONFIG_IO_MACRO(NAME) " + echo "/* Macro for CFG IO bit mapping */" + echo -n "#define CFG_IO_MACRO(NAME) " echo "(((NAME ## _RTRIM & 0xff) << 19) | \\" echo " ((NAME ## _INPUT_BUF_EN & 0x3) << 17) | \\" echo " ((NAME ## _WK_PU_EN & 0x1) << 16) | \\"
@@ -116,7 +116,7 @@ EOF cat << EOF -#endif /* __SOCFPGA_ARRIA10_CONFIG_H__ */ +#endif /* __SOCFPGA_ARRIA10_CFG_H__ */ EOF ) > "${outfile}" }
Signature · 1 line
2.43.7
PATCH 2/4 ARM: socfpga: Add default FIT images for Arria 10 SoCDK
In reply to [email protected]From: Dinesh Maniyam <[email protected]>
This introduces default FIT images for U-Boot and the Linux kernel, allowing a consolidated boot flow using mkimage-generated FIT binaries.
--- .../altera/arria10-socdk/fit_kernel_nand.its | 44 +++++++++++++++++++ .../altera/arria10-socdk/fit_kernel_qspi.its | 44 +++++++++++++++++++ board/altera/arria10-socdk/fit_uboot.its | 43 ++++++++++++++++++ 3 files changed, 131 insertions(+) create mode 100644 board/altera/arria10-socdk/fit_kernel_nand.its create mode 100644 board/altera/arria10-socdk/fit_kernel_qspi.its create mode 100644 board/altera/arria10-socdk/fit_uboot.its
board/altera/arria10-socdk/fit_kernel_nand.its new file +44 -0
@@ -0,0 +1,44 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2019 Altera Corporation + * + */ + +/dts-v1/; + +/ { + description = "FIT image with kernel and DTB"; + #address-cells = <1>; + + images { + kernel { + description = "Linux Kernel"; + data = /incbin/("../../../Image"); + type = "kernel"; + os = "linux"; + arch = "arm"; + compression = "none"; + load = <0x8000>; + entry = <0x8000>; + }; + + fdt { + description = "Linux DTB"; + data = /incbin/("../../../socfpga_arria10_socdk_nand.dtb"); + type = "flat_dt"; + os = "linux"; + arch = "arm"; + compression = "none"; + + }; + }; + + configurations { + default = "conf"; + conf { + description = "Linux boot configuration"; + kernel = "kernel"; + fdt = "fdt"; + }; + }; +};
board/altera/arria10-socdk/fit_kernel_qspi.its new file +44 -0
44 lines not on this page · raw message
board/altera/arria10-socdk/fit_uboot.its new file +43 -0
43 lines not on this page · raw message
Signature · 1 line
2.43.7
PATCH 3/4 arm: socfpga: Add Arria 10 SoCDK QSPI and NAND boards
In reply to [email protected]From: Dinesh Maniyam <[email protected]>
Add the Arria 10 SoCDK QSPI and NAND board variants.
Each board ships with a minimal top-level device tree under arch/arm/dts that includes the existing socfpga_arria10_socdk.dtsi and enables the relevant storage peripheral:
- arch/arm/dts/socfpga_arria10_socdk_nand.dts enables the Denali NAND controller and declares two MTD partitions (boot/FPGA data and the JFFS2 rootfs).
- arch/arm/dts/socfpga_arria10_socdk_qspi.dts enables the Cadence QSPI controller.
The matching defconfigs select the new device trees, the storage-specific drivers (NAND_DENALI_DT + SPL_NAND_CADENCE for NAND; Cadence QSPI for QSPI), and the SPL memory layout shared with the existing SDMMC variant. Board-specific run-time settings live in include/configs/socfpga_arria10_socdk.h.
The boards do not use CONFIG_OF_UPSTREAM because the upstream Linux Arria 10 device tree does not provide the clkmgr (and related) labels that arch/arm/dts/socfpga_arria10-u-boot.dtsi references; the in-tree arch/arm/dts copy continues to provide those labels for U-Boot.
--- arch/arm/dts/socfpga_arria10_socdk_nand.dts | 26 ++++++ arch/arm/dts/socfpga_arria10_socdk_qspi.dts | 11 +++ configs/socfpga_arria10_nand_defconfig | 95 +++++++++++++++++++++ configs/socfpga_arria10_qspi_defconfig | 86 +++++++++++++++++++ include/configs/socfpga_arria10_socdk.h | 27 ++++++ 5 files changed, 245 insertions(+) create mode 100644 arch/arm/dts/socfpga_arria10_socdk_nand.dts create mode 100644 arch/arm/dts/socfpga_arria10_socdk_qspi.dts create mode 100644 configs/socfpga_arria10_nand_defconfig create mode 100644 configs/socfpga_arria10_qspi_defconfig
arch/arm/dts/socfpga_arria10_socdk_nand.dts new file +26 -0
@@ -0,0 +1,26 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2015-2022 Altera Corporation. All rights reserved. + */ + +/dts-v1/; +#include "socfpga_arria10_socdk.dtsi" + +&nand { + status = "okay"; + + nand@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <1>; + + partition@0 { + label = "Boot and fpga data"; + reg = <0x0 0x02500000>; + }; + partition@1c00000 { + label = "Root Filesystem - JFFS2"; + reg = <0x02500000 0x05500000>; + }; + }; +};
arch/arm/dts/socfpga_arria10_socdk_qspi.dts new file +11 -0
@@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Intel Corporation. All rights reserved. + */ + +/dts-v1/; +#include "socfpga_arria10_socdk.dtsi" + +&qspi { + status = "okay"; +};
configs/socfpga_arria10_nand_defconfig new file +95 -0
95 lines not on this page · raw message
configs/socfpga_arria10_qspi_defconfig new file +86 -0
86 lines not on this page · raw message
include/configs/socfpga_arria10_socdk.h +27 -0
@@ -32,6 +32,33 @@/* SPL memory allocation configuration, this is for FAT implementation */ +#if defined(CONFIG_QSPI_BOOT ) || defined(CONFIG_NAND_BOOT ) +#define CFG_EXTRA_ENV_SETTINGS \ + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ + "bootm_size=0xa000000\0" \ + "kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ + "fdt_addr_r=0x02000000\0" \ + "scriptaddr=0x02100000\0" \ + "pxefile_addr_r=0x02200000\0" \ + "ramdisk_addr_r=0x02300000\0" \ + "socfpga_legacy_reset_compat=1\0" \ + "kernelfit_addr=0x1200000\0" \ + "fitimagesize=0x5F0000\0" \ + "qspiroot=/dev/mtdblock1\0" \ + "qspirootfstype=jffs2\0" \ + "qspiload=sf probe; sf read ${scriptaddr} ${kernelfit_addr}\0" \ + "qspiboot=setenv bootargs " CONFIG_BOOTARGS \ + "root=${qspiroot} rw rootfstype=${qspirootfstype}; " \ + "bootm ${scriptaddr}\0" \ + "nandroot=/dev/mtdblock1\0" \ + "nandrootfstype=jffs2\0" \ + "nandload=nand read ${scriptaddr} ${kernelfit_addr}\0" \ + "nandboot=setenv bootargs " CONFIG_BOOTARGS \ + "root=${nandroot} rw rootfstype=${nandrootfstype}; " \ + "bootm ${scriptaddr}\0" \ + +#endif +/* The rest of the configuration is shared */ #include <configs/socfpga_common.h>
Signature · 1 line
2.43.7
PATCH 4/4 doc: socfpga: Describe Arria 10 SoCDK QSPI U-Boot and SPL build flow
In reply to [email protected]From: Dinesh Maniyam <[email protected]>
Describe the U-Boot and SPL build and boot flow for the Arria 10 SoCDK QSPI platform.
The document outlines the steps to build SPL and U-Boot, generate default FIT images for FPGA bitstreams, U-Boot, and the Linux kernel, and provides a reference QSPI flash layout for the resulting images.
--- doc/README.socfpga_arria10_qspi_socdk | 56 +++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 doc/README.socfpga_arria10_qspi_socdk
doc/README.socfpga_arria10_qspi_socdk new file +56 -0
@@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2019 Altera Corporation <www.altera.com> + * + */ + +---------------------------------------- +SOCFPGA Documentation for U-Boot and SPL +---------------------------------------- +This README is about U-Boot and SPL support for Arria 10 QSPI SoCDK. + +a. Steps for building SPL and U-Boot: +------------------------------------- +1. cd to U-Boot source directory. +2. Build both SPL and U-Boot, runs "export CROSS_COMPILE=arm-altera-eabi-; +make mrproper; make socfpga_arria10_qspi_defconfig; make -8" +3.Runs "mkpimage -hv 1 -o spl/spl_w_dtb-mkpimage.bin + spl/u-boot-spl-dtb.bin spl/u-boot-spl-dtb.bin spl/u-boot-spl-dtb.bin + spl/u-boot-spl-dtb.bin" + +b. Steps for building default FIT image for FPGA bitstreams: +------------------------------------------------------------ +1. Copy both ghrd_10as066n2.periph.rbf and ghrd_10as066n2.core.rbf to U-Boot +source root directory. +2. Runs "tools /mkimage -E -f + board/altera/arria10-socdk/fit_spl_fpga.its fit_spl_fpga.itb" + +c. Steps for buiding default FIT image for U-Boot: +-------------------------------------------------- +1. Ensure a. Steps for building SPL and U-Boot are done. +2. Runs "tools/mkimage -E -f board/altera/arria10-socdk/fit_uboot.its + fit_spl_uboot.itb" + +d. Steps for buiding default FIT image for Linux and DTB: +--------------------------------------------------------- +1. Copy uImage & socfpga_arria10_socdk_qspi.dtb to U-Boot source root directory. +2. Runs "tools/mkimage -f + board/altera/arria10-socdk/fit_kernel_qspi.its kernel.itb" + +After going through all steps described above, those images/binaries can be +written into QSPI flash as shown in below proposed layout. Ensure no overlapping +for each image. + +Addr 0 -------------------------------------- + | spl_w_dtb-mkpimage.bin | 1MB + -------------------------------------- + | fit_spl_uboot.itb | 1MB + -------------------------------------- + |env(64K) & env_redundant(64k) | 1MB + -------------------------------------- + | fit_spl_fpga.itb | depend on bitstreams size +Addr 0x1200000 -------------------------------------- + | kernel.itb | depend on kernel.itb size +Addr 0x2720000 -------------------------------------- + |console-image-minimal-arria10.jffs2 | -(RFS) + --------------------------------------
Signature · 1 line
2.43.7