platform/x86: Fix typos in comments
Subsystems (8)
v2 cover platform/x86: Fix typos in comments
v1 was one patch touching eight drivers. Denis Benato asked for it to be split one patch per file or driver, so here it is as eight patches, one per driver. The corrections themselves are unchanged from v1.
The words all come from scripts/spelling.txt, which is the list checkpatch.pl uses. codespell finds nothing further in these eight files except "ALS" in asus-laptop.c, which is the Ambient Light Sensor and must stay as it is.
Two of these comments have a grammar problem in addition to the misspelling:
asus-laptop.c "The HWRS method return information about the
hardware" wants "returns"
samsung-laptop.c "This allow to call arbitrary sabi commands" wants
"allows calling"
I have left both alone so that this series stays a spelling fix and so Mark's review still covers exactly the text he read. I am happy to send those two as a separate patch if you would like them corrected.
Mark Pearson reviewed v1 in full, so his tag is carried on every patch. Denis offered his tag on the condition that Ilpo agrees to the split, and it is included on that basis; please drop it if that is not right.
v1: https://lore.kernel.org/all/[email protected]/
Hemanth Selam (8):
platform/x86: asus-laptop: Fix typo in infos_show() comment platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment platform/x86: msi-laptop: Fix typo in struct quirk_entry comment platform/x86: panasonic-laptop: Fix typo in the file history comment platform/x86: samsung-laptop: Fix typo in sabi_configs comment platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness
comment
drivers/platform/x86/asus-laptop.c | 2 +- drivers/platform/x86/asus-nb-wmi.c | 2 +- drivers/platform/x86/hp/hp_accel.c | 2 +- drivers/platform/x86/intel/vsec_tpmi.c | 2 +- drivers/platform/x86/msi-laptop.c | 2 +- drivers/platform/x86/panasonic-laptop.c | 2 +- drivers/platform/x86/samsung-laptop.c | 2 +- drivers/platform/x86/uniwill/uniwill-acpi.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.48.1
PATCH v2 1/8 platform/x86: asus-laptop: Fix typo in infos_show() comment
Correct "informations" to "information" in the comment describing the HWRS method. Comment only, no functional change.
--- drivers/platform/x86/asus-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/asus-laptop.c +1 -1
@@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, len +=sysfs_emit_at (page, len,"SFUN value : %#x\n" , (uint ) temp);/* -* The HWRS method return informations about the hardware. +* The HWRS method return information about the hardware. * 0x80 bit is for WLAN, 0x100 for Bluetooth. * 0x40 for WWAN, 0x10 for WIMAX. * The significance of others is yet to be found.
Signature · 1 line
2.48.1
PATCH v2 2/8 platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment
In reply to Hemanth SelamCorrect "paramater" to "parameter". Comment only, no functional change.
--- drivers/platform/x86/asus-nb-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/asus-nb-wmi.c +1 -1
@@ -573,7 +573,7 @@ static void asus_nb_wmi_quirks(struct asus_wmi_driver *driver) driver->quirks = quirks; driver->panel_power =BACKLIGHT_POWER_ON ; -/* overwrite the wapf setting if the wapf paramater is specified */ +/* overwrite the wapf setting if the wapf parameter is specified */ if (wapf !=-1 ) quirks->wapf = wapf;else
Signature · 1 line
2.48.1
PATCH v2 3/8 platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment
In reply to Hemanth SelamCorrect "writting" to "writing". Comment only, no functional change.
--- drivers/platform/x86/hp/hp_accel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/hp/hp_accel.c +1 -1
@@ -122,7 +122,7 @@ static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)static int lis3lv02d_acpi_write (struct lis3lv02d *lis3,int reg,u8 val) {struct acpi_device *dev = lis3->bus_priv; -unsigned long long ret;/* Not used when writting */ +unsigned long long ret;/* Not used when writing */ union acpi_object in_obj[2 ];struct acpi_object_list args = {2 , in_obj };
Signature · 1 line
2.48.1
PATCH v2 4/8 platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment
In reply to Hemanth SelamCorrect "upto" to "up to". Comment only, no functional change.
--- drivers/platform/x86/intel/vsec_tpmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/vsec_tpmi.c +1 -1
@@ -597,7 +597,7 @@ static const char *intel_tpmi_name(enum intel_tpmi_id id) } } -/* String Length for tpmi-"feature_name(upto 8 bytes)" */ +/* String Length for tpmi-"feature_name(up to 8 bytes)" */ #define TPMI_FEATURE_NAME_LEN 14 static int tpmi_create_device(struct intel_tpmi_info *tpmi_info,
Signature · 1 line
2.48.1
PATCH v2 5/8 platform/x86: msi-laptop: Fix typo in struct quirk_entry comment
In reply to Hemanth SelamCorrect "cann't" to "can't". Comment only, no functional change.
--- drivers/platform/x86/msi-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/msi-laptop.c +1 -1
@@ -117,7 +117,7 @@ struct quirk_entry {* Wlan/Bluetooth/3G, those netbook will load the SCM (windows app) to * disable the original Wlan/Bluetooth control by BIOS when user press * fn key, then control Wlan/Bluetooth/3G by SCM (software control by -* OS). Without SCM, user cann't on/off 3G module on those 3G netbook. +* OS). Without SCM, user can't on/off 3G module on those 3G netbook. * On Linux, msi-laptop driver will do the same thing to disable the * original BIOS control, then might need use HAL or other userland * application to do the software control that simulate with SCM.
Signature · 1 line
2.48.1
PATCH v2 6/8 platform/x86: panasonic-laptop: Fix typo in the file history comment
In reply to Hemanth SelamCorrect "retrive" to "retrieve" in the v0.4 entry. Comment only, no functional change.
--- drivers/platform/x86/panasonic-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/panasonic-laptop.c +1 -1
@@ -107,7 +107,7 @@* * Jul.25, 2004 Hiroshi Miura <[email protected]> * - v0.4 first post version -* add function to retrive SIFR +* add function to retrieve SIFR * * Jul.24, 2004 Hiroshi Miura <[email protected]> * - v0.3 get proper status of hotkey
Signature · 1 line
2.48.1
PATCH v2 7/8 platform/x86: samsung-laptop: Fix typo in sabi_configs comment
In reply to Hemanth SelamCorrect "wihout" to "without". Comment only, no functional change.
--- drivers/platform/x86/samsung-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/samsung-laptop.c +1 -1
@@ -295,7 +295,7 @@ static const struct sabi_config sabi_configs[] = {* d0, d1, d2, d3 - data fields * call - call SABI using command and data * -* This allow to call arbitrary sabi commands wihout +* This allow to call arbitrary sabi commands without * modifying the driver at all. * For example, setting the keyboard backlight brightness to 5 *
Signature · 1 line
2.48.1
PATCH v2 8/8 platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment
In reply to Hemanth SelamCorrect "device-specfic" to "device-specific" in the comment on restoring the default RGB value. Comment only, no functional change.
--- drivers/platform/x86/uniwill/uniwill-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/uniwill/uniwill-acpi.c +1 -1
@@ -1705,7 +1705,7 @@ static int uniwill_kbd_led_mc_brightness_set(struct led_classdev *led_cdev,/* * The EC interprets a RGB value of 0x000000 as a command to restore -* the device-specfic default RGB value. Work around this by writing +* the device-specific default RGB value. Work around this by writing * a RGB value of 0x010101 (faint white) instead. */ if (data->kbd_led_mc_subled_info[0].intensity == 0 &&
Signature · 1 line
2.48.1
Ilpo Järvinen
maintainerQuoted 10 lines · Hemanth Selam
v1 was one patch touching eight drivers. Denis Benato asked for it to be split one patch per file or driver, so here it is as eight patches, one per driver. The corrections themselves are unchanged from v1.
The words all come from
scripts/spelling.txt, which is the list checkpatch.pl uses. codespell finds nothing further in these eight files except "ALS" inasus-laptop.c, which is the Ambient Light Sensor and must stay as it is.[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.
The list of commits applied:
[1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment
commit: 3bf79c45d88b54c9a76f8bfb6733249acfc3c8b7
[2/8] platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment
commit: b6cf8c621b85648b82a6704b1a68106eb193616f
[3/8] platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment
commit: ad483da2140339400bc50c69b017f6fd0cc9774b
[4/8] platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment
commit: 65d3f988c5fae277a3ff732115697d252d5b3913
[5/8] platform/x86: msi-laptop: Fix typo in struct quirk_entry comment
commit: d11503cd82f48242ccaf7b3d481a103d1a75105d
[6/8] platform/x86: panasonic-laptop: Fix typo in the file history comment
commit: d766ef2dab2d718ca760e4f1771e883736ccb861
[7/8] platform/x86: samsung-laptop: Fix typo in sabi_configs comment
commit: 0934b4b77a462240d591f90472b690788b3988b8
[8/8] platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment
commit: 974014bb4087fea3b481c0ac358873587f628663--
i.