Improve MFD_ASUS_TRANSFORMER_EC dependencies
Subsystems (5)
cover Improve MFD_ASUS_TRANSFORMER_EC dependencies
Hi all,
This patch series improves dependencies for the MFD_ASUS_TRANSFORMER_EC MFD driver and its various subdrivers:
- The first patch adds a missing dependency for the MFD driver,
- The other patches enable compile-testing for the input, serio, and battery subdrivers.
Note that compile-testing cannot be enabled for the LED and charger subdrivers, as they have a hard dependency on the MFD driver.
Thanks for your comments!
Geert Uytterhoeven (4):
mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA
input: keyboard: Enable compile-testing for
KEYBOARD_ASUS_TRANSFORMER_EC
input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC
power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC
drivers/input/keyboard/Kconfig | 2 +- drivers/input/serio/Kconfig | 2 +- drivers/mfd/Kconfig | 1 + drivers/power/supply/Kconfig | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-)
Signature · 12 lines
2.43.0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsPATCH 1/4 mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA
The ASUS Transformer's Embedded Controller is only found in Tegra-based ASUS Transformer series tablets and mobile docks. Hence add a dependency on ARCH_TEGRA, to prevent asking the user about this functionality when configuring a kernel without NVIDIA Tegra SoC support.
--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
@@ -141,6 +141,7 @@ config MFD_ASUS_TRANSFORMER_EC tristate "ASUS Transformer's embedded controller" select MFD_CORE depends on I2C && OF + depends on ARCH_TEGRA || COMPILE_TEST help Select this to enable support for the Embedded Controller (EC) found in Tegra based ASUS Transformer series tablets and mobile
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 1/4] mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA
Sashiko has reviewed this patch and found no issues.
Quoted 8 lines
The ASUS Transformer's Embedded Controller is only found in Tegra-based ASUS Transformer series tablets and mobile docks. Hence add a dependency on
ARCH_TEGRA, to prevent asking the user about this functionality when configuring a kernel without NVIDIA Tegra SoC support.Fixes ccb21236e307ff60 ("mfd: Add driver for ASUS Transformer embedded controller")Signed-off-by Geert Uytterhoeven <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
PATCH 2/4 input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC
In reply to Geert UytterhoevenThe Asus Transformer's Mobile Dock multimedia keys driver builds fine when MFD_ASUS_TRANSFORMER_EC is not enabled.
--- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
@@ -91,7 +91,7 @@ config KEYBOARD_APPLESPI config KEYBOARD_ASUS_TRANSFORMER_EC tristate "Asus Transformer's Mobile Dock multimedia keys" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST help Say Y here if you want to use multimedia keys present on Asus Transformer's Mobile Dock.
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 2/4] input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] Input: missing I2C dependency causes build failure in asus_ec_keys_probe() --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Medium] Input: missing I2C dependency causes build failure in asus_ec_keys_probe()
--
commit fd9324a9324e26f4ff25ae83d8027b69e04951cd
Author: Geert Uytterhoeven <[email protected]>
input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC
This commit relaxes the Kconfig dependency for KEYBOARD_ASUS_TRANSFORMER_EC to allow compile-testing when MFD_ASUS_TRANSFORMER_EC is disabled.
drivers/input/keyboard/Kconfig config KEYBOARD_APPLESPI · line 94
Quoted 10 lines
drivers/input/keyboard/Kconfig +1
-1@@ -91,7 +91,7 @@ config KEYBOARD_APPLESPI config KEYBOARD_ASUS_TRANSFORMER_EC tristate "Asus Transformer's Mobile Dock multimedia keys" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST
[Severity: Medium]
Does KEYBOARD_ASUS_TRANSFORMER_EC also need to depend on I2C?
asus_ec_keys_probe() calls i2c_adapter_id(), which is only declared in include/linux/i2c.h when CONFIG_I2C is enabled and has no fallback stub. With COMPILE_TEST=y and I2C=n, building this driver fails with an implicit function declaration error.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
PATCH 3/4 input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC
In reply to Geert UytterhoevenThe Asus Transformer's Dock keyboard and touchpad controller driver builds fine when MFD_ASUS_TRANSFORMER_EC is not enabled.
--- drivers/input/serio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/serio/Kconfig +1 -1
@@ -86,7 +86,7 @@ config SERIO_RPCKBD config SERIO_ASUS_TRANSFORMER_EC tristate "Asus Transformer's Dock keyboard and touchpad controller" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST help Say Y here if you want to use the keyboard and/or touchpad on Asus Transformed's Mobile Dock.
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 3/4] input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] input: serio: missing I2C dependency for SERIO_ASUS_TRANSFORMER_EC --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Medium] input: serio: missing I2C dependency for SERIO_ASUS_TRANSFORMER_EC
--
commit 9aac592895b890fc23d1336a836e2584fd6f0d20
Author: Geert Uytterhoeven <[email protected]>
input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC
This commit relaxes the Kconfig dependency of SERIO_ASUS_TRANSFORMER_EC to allow compile-testing when MFD_ASUS_TRANSFORMER_EC is disabled.
drivers/input/serio/Kconfig config SERIO_RPCKBD · line 89
Quoted 10 lines
drivers/input/serio/Kconfig +1
-1@@ -86,7 +86,7 @@ config SERIO_RPCKBD config SERIO_ASUS_TRANSFORMER_EC tristate "Asus Transformer's Dock keyboard and touchpad controller" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST
[Severity: Medium]
Should SERIO_ASUS_TRANSFORMER_EC also depend on I2C?
asus_ec_serio_write() calls i2c_smbus_write_word_data(), which is only declared when CONFIG_I2C is enabled. Without a dependency on I2C, enabling COMPILE_TEST allows building the driver with CONFIG_I2C=n (which fails compilation) or built-in with CONFIG_I2C=m (which fails linking).
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
PATCH 4/4 power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC
In reply to Geert UytterhoevenThe Asus Transformer's battery driver builds fine when MFD_ASUS_TRANSFORMER_EC is not enabled.
--- drivers/power/supply/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/Kconfig +1 -1
@@ -124,7 +124,7 @@ config BATTERY_CHAGALL config BATTERY_ASUS_TRANSFORMER_EC tristate "Asus Transformer's battery driver" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST help Say Y to enable support for battery status access on Tegra based ASUS Transformer devices.
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 4/4] power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] power: supply: missing I2C dependency on BATTERY_ASUS_TRANSFORMER_EC --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Medium] power: supply: missing I2C dependency on BATTERY_ASUS_TRANSFORMER_EC
--
commit 08aa893cb21ca94a6803c481fce373ce94bd11f3
Author: Geert Uytterhoeven <[email protected]>
power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC
This commit relaxes the MFD_ASUS_TRANSFORMER_EC dependency on BATTERY_ASUS_TRANSFORMER_EC when COMPILE_TEST is enabled.
drivers/power/supply/Kconfig config BATTERY_CHAGALL · line 127
Quoted 10 lines
drivers/power/supply/Kconfig +1
-1@@ -124,7 +124,7 @@ config BATTERY_CHAGALL config BATTERY_ASUS_TRANSFORMER_EC tristate "Asus Transformer's battery driver" - depends on MFD_ASUS_TRANSFORMER_EC + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST
[Severity: Medium]
Does BATTERY_ASUS_TRANSFORMER_EC also need to depend on I2C?
MFD_ASUS_TRANSFORMER_EC depends on I2C, so relaxing the dependency with "|| COMPILE_TEST" allows BATTERY_ASUS_TRANSFORMER_EC to be built with CONFIG_I2C=n or built-in with CONFIG_I2C=m. Because asus_ec_battery_refresh() calls i2c_smbus_read_i2c_block_data(), which is only declared and built when CONFIG_I2C is enabled, those configurations fail to compile or link.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
чт, 19 лист. 2026 р. о 15:52 Geert Uytterhoeven <[email protected]> пише:
Quoted 9 lines
Hi all,
This patch series improves dependencies for the
MFD_ASUS_TRANSFORMER_ECMFD driver and its various subdrivers:
- The first patch adds a missing dependency for the MFD driver,
- The other patches enable compile-testing for the input, serio, and battery subdrivers.
Quoted 7 lines
Note that compile-testing cannot be enabled for the LED and charger subdrivers, as they have a hard dependency on the MFD driver.
Thanks for your comments!
Geert Uytterhoeven (4):
mfd:MFD_ASUS_TRANSFORMER_ECshould depend onARCH_TEGRA
Though this EC is designed for Tegra based devices, it does not have any Tegra specific parts. It can be used by any other SoC.
Quoted 24 lines
input: keyboard: Enable compile-testing for
KEYBOARD_ASUS_TRANSFORMER_EC
input: serio: Enable compile-testing forSERIO_ASUS_TRANSFORMER_EC
power: supply: Enable compile-testing forBATTERY_ASUS_TRANSFORMER_ECdrivers/input/keyboard/Kconfig | 2 +- drivers/input/serio/Kconfig | 2 +- drivers/mfd/Kconfig | 1 + drivers/power/supply/Kconfig | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-)--
2.43.0Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds