Skip to contentSkip to conversation

ECRC configuration if AER is owned by the firmware

DISCUSSION Bjorn Helgaas 1 participant 1 message Oct 31, 2022 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 4 lines · Vidya Sagar

Hi,
With the top of the tree codebase, pcie_set_ecrc_checking() is called from pci_aer_init().
This flow doesn't really take into account the ownership of the AER

Quoted 8 lines

registers, and it makes sense in the case of the Linux kernel owning the AER.
But, if the owner of AER is firmware and not OS, then, ideally, any register/fields (including ECRC bits) are not supposed to be touched by the OS.
Is my understanding correct?
If so, then, isn't the current code violating that rule?
Could you please comment on it?

I think you are correct and the current code violates the rule.

Bjorn

P.S. Your message was a multi-part message that will likely be rejected by the vger mailing lists:
http://vger.kernel.org/majordomo-info.html