net: Fix potential deadloop in skb_copy_ubufs()
Quoted 6 lines · Eric Dumazet
Quoted 4 lines · linmiaohe
Willem de Bruijn <[email protected]> wrote:
Since we always call
skb_orphan_fragsinskb_clone, is it unnecessary to callskb_orphan_fragsinpskb_expand_headwhen skb is cloned ?
Quoted 7 lines
Please give us a real case.
I fear that your patches are coming directly from some kind of automated tool, that really misses how the code is really used from _current_ code base, not _hypothetical_ one.
This is very time consuming. Please provide evidence first.
Thank you.
I'am sorry about it. I do this mainly through code review and do some test code. So the problem codepath may not exist from current code base, but may happen when we do not take care of it in the future use. We may forget same assumption. And make these assumptions clear seems not a bad thing. But I'am going to just drop this patch. I believe you all can handle the things correctly.
Many thanks.