Skip to contentSkip to conversation

needs_root: Add setting of needs_root

PATCH zhaogongyi via ltp 1 participant 1 message Oct 14, 2022

lore
Share & tools
lore
#0 lore raw

Hi Petr,

Quoted 56 lines

Hi all,

Quoted 10 lines

Hi,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Hi Petr,

It is failed on my system:

sh-4.4$ ./msgget03
tst_test.c:1535: TINFO: Timeout per run is 0h 00m 30s msgget03.c:42: TINFO: Current environment 0 message queues

are

Quoted 40 lines
Quoted 40 lines
Quoted 3 lines
Quoted 3 lines

already

Quoted 2 lines

in use
msgget03.c:45: TBROK: Failed to open FILE

'/proc/sys/kernel/msgmni'

Quoted 6 lines
Quoted 6 lines
Quoted 1 line

for writing: EACCES (13)

Ah, b740bfac5 ("msgget03: Set custom queue limit") causes the need for root. IMHO this one is valid.

I'd suggest to remove needs_root for needs_device and

mount_device

Quoted 3 lines
Quoted 1 line

now (i.e. send v2).

Just remove the patch 1 and keep adding needs_root in patch 2?

If you haven't added it to any test which would have needs_device or mount_device, then v2 can be kept.

But process_vm_readv02 works for me (on master, on Debian) without root:

$ ./process_vm_readv02
tst_test.c:1526: TINFO: Timeout per run is 0h 00m 30s
process_vm_readv02.c:32: TINFO: child 0: memory allocated and
initialized
process_vm_readv02.c:49: TINFO: child 1: reading string from same
memory location
process_vm_readv02.c:61: TPASS: expected string received

Summary:

passed   1
failed   0
broken   0
skipped  0

warnings 0

Also process_vm_readv03, process_vm_writev02 (I stopped checking now).

Why you need it?

Quoted 6 lines
Quoted 3 lines

On my system, these testcases failed and report EPERM:

sh-4.4$ ./process_vm_readv02

OK, your system is Alpine (it can shorten our discussion next time if you report you have problems on musl - i.e. which kernel and libc + versions you use).

My system is base on kernel version 4.15.0 and glibc 2.27.

When I run the test on the kernel version 6.0 system with non-root, it is passed.

Regards,
Gongyi

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp