nvdimm: Call nvdimm_put_key(key) only once in nvdimm_key_revalidate()
Subsystems (2)
PATCH 1/1 nvdimm: Call nvdimm_put_key(key) only once in nvdimm_key_revalidate()
From: Markus Elfring <[email protected]>
Date: Mon, 23 Sep 2024 17:05:39 +0200
A nvdimm_put_key(key) call was immediately used after a return code check for a change_key() call in this function implementation. Thus call such a function only once instead directly before the check.
This issue was transformed by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
--- drivers/nvdimm/security.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/nvdimm/security.c +2 -4
@@ -152,12 +152,10 @@ static int nvdimm_key_revalidate(struct nvdimm *nvdimm)* verify that the key is good. */ rc = nvdimm->sec.ops->change_key (nvdimm, data, data,NVDIMM_USER ); -if (rc <0 ) { -nvdimm_put_key (key); +nvdimm_put_key (key); +if (rc <0 )return rc; - } -nvdimm_put_key (key); nvdimm->sec.flags =nvdimm_security_flags (nvdimm,NVDIMM_USER );return 0 ; }
--
2.46.1