Skip to contentSkip to conversation

Relocation size penalty calculation

U-Boot Graeme Russ 6 participants 47 messages Oct 8, 2009 – Oct 17, 2009 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Have any metrics been done for PPC?

Regards,

Graeme

#1 lore raw
Quoted 29 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Quoted 6 lines

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Have any metrics been done for PPC?

Things actually improve a little bit when we use -mrelocatable and get rid of all the manual "+= gd->reloc_off" fixups:

1) Top of mainline on XPedite5370:
text data bss dec hex filename
308612 24488 33172 366272 596c0 u-boot

2) Top of "reloc" branch on XPedite5370 (ie -mrelocatable):
text data bss dec hex filename
303704 28644 33156 365504 593c0 u-boot

For fun:
3) #2 but with s/-mrelocatable/-fpic/ (probably doesn't boot):
text data bss dec hex filename
303704 24472 33156 361332 58374 u-boot

There may be some other changes that affect the size between mainline and "reloc", but their sizes are in the same general ballpark.

Best,
Peter

#2 lore raw
Quoted 42 lines · Peter Tyser
Quoted 29 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Quoted 7 lines

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Have any metrics been done for PPC?

Things actually improve a little bit when we use -mrelocatable and get rid of all the manual "+= gd->reloc_off" fixups:

Quoted 9 lines

1) Top of mainline on XPedite5370:
text data bss dec hex filename
308612 24488 33172 366272 596c0 u-boot

2) Top of "reloc" branch on XPedite5370 (ie -mrelocatable):
text data bss dec hex filename
303704 28644 33156 365504 593c0 u-boot

Hi Peter,
Just to be clear, the total text+data length of u-boot with the
"manual" relocations (#1) is LARGER than the text+data length of u-boot with the "manual" relocations removed and the necessary centralized relocation code added, along with any additional data sections required by -mrelocateable (#2), by 768 (dec) bytes? And both cases (1 and 2) work equivalently?

Best Regards,
Bill Campbell.

Quoted 19 lines

For fun:
3) #2 but with s/-mrelocatable/-fpic/ (probably doesn't boot):
text data bss dec hex filename
303704 24472 33156 361332 58374 u-boot

There may be some other changes that affect the size between mainline and "reloc", but their sizes are in the same general ballpark.

Best,
Peter

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw
Quoted 52 lines · J. William Campbell
Quoted 42 lines · Peter Tyser
Quoted 29 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Quoted 7 lines

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Have any metrics been done for PPC?

Things actually improve a little bit when we use -mrelocatable and get rid of all the manual "+= gd->reloc_off" fixups:

Quoted 9 lines

1) Top of mainline on XPedite5370:
text data bss dec hex filename
308612 24488 33172 366272 596c0 u-boot

2) Top of "reloc" branch on XPedite5370 (ie -mrelocatable):
text data bss dec hex filename
303704 28644 33156 365504 593c0 u-boot

Quoted 6 lines

Hi Peter,
Just to be clear, the total text+data length of u-boot with the
"manual" relocations (#1) is LARGER than the text+data length of u-boot with the "manual" relocations removed and the necessary centralized relocation code added, along with any additional data sections required by -mrelocateable (#2), by 768 (dec) bytes?

Hi Bill,
Doah, looks like I chose a bad board as an example. The XPedite5370 already had -mrelocatable defined in its own board/xes/xpedite5370/config.mk in mainline, so the above comparison should be ignored as both builds used -mrelocatable.

Here's some *real* results from the MPC8548CDS:
1) Top of mainline:
text data bss dec hex filename
219968 17052 22992 260012 3f7ac u-boot

2) Top of "reloc" branch (ie -mrelocatable)
text data bss dec hex filename
219192 20640 22980 262812 4029c u-boot

So the reloc branch is 2.7K bigger for the MPC8548CDS.

Best,
Peter

#4 lore raw
Quoted 76 lines · Peter Tyser
Quoted 55 lines · J. William Campbell
Quoted 43 lines · Peter Tyser
Quoted 29 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Quoted 8 lines

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Have any metrics been done for PPC?

Things actually improve a little bit when we use -mrelocatable and get rid of all the manual "+= gd->reloc_off" fixups:

Quoted 10 lines

1) Top of mainline on XPedite5370:
text data bss dec hex filename
308612 24488 33172 366272 596c0 u-boot

2) Top of "reloc" branch on XPedite5370 (ie -mrelocatable):
text data bss dec hex filename
303704 28644 33156 365504 593c0 u-boot

Quoted 7 lines

Hi Peter,
Just to be clear, the total text+data length of u-boot with the
"manual" relocations (#1) is LARGER than the text+data length of u-boot with the "manual" relocations removed and the necessary centralized relocation code added, along with any additional data sections required by -mrelocateable (#2), by 768 (dec) bytes?

Hi Bill,
Doah, looks like I chose a bad board as an example. The XPedite5370 already had -mrelocatable defined in its own board/xes/xpedite5370/config.mk in mainline, so the above comparison should be ignored as both builds used -mrelocatable.

Here's some *real* results from the MPC8548CDS:
1) Top of mainline:
text data bss dec hex filename
219968 17052 22992 260012 3f7ac u-boot

Quoted 6 lines

2) Top of "reloc" branch (ie -mrelocatable)
text data bss dec hex filename
219192 20640 22980 262812 4029c u-boot

So the reloc branch is 2.7K bigger for the MPC8548CDS.

Hi Peter,
OK, that's more like it! A 1.2 % size increase in ROM seems like a
very small price to pay for a truly relocatable u-boot image that will run on any size memory without the programmer having to actively worry about what may need relocating as code is written. . Also, it should be noted that the size increase in 2) is mostly in relocation segments that do not need to be copied into ram, so the ram footprint should be smaller for 2) than 1). The relocation code itself could also be placed is a segment that is not copied into ram, although that may be more trouble than it is worth.
I am looking forward to Graeme's results with the 386. I expect
that it will not be quite so favorable, perhaps a 4 or 5% size increase for -mrelocatable over an absolute build. However, -mrelocatable vs. -fpic may be comparable, with -mrelocatable actually winning. But then again, I could be totally wrong!

Best Regards,
Bill Campbell

Quoted 6 lines

Best,
Peter

#5 lore raw
In reply to Graeme Russ
Quoted 26 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 8 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Hi Graeme,
I would be interested in a third option (column), the x86 build
with just -mrelocateable but NOT -fpic. It will not be definitive because there will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Best Regards,
Bill Campbell

Quoted 12 lines

Have any metrics been done for PPC?

Regards,

Graeme
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#6 lore raw
Quoted 37 lines · J. William Campbell
Quoted 27 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 8 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 5 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 9 lines

Best Regards,
Bill Campbell

Quoted 6 lines

Have any metrics been done for PPC?

Regards,

Graeme

Once the reloc branch has been merged, how many arches are left which do not support relocation?

Regards,

Graeme

#7 lore raw

Dear Graeme Russ,

Quoted 4 lines · In message <[email protected]> you…

Once the reloc branch has been merged, how many arches are left which do not support relocation?

All but PPC ?

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There comes to all races an ultimate crisis which  you  have  yet  to
face  ....  One  day  our  minds became so powerful we dared think of
ourselves as gods.
	-- Sargon, "Return to Tomorrow", stardate 4768.3
#8 lore raw
Quoted 9 lines · Wolfgang Denk

Dear Graeme Russ,

Quoted 4 lines · In message <[email protected]> you…

Once the reloc branch has been merged, how many arches are left which do not support relocation?

All but PPC ?

Hmm, so commit 0630535e2d062dd73c1ceca5c6125c86d1127a49 is all about removing code that is not used because these arches do not do any relocation at all?

So ultimately, what we are looking at is the complete and utter removal of any code which references a relocation adjustment in lieu of each arch either:

a) Execute in Place from Flash, or;
b) Setting a fixed TEXT_BASE at a known RAM location and copying

     the contents of Flash to RAM, or;

c) Implementing full Relocation

Quoted 5 lines

Best regards,

Wolfgang Denk

Regards,

Graeme

#9 lore raw
Quoted 6 lines · Graeme Russ
Quoted 5 lines · Wolfgang Denk

Dear Graeme Russ,

Quoted 2 lines · In message <[email protected]> you…
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Once the reloc branch has been merged, how many arches are left which do not support relocation?

All but PPC ?

Hmm, so commit 0630535e2d062dd73c1ceca5c6125c86d1127a49 is all about removing code that is not used because these arches do not do any relocation at all?

I sent that patch/RFC after noticing none of those architectures performed manual relocation fixups, thus they could save some code space by defining CONFIG_RELOC_FIXUP_WORKS. Similarly the gd->reloc_off field was no longer needed for them.

I'm not familiar with if or how those architectures are relocating, just that they didn't need relocation fixups. So that was the logic...

Quoted 8 lines

So ultimately, what we are looking at is the complete and utter removal of any code which references a relocation adjustment in lieu of each arch either:

a) Execute in Place from Flash, or;
b) Setting a fixed TEXT_BASE at a known RAM location and copying

     the contents of Flash to RAM, or;

c) Implementing full Relocation

d) Leaving those architectures the way they are now Could be added if a,b,c won't work for some reason too.

I think it would be great to remove any manual relocation adjustments in the long run. This isn't strictly necessary though, as we can still have manual relocations littering the code - its just a bit dirty and prone to issues in the long run.

So my vote would be to shoot for c) for all arches, but I have no idea what impact that would have on them:)

Best,
Peter

#10 lore raw
Quoted 12 lines · On Thursday 08 October 2009 18:20:18 Peter Tyser wrote:
Quoted 10 lines · Graeme Russ
Quoted 5 lines · Wolfgang Denk
Quoted 2 lines · Graeme Russ

Once the reloc branch has been merged, how many arches are left which do not support relocation?

All but PPC ?

Hmm, so commit 0630535e2d062dd73c1ceca5c6125c86d1127a49 is all about removing code that is not used because these arches do not do any relocation at all?

Quoted 7 lines

I sent that patch/RFC after noticing none of those architectures performed manual relocation fixups, thus they could save some code space by defining CONFIG_RELOC_FIXUP_WORKS. Similarly the gd->reloc_off field was no longer needed for them.

I'm not familiar with if or how those architectures are relocating, just that they didn't need relocation fixups. So that was the logic...

the usage in the Blackfin port is most likely a copy & paste of existing code. deleting malloc_bin_reloc() from lib_blackfin/board.c and adding CONFIG_RELOC_FIXUP_WORKS results in a working boot. ive never really looked into relocation as no one has asked for it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091008/d42e7117/attachment.pgp

#11 lore raw
In reply to Peter Tyser
Quoted 12 lines · Peter Tyser
Quoted 11 lines · Graeme Russ
Quoted 9 lines · Wolfgang Denk

Dear Graeme Russ,

Quoted 4 lines · In message <[email protected]> you…

Once the reloc branch has been merged, how many arches are left which do not support relocation?

All but PPC ?

Quoted 8 lines
Quoted 3 lines

Hmm, so commit 0630535e2d062dd73c1ceca5c6125c86d1127a49 is all about removing code that is not used because these arches do not do any relocation at all?

I sent that patch/RFC after noticing none of those architectures performed manual relocation fixups, thus they could save some code space by defining CONFIG_RELOC_FIXUP_WORKS. Similarly the gd->reloc_off field was no longer needed for them.

Maybe CONFIG_RELOC_NOT_IMPLEMENTED would be more descriptive

Quoted 8 lines

I'm not familiar with if or how those architectures are relocating, just that they didn't need relocation fixups. So that was the logic...

Quoted 4 lines

So ultimately, what we are looking at is the complete and utter removal of any code which references a relocation adjustment in lieu of each arch either:

Quoted 7 lines
Quoted 4 lines

a) Execute in Place from Flash, or;
b) Setting a fixed TEXT_BASE at a known RAM location and copying

     the contents of Flash to RAM, or;

c) Implementing full Relocation

d) Leaving those architectures the way they are now Could be added if a,b,c won't work for some reason too.

Which is essentially either a) or b) depending on which way the arch was implemented. For x86, it has been b) but it is going towards c)

Quoted 8 lines

I think it would be great to remove any manual relocation adjustments in the long run. This isn't strictly necessary though, as we can still have manual relocations littering the code - its just a bit dirty and prone to issues in the long run.

So my vote would be to shoot for c) for all arches, but I have no idea what impact that would have on them:)

So the big question now is - How many arches do partial relocation and really need gd->reloc_off

Quoted 5 lines

Best,
Peter

Regards,

Graeme

#12 lore raw
In reply to Graeme Russ
Quoted 40 lines · Graeme Russ
Quoted 37 lines · J. William Campbell
Quoted 35 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 9 lines
Quoted 6 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

x86 does not have -mrelocatable. This is a PPC only option :(

Hi Graeme,
You are unfortunately correct. However, I wonder if we can
get essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Best Regards,
Bill Campbell
**

Quoted 21 lines
Quoted 11 lines

Best Regards,
Bill Campbell

Quoted 6 lines

Have any metrics been done for PPC?

Regards,

Graeme

Once the reloc branch has been merged, how many arches are left which do not support relocation?

Regards,

Graeme

#13 lore raw
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Regards,

Graeme

Quoted 28 lines

Best Regards,
Bill Campbell
**

Quoted 23 lines
Quoted 13 lines

Best Regards,
Bill Campbell

Quoted 7 lines

Have any metrics been done for PPC?

Regards,

Graeme

Once the reloc branch has been merged, how many arches are left which do not support relocation?

Regards,

Graeme

#14 lore raw
Quoted 68 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Quoted 4 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Try -fvisibility=hidden

Jocke

#15 lore raw
Quoted 68 lines · Joakim Tjernlund
Quoted 68 lines
Quoted 65 lines · J. William Campbell
Quoted 52 lines · Graeme Russ
Quoted 40 lines · J. William Campbell
Quoted 27 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 10 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 8 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 3 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Quoted 7 lines
Quoted 5 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

It is true that --emit-relocs is not required when -pic and -pie are used instead. However, pic and pie are designed to allow shared code (libraries) to appear at different logical addresses in several programs without altering the text. This is grand overkill for what we need, which is the ability to relocate the code. The -pic and -pie code will be larger than the code without pic and pie. How much larger is a good question. On the PPC, it is larger but not much larger, because there are lots of registers available and one is almost for sure got (no pun intended) the magic relocation constant(s) in it. On the 386 with many fewer registers, pic and pie will cause the code to be percentage-wise larger than on the PPC. Thus avoiding pic and pie is a Good Thing in most cases.

Quoted 2 lines

Try -fvisibility=hidden

I assume the -fvisibility=hidden is suggested in order to reduce (eliminate) the symbol table from the output, which we don't need because there are assumed to be no undefined symbols in our final ld. If that works, great! I was assuming we might need a custom "strip" program to delete any sections that we don't need, but this sounds easier if it gets them all.

Best Regards,
Bill Campbell

Quoted 5 lines

Jocke

#16 lore raw
In reply to Joakim Tjernlund
Quoted 68 lines · Joakim Tjernlund
Quoted 68 lines
Quoted 64 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Quoted 6 lines
Quoted 4 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Quoted 4 lines

Jocke

Regards,

Graeme

#17 lore raw

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

#18 lore raw
Quoted 79 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 78 lines
Quoted 74 lines · Joakim Tjernlund
Quoted 68 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Quoted 4 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Try -fvisibility=hidden

Quoted 10 lines
Quoted 6 lines

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Not really - The .eh_frame saving applies to both relocated and non relocated builds

Regards,

Graeme

#19 lore raw

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 87 lines
Quoted 84 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 83 lines
Quoted 68 lines · Joakim Tjernlund
Quoted 68 lines
Quoted 64 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

Quoted 6 lines
Quoted 4 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

#20 lore raw
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 93 lines
Quoted 89 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Quoted 10 lines
Quoted 2 lines

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

#21 lore raw

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 110 lines
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 93 lines
Quoted 89 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Quoted 10 lines
Quoted 2 lines

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

Quoted 7 lines

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

Quoted 6 lines

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

Ah, that is because you built an exe with -pie Then you should be able to drop everything but the RELATIVE from the linking, or almost in any case.

Jocke

#22 lore raw
Quoted 127 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 110 lines
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 93 lines
Quoted 89 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 28 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are the results (fixed width font will help - its space, not tab, formatted):

Section non-reloc reloc
---------------------------------------

.text                000118c4  000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata              00005bad  000059d0
.interp              n/a       00000013
.dynstr              n/a       00000648
.hash                n/a       00000428
.eh_frame            00003268  000034fc
.data                00000a6c  000001dc
.data.rel            n/a       00000098
.data.rel.ro.local   n/a       00000178
.data.rel.local      n/a       000007e4
.got                 00000000  000001f0
.got.plt             n/a       0000000c
.rel.got             n/a       000003e0
.rel.dyn             n/a       00001228
.dynsym              n/a       00000850
.dynamic             n/a       00000080
.u_boot_cmd          000003c0  000003c0
.bss                 00001a34  00001a34
.realmode            00000166  00000166
.bios                0000053e  0000053e
Quoted 9 lines

=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that, the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code to do some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Quoted 10 lines
Quoted 2 lines

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

Quoted 7 lines

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

Quoted 4 lines

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Quoted 10 lines
Quoted 2 lines

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

Ah, that is because you built an exe with -pie Then you should be able to drop everything but the RELATIVE from the linking, or almost in any case.

Jocke

Hmm, so its seems I may have hit the limit. I tried:

PLATFORM_LDFLAGS += -r --emit-relocs

but there is not enough information left to complete the relocation. It seems as though I need .rel.got, .got.plt, .dynsym and .rel.dyn in order to find the actual bytes that need modifying (it also seems to mess with the size of the stripped binary for some reason)

Looks like I'll have to proceed with my original plan - a bit bloated, but it works

Graeme

#23 lore raw

Graeme Russ <[email protected]> wrote on 10/10/2009 13:21:10:

Quoted 145 lines
Quoted 127 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 110 lines
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 93 lines
Quoted 89 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 41 lines · J. William Campbell
Quoted 37 lines · Graeme Russ

Out of curiosity, I wanted to see just how much of a size penalty I am
incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are
the results (fixed width font will help - its space, not tab,
formatted):

Section non-reloc reloc
---------------------------------------
.text 000118c4 000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata 00005bad 000059d0
.interp n/a 00000013
.dynstr n/a 00000648
.hash n/a 00000428
.eh_frame 00003268 000034fc
.data 00000a6c 000001dc
.data.rel n/a 00000098
.data.rel.ro.local n/a 00000178
.data.rel.local n/a 000007e4
.got 00000000 000001f0
.got.plt n/a 0000000c
.rel.got n/a 000003e0
.rel.dyn n/a 00001228
.dynsym n/a 00000850
.dynamic n/a 00000080
.u_boot_cmd 000003c0 000003c0
.bss 00001a34 00001a34
.realmode 00000166 00000166
.bios 0000053e 0000053e
=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that,
the crude dynamic loader accounts for only 341 bytes

Quoted 7 lines

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because there
will be extra code that references the GOT and missing code todo some of the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Quoted 10 lines
Quoted 2 lines

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

Quoted 7 lines

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

Quoted 4 lines

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Quoted 10 lines
Quoted 2 lines

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

Ah, that is because you built an exe with -pie Then you should be able to drop everything but the RELATIVE from the linking, or almost in any case.

Jocke

Hmm, so its seems I may have hit the limit. I tried:

PLATFORM_LDFLAGS += -r --emit-relocs

Quoted 7 lines

but there is not enough information left to complete the relocation. It seems as though I need .rel.got, .got.plt, .dynsym and .rel.dyn in order to find the actual bytes that need modifying (it also seems to mess with the size of the stripped binary for some reason)

Looks like I'll have to proceed with my original plan - a bit bloated, but it works

Relocation costs :(

I am not sure why you need .got.plt, it should be empty, what is in it?
Same with dynsym, what is in it?

Memory fails me, but since u-boot is a freestanding app it I think these two might not be needed. Perhaps there are weak unresolved syms in there?

Jocke

#24 lore raw
Quoted 160 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 13:21:10:

Quoted 145 lines
Quoted 127 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 110 lines
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 93 lines
Quoted 89 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 76 lines
Quoted 73 lines · Joakim Tjernlund
Quoted 72 lines
Quoted 57 lines · J. William Campbell
Quoted 53 lines · Graeme Russ
Quoted 48 lines · J. William Campbell

Graeme Russ wrote:

Out of curiosity, I wanted to see just how much of a size penalty I am
incurring by using gcc -fpic / ld -pic on my x86 u-boot build. Here are
the results (fixed width font will help - its space, not tab,
formatted):

Section non-reloc reloc
---------------------------------------
.text 000118c4 000137fc <- 0x1f38 bytes (~8kB) bigger
.rodata 00005bad 000059d0
.interp n/a 00000013
.dynstr n/a 00000648
.hash n/a 00000428
.eh_frame 00003268 000034fc
.data 00000a6c 000001dc
.data.rel n/a 00000098
.data.rel.ro.local n/a 00000178
.data.rel.local n/a 000007e4
.got 00000000 000001f0
.got.plt n/a 0000000c
.rel.got n/a 000003e0
.rel.dyn n/a 00001228
.dynsym n/a 00000850
.dynamic n/a 00000080
.u_boot_cmd 000003c0 000003c0
.bss 00001a34 00001a34
.realmode 00000166 00000166
.bios 0000053e 0000053e
=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes (~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and of that,
the crude dynamic loader accounts for only 341 bytes

Hi Graeme,
I would be interested in a third option (column), the x86 build with
just -mrelocateable but NOT -fpic. It will not be definitive because
there
will be extra code that references the GOT and missing code todo some of
the relocation, but it would still be interesting.

Quoted 2 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 7 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we can get
essentially the same result by executing the final ld step with the --emit-relocs switch included. This may also include some "extra" sections that we would want to strip out, but if it works, it could give all ELF-based systems a way to a relocatable u-boot.

I don't think --emit-relocs is necessary with -pic. I haven't gone through all the permutations to see if there is a smaller option, but gcc -fpic and ld -pie creates enough information to perform relocation on the x86 platform

Quoted 8 lines
Quoted 1 line

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Great, so now you are back at just a few percent added I guess?

Quoted 10 lines
Quoted 2 lines

Not really - The .eh_frame saving applies to both relocated and non relocated builds

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above. Have a look at uClibc ldso/ldso/dl-startup.c

Quoted 7 lines

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

Quoted 4 lines

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Quoted 10 lines
Quoted 2 lines

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

Ah, that is because you built an exe with -pie Then you should be able to drop everything but the RELATIVE from the linking, or almost in any case.

Jocke

Hmm, so its seems I may have hit the limit. I tried:

PLATFORM_LDFLAGS += -r --emit-relocs

Quoted 7 lines

but there is not enough information left to complete the relocation. It seems as though I need .rel.got, .got.plt, .dynsym and .rel.dyn in order to find the actual bytes that need modifying (it also seems to mess with the size of the stripped binary for some reason)

Looks like I'll have to proceed with my original plan - a bit bloated, but it works

Relocation costs :(

I am not sure why you need .got.plt, it should be empty, what is in it?
Same with dynsym, what is in it?

Quoted 7 lines

Memory fails me, but since u-boot is a freestanding app it I think these two might not be needed. Perhaps there are weak unresolved syms in there?

Jocke

Well, I'm in the middle of a pretty intense analysis of what is going on.

Compile flags are:

PLATFORM_RELFLAGS += -fpic -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic -Bsymbolic

So far I have found that the only sections that have changes as a result of a change in TEXT_BASE are:

    .text
    .rodata
    .data.rel
    .got
    .got.plt
    .rel.text
    .rel.got
    .rel.dyn
    .dynsym
    .dynamic
    .u_boot_cmd

Changes in .text are covered by .rel.text (see below) or as a result of CONFIG_SYS_MONITOR_BASE being equal to TEXT_BASE (used in cfi_flash.c)

Changes in .rodata are a result of version_string changing for each compile

.rel.text
- Contains a list of pointers into .got
- All entries are R_386_RELATIVE
- All entries (8 of) are in cpu/i386/start.o
- cpu/i386/start.o only used during initial bootstrap - not needed after execution starts in RAM
- Can be safely discarded

.rel.got
- Contains a list of pointers into .got
- All entries are R_386_RELATIVE
- Not all entries change with TEXT_BASE. Some entries are symbols exported from the linker script (in particular section size exports) while the others are in the somewhat 'special' BIOS and Real Mode sections which are located in a fixed RAM location (these sections are used for real-mode trampolining into Linux by providing a limited PC 'BIOS'
- All entries that are not linked to TEXT_BASE are easily identified because they are 'located' below TEXT_BASE (specically between 0x00000000 and 0x00001A34)
- This section is not needed in the final binary - Direct processing of .got will achieve the required end result

.rel.dyn
- Contains a list of pointers into .data.rel and .u_boot_cmd
- Like .rel.got, not all entries in .data.rel need relocating. Again, like .rel.got, these are easily identified
- This section not needed

Another 5.5k saved

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C
- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
      [09] 0x00000013, 0x00000008 DT_RELENT, ???
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???
      [0b] 0x6FFFFFFA, 0x00000236 ???, Entries in .rel.dyn
      [0c] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0d] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0e] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0f] 0x00000000, 0x00000000 DT_NULL, End of Array
      [10] 0x00000000, 0x00000000 DT_NULL, End of Array

I think some more investigation into the need for .dynsym and .dynamic is still required...

Regards,

Graeme

A message that is not in the archive (sent off-list or not yet received): OF83D1271F.04B67606-ONC125764C.0045BFF2-C125764C.0046AC45@transmode.se

#26 lore raw
Quoted 1 line · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 11 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

Quoted 23 lines
Quoted 15 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
Quoted 8 lines
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 3 lines

How big DT_REL is

Quoted 1 line
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Quoted 7 lines
Quoted 1 line
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

This is not a problem because this is very low-level init that is not called once relocated into RAM - These relocations can be safely ignored

Quoted 9 lines
Quoted 9 lines
      [0b] 0x6FFFFFFA, 0x00000236 ???, Entries in .rel.dyn
      [0c] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0d] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0e] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0f] 0x00000000, 0x00000000 DT_NULL, End of Array
      [10] 0x00000000, 0x00000000 DT_NULL, End of Array

I think some more investigation into the need for .dynsym and .dynamic is still required...

.dynsym may still be required if only for accessing the __u_boot_cmd structure. However, I may be able to hack that a little and not create a __u_boot_cmd symbol in the linker script (create some other temporary symbol) and populate __u_boot_cmd with a valid value after relocation. It will look a little weird, but may mean not loading this section into RAM

Other than that, .dynsym is now only needed to locate the sections during the relocation phase and can be kept in flash and not copied to RAM

I don't think .dynamic is needed due to the exporting of section addresses from the linker script

Regards,

Graeme

#27 lore raw

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 15 lines
Quoted 1 line · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 9 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 4 lines
Quoted 2 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 5 lines
Quoted 3 lines

How big DT_REL is

Quoted 1 line
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 8 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 6 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

Quoted 12 lines

This is not a problem because this is very low-level init that is not called once relocated into RAM - These relocations can be safely ignored

Quoted 7 lines
Quoted 7 lines
      [0b] 0x6FFFFFFA, 0x00000236 ???, Entries in .rel.dyn
      [0c] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0d] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0e] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0f] 0x00000000, 0x00000000 DT_NULL, End of Array
      [10] 0x00000000, 0x00000000 DT_NULL, End of Array
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

I think some more investigation into the need for .dynsym and .dynamic is still required...

.dynsym may still be required if only for accessing the __u_boot_cmd structure. However, I may be able to hack that a little and not create a __u_boot_cmd symbol in the linker script (create some other temporary symbol) and populate __u_boot_cmd with a valid value after relocation. It will look a little weird, but may mean not loading this section into RAM

Why do you need to much around with u_boot_cmd at all? Now that relocation works you should be able to drop all that code/linker stuff?

Quoted 3 lines

Other than that, .dynsym is now only needed to locate the sections during the relocation phase and can be kept in flash and not copied to RAM

Still occupies space in the *bin image though.

#28 lore raw
Quoted 76 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 9 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

I think this approach will turn out to be a big win. At present, the problem with just using the relocs is that objcopy is stripping them out when u-boot.bin is created, as I understand it. It seems this can be solved by changing the command switches appropriately, like using --strip-unneeded. In any case, there is some combination of switches that will preserve the relocation data. The executable code will get smaller, there will be no .got, and the relocation data will be larger (than with -fpic). In total size, it probably will be slightly smaller, but that is a guess. The most important benefit of this approach is that it will work for all architectures, thereby solving the problem once and forever! Even if the result is a bit larger, the RAM footprint will be reduced by the smaller object code size (since the relocation data need not be copied into ram).Having this approach as an option would be real nice, since it would always "just work".

Best Regards,
Bill Campbell

Quoted 40 lines
Quoted 13 lines

This is not a problem because this is very low-level init that is not called once relocated into RAM - These relocations can be safely ignored

Quoted 7 lines
Quoted 7 lines
      [0b] 0x6FFFFFFA, 0x00000236 ???, Entries in .rel.dyn
      [0c] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0d] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0e] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0f] 0x00000000, 0x00000000 DT_NULL, End of Array
      [10] 0x00000000, 0x00000000 DT_NULL, End of Array
Quoted 9 lines
Quoted 3 lines
Quoted 3 lines

I think some more investigation into the need for .dynsym and .dynamic is still required...

.dynsym may still be required if only for accessing the __u_boot_cmd structure. However, I may be able to hack that a little and not create a __u_boot_cmd symbol in the linker script (create some other temporary symbol) and populate __u_boot_cmd with a valid value after relocation. It will look a little weird, but may mean not loading this section into RAM

Why do you need to much around with u_boot_cmd at all? Now that relocation works you should be able to drop all that code/linker stuff?

Quoted 3 lines

Other than that, .dynsym is now only needed to locate the sections during the relocation phase and can be kept in flash and not copied to RAM

Still occupies space in the *bin image though.

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#29 lore raw

"J. William Campbell" <[email protected]> wrote on 13/10/2009 18:30:43:

Quoted 87 lines
Quoted 76 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 9 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

Quoted 14 lines

I think this approach will turn out to be a big win. At present, the problem with just using the relocs is that objcopy is stripping them out when u-boot.bin is created, as I understand it. It seems this can be solved by changing the command switches appropriately, like using --strip-unneeded. In any case, there is some combination of switches that will preserve the relocation data. The executable code will get smaller, there will be no .got, and the relocation data will be larger (than with -fpic). In total size, it probably will be slightly smaller, but that is a guess. The most important benefit of this approach is that it will work for all architectures, thereby solving the problem once and forever! Even if the result is a bit larger, the RAM footprint will be reduced by the smaller object code size (since the relocation data need not be copied into ram).Having this approach as an option would be real nice, since it would always "just work".

Yes, I had this in the back of my head. I do think some other arch than ppc will have to try this out though :)
I am not 100% sure this will work with my end goal, true PIC so I can load the same img anywhere in flash.

Jocke

#30 lore raw
In reply to Joakim Tjernlund
Quoted 68 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 15 lines
Quoted 1 line · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 9 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 4 lines
Quoted 2 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 5 lines
Quoted 3 lines

How big DT_REL is

Quoted 1 line
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 8 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 6 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 9 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

Quoted 31 lines
Quoted 12 lines

This is not a problem because this is very low-level init that is not called once relocated into RAM - These relocations can be safely ignored

Quoted 7 lines
Quoted 7 lines
      [0b] 0x6FFFFFFA, 0x00000236 ???, Entries in .rel.dyn
      [0c] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0d] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0e] 0x00000000, 0x00000000 DT_NULL, End of Array
      [0f] 0x00000000, 0x00000000 DT_NULL, End of Array
      [10] 0x00000000, 0x00000000 DT_NULL, End of Array
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

I think some more investigation into the need for .dynsym and .dynamic is still required...

.dynsym may still be required if only for accessing the __u_boot_cmd structure. However, I may be able to hack that a little and not create a __u_boot_cmd symbol in the linker script (create some other temporary symbol) and populate __u_boot_cmd with a valid value after relocation. It will look a little weird, but may mean not loading this section into RAM

Why do you need to much around with u_boot_cmd at all? Now that relocation works you should be able to drop all that code/linker stuff?

Quoted 3 lines

Other than that, .dynsym is now only needed to locate the sections during the relocation phase and can be kept in flash and not copied to RAM

Still occupies space in the *bin image though.

#31 lore raw

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 83 lines
Quoted 68 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 15 lines
Quoted 1 line · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 9 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 4 lines
Quoted 2 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 5 lines
Quoted 3 lines

How big DT_REL is

Quoted 1 line
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 8 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 6 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 9 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

Quoted 7 lines

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

Possibly, but I think you only need to add an offset to all those relocs.

Jokce

#32 lore raw
Quoted 96 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 93 lines
Quoted 74 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 10 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

Quoted 8 lines
Quoted 4 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

Possibly, but I think you only need to add an offset to all those relocs.

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Best Regards,
Bill Campbell

Quoted 9 lines

Jokce

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#33 lore raw

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 94 lines
Quoted 92 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 89 lines
Quoted 74 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 10 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 12 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the new address.

Normally one do what you describe but here we know that the whole img has moved so we don't have to do calculate the new address from scratch.

Jocke

#34 lore raw
Quoted 124 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 94 lines
Quoted 92 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 89 lines
Quoted 74 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 10 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 12 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 4 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the new address.

OK, I don't really get this at all....

This code:

    printf ("\n\n%s\n\n", version_string);

gets compiled into:

    380403e7:   68 a4 18 05 38   push   $0x380518a4
    380403ec:   68 de 2c 05 38   push   $0x38052cde
    380403f1:   e8 4f 84 00 00   call   38048845 <printf>

With relocation entries in .rel.text of:

Offset Info Type Sym.Value Sym. Name

   380403e8  00016201 R_386_32          380519f0   version_string
   380403ed  00000201 R_386_32          380519f0   .rodata
   380403f2  00016b02 R_386_PC32        38048991   printf

Now I get the first two (R_386_32) entries - Relocation involves a simple addition of an offset to the values at addresses 0x380403e8 and 0x380403ed (of course, these addresses will be offset)

However, the R_386_PC32 is an enigma - The call is already relative - there is no need to relocate it at all (call is a position independent opcode because it is a relative jump!)

Will all R_386_PC32 be like this? Can I simply ignore them all? If so, why do they even need to be generated?

Hmmm

Graeme

Quoted 6 lines

Normally one do what you describe but here we know that the whole img has moved so we don't have to do calculate the new address from scratch.

Jocke

#35 lore raw

Graeme Russ <[email protected]> wrote on 14/10/2009 13:48:27:

Quoted 152 lines
Quoted 124 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 94 lines
Quoted 92 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 89 lines
Quoted 74 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 16 lines
Quoted 2 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 8 lines
Quoted 8 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 5 lines
Quoted 3 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???
Quoted 8 lines
Quoted 6 lines

How big DT_REL is

Quoted 2 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 7 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 10 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 12 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 3 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the

new address.

Quoted 1 line

OK, I don't really get this at all....

This code:

    printf ("\n\n%s\n\n", version_string);

gets compiled into:

    380403e7:   68 a4 18 05 38   push   $0x380518a4
    380403ec:   68 de 2c 05 38   push   $0x38052cde
    380403f1:   e8 4f 84 00 00   call   38048845 <printf>

With relocation entries in .rel.text of:

Offset Info Type Sym.Value Sym. Name

   380403e8  00016201 R_386_32          380519f0   version_string
   380403ed  00000201 R_386_32          380519f0   .rodata
   380403f2  00016b02 R_386_PC32        38048991   printf
Quoted 7 lines

Now I get the first two (R_386_32) entries - Relocation involves a simple addition of an offset to the values at addresses 0x380403e8 and 0x380403ed (of course, these addresses will be offset)

However, the R_386_PC32 is an enigma - The call is already relative - there is no need to relocate it at all (call is a position independent opcode because it is a relative jump!)

Yes, but printf is defined in glibc s? the app needs to relocate the call to glibc. U-boot has all it needs so there you should not have PC32 I think. Try defining a local static function. For non static functions you may need to define visibility=hidden and/or -Bsymbolic too. You also need to look at the img after final linking.

Quoted 3 lines

Will all R_386_PC32 be like this? Can I simply ignore them all? If so, why do they even need to be generated?

Hopefully you won't have any. Not sure about weak functions though. These might need PC32 relocs in some cases.

Also, if you look at _dl_do_reloc() in uClibc/ldso/ldso/i386/elfinterp.c I think you can replace symbol_addr with relocation offset.

Jocke

#36 lore raw
Quoted 180 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 14/10/2009 13:48:27:

Quoted 178 lines
Quoted 146 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 118 lines
Quoted 116 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 112 lines
Quoted 91 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 20 lines
Quoted 3 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 9 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 7 lines
Quoted 4 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 27 lines
Quoted 27 lines
Quoted 14 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
Quoted 10 lines
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???

How big DT_REL is

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 11 lines
Quoted 11 lines
Quoted 3 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 8 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 11 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 13 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 4 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the

new address.

OK, I don't really get this at all....

This code:

    printf ("\n\n%s\n\n", version_string);

gets compiled into:

    380403e7:   68 a4 18 05 38   push   $0x380518a4
    380403ec:   68 de 2c 05 38   push   $0x38052cde
    380403f1:   e8 4f 84 00 00   call   38048845 <printf>

With relocation entries in .rel.text of:

Offset Info Type Sym.Value Sym. Name

   380403e8  00016201 R_386_32          380519f0   version_string
   380403ed  00000201 R_386_32          380519f0   .rodata
   380403f2  00016b02 R_386_PC32        38048991   printf

Now I get the first two (R_386_32) entries - Relocation involves a simple addition of an offset to the values at addresses 0x380403e8 and 0x380403ed (of course, these addresses will be offset)

Quoted 7 lines
Quoted 4 lines

However, the R_386_PC32 is an enigma - The call is already relative - there is no need to relocate it at all (call is a position independent opcode because it is a relative jump!)

Yes, but printf is defined in glibc s? the app needs to relocate the call to glibc.

Actually, the reason the call is relocatable is that the compiler DOESN'T KNOW where printf is at all. If it is in a library, it will not be in the text segment and must be relocated accordingly. It may be in a different segment for some reason. In any case, the compiler doesn't know the address in the image where printf resides, so it needs a relocation entry to get the value filled in at link time. After the value is filled in, if the referenced symbol is in the same segment (probably .text) as the point of reference, the relocation reference is probably of no more use. However, there is no rule that says the linker must delete the reference from the relocation list.

Quoted 4 lines

U-boot has all it needs so there you should not have PC32 I think.
Try defining a local static function. For non static functions you may need to define visibility=hidden and/or -Bsymbolic too.

Won't help. Any symbols referenced but not defined locally are relocatable. After linking, they MAY, but need not, go away.

Quoted 2 lines

You also need to look at the img after final linking.

After linking, if the symbol is defined, the R_386_PC32 is no longer important UNLESS the symbol referenced is in a different segment AND the segments are relocated with different offsets from each other than originally linked. For this reason, I think the linker will not discard these relocations. If we are not relocating the segments with different relative offsets, we can ignore these relocations as the change in offset will come out to be zero anyway. However, if you process them normally, you will just add 0 and nothing will change.

Quoted 6 lines
Quoted 4 lines

Will all R_386_PC32 be like this? Can I simply ignore them all? If so, why do they even need to be generated?

Hopefully you won't have any.

I think they may still be there, because we ask the linker to preserve relocation information. However, if the entire image is being relocated, not changing the order or relative offset of any segments, they can be ignored, because the relative values will not change. It will be interesting to know if they remain or if the linker drops them out. For references in the same segment, we can hope that they get dropped. For references across segments (if any), or any undefined symbols, they will remain.

Quoted 3 lines

Not sure about weak functions though. These might
need PC32 relocs in some cases.

There can be PC32 relocs referencing the weak symbol, but that symbol may be undefined.

Quoted 3 lines

Also, if you look at _dl_do_reloc() in uClibc/ldso/ldso/i386/elfinterp.c I think you can replace symbol_addr with relocation offset.

I agree, in the case you a moving the entire image and ignoring PC32 relocs.

Best Regards,
Bill Campbell

Quoted 6 lines

Jocke

#37 lore raw
Quoted 300 lines · J. William Campbell
Quoted 231 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 14/10/2009 13:48:27:

Quoted 228 lines
Quoted 191 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 153 lines
Quoted 150 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 145 lines
Quoted 123 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 27 lines
Quoted 4 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 13 lines
Quoted 12 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not
relocated
- 21 entries are the remaining symbols exported from the
linker
script
- 4 entries are labels defined in inline asm and used in C

Quoted 8 lines
Quoted 4 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 34 lines
Quoted 34 lines
Quoted 15 lines

- 1 entry is a NULL entry

.dynamic
- 88 bytes
- Array of Elf32_Dyn

   - typedef struct {
         Elf32_Sword     d_tag;
         union {
             Elf32_Word  d_val;
             Elf32_Addr  d_ptr;
         } d_un;
     } Elf32_Dyn;
   - 0x11 entries
     [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
Quoted 10 lines
     [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
     [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
     [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
     [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
     [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
     [06] 0x00000015, 0x00000000 DT_DEBUG, ???
     [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
     [08] 0x00000012, 0x000014D8 DT_RELSZ, ???

How big DT_REL is

Quoted 4 lines
     [09] 0x00000013, 0x00000008 DT_RELENT, ???
Quoted 7 lines
Quoted 3 lines

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 16 lines
Quoted 5 lines
Quoted 4 lines
     [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???
Quoted 10 lines

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs
to modify the .text segment to adjust for relocation. You should get rid of this one. Look for DT_TEXTREL in .o files to find
the culprit.

Quoted 12 lines

Alas I cannot - The relocations are a result of loading a register with a
return address when calling show_boot_progress in the very early stages of
initialisation prior to the stack becoming available. The x86 does not
allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return
address off the stack

hmm, same as ppc but that in it self should not cause a TEXREL, should it?
Ahh, the 'call' is absolute, not relative? I guess there is some way around it
but it is not important ATM I guess.

Quoted 9 lines

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space
but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic
-Bsymbolic-functions

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think
this might mean I need the symbol table in the binary in order to resolve
them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 6 lines
Quoted 5 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 15 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values
involved should be the start of the text section for program references,
the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 7 lines

Still think you can get away with just ADDING an offset. The image is linked to a
specific address and then you move the whole image to a new address. Therefore
you should be able to read the current address, add offset, write back the

new address.
OK, I don't really get this at all....

This code:

   printf ("\n\n%s\n\n", version_string);

gets compiled into:

   380403e7:   68 a4 18 05 38   push   $0x380518a4
   380403ec:   68 de 2c 05 38   push   $0x38052cde
   380403f1:   e8 4f 84 00 00   call   38048845 <printf>

With relocation entries in .rel.text of:

 Offset     Info    Type            Sym.Value  Sym. Name
  380403e8  00016201 R_386_32          380519f0   version_string
  380403ed  00000201 R_386_32          380519f0   .rodata
  380403f2  00016b02 R_386_PC32        38048991   printf

Now I get the first two (R_386_32) entries - Relocation involves a simple addition of an offset to the values at addresses 0x380403e8 and 0x380403ed
(of course, these addresses will be offset)

Quoted 7 lines
Quoted 4 lines

However, the R_386_PC32 is an enigma - The call is already relative - there is no need to relocate it at all (call is a position independent opcode because it is a relative jump!)

Yes, but printf is defined in glibc s? the app needs to relocate the call to glibc.

Actually, the reason the call is relocatable is that the compiler DOESN'T
KNOW where printf is at all. If it is in a library, it will not be in the
text segment and must be relocated accordingly. It may be in a different segment for some reason. In any case, the compiler doesn't know the address in the image where printf resides, so it needs a relocation entry to get the value filled in at link time. After the value is filled in, if the referenced symbol is in the same segment (probably .text) as the point of reference, the relocation reference is probably of no more use. However, there is no rule that says the linker must delete the reference from the relocation list.

Quoted 5 lines

U-boot has all it needs so there you should not have PC32 I think.
Try defining a local static function. For non static functions you may need to define visibility=hidden and/or -Bsymbolic too.

Won't help. Any symbols referenced but not defined locally are relocatable. After linking, they MAY, but need not, go away.

Quoted 3 lines

You also need to look at the img after final linking.

After linking, if the symbol is defined, the R_386_PC32 is no longer important UNLESS the symbol referenced is in a different segment AND the segments are relocated with different offsets from each other than originally linked. For this reason, I think the linker will not discard these relocations. If we are not relocating the segments with different relative offsets, we can ignore these relocations as the change in offset will come out to be zero anyway. However, if you process them normally, you will just add 0 and nothing will change.

Quoted 9 lines
Quoted 7 lines

Will all R_386_PC32 be like this? Can I simply ignore them all? If so, why
do they even need to be generated?

Hopefully you won't have any.

I think they may still be there, because we ask the linker to preserve relocation information. However, if the entire image is being relocated, not changing the order or relative offset of any segments, they can be ignored, because the relative values will not change. It will be interesting to know if they remain or if the linker drops them out. For references in the same segment, we can hope that they get dropped. For references across segments (if any), or any undefined symbols, they will remain.

Quoted 4 lines

Not sure about weak functions though. These might
need PC32 relocs in some cases.

There can be PC32 relocs referencing the weak symbol, but that symbol may be undefined.

Quoted 5 lines

Also, if you look at _dl_do_reloc() in uClibc/ldso/ldso/i386/elfinterp.c I think
you can replace symbol_addr with relocation offset.

Quoted 7 lines

I agree, in the case you a moving the entire image and ignoring PC32 relocs.

Best Regards,
Bill Campbell

Quoted 3 lines

Jocke

Apologies if this is getting way off-topic for a simple boot loader, but this is information I have gathered from far and wide over the net. I am surprised that there isn't a web site out there on 'How to create a relocatable boot loader'...

OK, its all starting to come together now - It helps when you look at the right files ;)

Firstly, u-boot.map

                0x380589a0                __rel_dyn_start = .

.rel.dyn 0x380589a0 0x42b0
*(.rel.dyn)

 .rel.got       0x00000000        0x0 cpu/i386/start.o
 .rel.plt       0x00000000        0x0 cpu/i386/start.o
 .rel.text      0x380589a0     0x2e28 cpu/i386/start.o
 .rel.start16   0x3805b7c8       0x10 cpu/i386/start.o
 .rel.data      0x3805b7d8      0xc18 cpu/i386/start.o
 .rel.rodata    0x3805c3f0      0x360 cpu/i386/start.o
 .rel.u_boot_cmd
                0x3805c750      0x500 cpu/i386/start.o
                0x3805cc50                __rel_dyn_end = .

And the output of readelf...

Section Headers:

  [Nr] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            00000000 000000 000000 00      0   0  0
  [ 1] .text             PROGBITS        38040000 001000 0118a4 00  AX  0   0  4
  [ 2] .rel.text         REL             00000000 066c68 005d00 08     40   1  4
  [ 3] .rodata           PROGBITS        380518a4 0128a4 005da5 00   A  0   0  4
  [ 4] .rel.rodata       REL             00000000 06c968 000360 08     40   3  4
  [ 5] .interp           PROGBITS        38057649 018649 000013 00   A  0   0  1
  [ 6] .dynstr           STRTAB          3805765c 01865c 0001ee 00   A  0   0  1
  [ 7] .hash             HASH            3805784c 01884c 0000cc 04   A 11   0  4
  [ 8] .data             PROGBITS        38057918 018918 000a3c 00  WA  0   0  4
  [ 9] .rel.data         REL             00000000 06ccc8 000c18 08     40   8  4
  [10] .got.plt          PROGBITS        38058354 019354 00000c 04  WA  0   0  4
  [11] .dynsym           DYNSYM          38058360 019360 000200 10   A  6   1  4
  [12] .dynamic          DYNAMIC         38058560 019560 000080 08  WA  6   0  4
  [13] .u_boot_cmd       PROGBITS        380585e0 0195e0 0003c0 00  WA  0   0  4
  [14] .rel.u_boot_cmd   REL             00000000 06d8e0 000500 08     40  13  4
  [15] .bss              NOBITS          3805cc50 01ec50 001a34 00  WA  0   0  4
  [16] .bios             PROGBITS        00000000 01e000 00053e 00  AX  0   0  1
  [17] .rel.bios         REL             00000000 06dde0 0000c0 08     40  16  4
  [18] .rel.dyn          REL             380589a0 0199a0 0042b0 08   A 11   0  4
  [19] .start16          PROGBITS        0000f800 01e800 000110 00  AX  0   0  1
  [20] .rel.start16      REL             00000000 06dea0 000038 08     40  19  4
  [21] .resetvec         PROGBITS        0000fff0 01eff0 000010 00  AX  0   0  1
  [22] .rel.resetvec     REL             00000000 06ded8 000008 08     40  21  4

...

Relocation section '.rel.text' at offset 0x66c68 contains 2976 entries:
Offset Info Type Sym.Value Sym. Name

38040010  00000101 R_386_32          38040000   .text
3804001e  00000101 R_386_32          38040000   .text
38040028  00000101 R_386_32          38040000   .text
3804003f  00000101 R_386_32          38040000   .text
38040051  00000101 R_386_32          38040000   .text
38040075  00000101 R_386_32          38040000   .text
38040085  00000101 R_386_32          38040000   .text
3804009d  0003e602 R_386_PC32        380403fa   load_uboot
380400a6  00000101 R_386_32          38040000   .text
38040015  00029f02 R_386_PC32        3804bdd8   early_board_init
38040023  0003f702 R_386_PC32        3804bdda   show_boot_progress_asm

...

Relocation section '.rel.rodata' at offset 0x6c968 contains 108 entries:
Offset Info Type Sym.Value Sym. Name

38051908  00000201 R_386_32          380518a4   .rodata
38051938  00000201 R_386_32          380518a4   .rodata
38051968  00000201 R_386_32          380518a4   .rodata
38051998  00000201 R_386_32          380518a4   .rodata
380519c8  00000201 R_386_32          380518a4   .rodata
380519f8  00000201 R_386_32          380518a4   .rodata

...

Relocation section '.rel.dyn' at offset 0x199a0 contains 2134 entries:
Offset Info Type Sym.Value Sym. Name

0000f838  00000008 R_386_RELATIVE
0000f846  00000008 R_386_RELATIVE
38040010  00000008 R_386_RELATIVE
3804001e  00000008 R_386_RELATIVE
38040028  00000008 R_386_RELATIVE
3804003f  00000008 R_386_RELATIVE
38040051  00000008 R_386_RELATIVE
38040075  00000008 R_386_RELATIVE
38040085  00000008 R_386_RELATIVE

Notice that, apart from .rel.dyn, non of the .rel.* sections have the A (Allocated) flag set - They do not end up in the stripped binary image. .rel.dyn is allocated in the binary image with all the R_386_PC32 entries from the other .rel section are discarded and the R_386_32 have been 'converted' to R_386_RELATIVE which are simple to adjust (locate in memory and adjust by the relocation offset)

The relocation fixup is really easy:

	Elf32_Rel *rel_dyn_start = (Elf32_Rel *)&__rel_dyn_start;
	Elf32_Rel *rel_dyn_end = (Elf32_Rel *)&__rel_dyn_end;
	Elf32_Rel *re;

	for (re = rel_dyn_start; re < rel_dyn_end; re++)
	{
		if (re->r_offset >= TEXT_BASE)
			if (*(ulong *)re->r_offset >= TEXT_BASE)
				*(ulong *)(re->r_offset - rel_offset) -= (Elf32_Addr)rel_offset;
	}

The size penalty is ~17kB of extra data (which is not copied to RAM) and a tiny amount of relocation code (easily offset by removal of other fixups such as the command table fixup

Any without using the pic flag in gcc, there is no GOT and no associated performance penalty.

Thanks for everyone's help (especially Jocke and Bill)

Regards,

Graeme

#38 lore raw

Graeme Russ <[email protected]> wrote on 17/10/2009 07:17:04:

Quoted 1 line

[SNIP]

Quoted 5 lines

Apologies if this is getting way off-topic for a simple boot loader, but this is information I have gathered from far and wide over the net. I am surprised that there isn't a web site out there on 'How to create a relocatable boot loader'...

:), now you can write one :)

Quoted 90 lines

OK, its all starting to come together now - It helps when you look at the right files ;)

Firstly, u-boot.map

                0x380589a0                __rel_dyn_start = .

.rel.dyn 0x380589a0 0x42b0
*(.rel.dyn)

 .rel.got       0x00000000        0x0 cpu/i386/start.o
 .rel.plt       0x00000000        0x0 cpu/i386/start.o
 .rel.text      0x380589a0     0x2e28 cpu/i386/start.o
 .rel.start16   0x3805b7c8       0x10 cpu/i386/start.o
 .rel.data      0x3805b7d8      0xc18 cpu/i386/start.o
 .rel.rodata    0x3805c3f0      0x360 cpu/i386/start.o
 .rel.u_boot_cmd
                0x3805c750      0x500 cpu/i386/start.o
                0x3805cc50                __rel_dyn_end = .

And the output of readelf...

Section Headers:

  [Nr] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            00000000 000000 000000 00      0   0  0
  [ 1] .text             PROGBITS        38040000 001000 0118a4 00  AX  0   0  4
  [ 2] .rel.text         REL             00000000 066c68 005d00 08     40   1  4
  [ 3] .rodata           PROGBITS        380518a4 0128a4 005da5 00   A  0   0  4
  [ 4] .rel.rodata       REL             00000000 06c968 000360 08     40   3  4
  [ 5] .interp           PROGBITS        38057649 018649 000013 00   A  0   0  1
  [ 6] .dynstr           STRTAB          3805765c 01865c 0001ee 00   A  0   0  1
  [ 7] .hash             HASH            3805784c 01884c 0000cc 04   A 11   0  4
  [ 8] .data             PROGBITS        38057918 018918 000a3c 00  WA  0   0  4
  [ 9] .rel.data         REL             00000000 06ccc8 000c18 08     40   8  4
  [10] .got.plt          PROGBITS        38058354 019354 00000c 04  WA  0   0  4
  [11] .dynsym           DYNSYM          38058360 019360 000200 10   A  6   1  4
  [12] .dynamic          DYNAMIC         38058560 019560 000080 08  WA  6   0  4
  [13] .u_boot_cmd       PROGBITS        380585e0 0195e0 0003c0 00  WA  0   0  4
  [14] .rel.u_boot_cmd   REL             00000000 06d8e0 000500 08     40  13  4
  [15] .bss              NOBITS          3805cc50 01ec50 001a34 00  WA  0   0  4
  [16] .bios             PROGBITS        00000000 01e000 00053e 00  AX  0   0  1
  [17] .rel.bios         REL             00000000 06dde0 0000c0 08     40  16  4
  [18] .rel.dyn          REL             380589a0 0199a0 0042b0 08   A 11   0  4
  [19] .start16          PROGBITS        0000f800 01e800 000110 00  AX  0   0  1
  [20] .rel.start16      REL             00000000 06dea0 000038 08     40  19  4
  [21] .resetvec         PROGBITS        0000fff0 01eff0 000010 00  AX  0   0  1
  [22] .rel.resetvec     REL             00000000 06ded8 000008 08     40  21  4

...

Relocation section '.rel.text' at offset 0x66c68 contains 2976 entries:
Offset Info Type Sym.Value Sym. Name

38040010  00000101 R_386_32          38040000   .text
3804001e  00000101 R_386_32          38040000   .text
38040028  00000101 R_386_32          38040000   .text
3804003f  00000101 R_386_32          38040000   .text
38040051  00000101 R_386_32          38040000   .text
38040075  00000101 R_386_32          38040000   .text
38040085  00000101 R_386_32          38040000   .text
3804009d  0003e602 R_386_PC32        380403fa   load_uboot
380400a6  00000101 R_386_32          38040000   .text
38040015  00029f02 R_386_PC32        3804bdd8   early_board_init
38040023  0003f702 R_386_PC32        3804bdda   show_boot_progress_asm

...

Relocation section '.rel.rodata' at offset 0x6c968 contains 108 entries:
Offset Info Type Sym.Value Sym. Name

38051908  00000201 R_386_32          380518a4   .rodata
38051938  00000201 R_386_32          380518a4   .rodata
38051968  00000201 R_386_32          380518a4   .rodata
38051998  00000201 R_386_32          380518a4   .rodata
380519c8  00000201 R_386_32          380518a4   .rodata
380519f8  00000201 R_386_32          380518a4   .rodata

...

Relocation section '.rel.dyn' at offset 0x199a0 contains 2134 entries:
Offset Info Type Sym.Value Sym. Name

0000f838  00000008 R_386_RELATIVE
0000f846  00000008 R_386_RELATIVE
38040010  00000008 R_386_RELATIVE
3804001e  00000008 R_386_RELATIVE
38040028  00000008 R_386_RELATIVE
3804003f  00000008 R_386_RELATIVE
38040051  00000008 R_386_RELATIVE
38040075  00000008 R_386_RELATIVE
38040085  00000008 R_386_RELATIVE
Quoted 6 lines

Notice that, apart from .rel.dyn, non of the .rel.* sections have the A (Allocated) flag set - They do not end up in the stripped binary image. .rel.dyn is allocated in the binary image with all the R_386_PC32 entries from the other .rel section are discarded and the R_386_32 have been 'converted' to R_386_RELATIVE which are simple to adjust (locate in memory and adjust by the relocation offset)

Ah, they are converted to relative. Wonder if all archs do this? If so one only will need two reloc functions, one for Rel and one for Rela relocs.

Quoted 13 lines

The relocation fixup is really easy:

   Elf32_Rel *rel_dyn_start = (Elf32_Rel *)&__rel_dyn_start;
   Elf32_Rel *rel_dyn_end = (Elf32_Rel *)&__rel_dyn_end;
   Elf32_Rel *re;

   for (re = rel_dyn_start; re < rel_dyn_end; re++)
   {
      if (re->r_offset >= TEXT_BASE)
         if (*(ulong *)re->r_offset >= TEXT_BASE)
            *(ulong *)(re->r_offset - rel_offset) -= (Elf32_Addr)rel_offset;
   }

Do you need the TEXT_BASE stuff or is it just a precaution?
Not sure if you need some test for NULL to handle weak undefined symbols though.

Quoted 3 lines

The size penalty is ~17kB of extra data (which is not copied to RAM) and a tiny amount of relocation code (easily offset by removal of other fixups such as the command table fixup

17kB, how does that compare to the -fPIC version?

Quoted 3 lines

Any without using the pic flag in gcc, there is no GOT and no associated performance penalty.

Yep :)

Quoted 2 lines

Thanks for everyone's help (especially Jocke and Bill)

NP, will we see a patch soon?

Jocke

#39 lore raw
In reply to Graeme Russ
Quoted 6 lines · Graeme Russ
Quoted 2 lines · J. William Campbell

Joakim Tjernlund wrote:

<megasnip>

Quoted 114 lines

Apologies if this is getting way off-topic for a simple boot loader, but this is information I have gathered from far and wide over the net. I am surprised that there isn't a web site out there on 'How to create a relocatable boot loader'...

OK, its all starting to come together now - It helps when you look at the right files ;)

Firstly, u-boot.map

                0x380589a0                __rel_dyn_start = .

.rel.dyn 0x380589a0 0x42b0
*(.rel.dyn)

 .rel.got       0x00000000        0x0 cpu/i386/start.o
 .rel.plt       0x00000000        0x0 cpu/i386/start.o
 .rel.text      0x380589a0     0x2e28 cpu/i386/start.o
 .rel.start16   0x3805b7c8       0x10 cpu/i386/start.o
 .rel.data      0x3805b7d8      0xc18 cpu/i386/start.o
 .rel.rodata    0x3805c3f0      0x360 cpu/i386/start.o
 .rel.u_boot_cmd
                0x3805c750      0x500 cpu/i386/start.o
                0x3805cc50                __rel_dyn_end = .

And the output of readelf...

Section Headers:

  [Nr] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            00000000 000000 000000 00      0   0  0
  [ 1] .text             PROGBITS        38040000 001000 0118a4 00  AX  0   0  4
  [ 2] .rel.text         REL             00000000 066c68 005d00 08     40   1  4
  [ 3] .rodata           PROGBITS        380518a4 0128a4 005da5 00   A  0   0  4
  [ 4] .rel.rodata       REL             00000000 06c968 000360 08     40   3  4
  [ 5] .interp           PROGBITS        38057649 018649 000013 00   A  0   0  1
  [ 6] .dynstr           STRTAB          3805765c 01865c 0001ee 00   A  0   0  1
  [ 7] .hash             HASH            3805784c 01884c 0000cc 04   A 11   0  4
  [ 8] .data             PROGBITS        38057918 018918 000a3c 00  WA  0   0  4
  [ 9] .rel.data         REL             00000000 06ccc8 000c18 08     40   8  4
  [10] .got.plt          PROGBITS        38058354 019354 00000c 04  WA  0   0  4
  [11] .dynsym           DYNSYM          38058360 019360 000200 10   A  6   1  4
  [12] .dynamic          DYNAMIC         38058560 019560 000080 08  WA  6   0  4
  [13] .u_boot_cmd       PROGBITS        380585e0 0195e0 0003c0 00  WA  0   0  4
  [14] .rel.u_boot_cmd   REL             00000000 06d8e0 000500 08     40  13  4
  [15] .bss              NOBITS          3805cc50 01ec50 001a34 00  WA  0   0  4
  [16] .bios             PROGBITS        00000000 01e000 00053e 00  AX  0   0  1
  [17] .rel.bios         REL             00000000 06dde0 0000c0 08     40  16  4
  [18] .rel.dyn          REL             380589a0 0199a0 0042b0 08   A 11   0  4
  [19] .start16          PROGBITS        0000f800 01e800 000110 00  AX  0   0  1
  [20] .rel.start16      REL             00000000 06dea0 000038 08     40  19  4
  [21] .resetvec         PROGBITS        0000fff0 01eff0 000010 00  AX  0   0  1
  [22] .rel.resetvec     REL             00000000 06ded8 000008 08     40  21  4

...

Relocation section '.rel.text' at offset 0x66c68 contains 2976 entries:
Offset Info Type Sym.Value Sym. Name

38040010  00000101 R_386_32          38040000   .text
3804001e  00000101 R_386_32          38040000   .text
38040028  00000101 R_386_32          38040000   .text
3804003f  00000101 R_386_32          38040000   .text
38040051  00000101 R_386_32          38040000   .text
38040075  00000101 R_386_32          38040000   .text
38040085  00000101 R_386_32          38040000   .text
3804009d  0003e602 R_386_PC32        380403fa   load_uboot
380400a6  00000101 R_386_32          38040000   .text
38040015  00029f02 R_386_PC32        3804bdd8   early_board_init
38040023  0003f702 R_386_PC32        3804bdda   show_boot_progress_asm

...

Relocation section '.rel.rodata' at offset 0x6c968 contains 108 entries:
Offset Info Type Sym.Value Sym. Name

38051908  00000201 R_386_32          380518a4   .rodata
38051938  00000201 R_386_32          380518a4   .rodata
38051968  00000201 R_386_32          380518a4   .rodata
38051998  00000201 R_386_32          380518a4   .rodata
380519c8  00000201 R_386_32          380518a4   .rodata
380519f8  00000201 R_386_32          380518a4   .rodata

...

Relocation section '.rel.dyn' at offset 0x199a0 contains 2134 entries:
Offset Info Type Sym.Value Sym. Name

0000f838  00000008 R_386_RELATIVE
0000f846  00000008 R_386_RELATIVE
38040010  00000008 R_386_RELATIVE
3804001e  00000008 R_386_RELATIVE
38040028  00000008 R_386_RELATIVE
3804003f  00000008 R_386_RELATIVE
38040051  00000008 R_386_RELATIVE
38040075  00000008 R_386_RELATIVE
38040085  00000008 R_386_RELATIVE

Notice that, apart from .rel.dyn, non of the .rel.* sections have the A (Allocated) flag set - They do not end up in the stripped binary image. .rel.dyn is allocated in the binary image with all the R_386_PC32 entries from the other .rel section are discarded and the R_386_32 have been 'converted' to R_386_RELATIVE which are simple to adjust (locate in memory and adjust by the relocation offset)

The relocation fixup is really easy:

	Elf32_Rel *rel_dyn_start = (Elf32_Rel *)&__rel_dyn_start;
	Elf32_Rel *rel_dyn_end = (Elf32_Rel *)&__rel_dyn_end;
	Elf32_Rel *re;

	for (re = rel_dyn_start; re < rel_dyn_end; re++)
	{
		if (re->r_offset >= TEXT_BASE)
			if (*(ulong *)re->r_offset >= TEXT_BASE)
				*(ulong *)(re->r_offset - rel_offset) -= (Elf32_Addr)rel_offset;
	}
Quoted 9 lines

The size penalty is ~17kB of extra data (which is not copied to RAM) and a tiny amount of relocation code (easily offset by removal of other fixups such as the command table fixup

Any without using the pic flag in gcc, there is no GOT and no associated performance penalty.

Thanks for everyone's help (especially Jocke and Bill)

Great work Graeme. You have taken a lot of conjecture and guessing and converted it to actual truth!

In line with your comment about -fpic, the .text segment size goes from 000137fc down to 000118a4, or about an 8 k reduction in size. -fpic also contains a .rel_dyn segment, that presumably needs to be processed the same way as in the non -fpic case (otherwise, why would it be there?). The size of the "residual" .rel_dyn was 00001228, or 4.6 k. This means that the size penalty for not using -fpic is only about 3k bytes total in the image, and the ram footprint is actually smaller than with -fpic. So now, after Graeme's work here, it is easily possible to support three different u-boot configurations, absolute, relocatable, and relocatable with -fpic. If there are any size maniacs out there, we can reduce the size of the relocation table at the expense of some post-processing. These days, 9k of flash vs 4.5k of flash doesn't seem important, but I imagine if you are right against the stops on an existing product it can be very important!

It will be interesting to see similar numbers for other architectures. I expect similar results, but you never know. PPC relocation entries are larger, so they become more of an issue.

Still more questions for Graeme if he will indulge me! Are the if statements in the relocation code ever false? Are there relocations for stuff below TEXT_BASE in
the input binary? If so, do you have any idea why? Not that two if statements are a big deal, it is just that I can't explain why there would be any relocations below TEXT_BASE, and I can't explain why there would be any relocatable references to anything below text base. . I assume this might be related to not relocating NULL pointers. That would be reflected in the innermost if statement. I would not expect there to be any such references, as gas does know the relocation attributes of initialized data, and NULL is absolute(?) Also, if a function is not defined (weak or otherwise), the loader should give it an address of absolute 0, which would also not generate a relocation entry(?). It would be interesting to intentionally call an un-defined function in u-boot and see if the call ends up relocatable. It should not, and if it does we should file a bug report for ld!

Thanks again Graeme!

Best Regards,
Bill Campbell

Quoted 5 lines

Regards,

Graeme

#40 lore raw
Quoted 6 lines · J. William Campbell
Quoted 5 lines · Graeme Russ
Quoted 1 line · J. William Campbell
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Joakim Tjernlund wrote:

<megasnip>

[Yawn... YAS (Yet Another Snip) ;)]

Quoted 28 lines
Quoted 15 lines

The relocation fixup is really easy:

       Elf32_Rel *rel_dyn_start = (Elf32_Rel *)&__rel_dyn_start;
       Elf32_Rel *rel_dyn_end = (Elf32_Rel *)&__rel_dyn_end;
       Elf32_Rel *re;

       for (re = rel_dyn_start; re < rel_dyn_end; re++)
       {
               if (re->r_offset >= TEXT_BASE)
                       if (*(ulong *)re->r_offset >= TEXT_BASE)
                               *(ulong *)(re->r_offset - rel_offset) -=
(Elf32_Addr)rel_offset;
       }
Quoted 9 lines

The size penalty is ~17kB of extra data (which is not copied to RAM) and a tiny amount of relocation code (easily offset by removal of other fixups such as the command table fixup

Any without using the pic flag in gcc, there is no GOT and no associated performance penalty.

Thanks for everyone's help (especially Jocke and Bill)

Great work Graeme. You have taken a lot of conjecture and guessing and converted it to actual truth!

Quoted 7 lines

In line with your comment about -fpic, the .text segment size goes from 000137fc down to 000118a4, or about an 8 k reduction in size. -fpic also contains a .rel_dyn segment, that presumably needs to be processed the same way as in the non -fpic case (otherwise, why would it be there?). The size of the "residual" .rel_dyn was 00001228, or 4.6 k. This means that the size penalty for not using -fpic is only about 3k bytes total in the image, and the ram footprint is actually smaller than with -fpic. So now, after

Yes, especially on the x86 because with -fpic, the x86 needs to do a CALL/POP in the beginning of each function to determine the current IP in order to calculate absolute addresses using the GOT (ouch!)

Quoted 11 lines

Graeme's work here, it is easily possible to support three different u-boot configurations, absolute, relocatable, and relocatable with -fpic. If there are any size maniacs out there, we can reduce the size of the relocation table at the expense of some post-processing. These days, 9k of flash vs 4.5k of flash doesn't seem important, but I imagine if you are right against the stops on an existing product it can be very important!

It will be interesting to see similar numbers for other architectures. I expect similar results, but you never know. PPC relocation entries are larger, so they become more of an issue.

Quoted 16 lines

Still more questions for Graeme if he will indulge me! Are the if statements in the relocation code ever false? Are there relocations for stuff below TEXT_BASE in
the input binary? If so, do you have any idea why? Not that two if statements are a big deal, it is just that I can't explain why there would be any relocations below TEXT_BASE, and I can't explain why there would be any relocatable references to anything below text base. . I assume this might be related to not relocating NULL pointers. That would be reflected in the innermost if statement. I would not expect there to be any such references, as gas does know the relocation attributes of initialized data, and NULL is absolute(?) Also, if a function is not defined (weak or otherwise), the loader should give it an address of absolute 0, which would also not generate a relocation entry(?). It would be interesting to intentionally call an un-defined function in u-boot and see if the call ends up relocatable. It should not, and if it does we should file a bug report for ld!

Apart from NULL pointers, there are some peculiarities for x86 that have to be dealt with. There are two sections (for BIOS and the real mode trampoline) which get linked at a hard coded memory location in the low are of memory (<16M) - The TEXT_BASE checks are to ensure these do not get trampled.

Quoted 3 lines

Thanks again Graeme!

NP - Just scratching an itch

Quoted 10 lines

Best Regards,
Bill Campbell

Quoted 6 lines

Regards,

Graeme

#41 lore raw
In reply to Joakim Tjernlund
Quoted 148 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 118 lines
Quoted 116 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 112 lines
Quoted 91 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 20 lines
Quoted 3 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

Quoted 9 lines
Quoted 9 lines

So, all that is left are .dynsym and .dynamic ...
.dynsym
- Contains 70 entries (16 bytes each, 1120 bytes)
- 44 entries mimic those entries in .got which are not relocated
- 21 entries are the remaining symbols exported from the linker script
- 4 entries are labels defined in inline asm and used in C

Quoted 7 lines
Quoted 4 lines

Try adding proper asm declarations. Look at what gcc generates for a function/variable and mimic these.

Thanks - Now .dynsym contains only exports from the linker script

:)

Quoted 27 lines
Quoted 27 lines
Quoted 14 lines

- 1 entry is a NULL entry

.dynamic

    - 88 bytes
    - Array of Elf32_Dyn
    - typedef struct {
          Elf32_Sword     d_tag;
          union {
              Elf32_Word  d_val;
              Elf32_Addr  d_ptr;
          } d_un;
      } Elf32_Dyn;
    - 0x11 entries
      [00] 0x00000010, 0x00000000 DT_SYMBOLIC, (ignored)
Quoted 10 lines
      [01] 0x00000004, 0x38059994 DT_HASH, points to .hash
      [02] 0x00000005, 0x380595AB DT_STRTAB, points to .dynstr
      [03] 0x00000006, 0x3805BDCC DT_SYMTAB, points to .dynsym
      [04] 0x0000000A, 0x000003E6 DT_STRSZ, size of .dynstr
      [05] 0x0000000B, 0x00000010 DT_SYMENT, ???
      [06] 0x00000015, 0x00000000 DT_DEBUG, ???
      [07] 0x00000011, 0x3805A8F4 DT_REL, points to .rel.text
      [08] 0x00000012, 0x000014D8 DT_RELSZ, ???

How big DT_REL is

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
      [09] 0x00000013, 0x00000008 DT_RELENT, ???

hmm, cannot remeber :)

How big an entry in DT_REL is

Right, how could I forget :)

Quoted 11 lines
Quoted 11 lines
Quoted 3 lines
      [0a] 0x00000016, 0x00000000 DT_TEXTREL, ???

Oops, you got text relocations. This is generally a bad thing. TEXTREL is commonly caused by asm code that arent truly pic so it needs to modify the .text segment to adjust for relocation.
You should get rid of this one. Look for DT_TEXTREL in .o files to find the culprit.

Quoted 8 lines

Alas I cannot - The relocations are a result of loading a register with a return address when calling show_boot_progress in the very early stages of initialisation prior to the stack becoming available. The x86 does not allow direct access to the IP so the only way to find the 'current execution address' is to 'call' to the next instruction and pop the return address off the stack

Quoted 11 lines

hmm, same as ppc but that in it self should not cause a TEXREL, should it? Ahh, the 'call' is absolute, not relative? I guess there is some way around it but it is not important ATM I guess.

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 13 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 7 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the new address.

Normally one do what you describe but here we know that the whole img has moved so we don't have to do calculate the new address from scratch.

If the addresses of the bss, text, and data segments change by the same value, I think you are correct. However, if the text and data/bss segments are moved by different offsets, naturally the relocations would be different. One reason to retain this capability would be to allow the u-boot copy to execute in place in NOR flash while re-locating the read-write storage once memory has been sized. Having different relocation factors is not much worse than just one, and it may be just as easy to get working initially as a single relocation constant.

FWIW, the "ultimate" solution to minimum relocation size is a post-processing step that creates "several" arrays of relocation offsets as two byte quantities. This reduces the cost of each relocation entry to just a bit more than two bytes (there is a small overhead for array size, MSB values and relocation offset selection.) Naturally, this is much less than the ELF version of the same relocations, because we do not need to retain as much information and ELF doesn't worry about size that much.. This may pacify users for which the flash size of the image is critical, at the expense of an extra link step. Naturally, getting things to work with "standard ELF" is the most important step, and probably enough for most people.

I also am interested in the number of additional relocations generated without -fpic. I suspect on the 386 it can be substantial. However, for every new reloc generated, a .got reference load will probably be eliminated. This should result in a shorter text segment to balance the increased relocation segment. Adding the -fno-jump-tables gcc option may also help a bit.

Bill Campbell

Quoted 5 lines

Jocke

#42 lore raw

"J. William Campbell" <[email protected]> wrote on 14/10/2009 17:35:44:

Quoted 17 lines
Quoted 15 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 13 lines
Quoted 11 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 7 lines
Quoted 3 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

[Yet another SNIP :)]

Quoted 49 lines
Quoted 41 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 4 lines
Quoted 4 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 13 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 3 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the

new address.

Quoted 4 lines

Normally one do what you describe but here we know that the whole img has moved so we don't have to do calculate the new address from scratch.

Quoted 8 lines

If the addresses of the bss, text, and data segments change by the same value, I think you are correct. However, if the text and data/bss segments are moved by different offsets, naturally the relocations would be different. One reason to retain this capability would be to allow the u-boot copy to execute in place in NOR flash while re-locating the read-write storage once memory has been sized. Having different relocation factors is not much worse than just one, and it may be just as easy to get working initially as a single relocation constant.

How do figure that? You need to rewrite the insn to access the moved data/bss and they are in flash, did I miss something?

Quoted 12 lines

FWIW, the "ultimate" solution to minimum relocation size is a post-processing step that creates "several" arrays of relocation offsets as two byte quantities. This reduces the cost of each relocation entry to just a bit more than two bytes (there is a small overhead for array size, MSB values and relocation offset selection.) Naturally, this is much less than the ELF version of the same relocations, because we do not need to retain as much information and ELF doesn't worry about size that much.. This may pacify users for which the flash size of the image is critical, at the expense of an extra link step. Naturally, getting things to work with "standard ELF" is the most important step, and probably enough for most people.

That would save 2+4 bytes/reloc on REL arches and 2+4+4 on RELA(ppc) (provided one can ignore r_addend)

But yes, this is probably too "fancy" for the moment.

Jocke

#43 lore raw
Quoted 103 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 17:35:44:

Quoted 27 lines
Quoted 25 lines · Joakim Tjernlund

"J. William Campbell" <[email protected]> wrote on 14/10/2009 01:48:52:

Quoted 22 lines
Quoted 19 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 22:06:56:

Quoted 14 lines
Quoted 9 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 13/10/2009 13:21:05:

Quoted 5 lines

On Sun, Oct 11, 2009 at 11:51 PM, Joakim Tjernlund <[email protected]> wrote:

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Graeme Russ <[email protected]> wrote on 11/10/2009 12:47:19:

[Massive Snip :)]

[Yet another SNIP :)]

Quoted 54 lines
Quoted 44 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 8 lines

Evil idea, skip -fpic et. all and add the full reloc procedure to relocate by rewriting directly in TEXT segment. Then you save space but you need more relocation code. Something like dl_do_reloc from uClibc. Wonder how much extra code that would be? Not too much I think.

With the following flags

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pic --emit-relocs -Bsymbolic -Bsymbolic-functions

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I get no .got, but a lot of R_386_PC32 and R_386_32 relocations. I think this might mean I need the symbol table in the binary in order to resolve them

BTW, how many relocs do you get compared with -fPIC? I suspect you more now but hopefully not that many more.

Quoted 5 lines
Quoted 5 lines

Possibly, but I think you only need to add an offset to all those relocs.

Quoted 14 lines

Almost right. The relocations specify a symbol value that needs to be added to the data in memory to relocate the reference. The symbol values involved should be the start of the text section for program references, the start of the uninitialized data section for bss references, and the start of the data section for initialized data and constants. So there are about four symbols whose value you need to keep. Take a look at
http://refspecs.freestandards.org/elf/elf.pdf (which you have probably already looked at) and it tells you what to do with R_386_PC32 ad R_386_32 relocations. Hopefully the objcopy with the --strip-unneeded will remove all the symbols you don't actually need, but I don't know that for sure. Note also that you can change the section flags of a section marked noload to load.

Quoted 4 lines

Still think you can get away with just ADDING an offset. The image is linked to a specific address and then you move the whole image to a new address. Therefore you should be able to read the current address, add offset, write back the

new address.

Quoted 4 lines

Normally one do what you describe but here we know that the whole img has moved so we don't have to do calculate the new address from scratch.

Quoted 9 lines

If the addresses of the bss, text, and data segments change by the same value, I think you are correct. However, if the text and data/bss segments are moved by different offsets, naturally the relocations would be different. One reason to retain this capability would be to allow the u-boot copy to execute in place in NOR flash while re-locating the read-write storage once memory has been sized. Having different relocation factors is not much worse than just one, and it may be just as easy to get working initially as a single relocation constant.

Quoted 3 lines

How do figure that? You need to rewrite the insn to access the moved data/bss and they are in flash, did I miss something?

No, I did. You are quite correct, there would be references in flash that couldn't be fixed. Sorry about that.

Best Regards,
Bill Campbell

Quoted 24 lines
Quoted 13 lines

FWIW, the "ultimate" solution to minimum relocation size is a post-processing step that creates "several" arrays of relocation offsets as two byte quantities. This reduces the cost of each relocation entry to just a bit more than two bytes (there is a small overhead for array size, MSB values and relocation offset selection.) Naturally, this is much less than the ELF version of the same relocations, because we do not need to retain as much information and ELF doesn't worry about size that much.. This may pacify users for which the flash size of the image is critical, at the expense of an extra link step. Naturally, getting things to work with "standard ELF" is the most important step, and probably enough for most people.

That would save 2+4 bytes/reloc on REL arches and 2+4+4 on RELA(ppc) (provided one can ignore r_addend)

But yes, this is probably too "fancy" for the moment.

Jocke

A message that is not in the archive (sent off-list or not yet received): [email protected]

#45 lore raw
Quoted 191 lines · J. William Campbell
Quoted 184 lines · Graeme Russ
Quoted 171 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 148 lines
Quoted 134 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 10:46:52:

Quoted 122 lines
Quoted 118 lines · Joakim Tjernlund

Graeme Russ <[email protected]> wrote on 10/10/2009 06:43:52:

Quoted 114 lines
Quoted 98 lines · Joakim Tjernlund
Quoted 89 lines
Quoted 72 lines · J. William Campbell
Quoted 65 lines · Graeme Russ
Quoted 59 lines · J. William Campbell

Graeme Russ wrote:

Out of curiosity, I wanted to see just how much of a size
penalty I am
incurring by using gcc -fpic / ld -pic on my x86 u-boot build.
Here are
the results (fixed width font will help - its space, not tab,
formatted):

Section non-reloc reloc
---------------------------------------
.text 000118c4 000137fc <- 0x1f38 bytes (~8kB)
bigger
.rodata 00005bad 000059d0
.interp n/a 00000013
.dynstr n/a 00000648
.hash n/a 00000428
.eh_frame 00003268 000034fc
.data 00000a6c 000001dc
.data.rel n/a 00000098
.data.rel.ro.local n/a 00000178
.data.rel.local n/a 000007e4
.got 00000000 000001f0
.got.plt n/a 0000000c
.rel.got n/a 000003e0
.rel.dyn n/a 00001228
.dynsym n/a 00000850
.dynamic n/a 00000080
.u_boot_cmd 000003c0 000003c0
.bss 00001a34 00001a34
.realmode 00000166 00000166
.bios 0000053e 0000053e
=======================================
Total 0001d5dd 00022287 <- 0x4caa bytes
(~19kB) bigger

Its more than a 16% increase in size!!!

.text accounts for a little under half of the total bloat, and
of that,
the crude dynamic loader accounts for only 341 bytes

Hi Graeme,
I would be interested in a third option (column), the x86
build with
just -mrelocateable but NOT -fpic. It will not be definitive
because
there
will be extra code that references the GOT and missing code to
do some of
the relocation, but it would still be interesting.

Quoted 3 lines

x86 does not have -mrelocatable. This is a PPC only option :(

Quoted 12 lines

Hi Graeme,
You are unfortunately correct. However, I wonder if we
can get
essentially the same result by executing the final ld step with the
--emit-relocs switch included. This may also include some "extra" sections
that we would want to strip out, but if it works, it could give all
ELF-based systems a way to a relocatable u-boot.

Quoted 8 lines

I don't think --emit-relocs is necessary with -pic. I haven't gone through
all the permutations to see if there is a smaller option, but gcc -fpic and
ld -pie creates enough information to perform relocation on the x86
platform

Quoted 2 lines

Try -fvisibility=hidden

Thanks - Shaved another 2539 bytes off the binary

Also found out how to get rid of .eh_frame (crept in when I upgraded to
gcc 4.4.1) with -fno-dwarf2-cfi-asm, so that shaves another 13452 bytes

Total saving of 15.6k

Quoted 8 lines
Quoted 4 lines

Great, so now you are back at just a few percent added I guess?

Not really - The .eh_frame saving applies to both relocated and non relocated builds

Quoted 9 lines

OK, so you didn't use PIC before at all?

Anyway I think you can do more. Using -Bsymbolic you should get away with RELATIVE relocs only and be able to skip a lot of segments above.
Have a look at uClibc ldso/ldso/dl-startup.c

Quoted 8 lines

My build options thus far are:

PLATFORM_RELFLAGS += -fpie -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -pie

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

Quoted 7 lines

Interestingly, -Bsymbolic adds exactly 8 bytes to .dynamic, but doesn't change the size of any other section

Pulling apart the relocation sections, it seems that all relocations are already RELATIVE even without -Bsymbolic

Quoted 8 lines

Ah, that is because you built an exe with -pie Then you should be able to drop everything but the RELATIVE from the linking, or almost in any case.

Jocke

Quoted 5 lines

Hmm, so its seems I may have hit the limit. I tried:

PLATFORM_LDFLAGS += -r --emit-relocs

but there is not enough information left to complete the relocation.

Quoted 7 lines

Hi Graeme,
I am glad you tried this. It should work, -fpie should not be necessary.
Did you also change PLATFORM_RELFLAGS to omit the -fpie? Without pie, and with no libraries linked in that are pie, there should BE no .got, AFIK. I wonder if absolutely everything is getting re-built, like maybe there is a library routine that is being linked in? What exactly was missing when you compiled and linked without pie?

I just tried with:

PLATFORM_RELFLAGS += -fvisibility=hidden
PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
PLATFORM_LDFLAGS += -Bsymbolic --emit-relocs

There is relocation information in the linker output, however it is not marked for allocation so it gets stripped out when creating u-boot.bin

Quoted 18 lines

Best Regards,
Bill Campbell

Quoted 13 lines

It
seems as though I need .rel.got, .got.plt, .dynsym and .rel.dyn in order to find the actual bytes that need modifying (it also seems to mess with the size of the stripped binary for some reason)

Looks like I'll have to proceed with my original plan - a bit bloated, but it works

Graeme

#46 lore raw
In reply to Joakim Tjernlund
Quoted 4 lines · On Saturday 10 October 2009 06:47:42 Joakim Tjernlund wrote:

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 1 line

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

i think you guys mean -fpic and -fPIC because there is no -pic flag ... while the two make a big diff on some arches like ppc, they make pretty much no different on x86 last i looked
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091010/a0bb42ee/attachment.pgp

#47 lore raw

Mike Frysinger <[email protected]> wrote on 10/10/2009 18:52:29:

Quoted 10 lines · On Saturday 10 October 2009 06:47:42 Joakim Tjernlund wrote:
Quoted 4 lines

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 1 line

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

i think you guys mean -fpic and -fPIC because there is no -pic flag ... while the two make a big diff on some arches like ppc, they make pretty much no different on x86 last i looked

Yes, this was what I was thinking(-fpic vs. -fPIC). These will probably only make a difference on RISC like arches.

Jocke

#48 lore raw
Quoted 11 lines · Joakim Tjernlund

Mike Frysinger <[email protected]> wrote on 10/10/2009 18:52:29:

Quoted 10 lines · On Saturday 10 October 2009 06:47:42 Joakim Tjernlund wrote:
Quoted 4 lines

Graeme Russ <[email protected]> wrote on 10/10/2009 12:38:19:

Quoted 1 line

-fpic / -pic make no difference

not on x86, on ppc it is a big difference.

i think you guys mean -fpic and -fPIC because there is no -pic flag ... while the two make a big diff on some arches like ppc, they make pretty much no different on x86 last i looked

Sorry for the confusion - by -fpic / -pic I was referring to -fpic (gcc) / -pic (ld) flags versus -fpie (gcc) / -pie (ld) flags.

Quoted 4 lines

Yes, this was what I was thinking(-fpic vs. -fPIC). These will probably only make a difference on RISC like arches.

There appears to be no difference (on x86) between pic, PIC, and pie. The big difference is when I drop ld's -pic and use ld's --emit-relocs instead

Quoted 3 lines

Jocke

Regards,

Graeme