Skip to contentSkip to conversation

Xen PV breakage after IRQ stack code refactoring

PATCH Boris Ostrovsky 3 participants 7 messages Nov 26, 2017 – Nov 27, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Any other suggestions?

-boris

maintainer
#1 lore raw
Quoted 36 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Quoted 7 lines

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

Quoted 3 lines

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

maintainer
#2 lore raw
In reply to Boris Ostrovsky
Quoted 36 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Quoted 7 lines

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

Quoted 3 lines

-boris

#3 lore raw
Quoted 44 lines · Andy Lutomirski
Quoted 42 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Quoted 3 lines
Quoted 1 line

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

No, but adding it would be pretty straight forward. Its something like:

#define SAVE_FLAGS(clobbers)                                        \
        PARA_SITE(PARA_PATCH(pv_irq_ops, PV_IRQ_save_fl), clobbers, \
                  PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE);        \
                  call PARA_INDIRECT(pv_irq_ops+PV_IRQ_save_fl);    \
                  PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);)

similar to DISABLE_INTERRUPTS(), requiring just the definition of PV_IRQ_save_fl in asm-offsets.c and the non-pvops definition of SAVE_FLAGS() in irqflags.h.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
In reply to Andy Lutomirski
Quoted 44 lines · Andy Lutomirski
Quoted 42 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Quoted 3 lines
Quoted 1 line

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

No, but adding it would be pretty straight forward. Its something like:

#define SAVE_FLAGS(clobbers)                                        \
        PARA_SITE(PARA_PATCH(pv_irq_ops, PV_IRQ_save_fl), clobbers, \
                  PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE);        \
                  call PARA_INDIRECT(pv_irq_ops+PV_IRQ_save_fl);    \
                  PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);)

similar to DISABLE_INTERRUPTS(), requiring just the definition of PV_IRQ_save_fl in asm-offsets.c and the non-pvops definition of SAVE_FLAGS() in irqflags.h.

Juergen

#5 lore raw
Quoted 55 lines · Juergen Gross
Quoted 38 lines · Andy Lutomirski
Quoted 36 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Quoted 8 lines
Quoted 7 lines

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

No, but adding it would be pretty straight forward. Its something like:

#define SAVE_FLAGS(clobbers)                                        \
        PARA_SITE(PARA_PATCH(pv_irq_ops, PV_IRQ_save_fl), clobbers, \
                  PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE);        \
                  call PARA_INDIRECT(pv_irq_ops+PV_IRQ_save_fl);    \
                  PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);)
Quoted 3 lines

similar to DISABLE_INTERRUPTS(), requiring just the definition of PV_IRQ_save_fl in asm-offsets.c and the non-pvops definition of SAVE_FLAGS() in irqflags.h.

Hmm.. Indeed, I haven't thought of this for whatever reasons. I'll send the patch soon.

Thanks.
-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
In reply to Juergen Gross
Quoted 55 lines · Juergen Gross
Quoted 38 lines · Andy Lutomirski
Quoted 36 lines · Boris Ostrovsky

Andy,

(Can't find the original patch in my mailbox)

This hunk from 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe")

arch/x86/entry/entry_64.S +11 -0
index a9a8027..0d4483a 100644
@@ -447,6 +447,59 @@ ENTRY(irq_entries_start)
     .endr
 END(irq_entries_start)
 
+.macro DEBUG_ENTRY_ASSERT_IRQS_OFF
+#ifdef CONFIG_DEBUG_ENTRY
+       pushfq
+       testl $X86_EFLAGS_IF, (%rsp)
+       jz .Lokay_\@
+       ud2
+.Lokay_\@:
+       addq $8, %rsp
+#endif
+.endm
+
 

makes Xen PV guests somewhat unhappy because IF flag will be set.

I was hoping to use ALTERNATIVE instruction but when we hit this for the first time we haven't rewritten instructions yet. Moving check_bugs() a bit higher helps but because this is common code I don't know how well it will work on other architectures (and, in fact, whether it is even safe on x86 in general, although that can be verified).

Quoted 8 lines
Quoted 7 lines

Another option is to also add a parameter to DEBUG_ENTRY_ASSERT_IRQS_OFF (or to ENTER_IRQ_STACK) from xen_do_hypervisor_callback (which is where the failure happens) but this looks pretty fragile in that it assumes that xen_do_hypervisor_callback is the only place where we use this codepath before alt instructions are set.

Any other suggestions?

Do we have a convenient asm way to access the save_fl pvop?

No, but adding it would be pretty straight forward. Its something like:

#define SAVE_FLAGS(clobbers)                                        \
        PARA_SITE(PARA_PATCH(pv_irq_ops, PV_IRQ_save_fl), clobbers, \
                  PV_SAVE_REGS(clobbers | CLBR_CALLEE_SAVE);        \
                  call PARA_INDIRECT(pv_irq_ops+PV_IRQ_save_fl);    \
                  PV_RESTORE_REGS(clobbers | CLBR_CALLEE_SAVE);)
Quoted 3 lines

similar to DISABLE_INTERRUPTS(), requiring just the definition of PV_IRQ_save_fl in asm-offsets.c and the non-pvops definition of SAVE_FLAGS() in irqflags.h.

Hmm.. Indeed, I haven't thought of this for whatever reasons. I'll send the patch soon.

Thanks.
-boris