Skip to contentSkip to conversation

Fix markup_oops.pl get $func_offset error in x8664

PATCH In review Hui Zhu 2 participants 3 messages Jan 17, 2010 – Jan 25, 2010

lore
Share & tools
lore

Hui Zhu

author
#0 lore raw

PATCH 1/1 Fix markup_oops.pl get $func_offset error in x8664

This patch like the prev patch in http://lkml.org/lkml/2010/1/6/57
The x8664 part have the same trouble with it. This patch is to fix it.

Thanks,
Hui

Cc Andrew Morton <[email protected]>
Cc Arjan van de Ven <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Ozan Çaglayan <[email protected]>
Cc Matthew Wilcox <[email protected]>
---
 scripts/markup_oops.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/markup_oops.pl +0 -1
@@ -158,7 +158,7 @@ while (<STDIN>) {
 		$function = $1;
 		$func_offset = $2;
 	}
-	if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\]  \[\<[0-9a-f]+\>\]

([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
+ if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\] \[\<[0-9a-f]+\>\]
([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) {
$function = $1;
$func_offset = $2;
}

#1 lore raw
Quoted 3 lines · On Sun, 17 Jan 2010 21:35:25 +0800 Hui Zhu <[email protected]> wrote:

This patch like the prev patch in http://lkml.org/lkml/2010/1/6/57
The x8664 part have the same trouble with it. This patch is to fix it.

This changelog isn't very useful. Please provide a description for this change which doesn't require that people have to go off and read the internet and then work out how some other patch is relevant to this one!

Quoted 15 lines
---
 scripts/markup_oops.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/markup_oops.pl +1 -1
@@ -158,7 +158,7 @@ while (<STDIN>) {
 		$function = $1;
 		$func_offset = $2;
 	}
-	if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\]  \[\<[0-9a-f]+\>\]
 ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
+	if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\]  \[\<[0-9a-f]+\>\]
 ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) {
 		$function = $1;

scripts/markup_oops.pl while (<STDIN>) { · line 160

Quoted 2 lines
scripts/markup_oops.pl +0 -0
 		$func_offset = $2;
 	}

Your email client wordwrapped the patch. Please fix it then resend.

author
#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 3 lines · On Sun, 17 Jan 2010 21:35:25 +0800 Hui Zhu <[email protected]> wrote:

This patch like the prev patch in http://lkml.org/lkml/2010/1/6/57
The x8664 part have the same trouble with it.  This patch is to fix it.

This changelog isn't very useful.  Please provide a description for this change which doesn't require that people have to go off and read the internet and then work out how some other patch is relevant to this one!

OK. I will post a new mail for this patch.

Quoted 6 lines
Quoted 6 lines

---
 scripts/markup_oops.pl |    2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines
Quoted 11 lines
scripts/markup_oops.pl +1 -1
@@ -158,7 +158,7 @@ while (<STDIN>) {
               $function = $1;
               $func_offset = $2;
       }
-     if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\]  \[\<[0-9a-f]+\>\]
 ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
+     if ($line =~ /RIP: 0010:\[\<[0-9a-f]+\>\]  \[\<[0-9a-f]+\>\]
 ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) {
               $function = $1;
Quoted 2 lines

              $func_offset = $2;
      }

Your email client wordwrapped the patch.  Please fix it then resend.

I will fix it in new mail. Sorry for it.

Best regards,
Hui