drm encoders cleanup: nuke optional dummy encoder mode_fixup function.
Subsystems (9)
A message that is not in the archive (sent off-list or not yet received): [email protected],
cover drm encoders cleanup: nuke optional dummy encoder mode_fixup function.
mode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/[email protected]
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Carlos Palminha (17):
drm/virtio: removed optional dummy encoder mode_fixup function. drm/udl: removed optional dummy encoder mode_fixup function. drm/exynos: removed optional dummy encoder mode_fixup function. drm/amdgpu: removed optional dummy encoder mode_fixup function. drm/ast: removed optional dummy encoder mode_fixup function. drm/bochs: removed optional dummy encoder mode_fixup function. drm/cirrus: removed optional dummy encoder mode_fixup function. drm/exynos: removed optional dummy encoder mode_fixup function. drm/gma500: removed optional dummy encoder mode_fixup function. drm/imx: removed optional dummy encoder mode_fixup function. drm/msm/mdp: removed optional dummy encoder mode_fixup function. drm/mgag200: removed optional dummy encoder mode_fixup function. drm/qxl: removed optional dummy encoder mode_fixup function. drm/radeon: removed optional dummy encoder mode_fixup function. drm/rockchip: removed optional dummy encoder mode_fixup function. drm/sti: removed optional dummy encoder mode_fixup function. drm/tilcdc: removed optional dummy encoder mode_fixup function.
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- drivers/gpu/drm/exynos/exynos_dp_core.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 -------- drivers/gpu/drm/gma500/cdv_intel_crt.c | 1 - drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 1 - drivers/gpu/drm/gma500/gma_display.c | 7 ------- drivers/gpu/drm/gma500/gma_display.h | 3 --- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 1 - drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 -------- drivers/gpu/drm/imx/imx-ldb.c | 8 -------- drivers/gpu/drm/imx/imx-tve.c | 8 -------- drivers/gpu/drm/imx/parallel-display.c | 8 -------- drivers/gpu/drm/mgag200/mgag200_mode.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_dsi_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_dtv_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 9 --------- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 8 -------- drivers/gpu/drm/qxl/qxl_display.c | 9 --------- drivers/gpu/drm/radeon/atombios_encoders.c | 8 -------- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 -------- drivers/gpu/drm/sti/sti_tvout.c | 10 ---------- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 --------- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 9 --------- drivers/gpu/drm/udl/udl_encoder.c | 8 -------- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 33 files changed, 244 deletions(-)
Signature · 1 line
2.5.0
PATCH 1/17 drm/virtio: removed optional dummy encoder mode_fixup function.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/virtio/virtgpu_display.c +0 -8
@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)
@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable,
Signature · 1 line
2.5.0
Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.
On Fri, Feb 12, 2016 at 01:50:53PM +0000, Carlos Palminha wrote:
Sob-line from you is missing on all patches, I can't merge them. Also please copypaste a default blurb to all patches that this is only recently no longer needed. And dunno what happened to your patch series, the threading is somehow broken. In case your mail server doesn't accept a big patch series you can first format .patch files using git format-patch with threading enabled (should be the default) and then send them out in chunks.
When resending please also add the r-b tag from Alex for amdgpu/radoen.
Thanks, Daniel
Quoted 37 lines
--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +0
-8@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable,Signature · 6 lines
2.5.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.
Daniel, thanks for the feedback.
v2 patch will follow-up. :)
Quoted 52 lines · Daniel Vetter
On Fri, Feb 12, 2016 at 01:50:53PM +0000, Carlos Palminha wrote:
Sob-line from you is missing on all patches, I can't merge them. Also please copypaste a default blurb to all patches that this is only recently no longer needed. And dunno what happened to your patch series, the threading is somehow broken. In case your mail server doesn't accept a big patch series you can first format .patch files using git format-patch with threading enabled (should be the default) and then send them out in chunks.
When resending please also add the r-b tag from Alex for amdgpu/radoen.
Thanks, Daniel
Quoted 37 lines
--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +0
-9@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable, --2.5.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.
In reply to Daniel VetterDaniel, thanks for the feedback.
v2 patch will follow-up. :)
Quoted 52 lines · Daniel Vetter
On Fri, Feb 12, 2016 at 01:50:53PM +0000, Carlos Palminha wrote:
Sob-line from you is missing on all patches, I can't merge them. Also please copypaste a default blurb to all patches that this is only recently no longer needed. And dunno what happened to your patch series, the threading is somehow broken. In case your mail server doesn't accept a big patch series you can first format .patch files using git format-patch with threading enabled (should be the default) and then send them out in chunks.
When resending please also add the r-b tag from Alex for amdgpu/radoen.
Thanks, Daniel
Quoted 37 lines
--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +0
-9@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable, --2.5.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.
In reply to Carlos PalminhaOn Fri, Feb 12, 2016 at 01:50:53PM +0000, Carlos Palminha wrote:
Sob-line from you is missing on all patches, I can't merge them. Also please copypaste a default blurb to all patches that this is only recently no longer needed. And dunno what happened to your patch series, the threading is somehow broken. In case your mail server doesn't accept a big patch series you can first format .patch files using git format-patch with threading enabled (should be the default) and then send them out in chunks.
When resending please also add the r-b tag from Alex for amdgpu/radoen.
Thanks, Daniel
Quoted 37 lines
--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +0
-8@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable,Signature · 6 lines
2.5.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
PATCH 1/17 drm/virtio: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/virtio/virtgpu_display.c +0 -8
@@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { .atomic_check = virtio_gpu_crtc_atomic_check, }; -static bool virtio_gpu_enc_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void virtio_gpu_enc_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)
@@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector) }static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { - .mode_fixup = virtio_gpu_enc_mode_fixup, .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, .disable = virtio_gpu_enc_disable,
Signature · 1 line
2.5.0
PATCH 2/17 drm/udl: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/udl/udl_encoder.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/udl/udl_encoder.c +0 -8
@@ -26,13 +26,6 @@ static void udl_encoder_disable(struct drm_encoder *encoder) { } -static bool udl_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void udl_encoder_prepare (struct drm_encoder *encoder) { }
@@ -54,7 +47,6 @@ udl_encoder_dpms(struct drm_encoder *encoder, int mode)static const struct drm_encoder_helper_funcs udl_helper_funcs = { .dpms = udl_encoder_dpms, - .mode_fixup = udl_mode_fixup, .prepare = udl_encoder_prepare, .mode_set = udl_encoder_mode_set, .commit = udl_encoder_commit,
Signature · 1 line
2.5.0
PATCH 2/17 drm/udl: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/udl/udl_encoder.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/udl/udl_encoder.c +0 -8
@@ -26,13 +26,6 @@ static void udl_encoder_disable(struct drm_encoder *encoder) { } -static bool udl_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void udl_encoder_prepare (struct drm_encoder *encoder) { }
@@ -54,7 +47,6 @@ udl_encoder_dpms(struct drm_encoder *encoder, int mode)static const struct drm_encoder_helper_funcs udl_helper_funcs = { .dpms = udl_encoder_dpms, - .mode_fixup = udl_mode_fixup, .prepare = udl_encoder_prepare, .mode_set = udl_encoder_mode_set, .commit = udl_encoder_commit,
Signature · 1 line
2.5.0
PATCH 3/17 drm/exynos: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/exynos/exynos_drm_dsi.c +0 -8
@@ -1597,13 +1597,6 @@ static int exynos_dsi_create_connector(struct drm_encoder *encoder)return 0 ; } -static bool exynos_dsi_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void exynos_dsi_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)
@@ -1623,7 +1616,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder, }static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = { - .mode_fixup = exynos_dsi_mode_fixup, .mode_set = exynos_dsi_mode_set, .enable = exynos_dsi_enable, .disable = exynos_dsi_disable,
Signature · 1 line
2.5.0
PATCH 3/17 drm/exynos: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/exynos/exynos_drm_dsi.c +0 -8
@@ -1597,13 +1597,6 @@ static int exynos_dsi_create_connector(struct drm_encoder *encoder)return 0 ; } -static bool exynos_dsi_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static void exynos_dsi_mode_set (struct drm_encoder *encoder,struct drm_display_mode *mode,struct drm_display_mode *adjusted_mode)
@@ -1623,7 +1616,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder, }static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = { - .mode_fixup = exynos_dsi_mode_fixup, .mode_set = exynos_dsi_mode_set, .enable = exynos_dsi_enable, .disable = exynos_dsi_disable,
Signature · 1 line
2.5.0
PATCH 4/17 drm/amdgpu: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- 3 files changed, 24 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +0 -8
@@ -3624,16 +3624,8 @@ dce_v10_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v10_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v10_0_ext_helper_funcs = { .dpms = dce_v10_0_ext_dpms, - .mode_fixup = dce_v10_0_ext_mode_fixup, .prepare = dce_v10_0_ext_prepare, .mode_set = dce_v10_0_ext_mode_set, .commit = dce_v10_0_ext_commit,
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +0 -8
@@ -3619,16 +3619,8 @@ dce_v11_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v11_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v11_0_ext_helper_funcs = { .dpms = dce_v11_0_ext_dpms, - .mode_fixup = dce_v11_0_ext_mode_fixup, .prepare = dce_v11_0_ext_prepare, .mode_set = dce_v11_0_ext_mode_set, .commit = dce_v11_0_ext_commit,
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -8
@@ -3554,16 +3554,8 @@ dce_v8_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v8_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v8_0_ext_helper_funcs = { .dpms = dce_v8_0_ext_dpms, - .mode_fixup = dce_v8_0_ext_mode_fixup, .prepare = dce_v8_0_ext_prepare, .mode_set = dce_v8_0_ext_mode_set, .commit = dce_v8_0_ext_commit,
Signature · 1 line
2.5.0
Re: [PATCH 04/17] drm/amdgpu: removed optional dummy encoder mode_fixup function.
Quoted 5 lines · Carlos Palminha
--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- 3 files changed, 24 deletions(-)
Quoted 71 lines
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +0
-8@@ -3624,16 +3624,8 @@ dce_v10_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v10_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v10_0_ext_helper_funcs = { .dpms = dce_v10_0_ext_dpms, - .mode_fixup = dce_v10_0_ext_mode_fixup, .prepare = dce_v10_0_ext_prepare, .mode_set = dce_v10_0_ext_mode_set, .commit = dce_v10_0_ext_commit,drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +0
-8@@ -3619,16 +3619,8 @@ dce_v11_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v11_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v11_0_ext_helper_funcs = { .dpms = dce_v11_0_ext_dpms, - .mode_fixup = dce_v11_0_ext_mode_fixup, .prepare = dce_v11_0_ext_prepare, .mode_set = dce_v11_0_ext_mode_set, .commit = dce_v11_0_ext_commit,drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0
-9@@ -3554,16 +3554,8 @@ dce_v8_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v8_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v8_0_ext_helper_funcs = { .dpms = dce_v8_0_ext_dpms, - .mode_fixup = dce_v8_0_ext_mode_fixup, .prepare = dce_v8_0_ext_prepare, .mode_set = dce_v8_0_ext_mode_set, .commit = dce_v8_0_ext_commit, --2.5.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/17] drm/amdgpu: removed optional dummy encoder mode_fixup function.
In reply to Carlos PalminhaQuoted 5 lines · Carlos Palminha
--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- 3 files changed, 24 deletions(-)
Quoted 71 lines
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +0
-8@@ -3624,16 +3624,8 @@ dce_v10_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v10_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v10_0_ext_helper_funcs = { .dpms = dce_v10_0_ext_dpms, - .mode_fixup = dce_v10_0_ext_mode_fixup, .prepare = dce_v10_0_ext_prepare, .mode_set = dce_v10_0_ext_mode_set, .commit = dce_v10_0_ext_commit,drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +0
-8@@ -3619,16 +3619,8 @@ dce_v11_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v11_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v11_0_ext_helper_funcs = { .dpms = dce_v11_0_ext_dpms, - .mode_fixup = dce_v11_0_ext_mode_fixup, .prepare = dce_v11_0_ext_prepare, .mode_set = dce_v11_0_ext_mode_set, .commit = dce_v11_0_ext_commit,drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0
-9@@ -3554,16 +3554,8 @@ dce_v8_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v8_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v8_0_ext_helper_funcs = { .dpms = dce_v8_0_ext_dpms, - .mode_fixup = dce_v8_0_ext_mode_fixup, .prepare = dce_v8_0_ext_prepare, .mode_set = dce_v8_0_ext_mode_set, .commit = dce_v8_0_ext_commit, --2.5.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 4/17 drm/amdgpu: removed optional dummy encoder mode_fixup function.
In reply to Carlos Palminha--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- 3 files changed, 24 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +0 -8
@@ -3624,16 +3624,8 @@ dce_v10_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v10_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v10_0_ext_helper_funcs = { .dpms = dce_v10_0_ext_dpms, - .mode_fixup = dce_v10_0_ext_mode_fixup, .prepare = dce_v10_0_ext_prepare, .mode_set = dce_v10_0_ext_mode_set, .commit = dce_v10_0_ext_commit,
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +0 -8
@@ -3619,16 +3619,8 @@ dce_v11_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v11_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v11_0_ext_helper_funcs = { .dpms = dce_v11_0_ext_dpms, - .mode_fixup = dce_v11_0_ext_mode_fixup, .prepare = dce_v11_0_ext_prepare, .mode_set = dce_v11_0_ext_mode_set, .commit = dce_v11_0_ext_commit,
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -8
@@ -3554,16 +3554,8 @@ dce_v8_0_ext_dpms(struct drm_encoder *encoder, int mode) } -static bool dce_v8_0_ext_mode_fixup (struct drm_encoder *encoder, -const struct drm_display_mode *mode, -struct drm_display_mode *adjusted_mode) -{ -return true; -} -static const struct drm_encoder_helper_funcs dce_v8_0_ext_helper_funcs = { .dpms = dce_v8_0_ext_dpms, - .mode_fixup = dce_v8_0_ext_mode_fixup, .prepare = dce_v8_0_ext_prepare, .mode_set = dce_v8_0_ext_mode_set, .commit = dce_v8_0_ext_commit,
Signature · 1 line
2.5.0
cover drm encoders cleanup: nuke optional dummy encoder mode_fixup function.
In reply to a message not in the archivemode_fixup function for encoder drivers became optional with patch
http://patchwork.freedesktop.org/patch/msgid/[email protected]
This patch set nukes all the dummy mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)
Carlos Palminha (17):
drm/virtio: removed optional dummy encoder mode_fixup function. drm/udl: removed optional dummy encoder mode_fixup function. drm/exynos: removed optional dummy encoder mode_fixup function. drm/amdgpu: removed optional dummy encoder mode_fixup function. drm/ast: removed optional dummy encoder mode_fixup function. drm/bochs: removed optional dummy encoder mode_fixup function. drm/cirrus: removed optional dummy encoder mode_fixup function. drm/exynos: removed optional dummy encoder mode_fixup function. drm/gma500: removed optional dummy encoder mode_fixup function. drm/imx: removed optional dummy encoder mode_fixup function. drm/msm/mdp: removed optional dummy encoder mode_fixup function. drm/mgag200: removed optional dummy encoder mode_fixup function. drm/qxl: removed optional dummy encoder mode_fixup function. drm/radeon: removed optional dummy encoder mode_fixup function. drm/rockchip: removed optional dummy encoder mode_fixup function. drm/sti: removed optional dummy encoder mode_fixup function. drm/tilcdc: removed optional dummy encoder mode_fixup function.
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 8 -------- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 8 -------- drivers/gpu/drm/ast/ast_mode.c | 8 -------- drivers/gpu/drm/bochs/bochs_kms.c | 8 -------- drivers/gpu/drm/cirrus/cirrus_mode.c | 9 --------- drivers/gpu/drm/exynos/exynos_dp_core.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 -------- drivers/gpu/drm/gma500/cdv_intel_crt.c | 1 - drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 1 - drivers/gpu/drm/gma500/gma_display.c | 7 ------- drivers/gpu/drm/gma500/gma_display.h | 3 --- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 1 - drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 -------- drivers/gpu/drm/imx/imx-ldb.c | 8 -------- drivers/gpu/drm/imx/imx-tve.c | 8 -------- drivers/gpu/drm/imx/parallel-display.c | 8 -------- drivers/gpu/drm/mgag200/mgag200_mode.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_dsi_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_dtv_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 8 -------- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 9 --------- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 8 -------- drivers/gpu/drm/qxl/qxl_display.c | 9 --------- drivers/gpu/drm/radeon/atombios_encoders.c | 8 -------- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 -------- drivers/gpu/drm/sti/sti_tvout.c | 10 ---------- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 --------- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 9 --------- drivers/gpu/drm/udl/udl_encoder.c | 8 -------- drivers/gpu/drm/virtio/virtgpu_display.c | 8 -------- 33 files changed, 244 deletions(-)
Signature · 1 line
2.5.0