Skip to contentSkip to conversation

nvme_fc: add module to ops template to allow module

REVERT James Smart 2 participants 2 messages Apr 1, 2020 – Apr 2, 2020 NVMe

lore
Share & tools
lore
#0 lore raw

(not quite sure how to request this)

Please revert commit  863fbae929c7 nvme_fc: add module to ops template to allow module  references

This is blocking lldd driver removal from under nvme-fc whenever there is a nvme controller attached via the driver. The driver module detach routine can't be called, thus there's no way start the controller deletes/port removals so the driver can unload.  Should have been obvious from the get go that this was a bad idea, but.... not seeing the forest for the trees.

Reverting this does mean I don't know how to solve a booted-from device where the driver wants to unload and (re)load, but the load may be blocked as swap/fs access may be needed to access the new module to load. Suggestions welcome.

-- james

Sasha: This was upstream as of 5.5 and I believe went into 5.4/4.14/4.19

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme