Skip to contentSkip to conversation

add missing "source" line for firmware subdirectory in drivers/Kconfig

PATCH In review Heiner Kallweit 2 participants 3 messages Nov 28, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add missing "source" line for firmware subdirectory in drivers/Kconfig

I have a little bit of a hard time to find the right addressee for this patch because there is no maintainer entry for drivers/firmware. Can you apply the following through your tree?

Add missing entry for firmware subdirectory in drivers/Kconfig.

---
 drivers/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/Kconfig +2 -0
index 152744c5e..a506867d9 100644
@@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
 
 source "drivers/firewire/Kconfig"
 
+source "drivers/firmware/Kconfig"
+
 source "drivers/macintosh/Kconfig"
 
 source "drivers/net/Kconfig"
Signature · 1 line
2.15.0
#1 lore raw
Quoted 7 lines · Heiner Kallweit

I have a little bit of a hard time to find the right addressee for this patch because there is no maintainer entry for drivers/firmware. Can you apply the following through your tree?

Add missing entry for firmware subdirectory in drivers/Kconfig.

Hi,
Why do you need this patch? You should explain that in the (missing) patch description.

I suppose that it could be done like this, but currently any $ARCH that wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:

arch> grep firmware/Kconfig */Kconfig arm/Kconfig:source "arch/arm/firmware/Kconfig" arm/Kconfig:source "drivers/firmware/Kconfig" arm64/Kconfig:source "drivers/firmware/Kconfig" blackfin/Kconfig:source "drivers/firmware/Kconfig" ia64/Kconfig:source "drivers/firmware/Kconfig" mips/Kconfig:source "drivers/firmware/Kconfig" x86/Kconfig:source "drivers/firmware/Kconfig"

so all of these would need to be removed.

Quoted 18 lines
---
 drivers/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/Kconfig +2 -0
index 152744c5e..a506867d9 100644
@@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
 
 source "drivers/firewire/Kconfig"
 
+source "drivers/firmware/Kconfig"
+
 source "drivers/macintosh/Kconfig"
 
 source "drivers/net/Kconfig"
Signature · 1 line
~Randy
#2 lore raw

Am 28.11.2017 um 18:09 schrieb Randy Dunlap:

Quoted 25 lines · Heiner Kallweit
Quoted 7 lines

I have a little bit of a hard time to find the right addressee for this patch because there is no maintainer entry for drivers/firmware. Can you apply the following through your tree?

Add missing entry for firmware subdirectory in drivers/Kconfig.

Hi,
Why do you need this patch? You should explain that in the (missing) patch description.

I suppose that it could be done like this, but currently any $ARCH that wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:

arch> grep firmware/Kconfig */Kconfig arm/Kconfig:source "arch/arm/firmware/Kconfig" arm/Kconfig:source "drivers/firmware/Kconfig" arm64/Kconfig:source "drivers/firmware/Kconfig" blackfin/Kconfig:source "drivers/firmware/Kconfig" ia64/Kconfig:source "drivers/firmware/Kconfig" mips/Kconfig:source "drivers/firmware/Kconfig" x86/Kconfig:source "drivers/firmware/Kconfig"

Quoted 2 lines

so all of these would need to be removed.

Thanks for the hints!
Reason is that I received an error report for a patch, and this error report was about a problem with compiling scpi clk driver with COMPILE_TEST on a xtensa platform. And the scpi clk driver depends on the scpi driver under drivers/firmware.
Based on what you explained and after fixing the dependency for the scpi clk driver the proposed patch shouldn't be needed any longer.

Thanks, Heiner

Quoted 20 lines
Quoted 18 lines
---
 drivers/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/Kconfig +2 -0
index 152744c5e..a506867d9 100644
@@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
 
 source "drivers/firewire/Kconfig"
 
+source "drivers/firmware/Kconfig"
+
 source "drivers/macintosh/Kconfig"
 
 source "drivers/net/Kconfig"