OPENBMC ASRock Rack
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): CALVHhedqJhfKD+MNofiwnKBB7sGG1wRPV4gXTdW_h=8=6=4HKw@mail.gmail.com
A message that is not in the archive (sent off-list or not yet received): OF6DE94A96.B5787DB8-ON00258584.00525E62-00258584.0052E3DC@notes.na.collabserv.com
A message that is not in the archive (sent off-list or not yet received): OF796A58B2.9DA64EBD-ON00258585.003E519E-00258585.003F6F0E@notes.na.collabserv.com
A message that is not in the archive (sent off-list or not yet received): OF2B5AA3C5.40A65716-ON00258589.004350E5-00258589.00436A50@notes.na.collabserv.com
A message that is not in the archive (sent off-list or not yet received): OF5B0F1DD8.7358EE61-ON002586BE.004FB2E2-002586BE.0050DCF8@notes.na.collabserv.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re-send
Hi Bradley,
I got below error when I try to push meta-asrockrack layer to gerrit. Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
error: failed to push some refs to 'ssh://openbmc.gerrit/openbmc/openbmc'
My procedure is:
1. Git clone openbmc
2. Add meta-asrockrack layer
3. git remote add gerrit ssh://openbmc.gerrit/openbmc/openbmc
4. git commit
5. git push gerrit
My git log:
commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
Author: Jeff9Chan <[email protected]> Date: Tue Jun 8 09:15:44 2021 +0800
add meta-asrockrack layer
Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
Quoted 8 lines · On Mon, Jun 7, 2021 at 7:01 PM Jeff9 Chan(陳松儉_ASRockRack)…
Re-send
Hi Bradley,
I got below error when I try to push meta-asrockrack layer to gerrit.
Jeff,
On your last thread that you asked this on, you got several replies about what you were doing wrong. Please use that thread to communicate with this list and reply; Don't start a second thread like you've done here.
Quoted 58 lines
Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
error: failed to push some refs to 'ssh://openbmc.gerrit/openbmc/openbmc'
My procedure is:
1. Git clone openbmc
2. Add meta-asrockrack layer
3. git remote add gerrit ssh://openbmc.gerrit/openbmc/openbmc
4. git commit
5. git push gerrit
My git log:
commit
1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)Author: Jeff9Chan <[email protected]>
Date: Tue Jun 8 09:15:44 2021 +0800
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
Quoted 15 lines · Jeff Chan
Hi Bradley,
I got below error when I try to push meta-asrockrack layer
to gerrit.
Is that means my email is not listed in the list?To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c:
not Signed-off-by author/committer/uploader in message footer)
error: failed to push some refs to
'ssh://openbmc.gerrit/openbmc/openbmc'My procedure is:
1. Git clone openbmc 2. Add meta-asrockrack layer 3. git remote add gerrit
Quoted 7 lines
ssh://openbmc.gerrit/openbmc/openbmc
4. git commit
5. git push gerritMy git log:
commit1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)
Author: Jeff9Chan <[email protected]>
The Author name is Jeff9Chan here
Quoted 4 lines
Date: Tue Jun 8 09:15:44 2021 +0800
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>
The Signed-off-by is Jeff Chan here.
The email has different case, not sure if that matters. But the name format likley does.
You can control the format of the author and committer via git config --global user.name "Jeff Chan"
git config --global user.email [email protected]
You can amend the author with git commit --amend --reset-author
Hope this helps,
milton
Hi Milton,
My user account in Github/Gerrit is Jeff9Chan, but registered CLA account is 'Jeff Chan < [email protected]>' Should I re-register CLA info?
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
-----Original Message-----
From: Milton Miller II [mailto:[email protected]]
Sent: Tuesday, June 8, 2021 10:45 AM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: RE: OPENBMC ASRock Rack
Quoted 15 lines · Jeff Chan
Hi Bradley,
I got below error when I try to push meta-asrockrack layer
to gerrit.
Is that means my email is not listed in the list?To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c:
not Signed-off-by author/committer/uploader in message footer)
error: failed to push some refs to
'ssh://openbmc.gerrit/openbmc/openbmc'My procedure is:
1. Git clone openbmc 2. Add meta-asrockrack layer 3. git remote add gerrit
Quoted 7 lines
ssh://openbmc.gerrit/openbmc/openbmc
4. git commit
5. git push gerritMy git log:
commit1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)
Author: Jeff9Chan <[email protected]>
The Author name is Jeff9Chan here
Quoted 4 lines
Date: Tue Jun 8 09:15:44 2021 +0800
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>
The Signed-off-by is Jeff Chan here.
The email has different case, not sure if that matters. But the name format likley does.
You can control the format of the author and committer via git config --global user.name "Jeff Chan"
git config --global user.email [email protected]
You can amend the author with git commit --amend --reset-author
Hope this helps,
milton
Quoted 2 lines · On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)…
Re-send
Please use plain text email when posting to the list. This is a good rule to follow for all open source mailing lists.
Quoted 9 lines
I got below error when I try to push meta-asrockrack layer to gerrit.
Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
Here is the error:
(commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)
Quoted 8 lines
commit
1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)Author: Jeff9Chan <[email protected]>
Date: Tue Jun 8 09:15:44 2021 +0800
Quoted 7 lines
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of the on the line immediately above or below the change id. Try git commit --amend and moving it so the message looks like this:
Add meta-asrockrack layer
Cheers,
Joel
Thanks Joel, it works now.
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
-----Original Message-----
From: Joel Stanley [mailto:[email protected]]
Sent: Tuesday, June 8, 2021 2:00 PM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: Re: OPENBMC ASRock Rack
Quoted 2 lines · On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)…
Re-send
Please use plain text email when posting to the list. This is a good rule to follow for all open source mailing lists.
Quoted 9 lines
I got below error when I try to push meta-asrockrack layer to gerrit.
Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
Here is the error:
(commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)
Quoted 8 lines
commit
1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)Author: Jeff9Chan <[email protected]>
Date: Tue Jun 8 09:15:44 2021 +0800
Quoted 7 lines
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of the on the line immediately above or below the change id. Try git commit --amend and moving it so the message looks like this:
Add meta-asrockrack layer
Cheers,
Joel
Hi,
It has been a while after uploading asrockrack layer, looks like no one is reviewing it, what's the next step for me?
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/43850
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
-----Original Message-----
From: Jeff9 Chan(陳松儉_ASRockRack)
Sent: Tuesday, June 8, 2021 2:48 PM
To: 'Joel Stanley'
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: RE: OPENBMC ASRock Rack
Thanks Joel, it works now.
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670
-----Original Message-----
From: Joel Stanley [mailto:[email protected]]
Sent: Tuesday, June 8, 2021 2:00 PM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: Re: OPENBMC ASRock Rack
Quoted 2 lines · On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)…
Re-send
Please use plain text email when posting to the list. This is a good rule to follow for all open source mailing lists.
Quoted 9 lines
I got below error when I try to push meta-asrockrack layer to gerrit.
Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
Here is the error:
(commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)
Quoted 8 lines
commit
1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)Author: Jeff9Chan <[email protected]>
Date: Tue Jun 8 09:15:44 2021 +0800
Quoted 7 lines
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of the on the line immediately above or below the change id. Try git commit --amend and moving it so the message looks like this:
Add meta-asrockrack layer
Cheers,
Joel
Quoted 3 lines · On Wed, Jul 7, 2021 at 6:50 PM Jeff9 Chan(陳松儉_ASRockRack)…
Hi,
It has been a while after uploading asrockrack layer, looks like no one is reviewing it, what's the next step for me?
I responded to your gerrit review with next steps, primarily educating yourself on what is allowed in a meta layer, how big patches should be, and where patches need to be submitted (which are documented in the docs folder). Apologies for letting it sit for so long, I was hoping that you would read the relevant docs and start updating/submitting your patches, but it looks like you were just waiting.
-Ed
Quoted 86 lines
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/43850
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670-----Original Message-----
From: Jeff9Chan(陳松儉_ASRockRack)
Sent: Tuesday, June 8, 2021 2:48 PM
To: 'Joel Stanley'
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: RE: OPENBMC ASRock RackThanks Joel, it works now.
best regards
Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670-----Original Message-----
From: Joel Stanley [mailto:[email protected]]
Sent: Tuesday, June 8, 2021 2:00 PM
To: Jeff9Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; [email protected]; [email protected]
Subject: Re: OPENBMC ASRock RackQuoted 2 lines · On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)…
Re-send
Please use plain text email when posting to the list. This is a good rule to follow for all open source mailing lists.
Quoted 9 lines
I got below error when I try to push meta-asrockrack layer to gerrit.
Is that means my email is not listed in the list?
To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected] HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
Here is the error:
(commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)Quoted 8 lines
commit
1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed(HEAD -> master)Author: Jeff9Chan <[email protected]>
Date: Tue Jun 8 09:15:44 2021 +0800
Quoted 7 lines
add meta-asrockrack layer
Signed-off-by Jeff Chan <[email protected]>Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of the on the line immediately above or below the change id. Try git commit --amend and moving it so the message looks like this:Add meta-asrockrack layer
Change-Id I1686133e0093e4e00adeadc068972396c8dc4fabSigned-off-by Jeff Chan <[email protected]>Cheers,
Joel