Skip to contentSkip to conversation

selftests/memory-hotplug: Add checking after online or offline

PATCH zhaogongyi 2 participants 2 messages Sep 27, 2022 – Sep 28, 2022

Subsystems (3)
lore
Share & tools
lore

zhaogongyi

author
#0 lore raw

Hi!

Quoted 76 lines · Zhao Gongyi
Quoted 7 lines

Add checking for online_memory_expect_success()/ offline_memory_expect_success()/offline_memory_expect_fail(), or the test would exit 0 although the functions return 1.

---
  .../selftests/memory-hotplug/mem-on-off-test.sh      | 12

+++++++++---

tools/testing/selftests/memory-hotplug/mem-on-off-test.sh done · line 267

Quoted 10 lines
  1 file changed, 9 insertions(+), 3 deletions(-)
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh +0 -0
index 46a97f318f58..1d87611a7d52 100755
@@ -266,7 +266,9 @@ done
  #
  echo $error >

$NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error

tools/testing/selftests/memory-hotplug/mem-on-off-test.sh done · line 277

Quoted 11 lines
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh +3 -1
  for memory in `hotpluggable_offline_memory`; do
-	online_memory_expect_fail $memory
+	if ! online_memory_expect_fail $memory; then
+		retval=1
+	fi
  done
 
  #
@@ -274,7 +276,9 @@ done
  #
  echo 0 >

$NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error

tools/testing/selftests/memory-hotplug/mem-on-off-test.sh done · line 287

Quoted 10 lines
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh +3 -1
  for memory in `hotpluggable_offline_memory`; do
-	online_memory_expect_success $memory
+	if ! online_memory_expect_success $memory; then
+		retval=1
+	fi
  done
 
  #
@@ -283,7 +287,9 @@ done
  echo $error >

$NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error

tools/testing/selftests/memory-hotplug/mem-on-off-test.sh done · line 293

Quoted 7 lines
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh +3 -1
  for memory in `hotpluggable_online_memory`; do
  	if [ $((RANDOM % 100)) -lt $ratio ]; then
-		offline_memory_expect_fail $memory
+		if ! offline_memory_expect_fail $memory; then
+			retval=1
+		fi
  	fi

LGTM

I am questioning the stability of the offlining test, though. Offlining a random memory block can fail easily, because "->removable" is not expressive:

# tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
Test scope: 2% hotplug memory
          online all hot-pluggable memory in offline state:
                  SKIPPED - no hot-pluggable memory in offline state
          offline 2% hot-pluggable memory in online state
          trying to offline 2 out of 96 memory block(s):
online->offline memory0
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo:
write error: Invalid argument offline_memory_expect_success 0: unexpected
fail
online->offline memory10
online->offline memory11
Quoted 1 line

I guess this test will almost always fail nowadays.

Offline some memory node maybe failed as expected, but the error message is a bit annoying.

Quoted 5 lines

--
Thanks,

David / dhildenb

#1 lore raw
Quoted 22 lines
Quoted 22 lines

I am questioning the stability of the offlining test, though. Offlining a random memory block can fail easily, because "->removable" is not expressive:

# tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
Test scope: 2% hotplug memory
           online all hot-pluggable memory in offline state:
                   SKIPPED - no hot-pluggable memory in offline state
           offline 2% hot-pluggable memory in online state
           trying to offline 2 out of 96 memory block(s):
online->offline memory0
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo:
write error: Invalid argument offline_memory_expect_success 0: unexpected
fail
online->offline memory10
online->offline memory11
Quoted 3 lines
Quoted 1 line

I guess this test will almost always fail nowadays.

Offline some memory node maybe failed as expected, but the error message is a bit annoying.

Ah, I see it now. We try offlining two and fail offlining the first one. Can we silence that warning in that case somehow?

Signature · 3 lines
Thanks,

David / dhildenb