clk: ti: clkctrl: add the missed kfree() for _ti_omap4_clkctrl_setup()

PATCH Markus Elfring 1 participant 1 message Jul 20, 2020

Subsystems (2)

Kernel janitors Common clk

lore

Share & tools

lore

Markus Elfring

author

2020-07-20 14:19 UTC #0 lore raw

…

Review static void __init _ti_omap4_clkctrl_setup(struct device_node *node) · line 661

Quoted 10 lines

+++ b/drivers/clk/ti/clkctrl.c

(quoted diff) +3 -1

@@ -655,8 +655,10 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
 		}
 
 		hw = kzalloc(sizeof(*hw), GFP_KERNEL);
-		if (!hw)
+		if (!hw) {
+			kfree(clkctrl_name);
 			return;
+		}

…

I suggest to use an additional label instead.

if (!hw)
- return;
+ goto free_control_name;

By the way:
How do you think about to replace the label “cleanup” by other jump targets for better exception handling in this function implementation?

Regards,
Markus